- 11 Sep, 2020 9 commits
-
-
Becca Hughes authored
This is still gated by the NTP modules flag and the server side KS gating but we can turn it on so people can test it easier. BUG=1121360 Change-Id: I20736d9e8ebe594d03d510749eb9a2b5effaddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401729 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805978}
-
Sunny Sachanandani authored
ReadBackFramebuffer assumes that the destination buffer size and format match the source. However, this isn't true when exporting the buffer for software compositiing since it only supports RGBA_8888, but the buffer could be RGBA_F16. Also fixes undefined behavior due to using the same buffer as source and destination for SkPixmap::readPixels which does a memcpy under the hood. Bug: 1122638 Change-Id: I887f70ea65fdf7ad215f5db22b39d0727fc3d09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393160 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805977}
-
yiyix authored
ImageData::StorageFormatDataSize returns 1, 2 and 4 for the data size for color format in uint8, uint16 and float 32 format, respectively. This not really true, since we need 4 channel to describe a color, the data size should really be 4, 8 and 16 bytes instead. In image_data.cc, we always call ImageData::StorageFormatDataSize and then multiply the result by 4 to get the real data size. In this cl, I update ImageData::StorageFormatDataSize to return 4, 8 and 16 and remove the multiplication to improve the readability of the code. Bug: 1122866 Change-Id: Ib78e31cff3c919728a3a84771acf2545d29a89a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391984Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#805976}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc83cdc8198b..8b9424e9da85 2020-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b55cb19f..a3dcf9ef (805701:805834) 2020-09-10 hidehiko@chromium.org Expand is_linux to is_linux || is_chromeos. 2020-09-10 nisse@webrtc.org Make NetEqController::TargetLevelMs method const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110266 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fd5d1de23efde64a3460a9ada88f679969c818e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805975}
-
Andrew Comminos authored
Since the JS Self-Profiling API will require COOP+COEP to ship, it's no longer necessary to isolate by context. This is a step towards deprecating this functionality in V8 entirely, as context scraping depends on reads of potentially uninitialized memory. Bug: 956688 Change-Id: I6fb8c2565f1979991f6ef8f86ceefe82ce5a5e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387150 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#805974}
-
Harvey Yang authored
This commit adds Sensor Hal Dispatcher, sensor mojo interfaces, and basic usages of them to connect clients to iioservice. BUG=chromium:1006141, b:162154663 TEST=builds, unit tests and test on octopus: Chromium connects to iioservice as a DBus client, and invites iioservice into the mojo network. Chromium then waits for iioservice_client (test executable) to register and establish a connection between iioservice and iioservice_client. All re-connections between Chromium and iioservice work well. Change-Id: I9f9ed4267093191ad306c25216300f850dc42006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332056 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805973}
-
David Black authored
These APIs will eventually be wired up to Holding Space UI. Bug: 1126274 Change-Id: I8c213459488dea838dd34e64f4c80dd57d466172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404470 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805972}
-
Tommy Li authored
Previously, the header expand/collapse chevron button was on the far right side of the header row. This looked like a bug sometimes, when the header started out collapsed. This CL moves the button to be directly adjacent to the header text. See the bug for details. Bug: 1127090 Change-Id: I23eba83d9ff58d31e6983af195fb219e668e9cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404663Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#805971}
-
Daniel Classon authored
Adds deep links to the Crostini Page, including the Crostini Details, Import Export, and Android ADB subpages. Bug: 1084154 Change-Id: I0dd75e13999b5ce7f8c17b39442d20dc0bfea59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381072Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#805970}
-
- 10 Sep, 2020 31 commits
-
-
James Cook authored
Type kBorealis had a FALLTHROUGH to the default case, which contains a NOTREACHED(). Remove FALLTHROUGH, since those are only needed for non-empty blocks. Remove default case, so the compiler will emit an error when an app type is not included. This reveals that AppType::kRemote was not being handled. No behavior changed expected. I just noticed this while working on an unrelated issue. Bug: none Change-Id: If55a1473c5739f5070b1377aae7e06da704a1806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393949Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#805969}
-
Daniel Murphy authored
This change adds 2 new install icons, and creates a configurable feature that will change the current icon to one of the new ones. Before: https://drive.google.com/file/d/1kjTrjTw1aPIBnEbZ018CEv3v9G25Q9Ve/view Download style: https://drive.google.com/file/d/1H6-GojGKMigLtSMBnqoJ3-H3SJYX5ZL9/view Device style: https://drive.google.com/file/d/1Cn1r6FCt4AxRPgMp0RGLM8P7w0fbTZJc/view Reference images: https://drive.google.com/corp/drive/folders/1m4CGxZJNP6PkQ6u7QHGPYuO5vy59fAlm Doc: https://docs.google.com/document/d/1D6vQpZR8X5l4rMCs9ErUvgxWNIPRK3iv4hGvy5qXSDo/edit# Bug: 1117260 Change-Id: Id4d0ca6e67ce13093fe4ed6344424810e6665f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401329Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This CL adds SignedExchangeSubresourcePrefetch to the config. Bug: 935267 Change-Id: Ia138e0667e4a13fcf210d931db55fdbf0bc41477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398040Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805967}
-
Mark Pearson authored
Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/2392712/2 Change-Id: I7642e72fbe75f8b31f19bc34f10cbbb60201e81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404571 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805966}
-
Markus Handell authored
This change prepares for development of capturer features behind a new flag. Moving static functionality into a separate file allows the capturer implementation to be duped, and the creator to create either implementation based on a flag. Future CLs will add the flag and perform the duplication. Bug: chromium:1126690 Change-Id: I8592a2ba81765e999c497eda9a6f09cc644e1423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401520Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1126205 Change-Id: I0409fa9fa12f272077bbef6f107ff81fe0866132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401975 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805964}
-
Ben Goldberger authored
Will clean up test files for the disabled case in a follow up. Bug: 994052 Change-Id: I45f5e12fcc901fbf656aaad1423949deea6322f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402184Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#805963}
-
Xinghui Lu authored
The "SafeBrowsing.Settings.UserAction*" metrics was added on Android settings page in https://crrev.com/c/2357677. We'd like to log the same metrics on desktop settings page as well. Bug: 1124491 Change-Id: Ib87672da86d696fd28c46955ac78159719cfba82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389260Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805962}
-
Daniel Hosseinian authored
Generate the thumbnail onto the SkBitmap of a Thumbnail object using PDFium's FPDF_RenderPageBitmap(). Add a test PDF and expectation PNGs of its thumbnails at different resolutions. Compare the rendered thumbnails to the expectation PNGs. Bug: 652400 Change-Id: Id4c5e7f7a93822c6c38efdd63657e3e8002cd9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382687Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805961}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I83438888e9bc42b8965e4e3aebd045da75dc9dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405000Reviewed-by:
-
Charlie Hu authored
This CL adds feature author guide section for document policy to README.md. Change-Id: Ib75b203192545fbbb8de48ceef25f1156398c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380609Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#805959}
-
Xianzhu Wang authored
This reverts commit cf0f02ca. Reason for revert: may be the cause of crbug.com/1127106 (linux-blink-rel failure in webdriver_tests_suite) Original change's description: > [chromium] Enable ChromeDriver log for WPT tests > > Enable chromedriver log for CI wpt tests > > Change-Id: I02d4acb627ca90233b7c0dab401c7c28e6759604 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402319 > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#805817} TBR=sky@chromium.org,johnchen@chromium.org,kyleju@chromium.org,shengfa@google.com Bug: 1127106 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0ca84f034e92e8858cd4fcf23bb49b0e52161f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404158Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805958}
-
Tomasz Wiszkowski authored
This change ensures that the RecyclerView clears the view pool when the user ends interaction with the Omnibox. Bug: 1075602 Change-Id: Iacd36ade19e67144421674cc85c05b750bd0b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404390 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#805957}
-
Peter Kasting authored
This replaces it with direct callback registration on the underlying links, conveyed by setting the callback on the RangeStyleInfo corresponding to the link. This allows eliminating parameters like the range, since a different callback or different bound arguments can be set for each range. With a change to how ContentSettingBubbleContents works (which was the other place using the Link* argument of Link::ClickedCallback), this allows reducing Link::ClickedCallback to one argument as well. It makes sense to make these changes simultaneously since they mostly affect the same listeners and thus this avoids changing lots of signatures twice. Bug: 1108460 Change-Id: Ie7c9cc7cafeb92b91aad2949e176b99d26d493e3 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388944 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805956}
-
Ben Mason authored
Bug: 1126713 Change-Id: Ie53a32768b8246f6ec7443281c65a08608f4e04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404521 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805955}
-
Kalvin Lee authored
This change prepares all public methods of PpdProvider to accept arguments that may contain mixed-case effective-make-and-model strings and explicitly converts any such members to lowercased ASCII. Bug: chromium:888189 Test: none Change-Id: I7ed8399858924828c138f0c27f86408a9ddcae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363656 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805954}
-
Shengfa Lin authored
main page Chrome has recent behavior change that it sends out load event fired for Out of Process Iframe(OOPIF). When ChromeDriver received it, it assumed that it's for the main page causing navigation to complete prematurely. The fix is to check the load event fired come from main page. Bug: chromedriver:3594 Change-Id: Icdc589ec6733c28e549b9110ea225fe7df00ce01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402323Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#805953}
-
chrome://signin-internalsJun Kokatsu authored
This change moves a style added for expired token in C++ code to JS code, in order to be compatible with Trusted Types. Bug: 1125965 Change-Id: I69c9d75364cf2ece4ed5009d981ebdf063f88fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401811 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805952}
-
Wenyu Fu authored
Add the content description for the loading spinner so that the screen reader can read out the loading status correctly. Change-Id: Ifa46b4b1c2d8255a592751132d56f66edb8b1257 Bug: 1119587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368445 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
-
Gang Wu authored
The CL-https://chromium-review.googlesource.com/c/chromium/src/+/2382958 caused this test to fail was reverted, so enable the test now. I thought "about"blank" was the problem, but after check the code, "about:blank" should not been recommended in the Omnibox suggestions, Therefore, using "about" here is kind of a test for that as well. Bug: 1126145 Change-Id: I2d78194c4663436d91a9c5965ca9fb4bdd0fc27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402324Reviewed-by:
-
Josh Nohle authored
Using base::Time::Min() for the overdue private certificate expiration time resulted in integer overflow because base::Time does not use clamped arithmetic. See crbug/1127026. Change-Id: I00a898858bf6d2b97aa6a34a37ca2ee90d2c9836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404363 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805949}
-
Scott Violet authored
If clip is set along one axis, the other axis must be either visible or clip. If not, clip is forced to hidden. This also removes a DCHECK in ComputedStyle::IsOverflowVisible(). I'm going to rename that function shortly (https://chromium-review.googlesource.com/c/chromium/src/+/2402303) BUG=1087667 TEST=StyleAdjusterTest Change-Id: Id00c6cd3269a81a391d541f994b9326a493c7bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402295Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805948}
-
Tsuyoshi Horo authored
Bug: 1053702 Change-Id: I65814fdd8ba45c46195141c5d5303bf49baf2c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397996Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium da055314. With Chromium commits locally applied on WPT: d3d1f16b "Visited background-color alpha channel in Forced Colors Mode" d5e233ea "WPT: Refactor idle-detection tests to use test-only-api.js" 612ba1ba "CookieStore: Remove matchType" 79f6cff0 "Animation effect now remains after timeline goes inactive while paused" da055314 "Revert "CookieStore: Remove matchType"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I06216c4604638b04c7c043f4a570e60f41b0f20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404482Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805946}
-
Arnaud Coomans authored
When simulating a fake audio device with the --use-fake-device-for-media-stream --use-file-for-fake-audio-capture=audio.wav arguments, the filepath (`audio.wav` here) isn't accessible because of the mac sandbox. As a result, opening the file fails and the audio file isn't played. This changeset adds a suggestion to disable the sandbox if simulating a fake audio device fails reading the audio file. Bug: 1032604 Change-Id: Ia4bc9a1ba4eb9a6d199f7d018bb0122bbd912517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383230Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805945}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 10 on the bug for details on why these studies are candidates for removal. Also, cleans up the ChromeSmartSelection feature flag. htpp://crbug/1127065 was filed for cleaning up a test file related to CopylessPaste, which can probably just be removed. Bug: 1126640 Change-Id: Ib63ce18c5cdbc8832f8cd8e98c7e007c8ba322b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404940Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805944}
-
Chris Thompson authored
This replaces the SCTReport struct used to store SCT audit reports in the SCTAuditingCache with the TLSConnectionReport proto we will use for sending reports to the server. Creating the proto at the time of adding the report to the cache avoids having to later translate the SCTReport into the final proto form, and lets us remove the SCTReport struct entirely. Bug: 1082860 Change-Id: Ib5848744fb79d33ce50f0909531ff983dc55af54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333302Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#805943}
-
Kalvin Lee authored
This change modifies the ZeroconfPrinterDetector to use the ty field specified in the ParsedMetadata class (instead of the product field) when calling Printer::set_make_and_model(). Bug: chromium:1062865 Fixed: chromium:1062865 Test: chromeos_unittests Change-Id: I7b1b742b402843cfa6e2d43f6318085ff578b2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399572Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805942}
-
Noah Rose Ledesma authored
This change fixes a bug where the "Devices" button in GMC had no text on Mac canary builds. The string associated with this button was moved to a more appropriate grd file. Bug: 1127069 Change-Id: Ic72ee633cdbd0094f7c6f402c15f2ea7a558a19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404942Reviewed-by:
-
Matt Jones authored
This patch moves the ownership of SceneOverlays from individual Layouts to the LayoutManager. Deciding whether an overlay should be shown can be done at the feature level rather than depending on the LayoutManager to sort them. For the most part, this patch is a logic move, but checks for whether an overlay is showing have been added before calling their respective methods. Bug: 1100332 Change-Id: Ic7f4bc9823295684bf3cc45007b0b227db11dd82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380267Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805940}
-
K. Moon authored
This reverts commit 3e085ec3. Reason for revert: Test is crashing with a segmentation fault Original change's description: > Add a pop-up for Chrome OS secondary login screen > > Bug: 1066489 > Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 > Commit-Queue: Thomas Tellier <tellier@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#805844} TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com Change-Id: I35550da66bba011cb35b9e50d38b4b02b572ce29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404061Reviewed-by:
-
