- 17 Sep, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change prolongs several Password Manager histograms. Fixed: 1125827, 1125734, 1125733, 1125732, 1125730, 1125724, 1117137 Change-Id: Ib14848f0db5dd5f437e1b0dd9bd447990bbba8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414215Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#807828}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8ce4355ae1c..34ef0c3fdc8e 2020-09-16 rharrison@google.com Fix missed modification flagging (#3814) 2020-09-16 andreperezmaselco.developer@gmail.com spirv-fuzz: Use an irrelevant id for the unused components (#3810) 2020-09-16 stefanomil@google.com spirv-fuzz: Improvements to random number generation (#3809) 2020-09-16 greg@lunarg.com Add buffer oob check to bindless instrumentation (#3800) 2020-09-16 vasniktel@gmail.com spirv-fuzz: Remove CanFindOrCreateZeroConstant (#3807) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: If070d9f97ec26f5bc06f6d4428d7642555e6cb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807827}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3018d5e57091..0a8a3ea25b36 2020-09-17 courtneygo@google.com Vulkan: Skip nested pow test on NVIDIA, Windows 2020-09-17 timvp@google.com Vulkan: Use linkedShaderStages in GlslangGetShaderSpirvCode() 2020-09-17 jmadill@chromium.org GN: Fix CrOS build due to buggy "defines". 2020-09-17 timvp@google.com Vulkan: Match descriptor pool sizes to descriptor set layouts 2020-09-17 jmadill@chromium.org Test Runner: Fix dirty thread teardown. 2020-09-17 jmadill@chromium.org Run trace tests against Vulkan Mock ICD. 2020-09-16 jmadill@chromium.org GN: Fix missing pkg_config import in GL back-end. 2020-09-16 capn@google.com Validate GLSL attribute location range 2020-09-16 jmadill@chromium.org Test Runner: Handle GTest sharding args. 2020-09-16 syoussefi@chromium.org Vulkan: Change VK suffix to Vk 2020-09-16 cclao@google.com Vulkan: Move mAttachedColorBufferMask to FramebufferState 2020-09-16 syoussefi@chromium.org Change renderbuffer width/height/sample types to GLsizei 2020-09-16 jmadill@chromium.org Show file in internal errors. 2020-09-16 cnorthrop@google.com EGL: Add another config for Mali 2020-09-16 ianelliott@google.com Vulkan: Disable BlitStencilWithFlip test on Win 2020-09-16 jmadill@chromium.org GN: Componentize GL back-end. 2020-09-16 lexa.knyazev@gmail.com Vulkan: Fix blendEnable-02023 VU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1110800,chromium:1127866,chromium:1128064,chromium:1129075 Tbr: jmadill@google.com Test: Test:Test: Test: VulkanDescriptorSetTestTest: Test: angle_end2end_testsTest: Test: local GN CrOS build Change-Id: Idb0889596d09481056523072965daf21db685c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414659Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807826}
-
Hirokazu Honda authored
Bug: 984693 Test: video_decode_accelerator_tests Change-Id: Idee4e53a555168433e7e138ba2fafd1cff649cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409726 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807825}
-
David Grogan authored
These tests were created with expectations for the normal bots, not the disable-layout-ng bot. FlexNG differs from legacy flex in at least one test in each file, so disable-layout-ng needs an expected.txt for each test. Change-Id: Ide3a709fb1e262ce0b072018a6c8b1a4d8d647d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414676 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807824}
-
Tanmoy Mollik authored
After going through the sync consent flow from SyncPromoPreference, this preference should be hidden. Keeping the SyncPromoPreference when SigninPromoController was not null was preventing that from happening. Bug: 1126074 Change-Id: Ibad0838ec2594b1c6825561df4d6392359fe7c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400418Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#807823}
-
Roberto Moura authored
rotates the screen. Update the ViewRevealingVerticalPanHandler's base view height when the BVC transitions to a different size. Keep track of whether the BVC is positioned at the bottom of the screen and reposition it on rotation if needed. Bug: 1123729, 1127604 Change-Id: I8fb2ee0f531204ff3788845af8f32b515f101931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414393Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#807822}
-
Rune Lillesveen authored
Timeout on multiple builders. Not able to identify culprit. Disabling. TBR=ellyjones@chromium.org Bug: 1129313 Change-Id: I9f9bb6f3c3e55499b4d8709d790886b8bfa8d5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414195Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807821}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5b4eaf71f78b..837fe726e639 2020-09-16 tsepez@chromium.org Rewrite some loops in CFXA_FMParser. 2020-09-16 tsepez@chromium.org Introduce PDFFuzzerPublic::MaybeForceGCAndPump(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I84f795181500294a4422d543a8095168830d9b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807820}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600310646-24416ad728deecf44e4a88c788126e2edffee2b4.profdata to chrome-mac-master-1600322062-3a48015e01b1446b1d53601d43c9f7d995fa4dd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I12b0574462366330741b5a92e84bae61fd9de06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807819}
-
Benoit L authored
This reverts commit 7cfe51d0. Reason for revert: Suspected as the reason for Canary build failures. Original change's description: > [WebLayer] Enable WebLayer in split on canary > > This enables WebLayer in a split in WebView bundles in canary. I tested > on L-Q and ran all instrumentation tests on P with this setup. > > Bug: 1105096 > Change-Id: I517bce4109531108a4fb3af64a87aa1f5d2a91bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412705 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807252} TBR=sky@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1105096, 1129288 Change-Id: I040fa6a2cd4dcfbfd006a49b32ec952625557132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414258Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807818}
-
Christian Dullweber authored
Describe lossy prefs and how to remove individual settings from HostContentSettingsMap. Bug: 1128286 Change-Id: I25d6bc0679a7e3184762888298c6ca2e7889ab3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410480 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807817}
-
Roman Sorokin authored
To reflect actual implementation Bug: none Change-Id: I7cdb669ffaa6aacf0b1442db49026aa8d8e26ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414034Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807816}
-
Omar Morsi authored
Change-Id: I340d719227315722953ef8f73409c0ec61ac0624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414069Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#807815}
-
Alex Rudenko authored
This CL adds grid node highlight configs to the regular inspect tool to make sure persistent grid overlays can be shown while inspecting. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2400498 Bug: 1109224 Change-Id: If0828bb67577136ceb01c7bee92480bee1f53be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400478Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807814}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I603a28a515baf49fcd72a9e7013a73a9c6b98aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414191 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807813}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I3f5a4c6c9402cf76f3234afbd89fac214be89ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415577Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#807812}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I7b78360226929347fcec3ee730e51aec869a6c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414294 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#807811}
-
Kuo Jen Wei authored
This CL polish CCA setting menu UI by: 1. Refresh icons. 2. Adjust sections size in setting menu. 3. Add color highlight to selected options. Bug: 1123750 Test: Manually Change-Id: Ia711d7747597e05c9301a5c60efa188bd1eb89d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409686 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#807810}
-
My Nguyen authored
Nodes created by "dom-if" are not added to "this.$" hash, so existing codes are updated to use "this.$$" Mock: http://go/cros-lang-settings-ux-slide#slide=9 Current view: http://screen/wApjKowehbqaZQM Bug: 1113439 Change-Id: If905281d4157ffb10b935f0389763568373b1918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407678Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807809}
-
Maggie Cai authored
This CL skips the ArcIntentHelper package from arc_apps. When ArcIntentHelper package registerd, the intent picker will show Chrome as an option for every link. One case will make this happen is to select an adress and choose to open with map from the context menu. BUG=1125915, 853604 Change-Id: Iad7b184cd2899eaaa04d504b738b7055a1009092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415753Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf66ffbbd4ce..e6467c88b64d 2020-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from da6c6f8f to 70a60d85 (419 revisions) 2020-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4d3a0f602852 to 0a8a3ea25b36 (21 revisions) 2020-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from dbd34449af20 to 6419bddd9b0c (3 revisions) 2020-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b33e0b36a08c to fe878dedd5ad (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1110800,chromium:1127866,chromium:1128064,chromium:1129075 Tbr: scroggo@google.com Test: Test: Test:Test: Test: VulkanDescriptorSetTestTest: Test: angle_end2end_testsTest: Test: local GN CrOS build Change-Id: Ie8bf6c2b910a89c2f9a344bc373e6725f379ce76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807807}
-
Colin Blundell authored
I fixed the underlying source of the flake in https://chromium-review.googlesource.com/c/chromium/src/+/2410488, so this should be safe to re-enable. I'll monitor, of course. TBR=dtrainor@chromium.org Bug: 1114795 Change-Id: Id31c8a4ce769bf43108595163dd347e0766fdd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414396 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807806}
-
Minoru Chikamune authored
[related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I737cd6d0f9199f7ba7da83410c52efa1b8e5008c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352580Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#807805}
-
Sami Kyostila authored
Wrap the trace event handle's name in a unique identifier to avoid shadowing a variable called |h| in the enclosing scope. Bug: 1119816 Change-Id: I7a247291b99aba5a3c10c6d1144d373b57af35d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414254 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807804}
-
Ioana Pandele authored
Make sure that tests which were not meant for Safety Check explicitly disable the feature. Bug: 1070620, 1092444 Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866 Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#807803}
-
Ken Rockot authored
Sources for this target are moved back into //content/common. No behavioral changes. Bug: 977637 Change-Id: I1aed5fb1010b11224cf509e0f3cf3de549bb6193 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411468 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807802}
-
Austin Sullivan authored
Makes behavior consistent with MemoryFSW and SandboxFSW Bug: 998913 Change-Id: I543b8136e558a57b7d9b732cb4d4845153efa4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412247 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#807801}
-
Rachel Carpenter authored
Release notes has been launched (enabled by default) for many milestones. Clean up the feature to reduce the complexity of the code. I also removed the function getEnabledReleaseNotes() from the settings about page, as that was only returning the value of this feature, and changing that to `return true` seemed a bit wrong. Change-Id: I85303b3dfe2b286c261d62725cfcfbe034a7757b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409882 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807800}
-
My Nguyen authored
When users change device language, if the device language isn't present in Languages for apps and websites section (enabled language list), it should be added and moved to the top. If it's already present, we don't do anything as users might want to keep their original preference if the language is already present because Chrome OS only supports a subset of languages and they might have a different preference for their languages for apps and websites Specified in: http://go/cros-lang-settings-ux-slide#slide=12 Bug: 1113439 Change-Id: Iab64854a68f9abebdee40ce04487bd09c7552970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413711 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807799}
-
Miyoung Shin authored
This CL converts WidgetMsg_WasShown/WidgetMsg_WasHidden IPCs to blink's Widget mojom and moves some implementation including is_hidden into WidgetBase, and moves ContentToVisibleTimeReporter class to blink. Bug: 1102446 Change-Id: I40bf1444627fdac5a96becef0907f5662a6a45e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377630 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#807798}
-
Kent Tamura authored
crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's offset. So hit-testing didn't work well if the FIELDSET was placed far from the origin. Bug: 1127743 Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#807797}
-
Istiaque Ahmed authored
This CL ensures PRE_FilteredEventsAfterRestart sees OnRegistrationStored. This CL also packs the extension before loading to avoid extension reload during LoadExtension. This CL reuses (and renames) .pem key from "events_to_stopped_extension" test. Due to crbug.com/1127126, the test still flakes on win bots. Therefore, this CL leaves the test disabled on win. Bug=1003244 Change-Id: I8d27b55899f3b272575ff8c3eef31c57afc439a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405612 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807796}
-
Hidehiko Abe authored
Currently is_linux is set to true on Chrome OS build, but it is planned to set false. This CL is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: Ia56a3e5a3ef3db14e4a4a3b2583e4496595263af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413723 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807795}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iea40b9bdb7cd777718e80b77a0d9b8fe71d273d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807794}
-
Ethan Jimenez authored
1. Implementing virtual methods `IsRangeSpanningIntrinsicTrack` and `IsRangeSpanningFlexTrack` in `NGGridTrackCollectionBase`. These will allow track collections to cache whether a range spans tracks with an intrinsic or flexible sizing functions. 2. Introducing new member variables to `GridItemData` that will be used in following changes, e.g. an item's resolved grid area, flags to cache if an item spans intrinsic or flexible tracks, etc. 3. Implementing an algorithm to cache which grid items contain ranges that span intrinsic/flexible tracks in `NGGridLayoutAlgorithm` (see `DetermineGridItemsSpanningIntrinsicOrFlexTracks`). 4. Adding unit tests for all the introduced caching. Bug: 1045599 Change-Id: I0c9121803aa1703bc38c7b18078a266f33b75156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402967 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807793}
-
Palak Agarwal authored
Bug: 1068681 Change-Id: I496affdb20eda7209a66aed25859b04234ec9bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401098Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#807792}
-
David Munro authored
Change-Id: I6eee3aab74df6c43c4f7db9dd534438dd0957330 Bug: chromium:1121463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413720 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807791}
-
Harald Alvestrand authored
Bug: chromium:1127625 Change-Id: I9ac8b6b90f241460ade299914369405363a36403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410407 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#807790}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600204796-8d7865915b9e4398ddfed4089a6b11aaf7991b68.profdata to chrome-mac-master-1600310646-24416ad728deecf44e4a88c788126e2edffee2b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib3d0a723914d8093da1701ca9a3e0c8933f4a325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415738Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807789}
-