- 03 Jul, 2018 36 commits
-
-
Xiaocheng Hu authored
This reverts commit d1c99618. Reason for revert: Observed many crashes in M68 & M69. Not ready for shipping. Original change's description: > Remove cold mode idle time spellchecker flag > > As cold mode idle time spellchecker is shipped into M68 > and no regression is obversed, this patch removes the flag > from M69 as cleanup. > > Bug: 716642 > Change-Id: I8f850c52469590ee9d5e542c14f4dae842a6163a > Reviewed-on: https://chromium-review.googlesource.com/1072953 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561951} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716642, 856376, 859056, 859443 Change-Id: I91426509a315a07bf4f548ebafe825c2ef856999 Reviewed-on: https://chromium-review.googlesource.com/1123120 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572086}
-
Yoshifumi Inoue authored
This patch changes "row-inner-text.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: I2efbd96aca89a2c4e5b63d62dcc3dc2f2968d8e0 Reviewed-on: https://chromium-review.googlesource.com/1122138Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572085}
-
chcunningham authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f1213c0111a204053680922a1c8b99f11222b2c Reviewed-on: https://chromium-review.googlesource.com/1103607 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#572084}
-
Luciano Pacheco authored
Test external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html has been marked as flaky by Try-Flakes, skipping until further investigation. Bug: 850964 Tbr: ekaramad@chromium.org Change-Id: I13ef5fd0520a2e04e1c7166fff2fd2a52a8d0add Reviewed-on: https://chromium-review.googlesource.com/1123739Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572083}
-
Luciano Pacheco authored
This reverts commit cf25f142. Reason for revert: crbug.com/859718 was a false alarm, failures was before merging the CL originally reverted. Original change's description: > Revert "Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase." > > This reverts commit ed47f31b. > > Reason for revert: All tests from TabTest reported flaky crbug.com/859718 > > Original change's description: > > Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase. > > > > This ensures these tests are testing the actual harmony/refresh behavior, and > > makes sure as people add more calls to ChromeLayoutProvider to the code they > > don't result in unexpected test crashes. > > > > Bug: none > > Change-Id: If21b7eec387dc47be448e2dbb2730ddacb7b51fe > > Reviewed-on: https://chromium-review.googlesource.com/1121787 > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#572008} > > TBR=pkasting@chromium.org,thestig@chromium.org > > Change-Id: Ib0d68d4aaff4a8617b95f4456eef0dad9f66e57b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1123839 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572070} TBR=pkasting@chromium.org,thestig@chromium.org,lucmult@chromium.org Change-Id: I7c738232c08a506baa0ebf43d1a4df87fa2ca2f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859718 Reviewed-on: https://chromium-review.googlesource.com/1123859Reviewed-by:
-
Ted Meyer authored
A histogram called Media.D3D11.WasVideoSupported is being added to track how many videos actually being played are capable of using the d3d11 decoder, or if they are not supported, then for what reason Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibb57f34644b66211afbf4bba4776124e8bafa6d3 Reviewed-on: https://chromium-review.googlesource.com/1117895 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572081}
-
rbpotter authored
Fix routing in bookmarks and history to work with Polymer2, where the race between iron-location and iron-query-params will cause queries from the URL to be lost. This causes MaterialBookmarksRouterTest and MaterialHistoryRoutingWithQueryParamTest to pass with Polymer2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib5aad55c25f8f29b25cd56cd11f2d4110d5b9b48 Reviewed-on: https://chromium-review.googlesource.com/1121589Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#572080}
-
Xiaocheng Hu authored
Current NG hit test code decides whether a hit test location is clipped by rounded border by adding border radius to all four corners and then compare with the hit test location. This is wrong if the box is fragmented, where it may have only two or zero rounded corners. This patch changes HitTestClippedOutByBorder() to take the above into consideration. By utilizing |border_edges_|, it can generate the corrected rounded border to be hit tested. Test: This patch slightly modifies WPT hit-test-inline-fragmentation-with-border-radius.html as a workaround of some rounding issue, which is out of the scope of this patch. Bug: 855279, 859233 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43 Reviewed-on: https://chromium-review.googlesource.com/1123265Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572079}
-
bsheedy authored
Re-enables VrShellTransitionTest#testWebXrReEntryFromVrBrowser since the flakiness that got it disabled should now be fixed. TBR=mthiesse@chromium.org Bug: 856546 Change-Id: I6aa101775e50e7c2ed605bc1c762fe6bd0e6ba58 Reviewed-on: https://chromium-review.googlesource.com/1123760Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572078}
-
bsheedy authored
Roll the WebXR sample repo to pick up a framebuffer scale fix. TBR=bajones@chromium.org Bug: 853400 Change-Id: Ic6880944037ace9fed199e647c04708aec0851af Reviewed-on: https://chromium-review.googlesource.com/1123642Reviewed-by:
-
Tetsui Ohkubo authored
UnifiedSystemTray has to show number of disabled notifier sources under the do-not-disturb feature pod button. In order to implement this, first we had to make NotifierSettingsListener in ash::MessageCenterController to support multiple listeners. TEST=manual BUG=856931 Change-Id: If4186853a7ced96d726ccf9b5d40ca05f8268cb3 Reviewed-on: https://chromium-review.googlesource.com/1116635 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572076}
-
Yutaka Hirano authored
This is for further investigation of flakiness. Bug: 799516 Change-Id: Ie31837422a4e0b8ed5926f8e669911b50721e2c9 Reviewed-on: https://chromium-review.googlesource.com/1123659Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572075}
-
James Darpinian authored
A previous change removed the command buffer flush when destroying a transfer buffer: https://chromium-review.googlesource.com/c/chromium/src/+/1105466 If we want to free a transfer buffer promptly, we now need to flush separately, and we do. Unfortunately if no commands were issued between the call to DestroyTransferBuffer and the flush, the flush might not execute because the CommandBufferProxy would pass an outdated flush ID to GpuChannelHost::EnsureFlush. The fix is to inform the CommandBufferProxy about the new flush ID when it calls DestroyTransferBuffer. This should fix the memory regressions on the perf waterfall noted in bug 855402. Bug: 855402, 850271, 835353, 828363 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id125c5124b26763e692c1fe8067df28761fa6dab Reviewed-on: https://chromium-review.googlesource.com/1121590Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#572074}
-
Darren Shen authored
After https://crrev.com/c/1098753, "container" now means the parent (ash) container of the virtual keyboard. Thus, there's no more ambiguity between the keyboard "container" vs "contents" window, so we can just refer to the "contents" window as the "keyboard window". Bug: 849980 Change-Id: Iddaca77b8bf37559db75efdedc6a9276491c453d Reviewed-on: https://chromium-review.googlesource.com/1119610Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572073}
-
Yutaka Hirano authored
It seems the crash is a null access in a ResourceResponse assignment. This CL adds a CHECK for that. Bug: 570946 Change-Id: I8c7afe8f76499f80fe918cd6d6617ff2952a2e6f Reviewed-on: https://chromium-review.googlesource.com/1123662Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572072}
-
Jun Choi authored
Add "Verifying USB" sheet to USB UI flow and combine 'kInsertUsb' state and 'kActivateUsb' state as it is shown in a single UI flow. As we do not plan on implementing "Complete" UI sheet for initial version, this completes the UI flow for USB security key use. Bug: 849323 Change-Id: I8c1a8cbc8d4aedee557ac65c730b99295070a4ab Reviewed-on: https://chromium-review.googlesource.com/1105403 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572071}
-
Luciano Pacheco authored
This reverts commit ed47f31b. Reason for revert: All tests from TabTest reported flaky crbug.com/859718 Original change's description: > Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase. > > This ensures these tests are testing the actual harmony/refresh behavior, and > makes sure as people add more calls to ChromeLayoutProvider to the code they > don't result in unexpected test crashes. > > Bug: none > Change-Id: If21b7eec387dc47be448e2dbb2730ddacb7b51fe > Reviewed-on: https://chromium-review.googlesource.com/1121787 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572008} TBR=pkasting@chromium.org,thestig@chromium.org Change-Id: Ib0d68d4aaff4a8617b95f4456eef0dad9f66e57b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1123839Reviewed-by:
-
Makoto Shimazu authored
These traces will be shown up on the IO thread tasks, but we can easily follow each event by clicking Incoming/Outgoing flow. Bug: 806658 Change-Id: I2de36f4741741e098dba28eab93606855d828551 Reviewed-on: https://chromium-review.googlesource.com/1119730Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572069}
-
rbpotter authored
Cloud print requests cannot be made from the Print Preview WebUI when the network service is enabled. Avoid making these requests when the flag is enabled, and add a (currently empty) CloudPrintHandler class that implements the PrinterHandler interface, and will generate these requests in future. Bug: 829414, 848987 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icec152b4687a325758a67fcf6562b913a8657073 Reviewed-on: https://chromium-review.googlesource.com/1120873 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572068}
-
Peter Kasting authored
The clip is inset by the separator opacities, which means the favicon bounds animate as the separator fades. It's possible crossfading would look better, but it's not clear (and that's harder to implement). This also makes a few other minor changes: * Use kSeparatorThickness in tab_strip.cc for consistency * Try to improve comments * Use a lambda when computing separator colors to avoid repetition * Ignore subsequent tab hover value for leading separator. This is technically more correct; in practice it would only be visible if the bounds animation were slow enough that you could have a preceding tab still animating back into position (thus not covering the leading separator) while hovering a subsequent tab. Since that's not really possible, this is mostly just to make the code easier to reason about. Bug: none Change-Id: I37eceae6c3b12a3730a0706853fc8cc1526c16c4 Reviewed-on: https://chromium-review.googlesource.com/1121785 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#572067}
-
Dmitry Gozman authored
There is no need for separate clipboard in platform, it just increases fragmentation. Also removed content/renderer/clipboard_utils, which is not used anymore. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iec73a4fe6658cc985faa5ab2283dcb194387ab71 Reviewed-on: https://chromium-review.googlesource.com/1122479Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572066}
-
Nicholas Verne authored
Addresses comments from tapted after https://chromium-review.googlesource.com/c/chromium/src/+/1114408 was submitted. Bug: 848118 Change-Id: I66059b005de6ede632f81ec8fa6c9c103a892051 Reviewed-on: https://chromium-review.googlesource.com/1121937 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572065}
-
rajendrant authored
Currently transfer size updates are reported only when report_raw_headers is set. This CL relaxes that requirement and checks if either report_raw_headers is set (to work with devtools) or the renderer has permission to read the resource. This CL also throttles the transfer size updates to be reported only once per 500 ms per resource. Bug: 836029 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7e34a0b0c5fad7e424772c075041c0609dc1b365 Reviewed-on: https://chromium-review.googlesource.com/1050814 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#572064}
-
P H authored
Bug: 845224 Change-Id: I705d93fb547c434768747544ef09264923bbfb53 Reviewed-on: https://chromium-review.googlesource.com/1119411 Commit-Queue: Patricia Hongo <phongo@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#572063}
-
Tetsui Ohkubo authored
This CL replaces main view icons of UnifiedSystemTray by new ones. Network icon is not included as it requires special handling. Detailed view icons will be also updated in upcoming CLs. Screenshot: http://screen/Kb8w2tQxdkP TEST=manual BUG=842079 Change-Id: Icd7454d8b26b642c58a0b014b7d6081069d38e7d Reviewed-on: https://chromium-review.googlesource.com/1118080Reviewed-by:
-
Alexei Filippov authored
The id is process scoped so mangle it with pid to get a unique id. Change-Id: I681bf76f1b01c946287c247257c911a326cbced5 Reviewed-on: https://chromium-review.googlesource.com/1123322Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572061}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b71f42943166..45a546a30885 git log b71f42943166..45a546a30885 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 dgarrett@google.com chromeos_config: Move PFQ masters to swarming. Created with: gclient setdep -r src/third_party/chromite@45a546a30885 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853969 TBR=chrome-os-gardeners@chromium.org Change-Id: I3c368338ba0aedceec55c7241c93a4f368d22b88 Reviewed-on: https://chromium-review.googlesource.com/1123085Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572060}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/312466a20450..0ea751539e3a git log 312466a20450..0ea751539e3a --date=short --no-merges --format='%ad %ae %s' 2018-07-02 qingsi@google.com Fix a bug in TurnServer that causes flakiness in webrtc_perf_tests. Created with: gclient setdep -r src/third_party/webrtc@0ea751539e3a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96e36d63e0d5575e502b71aeb290401db50d018c Reviewed-on: https://chromium-review.googlesource.com/1123084Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572059}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/555b41aebe00..65f38c8fae09 git log 555b41aebe00..65f38c8fae09 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 thestig@chromium.org Roll DEPS for build to 7ac2934. 2018-07-02 thestig@chromium.org Roll Clang to dec27d72. 2018-07-02 tsepez@chromium.org Kill a malloc/memcpy in cjs_document.cpp 2018-07-02 tsepez@chromium.org Virtualize Observable<T>::ObservedPtr::OnDestroy() for CPDF_Avail cleanup Created with: gclient setdep -r src/third_party/pdfium@65f38c8fae09 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I490de211a435960d532267e0945a3029b2384889 Reviewed-on: https://chromium-review.googlesource.com/1123087Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572058}
-
Karan Bhatia authored
This CL increments the Docserver version. I am testing auto-updating the server for github hosted repositories and this should help guard against any unintentional changes to the currently served documentation. BUG=820605 Change-Id: I3f68767da92e5b120904fc777862e72cea4269de Reviewed-on: https://chromium-review.googlesource.com/1123373Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#572057}
-
Ned Nguyen authored
Bug:859660 NOTRY=true TBR=crouleau@chromium.org Change-Id: Id29d359fd0319d3fce5e515bbe6ed28aefe7f812 Reviewed-on: https://chromium-review.googlesource.com/1123705Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572056}
-
git-meacer.google.com authored
UrlFormatter uses ICU's spoof checker to determine lookalike domains that contain unicode confusables. It does this by extracting a skeleton string from the given domain representing its visual appearance. For example, google.com and googlé[.]com have the same skeleton string (google.corn). In addition to this, we want to display a "Did you mean to go to..." UI for navigations involving IDN if the domain name matches a top 10K domain. In order to do that, we need to store the domains associated with ICU skeletons. UrlFormatter currently uses a DAFSA to store the list of the skeletons of the top 10K domains. It doesn't and cannot store the actual domain in this list. To support this, this CL changes the underlying storage from DAFSA to the Huffman Trie used by net's preload list code. It - Generates the huffman trie from top domain list during compile time. - Decodes the huffman trie during runtime in IDNSpoofChecker::SimilarToTopDomains. The design doc for the preload list migration is here: https://docs.google.com/document/d/11rqIozUDaK6DvNeu436SL3Coj65J5vhD9HVftOi-RrA/edit As mentioned in the doc, micro benchmarks indicate that the binary size and speed is minimally impacted by this change (51KB additional size, 4 microseconds of additional time for each lookup). Bug: 843361 Change-Id: If98b8161bf836fec6ba74e68587bd2159f4eb3d5 Reviewed-on: https://chromium-review.googlesource.com/1106539 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#572055}
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iebb2dea88b6e111893de79e86854d92dcd3932f8 Reviewed-on: https://chromium-review.googlesource.com/1123114Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#572054}
-
Miguel Casas authored
The original CL was reverted because BO_USE_HW_VIDEO_DECODER is not correctly handled in ARM platforms _for protected buffers_ (i.e. allocations coming from ARC++). crrev.com/c/1117606 added support for the flag on those platforms. CQ-DEPEND:1117025 TBR=dcastagna@chromium.org (no changes) Original CL ----------------------------------------------------------- This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a comment [1] in crrev.com/c/1021675. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147 Bug: 822346, 857095 Test: simplechrome video playback on nautilus, vaapi engaged. Change-Id: I1c11a8fffa662b69049d121ccb48ebfd85097228 Reviewed-on: https://chromium-review.googlesource.com/1104394Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1117025Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#572053}
-
Devlin Cronin authored
Adjust the runtime host permissions feature to withhold any host permission requested by the extension, rather than just the <all_urls> and all-hosts style permissions. Update browser and unit tests with the new expectations. Bug: 848448 Change-Id: I7c152d7a901bcb23515b6245dce94e1eedf756d7 Reviewed-on: https://chromium-review.googlesource.com/1083415Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572052}
-
Daniel Erat authored
Make PowerManagerClient notify its observers about ScreenDimImminent D-Bus signals from powerd, and expose a new method that calls powerd's DeferScreenDim D-Bus method. Bug: 854908 Change-Id: I28db70981ad44c6073db4ef90dd94180665012af Reviewed-on: https://chromium-review.googlesource.com/1123410Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572051}
-
- 02 Jul, 2018 4 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5155d38fdcd4..ef21d7e47963 git log 5155d38fdcd4..ef21d7e47963 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 timliang@google.com implement onreadpixels for metal gpu backend 2018-07-02 senorblanco@chromium.org GrTessellator: handle three consecutive collinear edges. 2018-07-02 timliang@google.com implemented wrapped backend texture/rendertarget/textureRT for Metal gpu backend 2018-07-02 halcanary@google.com Simplify GrGLInterface::abandon 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 0977edc92270..9d19e2abf000 (4 commits) 2018-07-02 brianosman@google.com Remove sRGB config checks based on color space 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 99b01c076f47..0977edc92270 (1 commits) Created with: gclient setdep -r src/third_party/skia@ef21d7e47963 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851409 TBR=ethannicholas@chromium.org Change-Id: Ib1d63293fa9961e041a34f0bad7b4f031e34689c Reviewed-on: https://chromium-review.googlesource.com/1123279Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572050}
-
Peter Kasting authored
Bug: 848412 Test: Open lots of tabs and shrink the window width. Tabs should be able to get narrow enough that only a center strip of the favicon is visible. Change-Id: Iccfe31adb06b9c922c619ae5436b611a876b82e0 Reviewed-on: https://chromium-review.googlesource.com/1121819 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Robert Liao authored
This reverts commit cb05af1b. Reason for revert: Causes a DCHECK followed by a crash. http://crbug.com/859697 Original change's description: > IdentityManager: Add APIs for querying state of refresh tokens > > This CL adds APIs to IdentityManager for obtaining the set of all > accounts with refresh tokens and querying whether the primary account > is available with a refresh token. > > The design follows that of IdentityManager's caching of the primary > account information: > - IdentityManager initializes its state with the current state of > ProfileOAuth2TokenService. > - IdentityManager updates this state in response to notifications from > PO2TS that an account's refresh token was updated/removed. > > TBR=bsazonov@chromium.org > > Bug: 806774 > Change-Id: Idc4a37a15ced2e7d32f012a50e4e0d1fdb1aecdf > Reviewed-on: https://chromium-review.googlesource.com/1098668 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571451} TBR=blundell@chromium.org,msarda@chromium.org,sdefresne@chromium.org,treib@chromium.org,bsazonov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806774, 859697 Change-Id: I636d458101a5a579202dc4683faddfc0643cb19c Reviewed-on: https://chromium-review.googlesource.com/1123119Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572048}
-
Ryan Hamilton authored
Switch a LOG(DFATAL) to a QUIC_LOG(DFATAL) in net/third_party/quic/core/congestion_control/bandwidth_sampler.cc. Merge internal change: 203004418 Change-Id: I5562cc1f625d19d96ac9fbe4e489f74edcd61f11 Reviewed-on: https://chromium-review.googlesource.com/1123300Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572047}
-
