GitLab

Screenshot with fake data: https://drive.google.com/file/d/1X1Pwho3xM_lyHQ6zO24XcGtuG2lbnAy-/view?usp=sharing&resourcekey=0-1esda1N3RkpWE_rTqZyuDg

Bug: 1157892
Change-Id: Ib3a6cb5d1cef705377d39d3e4b1fbd08df994d38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589364
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837854}

When mobile viewport is enabled, we have two viewports: the visual
(inner) viewport and the layout (outer) viewport. The clip of the
visible viewport is not in the paint property tree, so we need to
apply the clip separately. The clip was mistakenly removed in
crrev.com/824480.

Also fix a bug before crrev.com/824480: the current scroll offset
of the visual viewport was not considered when applying the visual
viewport clip, which caused invisible shifts reported and visible
shifts not reported.

Bug: 1141739
Change-Id: I425718b1fdfb2689a7f2948c561101d0b476eb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593180
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837853}

FilePathWatcherKQueue::Watch uses a FileDescriptorWatcher, which
requires that its callers handle spurious runs of callbacks after the
watch is cancelled.

If this speculative fix resolves the crash, a follow-on CL will revise
the FileDescriptorWatcher documentation to make this case explicit.

BUG=1156603
R=fdoray@chromium.org

Change-Id: I7d5da3fb4e58cf30efab21963908b3ff41e9dc71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593379
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837852}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I18c19719e133d5c770c98cd52544e084784a3905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837851}

The change is mostly mechanical replacing GN variable is_chromeos with
with is_chromeos_ash with some special cases (For those cases please
refer to http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: I516266244abf4f05495f690afcf330b7f28c27d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595747Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837850}

This is a mechanical change that renames deprecated macro replacing:

- BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}),
- gn var is_{ash,lacros} with is_chromeos_{ash,lacros}.

http://go/lacros-macros

Bug: 1052397
Tbr: reillyg@chromium.org
Change-Id: I4dfe8d18cbff8cfb1d7c251e6f0a84f6bf46cb92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592079Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837849}

This CL fixes a race that can occur in the DiskMountManager when disks
are added. Since we wait for the asynchronous GetDeviceProperties dbus
call to complete before updating the disk map, if the disk mount event
is received too soon, we notify observers of the mount even though the
disk entry is not yet created. As a result, the CrosUsbDetector cannot
correctly track these entries and settings may fail to prompt the user
when trying to share USB drives. The notification that a new removable
storage device is added also does not appear.

We fix this by deferring sending the event until GetDeviceProperties
returns. I observed this race being triggered consistently on an IronKey
D300s drive, which initially presents itself as a CD drive.

Bug: 1146325
Change-Id: I2a6b6c352b36c1e06a7ddaa49d5b987e7458c8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592575Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837848}

This reverts commit 994bc2bd.

Reason for revert: I noticed there were some artifacts appearing in ChromeOS system UI (on the shelf). This was caused by double backdrop blur. Previously, damage expansion for pixel-moving filters was solely done in viz::SurfaceAggregator, which includes expanding damage with |surface_root_rp_damage|, so it didn't need damage expansion done in cc::DamageTracker, before setting |intersects_damage_under|. The change in the CL made the damage intersection check in SurfaceAggregator::Prewalk to depend on |intersects_damage_under|, this requires |intersects_damage_under| to be set correctly in cc. In other words, in cc::DamageTracker, we should expand damage by any pixel-moving filters so the damage under double blur in the SAME surface could be counted for.

Original change's description:
> Fixed: launcher not using backdrop filter cache when appropriate.
>
> Launcher has a backdrop blur filter so when there is no activity, i.e.
> damage, under it, the backdrop filter cached result should be used. The
> bug was caused by damage accumulation taking into account the damage
> from above or on the RP with the backdrop filter.
>
> Change-Id: Ie98f9e4d32ec9f7b955da505276def18590a623d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494060
> Reviewed-by: kylechar <kylechar@chromium.org>
> Commit-Queue: Jun Liu <yjliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821384}

TBR=kylechar@chromium.org,yjliu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I09f36f2b0e9f19f3450199b5da3126469bc6a2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593359Reviewed-by: Jun Liu <yjliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837847}

This CL converts this base::Closure to base::RepeatingClosure. It
needs to be a RepeatingClosure because at
MTPDeviceDelegateImplLinux::CreateSingleDirectory, it is used
to bind twice.

Bug: 1152278
Change-Id: I982c9a7ff93c9e03d27af8825034c5c0c8bbf66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595632Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837846}

Migrate uses of the relevant set_* functions on the sql::Database object
to use the new DatabaseOptions constructor instead.

This change should have no intended behavioral effect.

Bug: 1126968
Change-Id: I500612cf31a29d0529337d65eccb7724a1e20ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595925Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837845}

Roll Chrome Win64 PGO profile from chrome-win64-master-1608119279-c2227cc33d0350f20f44d9be3f390190e6aa297e.profdata to chrome-win64-master-1608141458-dd35fe4430452753fc5df1ee6d76467993c9bca7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ic7eece835f6bffb1484219b6f3126d670cfb8911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595700Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837844}

This updates the expiry_milestone for the
enable-desktop-pwas-app-icon-shortcuts-menu flag to M93. We'll need this
flag for the upcoming macOS implementation for Shortcuts Menu.

Bug: 955497
Change-Id: I03eeb5dbe27d4ce4938430a0c45cbcf276859c48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595856
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837843}

BUG=1154591

Change-Id: I921bed5c14bdf8350b4e05d544537f012251d380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576986
Commit-Queue: John Palmer <jopalmer@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837842}

This CL adds an explicit [Exposed=(Window,Worker,Worklet)] declaration
to the ReadableStreamDefaultController WebIDL file as it was added
in a new version of the Streams spec, based on https://github.com/whatwg/streams/issues/963.

Intent To Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/yZuxrW9zhAs/m/6bXDaW2mAwAJ

Bug: 1093862
Change-Id: I2bd0c759d856c176037231adbe7e679ccea945c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570755Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Cr-Commit-Position: refs/heads/master@{#837841}

This CL provides a shill error message to notifications when
Connect fails with an immediate error (which does not set the
Service.Error property).

It also provides a message for kErrorResultNotOnHomeNetwork.

BUG=1137966

Change-Id: I8982c5a0087cc4b15b36f72c3db64b16f1f6f8bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575381
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837840}

There may be a race condition for when the JavaScript to query a child
in the shadow DOM of a tabstrip-tab-group element runs immediately after
the test adds a tab to a group. This CL waits for the tabstrip-tab-group
element to appear on the page before running this query.

Bug: 1132300
Change-Id: I228f694ffeffa5c9bf303f4952fbbabef8f2334e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594507
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837839}

This is a mechanical change that renames deprecated macro replacing:

- BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}),
- gn var is_{ash,lacros} with is_chromeos_{ash,lacros}.

http://go/lacros-macros

Bug: 1052397
Tbr: dcheng@chromium.org,zmo@chromium.org
Change-Id: I7eff0c9e5e705fe0940e6595eb0f54de3f3bb6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592078Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837838}

TBR=bling-team@google.com

Change-Id: I328fb7eee3a7b1ee5da3ff153322f2630f30a47f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595930Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837837}

Notably, remove the log, "Overwriting private certificates pref with X
certificates." Some certificate might be overwritten but with no
material changes. For example, consumed salts--used to encrypt the
metadata key during advertising--need to be stored in the private
certificate. That update overwrites the certificate, but the certificate
remains essentially the same.

Change-Id: I99b120689d1371f844dac682c2e1c398d65b4c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595191
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#837836}

Bug: 1152279
Change-Id: I2e493d1bda58742080d70a3a80d2652adcd93792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594017
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837835}

In certain languages the done title text needs to wrap, so we reduce the
width to align with the buttons underneath.

http://screen/5XLCiXVLPV6zxXS

Bug: 1059779
Change-Id: I576acceed8eae33a4486afe8b9aee8865bf4ee7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593719Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837834}

This is a mechanical change that renames deprecated macro replacing:

- BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}),
- gn var is_{ash,lacros} with is_chromeos_{ash,lacros}.

There is a section about the renaming on http://go/lacros-macros.

Bug: 1052397
Change-Id: Iab924af8d28426a60a28d505aeae99ec43717b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593853Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837833}

Some of the printer Tast tests use this attribute.

Bug: none
Change-Id: I07543b408f0282fec6077774bfad91a866b2f4d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591914
Auto-Submit: Pranav Batra <batrapranav@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837832}

This is a mechanical change that renames deprecated macro replacing:

- BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}),
- gn var is_{ash,lacros} with is_chromeos_{ash,lacros}.

There is a section about the renaming on http://go/lacros-macros.

Bug: 1052397
Change-Id: I281524bf9fecaa6ed36cf1de87221a79506ec0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594623Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837831}

This reverts commit c669ac6b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 837649 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzY2OWFjNmIyZmYzMWU2OTk5N2U1MTM1MzBjZTEwOTVlODI2MTBiYQw

Sample Failed Build: https://ci.chromium.org/b/8860723769678942640

Sample Failed Step: browser_tests on Mac-10.15

Sample Flaky Test: All/PaintPreviewBrowserTest.DontReloadInRenderProcessExit/FileSystem

Original change's description:
> [Paint Preview] Post task captured callback
> 
> This CL attempts to fix a bug where calling
> WebContents::DecrementCapturerCount in the callback passed to
> PaintPreviewClient can result in reloading a crashed render frame.
> This is problematic and crashes if it occurs inside RenderFrameDeleted
> and PaintPreviewClient::OnFinished is invoked. By posting the callback
> it should be invoked after RenderFrameDeleted cleanup is done resulting
> in DecrementCapturerCount no longer being called inside
> RenderFrameDeleted.
> 
> Bug: 1146573
> Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
> Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#837649}


Change-Id: Id23bade14aba40cafee9748b661597e8c04fb1fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1146573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595859
Cr-Commit-Position: refs/heads/master@{#837830}

This CL exposes the Java API to add the x-geo (geolocation) header based
on URL and Profile. Because prefetch isn't visible to the user or tied
to a tab, this exposes a version of the Java API that does not use Tab
to determine if the permission can be granted.

I added a dedicated bridge file on native to deal with unused build
errors when including the JNI header in two different native cc files.

Bug: 1138648
Change-Id: Ib66469f82a6b2737a4679ea3a911051ad33a16c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559228
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837829}

Update all the help links with the p-link for the scanning support
article.

Bug: 1059779
Change-Id: Ie6d04ad168de7a97f4afbb042c747000d60376a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596421Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837828}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/df6c3b4a..72c5b04f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1f14a2fc101b26771c45768339e9b85a53854118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596017Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837827}

This expires in 89 and we've launched, so let's remove it.

Bug: 1068851
Change-Id: I3ae1aab05df1c6badf92d0fa9bb3283ec5e37821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596277Reviewed-by: Rachel Wong <wrong@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837826}

BUG=1142103
TEST=./generate_buildbot_json_coveragetest.py

Change-Id: If3966a93e875c775b15da2c30b11309b5b5b39e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586272Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837825}

This test makes sure highlighting text in a disabled control still
scrolls. At device scale factor = 1.5, the entire text of the
control almost fits in the field. This CL adds more text. It also
changes the text of the test to indicate what should happen, not
what shouldn't happen.

Fixed: 1101178
Change-Id: I15e831bc2bf2d027f4c66e600fae262bdead2bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594311Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837824}

For languages with long translations for the settings labels, this
forces them to wrap instead of pushing the dropdowns out further to the
right.

Bug: 1059779
Change-Id: I8649605d6b4812508b4ad18ac493b8e07bac91c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595475Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837823}

Fixed: 1157108
Change-Id: I25e82866706a81d579c338e15a1cdfd011e5d2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594092Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Shane Fitzpatrick <shanefitz@google.com>
Cr-Commit-Position: refs/heads/master@{#837822}

Bug: 1152282
Change-Id: Ib5c3905e9a06926701be42fcf7913392a380657f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592011Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837821}

http://screen/9h6LUEHGXebCfzv

Bug: 1158473
Change-Id: I568e0e72e12636799491584ad7f65f84e0305df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593510Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837820}

Also removes some references still in the code. Calls to these
references were already removed.

The runtime flag for |NGFragmentItem| is still in the code.
Removing it will be in following patches.

Bug: 1154531
Change-Id: I98fa03d124d8f7684b3974eae2c6e6b82d38e25b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589576
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837819}

Previously, clients interested in seeing thumbnail updates had to
derive from ThumbnailImage::Observer and register themselves with
ThumbnailImage.

Removing ThumbnailTabHelper and ThumbnailImage from the public API and
instead exposing a global ThumbnailService is a design
goal. ThumbnailImage::Observer makes this refactor difficult.

This CL uses a callback-based subscriber model instead.
base::Callbacks replace observer methods. Hints are supplied
directly on the subscription object. The subscription models loosens
the coupling between clients and ThumbnailImage.

Clients subscribe by ThumbnailImage::Subscribe(). Subscription can
later be pushed up easily to the ThumbnailService level by a method
like ThumbnailService::Subscribe(content::WebContents*).

Bug: 1090038
Change-Id: I020d848e00331d5f5bbb562f0c53aec5f8ccbc62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593158Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837818}

If the user opts out of displaying phone notifications we should not
attempt to process any incoming notifications. This change adds an
additional check to ensure that notifications are allowed before
processing any new incoming notifications.

Fixed: 1158612
Test: chromeos_components_unittest
Change-Id: Idfa464dd0dcc4e4ee225ebb4405a0da3c87d8f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594563
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837817}

Replaces use of RenderFrameHost pointers as keys with FrameTreeNode IDs
in certain ContentSubresourceFilterThrottleManager maps.

Those maps track frames by detecting cross-process navigations in
ReadyToCommitNavigation. This migration removes the requirement for the
special logic, improving readability and reducing the risk of missed
edge cases.

Bug: 1151500
Change-Id: I2ec236c58101fc956c2ff87538c77fd191fe3c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561207
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837816}

The bounds will be used to allow capturing while the user scrolls.

Bug: 1153969
Change-Id: Ib29dfde98bedae3e26c55893fd7177f4166f4a00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594180
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837815}