- 18 Oct, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bad9daf2..fc50b795 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48cca61759ee0a79b921edd7a8151eedd037df96 Reviewed-on: https://chromium-review.googlesource.com/c/1288711Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600789}
-
Christian Biesinger authored
ComputeOverflow already calls these functions Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1af510148708078689fb421a750ae8d2eb82087a Reviewed-on: https://chromium-review.googlesource.com/c/1287249Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600788}
-
Bo Liu authored
This CL only moves onPageStarted of *renderer initiated* navigation to navigation commit. Browser initiated navigations are not changed. WebContentsObserver.didFinishNavigation is navigation commit, which is where onPageStarted of successful navigation is called. On error, onPageStarted is called from AwContentsClientBridge.onReceivedError. In order to distinguish between browser-initiated and renderer-initiated navigations, need to plumb the bool to all of these call sites. * Add new parameter to java WebContentsObserver.didFinishNavigation which requires updating a bunch of overrides. * Add isRendererInitiated to java NavigationParams. * Use ui::PageTransitionIsWebTriggerable to approximate renderer-initiated. New bool in AwWebResourceRequest is optional because there are code paths that do not have this information, and do not need it. Other changes: * Update WebContentsObserverProxy::DidFinishNavigation to return the base url if it is not empty. This ensures the new onPageStarted uses the same url as before. * Change LoadUrl calls to PageTransition.TYPED. This matches expectation better and make ui::PageTransitionIsWebTriggerable work. * Do not call didFailLoad, which calls onPageFinished, if navigation did not commit. This can happen for downloads. * Also add isDownload to WebContentsObserver.didFinishNavigation. This is important for suppressing onPageStarted and onPageFinished for downloads due to content-disposition: attachment * Add tests for all of the cases discussed here Bug: 896022 Change-Id: Ia30f733a9f4b0684683fe5594305a72b611f0442 Reviewed-on: https://chromium-review.googlesource.com/c/1270096Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600787}
-
Clark DuVall authored
This implements the DRP logic for only using CORE proxies when proxying RESOURCE_TYPE_MEDIA requests. A similar approach is used to DataReductionProxyDelegate, which uses an MRUCache to associate URLs to resource type during proxy resolution, since the ProxyDelegate only has access to the URL. Bug: 721403 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib1c50dbc1344535e46c80b2d3a900dbb6b215141 Reviewed-on: https://chromium-review.googlesource.com/c/1274526 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600786}
-
Daniel Rubery authored
There are two problems with the CheckClientDownloadRequest that this CL takes steps towards resolving. First, the control flow of the CheckClientDownloadRequest is very difficult to follow due to a large number of private helper methods. Secondly, it uses several techniques to prevent use-after-free (ref-counting, weak pointers, and cancellable tasks). This CL encapsulates the logic that was in CheckClientDownloadRequest that was related to analyzing the content of the file into a singly-owned class, so that those two concerns can be more easily addressed. TODO: The FileAnalyzer still needs to be tested for RAR files. Bug: 889986 Change-Id: I81c02bd3491c116a949dc959f2f02208511209bd Reviewed-on: https://chromium-review.googlesource.com/c/1272275 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600785}
-
danakj authored
Currently it is part of WebWidgetClient, but it is a global value for the ChromeClient-Page-WebView rather than a value per widget/frame. In the future we can move this to a separate IPC routed to the RenderView instead of the RenderWidget. R=avi@chromium.org, dcheng@chromium.org Change-Id: I7d10fc56e31d163fb8476b85c987f0122a7b1eb6 Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1279243 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600784}
-
Steven Bennetts authored
ChromeKeyboardControllerClient is going to need to keep track of when the KeyboardController is (actually) enabled and disabled. This CL: * Replaces the KeyboardControllerObserver::OnKeyboardDisabled with a more generalized OnKeyboardEnabledChanged. * Replaces the (poorly named) mojom::KeyboardControllerObserver:: OnKeyboardWindowDestroyed with OnKeyboardEnabledChanged. * Eliminates the now redundant VirtualKeyboardControllerObserver with KeyboardControllerObservers, reducing overall complexity. * Modifies exo/keyboard.cc to directly observe keyboard::KeyboardController instead of ash::VirtualKeyboardController and ash::AccessibilityController. For minor change to test_suites.pyl: TBR=bpastene@chromium.org Bug: 843332 Change-Id: I808c1f4ca3e732aa9b606810caa12533b9da8158 Reviewed-on: https://chromium-review.googlesource.com/c/1285329Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600783}
-
Kevin McNee authored
I previously made the DCHECK in WebGestureEvent::NeedsWheelEvent more strict, but overlooked these callers. Here we update these remaining callers so that they won't hit the DCHECK. Bug: 787924, 802369 Change-Id: I65ae2dc873b25d0a3d770f2581a278b06ce7e7d8 Reviewed-on: https://chromium-review.googlesource.com/c/1286767Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#600782}
-
Colin Blundell authored
Forgot to do this (again) in the CL converting away from these utils. TBR=droger@chromium.org Bug: 896180 Change-Id: I3845417f5884d5adfb048d919931a6e021221e6f Reviewed-on: https://chromium-review.googlesource.com/c/1288869Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600781}
-
Allen Webb authored
This needs to be enabled by Finch instead of disabled by finch. This in principle reverts but revision exceptions were blocking the merge: https://chromium-review.googlesource.com/1176475 BUG=chromium:889118 Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95 Reviewed-on: https://chromium-review.googlesource.com/c/1288709 Commit-Queue: Allen Webb <allenwebb@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#600780}
-
Robert Ogden authored
There's a few bug fixes in this CL but it seems ok to lump them together since each bug is in a separate file. CustomTabActivity.java - don't show AMP UI on a Preview ToolbarManager.java - also update Previews UI on commit ToolbarModel.java - explicity remove the scheme from Previews Bug: 896478 Change-Id: Id8353a8787481bf4fcbfa322994d8b0ec998d6df Reviewed-on: https://chromium-review.googlesource.com/c/1287289 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600779}
-
Peter Wen authored
TBR=agrieve@chromium.org Bug: 620034 Change-Id: I1e0b1d665692cc727453c7c974402d71aa4bc01b Reviewed-on: https://chromium-review.googlesource.com/c/1288889Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600778}
-
Friedrich Horschig authored
Before the keyboard accessory was visible on password fields only, it was correct to suppress the InfobarContainer until the accessory disappeared. Now that the accessory can disappear while keeping the keyboard open, the Infobar would be shown with an open keyboard. This CL fixes this unwanted state by checking keyboard visibility explicitly. This is an intermediate solution until crrev/c/1286426 lands. Bug: 895779 Change-Id: I1d24b5c71ce094102e9860cd415277d9570c19df Reviewed-on: https://chromium-review.googlesource.com/c/1286820 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#600777}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25843dd65181..945dea36ab8a git log 25843dd65181..945dea36ab8a --date=short --no-merges --format='%ad %ae %s' 2018-10-18 jsaarhelo@nvidia.com Clamp glClearDepthf and glDepthRangef Created with: gclient setdep -r src/third_party/angle@945dea36ab8a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I571b1ab2f8e9033d5d560b0572996237583daa64 Reviewed-on: https://chromium-review.googlesource.com/c/1288690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600776}
-
Charlie Harrison authored
Bug: b/117813236 Change-Id: I5f4d9753463e66fed0c336fa546ef80805586847 Reviewed-on: https://chromium-review.googlesource.com/c/1287049 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600775}
-
Olivier Robin authored
The iframe support has been developped. I tested locally and the test passes in the conditions described in crbug.com/857129 Renable WebStateTest.MessageFromIFrame tentatively. Bug: 857129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifab8070aa3c70447aa49f6b65ca2010fb5f49573 Reviewed-on: https://chromium-review.googlesource.com/c/1283073 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600774}
-
Etienne Bergeron authored
This CL is adding a renderers specific tracing scenario. The previous tracing scenario was BENCHMARK_IPC which is not given enough details to make renderers traces actionnale. We are making a specific scenario and will add the required category to debug renderers issues. R=gab@chromium.org, oysteine@chromium.org Change-Id: I8e0dbce3f18a403de6f0f7bb4c63abf4a1b53f66 Reviewed-on: https://chromium-review.googlesource.com/c/1286770 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#600773}
-
Will Harris authored
Re-run testing/buildbot/generate_buildbot_json.py BUG=868024 Change-Id: Iae857082985de453d256150f2ef653f9f570337f Reviewed-on: https://chromium-review.googlesource.com/c/1286757 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#600772}
-
Kent Tamura authored
* FooBarNames::FooBarNamesCount -> FooBarNames::kNamesCount * FooBarNames::FooBarTagsCount -> FooBarNames::kTagsCount * FooBarNames::FooBarAttrsCount -> FooBarNames::kAttrsCount * FooBarNames::getFooBarTags() -> FooBarNames::GetTags() * FooBarNames::getFooBarAttrs() -> FooBarNames::GetAttrs() This CL has no behavior changes. Bug: 889726 Change-Id: Ic9af4a9e267b816456e85c22bbd6079f5581c599 Reviewed-on: https://chromium-review.googlesource.com/c/1288519 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#600771}
-
Xida Chen authored
Right now the CSSPaintDefinition::Paint takes a IntSize which is the container size with subpixel snapping. At this moment there are two type cast: 1. The call site of the CSSPaintDefinition::Paint converts a FloatSize to IntSize 2. Inside the CSSPaintDefinition::Paint, GetSpecifiedSize is called which type casts the IntSize to float and uses it. This CL cleans it up by passing a FloatSize. That is, the Paint function takes a FloatSize such that type casting can be avoided at the GetSpecifiedSize. When we need to use the subpixel snapped size in the Paint function, we then conver the FloatSize to an IntSize. This CL should not introduce any behavior change. Bug: None Change-Id: I1387145c03b60380a0e0a53f2686647a54327e71 Reviewed-on: https://chromium-review.googlesource.com/c/1286440Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600770}
-
Rayan Kanso authored
According to the spec, responseReady in BackgroundFetchRecord should throw an AbortError DOMException if the fetch was abandoned. https://wicg.github.io/background-fetch/#create-record-objects (2.4.3) Change-Id: Ieadf278acd061e05b8822014d0934f050fcac702 Reviewed-on: https://chromium-review.googlesource.com/c/1283692 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600769}
-
Rayan Kanso authored
In addition, MatchAll should return all records, including unprocessed ones. To support this, the following changes were made: - Creating a registration also stores all the requests with an empty response in the cache. - When an individual request is processed, the failure reason (if any) is stored in the metadata. - The logic of GetSettledFetchesTask was moved to MarkRegistrationForDeletionTask. It checks the metadata rather than the cache itself to find a failure reason (if any). - Match/MatchAll logic was moved to a new database task (MatchRequestsTask). A new API call was added to the cache storage to allow querying request/response pairs. If a response is found to be empty it will be exposed as a nullptr. Change-Id: I631a3ef3da95117aed759a675fe591da5201eeca Reviewed-on: https://chromium-review.googlesource.com/c/1280851Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600768}
-
Colin Blundell authored
This is possible now that there is //chrome-level infrastructure for glueing an IdentityTestEnvironment instance to a Profile. Note that this particular test is somewhat unusual in that it builds multiple Profiles but does not require IdentityTestEnvironment to interact with those Profiles beyond doing initial configuration. For simplicity, we use local variables for the IdentityTestEnvironment associated with each Profile; otherwise, we would need to introduce distinct instance variables for the two. This CL also modifies the relevant IdentityTestEnvironmentProfileAdaptor APIs to return the TestingProfiles that they create as TestingProfiles; this avoids a cast that this test would otherwise require and clarifies the APIs. TBR=droger@chcromium.org Bug: 896180 Change-Id: Icba8cdc67c1667949636a96078f05e15fd79649c Reviewed-on: https://chromium-review.googlesource.com/c/1283038 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#600767}
-
Tavis Maclellan authored
Cast needs both render process ID and render frame ID for resolving URL requests to owning render frame / web contents. Bug: internal b/116784351 Test: Build cast_shell and run unittests Change-Id: Ib1913e41f33410241fe4d63fffa6c1ee68e18be3 Reviewed-on: https://chromium-review.googlesource.com/c/1280930Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Tavis Maclellan <maclellant@chromium.org> Cr-Commit-Position: refs/heads/master@{#600766}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/dom_distiller. This CL was uploaded by git cl split. R=bengr@chromium.org Bug: 809610 Change-Id: I30fc5cf421d359ac3072b38b940a783737e66f38 Reviewed-on: https://chromium-review.googlesource.com/c/1259023Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600765}
-
Charlie Harrison authored
All the functionality is in ContentSettingBlockedImageModel. This CL should have no behavior changes. Bug: None Change-Id: I7694d5968cbb514c0959d821bf0888a770477a0c Reviewed-on: https://chromium-review.googlesource.com/c/1287314 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600764}
-
Mugdha Lakhani authored
BackgroundFetchSettledFetch isn't exposed to JavaScript so we can remove this. Bug: 875201 Change-Id: Ic306b0f64897a7d7c1fbd61f64b6c635620d7bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1288357Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/sockets_udp. This CL was uploaded by git cl split. R=rkc@chromium.org Bug: 809610 Change-Id: Id800ae4bd2e053483b447457cd78cb50657d8ace Reviewed-on: https://chromium-review.googlesource.com/c/1259032Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600762}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 681136 Change-Id: I860ea8a950d3802572c22aaeecba23f716f55d5b Reviewed-on: https://chromium-review.googlesource.com/c/1288339Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600761}
-
Ned Nguyen authored
This also updates how we compute the default for 'configuration'. First, we try to look for the configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the value of configuration using the target value. Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. Bug: 893618 Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 Reviewed-on: https://chromium-review.googlesource.com/c/1281043Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#600760}
-
Yi Su authored
Add SearchEngineTabHelper without any functionality. This TabHelper will be the main worker for custom search engines feature. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie18b9237d0f1df52d94ff2c9b4e70b299ab426b1 Reviewed-on: https://chromium-review.googlesource.com/c/1288431 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600759}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 753973 Change-Id: Ia8531202caddd46a45169eae9b5b8af77585ab80 Reviewed-on: https://chromium-review.googlesource.com/c/1288173Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600758}
-
Tommy Martino authored
This CL implements footers in the Autofill dropdown on legacy (Jellybean - Marshmallow) Android. It does so by implementing an interface method which is currently empty. This also required AutofillPopup to be changed slightly, as the new implementation cannot be invoked after show()ing the popup. Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1 Bug: 896693 Reviewed-on: https://chromium-review.googlesource.com/c/1281723 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#600757}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 681136 Change-Id: I54485b40c1808525659f4af61369a04819c40e06 Reviewed-on: https://chromium-review.googlesource.com/c/1288493Reviewed-by:
-
Daniel Cheng authored
Bug: 891908 Change-Id: I5bbe921e0cf8462abe9be3c75c594e4a507d3118 Reviewed-on: https://chromium-review.googlesource.com/c/1280613 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600755}
-
Dave Tapuska authored
BUG=242216 Change-Id: I6f897509727b026b9d1f17227b0621b30821cc56 Reviewed-on: https://chromium-review.googlesource.com/c/1286937 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600754}
-
David Bokan authored
Bug: 798719 Change-Id: I371d41833373fe54efeb844a338840b7d862784c Reviewed-on: https://chromium-review.googlesource.com/c/1287188Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600753}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/413a5120b915..2d0fa5b17840 Created with: gclient setdep -r src-internal@2d0fa5b17840 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f6b61884ad88120573c736f2ebc486871527544 Reviewed-on: https://chromium-review.googlesource.com/c/1288681Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600752}
-
Ramin Halavati authored
A feature and flag is added to control adding an incognito window counter to the incognito icon on toolbar. Bug: 896235 Change-Id: Ic0766f2344d9caefc7ede1e5266df053d32ef2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1286423 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This eliminates the use of V8CallBoolean. Bug: 670615 Change-Id: Ifaaa803e47b08018546d30ad633f861f38a8d645 Reviewed-on: https://chromium-review.googlesource.com/c/1288673Reviewed-by:
-
