- 27 Jun, 2018 40 commits
- 
- 
Justin Cohen authoredBug: 852705 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I611e9625e988e077f61e71e58a7f44b741a20eab Reviewed-on: https://chromium-review.googlesource.com/1116702Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570800} 
- 
Scott Graham authoredThis reverts commit 0895c797. Reason for revert: Missed a hardcoded gn location: https://crbug.com/857107. Original change's description: > Pull GN via CIPD package > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where gn is no longer in buildtools. > > Because buildtools has no way to cleanup after itself, add > build/util/gn_cleanup.py to delete the old binaries so that we don't > accidentally depend on them. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Bug: 855791 > Bug: 794764 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 > Reviewed-on: https://chromium-review.googlesource.com/1112840 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570792} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I89e180710b5ce483106fa3b4ff6e8dec06780c07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 794764, 856883, 856884, 856878, 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117219Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570799} 
- 
danakj authoredIf the gpu process crashes, the viz service is gone and bitmaps need to be re-registered, but they are still valid bitmaps. So we can keep the ResourceId alive and not returned it as lost to the client in that case. R=kylechar@chromium.org Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1ef6af3a90bf90310793fcdbbb70ea00a0d85d25 Reviewed-on: https://chromium-review.googlesource.com/1115591Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570798} 
- 
Qiang Xu authoredchanges: MagnifierType is only used in chrome/. This CL moves it to chrome/. TBR=emaxx@chromium.org Bug: none Test: compile Change-Id: I75241de96f77004b906cfb762829c9bd01e470b9 Reviewed-on: https://chromium-review.googlesource.com/1116760 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#570797} 
- 
gogerald authoredBug: 856743 Change-Id: Icee41ddd6bd4d593ae19b12ac601644d0a004be1 Reviewed-on: https://chromium-review.googlesource.com/1115803 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570796} 
- 
Adithya Srinivasan authoredUsing a double timestamp is error prone and it's hard to tell which units are being used. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bb9e1fba0df15be9954cf055abed78016c39c9a Reviewed-on: https://chromium-review.googlesource.com/1114180 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570795} 
- 
Jonathan Backer authoredContextState is meant to track GL state. It is used for virtual context switching and temporary changes to GL state (e.g. temporarily change GL state and restore back to ContextState). Whenever we call Ganesh we must assume that GL state has diverged from ContextSate. This CL does 2 things within RasterDecoder: (1) Whitelists certain commands as not caring if GL state has diverged from ContextState. This would be if the command doesn't access GL state (e.g. InsertSyncPoint) or is using Ganesh (RasterCHROMIUM). (2) Does a hard reset back to ContextState whenever the GL state could have diverged from ContextState and a command is not whitelisted. The purpose of the whitelist is to avoid unnecessary state resets on the common OOP-R codepaths. Correctness: - GLES2Decoder: The GL state matches the ContextState before and after a command is executed here. The interesting case is making a GLES2Decoder current. If using a virtual context, we will restore state appropriately when the GLES2Decoder is made current because of RasterDecoderImpl::GetContextState. - RasterDecoder: There are two cases to consider Case 1: Making a RasterDecoder current. If we are using virtual contexts, we will restore to |state_| and GrContext::resetContext because of RasterDecoderImpl::{GetContextState,RestoreState}. If not, we will restore to the previous GL state (either |state_| or GrContext consistent with previous GL state). Case 2a: Executing a whitelisted command: Either the command doesn't inspect/modify GL state (InsertSyncPoint, CreateAndConsumeTexture) or it requires and maintains that GrContext state tracking matches GL context state (e.g. *RasterCHROMIUM). Case 2b: Executing a command that is not whitelisted: We now force GL state to match |state_| with as necessary RestoreState(nullptr). This will GrContext::resetContext. Bug: 856219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I85d9391f833760b37cb70d216e9e1e44ffe1c23f Reviewed-on: https://chromium-review.googlesource.com/1114136 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570794} 
- 
Owen Min authoredBug: 855378 Change-Id: I4c14ad013f891f6abe76604321c52e97cecaf874 Reviewed-on: https://chromium-review.googlesource.com/1115433Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570793} 
- 
Scott Graham authoredThe gn binary will be downloaded into third_party/gn. This CL rolls buildtools forward to a revision where gn is no longer in buildtools. Because buildtools has no way to cleanup after itself, add build/util/gn_cleanup.py to delete the old binaries so that we don't accidentally depend on them. Update mb.py to use the new location. Update explicit location in ios/web_view/BUILD.gn for the new location. Update explicit location in tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new location. Update explicit location in tools/licenses.py with for the new location. Bug: 855791 Bug: 794764 Bug: 856883 Bug: 856884 Bug: 856878 Bug: 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 Reviewed-on: https://chromium-review.googlesource.com/1112840 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#570792} 
- 
Xiaocheng Hu authoredPrevious CL crrev.com/c/775550 was supposed to be pure refactoring, but changed behavior that ComputeInlineBoxPosition no longer enters inline blocks, because the CL moved the branch handling atomic inlines above the branch that moves input position into inline blocks. This patch fixes the regression by moving the branches back to their old positions. Bug: 856417 Change-Id: I94a22259f723af11b701d3a1078e68b5729bb0d0 Reviewed-on: https://chromium-review.googlesource.com/1116357Reviewed-by: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570791} 
- 
Kouhei Ueno authoredThis CL follows signed exchange spec change: https://github.com/WICG/webpackage/commit/3903da6e Bug: 803774 Change-Id: I7f122272cf93f46a26757b08fe8a9d80f0404518 Reviewed-on: https://chromium-review.googlesource.com/1114403Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#570790} 
- 
Kevin McNee authoredIn EventFactoryEvdev::DispatchPinchEvent, we were attempting to set the scale for pinch begin (and end) events, instead of just pinch update events, which hits the DCHECK in GestureEventDetails::set_scale. Bug: None Change-Id: I6fc89469b4ec1ddc21f102cf3bb181e10243c545 Reviewed-on: https://chromium-review.googlesource.com/1114249Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#570789} 
- 
perfetto-chromium-autoroll authoredhttps://android.googlesource.com/platform/external/perfetto.git/+log/fa2ef190cd68..32dc063f6647 git log fa2ef190cd68..32dc063f6647 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 lalitm@google.com Merge "trace_processor: cleanup code in trace parser" 2018-06-25 lalitm@google.com trace_processor: cleanup code in trace parser Created with: gclient setdep -r src/third_party/perfetto@32dc063f6647 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I91d82b062e45888e587348cadc80a356a3124686 Reviewed-on: https://chromium-review.googlesource.com/1116818 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570788} 
- 
Emily Hanley authoredBug: 840427 Change-Id: I1f11ed443c31afe50607cde766df13e610a07762 Reviewed-on: https://chromium-review.googlesource.com/1104793 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570787} 
- 
James Wallace-Lee authoredWhen a button's textContent changes, post a textChanged notification. A button's textContent is a child of the button container, but in the accessibility tree button elements cannot have children, so ChildrenChanged previously did not update the button. Bug: 793078 Test: DumpAccessibilityTreeTest.AccessibilityButtonContentChanged Change-Id: I2be389c77763cb60fd2fc9951070370856b0c894 Reviewed-on: https://chromium-review.googlesource.com/1110658 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570786} 
- 
Marc Treib authoredIt was never accurate: It was recorded during most profile destructions, even if Sync was never enabled in the first place. Since I'm not aware of anything that depends on this number, let's just get rid of it rather than replace it with something that works. Bug: none Change-Id: I397e499f559852188c731c04cbb748f98a69fe24 Reviewed-on: https://chromium-review.googlesource.com/1117068Reviewed-by: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570785} 
- 
Vaclav Brozek authoredCurrently, chrome://password-manager-internals shows AutofillField::Type() as server predictions. This is not completely accurate, because Type() comes from multiple sources, and actually, it is AutofillField::server_type() which is passed to the password form parser as server predictions. Therefore this CL changes the internals page to output server_type() instead. Bug: 855987 Change-Id: Ib4bf8cdcbca21ee38450d6d0a0026dd2da71b2e5 Reviewed-on: https://chromium-review.googlesource.com/1114850Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570784} 
- 
Joshua Pawlicki authoredBug: 855724 Change-Id: Ib0a7ccc2f2fe272d53d19ef833b47dcf3994b0ba Reviewed-on: https://chromium-review.googlesource.com/1114096Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#570783} 
- 
sczs authoredThis was ported from the legacy implementation and its no longer needed now. Bug: 839384 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia3edcfb790ec3567fb24b0ebbb02903d5788fec1 Reviewed-on: https://chromium-review.googlesource.com/1116285Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#570782} 
- 
Josh Karlin authoredWhat: PrioritizedTaskRunner currently runs its tasks (from RunTaskAndReply) in prioritized order but not the replies. This CL adds a priority queue for replies to run in order as well. Why: At least for the cache, the reply task is equally important to the posted task and should run in priority order. Bug: 856674 Change-Id: Icea37adb96891473292e0c38805c42e84f9d4f5f Reviewed-on: https://chromium-review.googlesource.com/1114921Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570781} 
- 
sczs authoredCq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I312851c5408ad34f690dc0b456612506350d8be7 Reviewed-on: https://chromium-review.googlesource.com/1116347Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#570780} 
- 
Rayan Kanso authoredDatabaseTasks can create subtasks out of other DatabaseTasks in order to re-use components and not rewrite code. Change-Id: I04d84e90ddf4e2ac1986f7ccff122d210523d752 Reviewed-on: https://chromium-review.googlesource.com/1112665 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570779} 
- 
Mustaq Ahmed authoredWith User Activation v2, activating a parent frame doesn't activate its subframes. We fixed these two tests by sending the click to subframes. This needed a workaround in auto-click.js because the mutation observer there in doesn't seem to work when a button element is added to a subframe. Bug: 802371 Change-Id: I786668c87b802565e99ad16223cafc8ac1fd6296 Reviewed-on: https://chromium-review.googlesource.com/868323Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570778} 
- 
Justin Cohen authored-Fix tapping NTP action cells when omnibox is focused. -Do not remove action items when most visited is empty. -Disable dynamic type sizes on most visited and action items. -Fix omnibox visibility on iPad when search provider changes. Bug: 846764, 852108, 850469, 848762 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie1c38be47fb9a60325387a78f55eb1a548dae831 Reviewed-on: https://chromium-review.googlesource.com/1110148 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570777} 
- 
Vadym Doroshenko authoredThis CL contains: 1.Filtering blacklisted matches in NewPasswordFormManager. 2.Extracting blacklisted matches to |blacklisted_matches_| variable in NewPasswordFormManager. 3.Implementing functions GetBlacklistedMatches and IsBlacklisted in NewPasswordFormManager. Bug: 854197, 831123 Change-Id: I50476c16c2ebfa8c8a1062889b8d133d323233f5 Reviewed-on: https://chromium-review.googlesource.com/1116962Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#570776} 
- 
bsheedy authoredDisables Skia's CCPR support for the VR browser since it somehow causes serious rendering issues. This workaround can be removed once the root cause is found and fixed. Requires that https://skia-review.googlesource.com/c/skia/+/137763 be landed and rolled first. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4121319cae3a465798077cfeac058d84e9e9dd93 Reviewed-on: https://chromium-review.googlesource.com/1116066 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#570775} 
- 
Arthur Sonzogni authoredThe bug was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1107808 Soon after creating a new provisional DocumentLoader, the parser of the current DocumentLoader is canceled. It can causes document.onreadystatechange to fire. If window.stop() is called it can remove the new provisional DocumentLoader. This CL fixes the bug and add a regression test. Bug: 856759 Change-Id: Ifb39a75d04b250f0c97ebf07c5a9abf1f4631ff7 Reviewed-on: https://chromium-review.googlesource.com/1117038Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570774} 
- 
Allen Bauer authoredBug: none Test: none Change-Id: Ifecd2ab5a68c843a835b68f41bd6ac3b248dabde Reviewed-on: https://chromium-review.googlesource.com/1115217 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570773} 
- 
Marc Treib authoredIsSyncAllowed, IsSyncRequested and HasUnrecoverableError have all been replaced by GetDisableReasons/HasDisableReason, so use those instead. Bug: 839834 Change-Id: Id4939bd4de6a43ae4bfd5c64b6aa79be51a82ebf Reviewed-on: https://chromium-review.googlesource.com/1116704 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570772} 
- 
Nico Weber authoredNot clear why it wasn't running, and network_service_browser_tests, not_site_per_process_browser_tests, viz_browser_tests already all run and pass -- and what's better than running browser_tests three times? Running it four times, so add vanilla browser_tests too. Bug: 843511 Change-Id: I682375c0c4a5a673a0e5410452d5560cad3ccebd Reviewed-on: https://chromium-review.googlesource.com/1117019 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570771} 
- 
Nico Weber authoredThe one test that used to fail seems to pass now. Bug: 815190,843511 Change-Id: I2e77719aa557b2055209d58dcb3c124bc0ad2576 Reviewed-on: https://chromium-review.googlesource.com/1116899Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570770} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/2c74d85c16af..81f51975125c git log 2c74d85c16af..81f51975125c --date=short --no-merges --format='%ad %ae %s' 2018-06-27 titovartem@webrtc.org Fix pylint presubmit errors and warnings from untouched modules. 2018-06-27 titovartem@webrtc.org Extract fft to separate target to be able to move it to third_party Created with: gclient setdep -r src/third_party/webrtc@81f51975125c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id08c24336e0684dc9a932fcd885bdd50e4bdb86d Reviewed-on: https://chromium-review.googlesource.com/1116819Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570769} 
- 
Sahel Sharify authoredWith wheel scroll latching enabled, wheel dom events in a scroll sequence are sent to the target which was under the cursor at the beginning of the scroll and retargeting happens either on the beginning of the next scroll sequence or when the target gets deleted in the middle of the current scroll sequence. With this cl if an event gets prevented by default, the wheel target gets reset to make sure that a new targeting happens for the next wheel event. Bug: 829662 Test: AsyncWheelEventsBrowserTest.WheelEventRetargetOnPreventDefault Change-Id: Id60476ae0772a53e938cf8738283576a8083f6a4 Reviewed-on: https://chromium-review.googlesource.com/1113666 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570768} 
- 
Hwanseung Lee authoredshould throw an InvalidStateError when buffer has been already set in ConvolverNode Bug: 709656 Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147 Reviewed-on: https://chromium-review.googlesource.com/1077713Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#570767} 
- 
Koji Ishii authoredfast/text/emphasis-overlap.html fails in LayoutNG because what it is testing works correctly, but LayoutNG fixed crbug.com/40634 and that difference caused pixels to fail. This patch removes dependency to crbug.com/40634 behavior from the test, and hence it passes in LayoutNG. The behavior of crbug.com/40634 is now split to wpt/css/css-text/white-space/trailing-space-before-br-001.html in r570744 (CL:1116622). TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8acfa36f83bac02ae71bd8907e733f05ecf359fe Reviewed-on: https://chromium-review.googlesource.com/1116511Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570766} 
- 
Jan Krcal authoredThis CL creates the bridge for the autofill_profile sync type. It only implements reacting to local changes, applying sync changes will be implemented in a follow-up CL. The CL only converts relevant unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding to ProfileSyncServiceAutofillTest will come in later CLs. Bug: 836718 Change-Id: Ic91fad53a0623be416ceb4c1f96451c732cf5ac3 Reviewed-on: https://chromium-review.googlesource.com/1113187Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570765} 
- 
Vaclav Brozek authoredThis CL teached the FormData -> PasswordForm parser to prevent the conclusion that there is a confirmation password field on a form which has no new password field. This state does not correspond to reality. Therefore this CL adds a DCHECK to verify this and also a sanitization step for processing the server data. Bug: 845426 Change-Id: I6ffffb31766f9271f0f8021f3aa249d1ee163730 Reviewed-on: https://chromium-review.googlesource.com/1116920Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570764} 
- 
codeimpl authoredThe spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://github.com/WICG/shape-detection-api/pull/41 Bug: 852838 Change-Id: I8666d56fcaf4ac77c29b497827b410ec0aeaa916 Reviewed-on: https://chromium-review.googlesource.com/1102838Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#570763} 
- 
Tiger Oakes authoredsupersize html_report (in //tools/binary_size) is being redesigned to use a tree view to make it easier to navigate. Tree views are more familiar to users and open up additional features we plan to add, such as rendering size diffs by showing negative values. Symbols and files in the tree are organized by size, with larger items on top. You can preview an example report at: https://notwoods.github.io/chrome-supersize-reports/ Alternatively, compile your own report by running: ``` tools/binary_size/supersize html_report chrome.size --tree-view-ui --report-dir size-report -v xdg-open size-report/index.html ``` Design Doc: go/supersize-tree-view-ui Bug: 847599 Change-Id: I78add67bbc759903b1717585a9463dfd08dacceb Reviewed-on: https://chromium-review.googlesource.com/1113848 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570762} 
- 
Raphael Kubo da Costa authoredBack in early 2016, some tests were marked flaky and whatever was causing the flakiness has since been fixed -- they are currently failing because the existing expectations no longer match the results that are produced. Rebaseline the tests and remove them from TestExpectations as per the discussion in the bug, while also adjusting some of the tests in the process: * fast/events/scale-and-scroll-iframe-body.html: Explicitly disable scrollbars in the iframe after http://crrev.com/398951, otherwise we end up with platform-specific PNG expectations due to the differences in the scrollbars. * fast/events/updateLayoutForHitTest.html: Avoid confusion by removing some style assignments that had been causing console errors ever since the test was added more than 10 years ago. Bug: 594672 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I24264f86ce1dcebdac2a6a9f912d3b292d39bdc0 Reviewed-on: https://chromium-review.googlesource.com/1113310Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#570761} 
 
-