- 16 Apr, 2020 40 commits
-
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fit, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I6191eede67d85a8c84bca16a52fdc43e2249541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148894Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#759553}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/694ec49ed075..8c22240b1a04 git log 694ec49ed075..8c22240b1a04 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 582e5284d0f6..0721c1cf2a52 (14 commits) Created with: gclient setdep -r src/third_party/skia@8c22240b1a04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I90003d70f73c0467c23d230fd49c3c3f6c6d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759552}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 555fd40a. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" a2328fd6 "[css-grid] Migrate grid-element-remove-svg-child.html to WPT" 3fb5d786 "Roll external/wpt/webgpu and create wpt_internal/webgpu" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I4f6559885bc0fd542d3bb473f290ae27a64824a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151966Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759551}
-
Kent Tamura authored
- Make LayoutNGMixin<LayoutRubyBase> a friend of LayoutRubyBase because LayoutNGMixin<LayoutRubyBase> accesses some private functions. - Add an Element* argument to LayoutRubyBase constructor. LayoutNGMixin assumes that the constructor of its base class has an Element* argument. This CL has no behavior changes because changes are behind a runtime flag. Bug: 1069817 Change-Id: I0876d76efa8a66a39ba06b4c6df3ccd6f7e3f31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151378Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#759550}
-
Luciano Pacheco authored
The code was performing a regex in all open windows several times, refactor to perform only once. Bug: 1067478 Change-Id: I31d481dfb153f0f47f65bac081f1b4d73dccc8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148793 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759549}
-
Jesse Schettler authored
Make the scanning UI a page of the Print Management app. This allows the page to share API setup and resource loading with the rest of the app. The scanning page can be accessed by navigating to chrome://print-management/scanning.html when the print-job-management-app and scanning-ui feature flags are enabled. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningPageBrowserTest.All Change-Id: I90c235bdc00d7c2599d790b819fa5ced19ad3711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109819Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759548}
-
Yuki Shiino authored
The behavior of On{BeforeUnload,Error}EventHandler has already been supported, but the notation in *.idl files has not yet been supported. This patch makes it possible to write them in *.idl files, and helps the new bindings generator dintinguish error handler types. Bug: 839389 Change-Id: I1cc52407f634bc6ecfd740cf488413901e75cc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150352Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759547}
-
Findit authored
This reverts commit d69aec62. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 759540 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2OWFlYzYyZjkyY2QyMDY2MTE0ZTBkMWFmNGUwODk5MzU3NTUxMmQM Sample Failed Build: https://ci.chromium.org/b/8882888412342833920 Sample Failed Step: compile Original change's description: > Add ServiceWorkerStorageControl::UpdateToActiveState() > > This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). > > Bug: 1055677 > Change-Id: I1444227429fd4c4647198702db79b0d414514571 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759540} Change-Id: I7b8266d5bc681ca86618ab2993efab0a42a396d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152213 Cr-Commit-Position: refs/heads/master@{#759546}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, this migration makes the test and actual crash test as it was meant to be originally, by adding the -crash suffix to its name, and replaces the 'stack' value for grid-auto-flow, deprecated as of 5 years ago, with the 'dense' value, which should be equivalent for the purpose of exercising the engine to ensure no crash happens. Bug: 767015, 1063749 Change-Id: I0b58ad320aaed07d0d76bb31729ee861f7dd4228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149360 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Alexey Baskakov authored
Design doc: go/chrome-bmo-migration. This CL unifies sync-initiated install for server-side bookmark apps to BMO-enabled clients and BMO-disabled clients. We try to install the web app as if the user had requested to install it (in background mode, no dialog). If online install fails, we fallback to WebApplicationInfo data received form the sync server. Note that user_display_mode field from server (aka open_as_window bool) always overwrites a default value. - Extract GetIconSizes() / ContainsOneIconOfEachSize test utils. - Extract SetAboutBlankResultLoaded TestUrlLoader method. Bug: 1020037 Change-Id: I109fa884af1c3b373b2b5922527c98ff6b06a921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126339Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#759544}
-
Kenichi Ishibashi authored
This reverts commit 6d769734. Reason for revert: Broke fuchsia build Original change's description: > Add ServiceWorkerStorageControl::UpdateLastUpdateCheckTime() > > This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). > > Bug: 1055677 > Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759541} TBR=kinuko@chromium.org,bashi@chromium.org,shimazu@chromium.org Change-Id: I489f5363ac6460958c723f6b1d95660d7193fd5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152128Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759543}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in StartupBrowserCreator and StartupTabProvider test are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I15ae29ced658772423994bf5429eeb483b13593a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131327Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#759542}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). Bug: 1055677 Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759541}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). Bug: 1055677 Change-Id: I1444227429fd4c4647198702db79b0d414514571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983Reviewed-by:
-
Jan Wilken Dörrie authored
This change makes util::StrongAlias's APIs constexpr and adds small API improvements, such as a mutable overload for value() and an explicit operator bool for IdType. Bug: 954080 Change-Id: I66fe9e407b9e2b6e64f6a0d8a5664b4573aa26bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150431Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759539}
-
Alan Cutter authored
This CL fixes the warning in app_shell_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ValueStoreTest> value_store_unittest.cc defines a TestWithParam class without instantiating it. Targets that include this via test_support that don't instantiate the test for themselves (dozens) will trigger the warning. Bug: 1045846 Change-Id: If6a87e19af1783a8f58ec3e0ff1f03d933c0251e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143776 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759538}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::GetNewVersionId(). Bug: 1055677 Change-Id: Ia68260e56d0dfa6ade1b32d06d86f8caac52aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145384Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, this migration makes the test and actual crash test as it was meant to be originally, by adding the -crash suffix to its name, and replaces the 'stack' value for grid-auto-flow, deprecated as of 5 years ago, with the 'dense' value, which should be equivalent for the purpose of exercising the engine to ensure no crash happens. Bug: 767015, 1063749 Change-Id: I16250f5c32a5bbd334509d34c49ec6da7900e00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1eb13a3e372..bf0cc7170286 git log f1eb13a3e372..bf0cc7170286 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@bf0cc7170286 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d78cce86a926c10d9a3f54b62fa92d3db0a6eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151843Reviewed-by:
-
Hesen Zhang authored
This is a reland of 02f002af Original change's description: > [Upboarding]: Add a tile group proto. > > Bug: 1068368 > Change-Id: I1a2da9a32a71537abb3fd3626ef2614dcd24e0ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145703 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758600} Bug: 1068368 Change-Id: I1a935a01394b0fed138581ad293c8c2378290163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148118 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759534}
-
Luciano Pacheco authored
Given that this function is async, we can remove callback and the caller sites can use then() or "await" to chain additional work. This simplifies the logic inside launchFileManager() method. Bug: 1067478 Change-Id: I203370d5ff9dbb351df8bcd68696bae39630e5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147438Reviewed-by:
-
Curtis McMullan authored
Previously the bounds given to SetContainerType from the vk were ignored when showing the floating vk in its initial position. Now with this commit, the bounds given to SetContainerType will be used for the initial position of the floating vk. BUG=1019990 Change-Id: I7909b1745b0bcd8ba28c5657de81fa558a8ad19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138992 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#759532}
-
llin@chromium.org authored
More detail at: go/opa-cros-media-context-consent Bug: b/140531944 Test: Manual Test Change-Id: Ic6527fe70a053e475e6b07034cccf0923e6c6c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142959 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#759531}
-
Alex Danilo authored
The share menu button was using 'cr-button', while the other menu hosting buttons on the action bar were changed to use 'button'. See CL:2143415 for another case where this needed to be changed. Styling targeting files-ng action bar menu hosting buttons was not being applied to the 'cr-button'. Changes the share-menu button to 'button' element so the correct files-ng styles for drop-down menu buttons apply. Bug: 1070604 Change-Id: I6d3da19339ba1fb9ae7ce50cfef88ebc09e785c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148896Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL addresses comments that arose in crbug.com/2120663 . Adds comments in the implementation and fixes the test nits. Bug: 1064517 Change-Id: Id616a4bc8de5c35c1ebd2168bc2e45170dc18442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144797 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Fergal Daly authored
Navigating a subframe to the same address should not cause a history entry to be created. Change-Id: I5ee1bdc8e28c80b402db788fae686058c33810f7 Bug: 1068965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147490 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#759528}
-
Reilly Grant authored
This change adds temporary info-level log messages around the USB device chooser implementation on Android in order to diagnose a failure which is not reproducible on a local build. Bug: 1041804 No-Presubmit: true Change-Id: I536f6ae3b88e37f9ebac7def64e918a0b6d6a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148295 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759527}
-
Ben Mason authored
This reverts commit 38e3a62a. Reason for revert: Official build failure crbug/1071307 Original change's description: > [Clank SSM]: Implement NativeUnwinderAndroid. > > This CL implements NativeUnwinderAndroid & tests for android > unwinding support. It also enables StackSamplingProfilerTest > on Android. > > A new target source_set is added, native_unwinder_android > that contains NativeUnwinderAndroid. > StackSamplingProfilerTest depends on it for android. > > Bug: 989102 > Change-Id: Ie38fd99ca5fb053e1881d0977924b70a6fbc1e9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759283} TBR=gab@chromium.org,thakis@chromium.org,wittman@chromium.org,etiennep@chromium.org Change-Id: If46d65db088434e84e0fce10897669cd4a3739cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152205Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#759526}
-
Utkarsh Patankar authored
Fix TSAN data race found in Edge TSAN environment Bug: 1070210 Change-Id: Idda2324acc666d2a55ef55c28559f63b65d6de58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147771Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Utkarsh Patankar <utkpat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759525}
-
Ye Kuang authored
https://chromium.googlesource.com/infra/infra/+/56ae79476e3caf14da59d75118408aa778637936 Bug: 1070487 Change-Id: I036f6ff042f8f5ee7fd3e8d536c113197a7d1850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151380 Auto-Submit: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#759524}
-
Miyoung Shin authored
Migrates this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ie75e00e614e505e7b426d40e334e6e32ba174c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145417 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#759523}
-
Julian Watson authored
Logging was added to the SubPagePortForwarding tests in 182b5776 to diagnose test flakes. The test proved to no longer be flakey, so the logging can be removed. Bug: 1056268 Change-Id: I306ae2ee7d1f8107f95059e89f28065fcd7d1161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152048 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759522}
-
Regan Hsu authored
* Announce number of search results fetched. * Announce the selected search result as it changes via arrow keys. * Set the aria label to the same announcement in the event the user tabs to the result, or changes the selected result as it is focused via up/down arrow keys. * Announce that a result has been jumped to once route has changed. * Prevent ChromeVox from announcing result and saying "plus search plus space to activate" (and two times it does, like with many other random things) when user clicks on result. Instead, only announce once on click if the destination page isn't a11y correct. Manually recorded video: https://photos.app.goo.gl/NLB1n7gHVnJZsPWG9 Bug: 1056909 Change-Id: I2d5afd3dd608550d1956fea2d4da34a7d4f4ebfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135048 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Given that this function is async, we can remove callback and the caller sites can use then() or "await" to chain additional work. This simplifies the logic inside launch() method. Bug: 1067478 Change-Id: I5922dc4084bd193fe33d8d8e6d2116c48c274009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147524 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Fergal Daly authored
This is just a convenience. I've simplified one use of this. I'll be adding another use in a different CL. https://crrev.com/c/2148914 wraps all calls to this in EXPECT_TRUE but of course there are failures. It would be a bad idea to submit this right now with the code-freeze anyway. So I'll come back to it. Change-Id: I16b170fe8e697d0eb06716e30b877efdaa523869 Bug: 1071297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148711 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
dpapad authored
Also migrating test to use Mocha, and eliminating the need to refer to prod code using the cert_viewer namespace. The test code previously was replacing a prod code function as a way to intercept the response handler and make assertions, now replaced by an event instead. Bug: 1028829 Change-Id: Ieb5210965b311743c003a28c425f75d6ac1be462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145934 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759518}
-
John Z Wu authored
This will allow password autofill to work on already opened pages without doing a navigation or a reload. NSNotification was used because currently there is no good way to go from WebViewAccountPasswordStoreFactory to a CWVPasswordController. Bug: 1056406 Change-Id: I44bc1b2ca8ba3150738584bc705aed4e7d9f394e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151548Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759517}
-
dpapad authored
Specifically this CL affects the C++ backends of chrome://settings and chrome://terms replacing some call sites of GetRawDataResource() as well as GetStringUTF8(). The latter was somewhat misused, since it's not intended to be used to load entire file contents. GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: Ie06dda1c3bd37e66b79aa06ca3ce40a1cf85dc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151677 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759516}
-
Victor Costan authored
This reverts commit 24ee6490. Reason for revert: large value wrapping amplifies the IndexedDB Blob leak in https://crbug.com/488851. This CL also disables IndexedDBBrowserTest.DeleteCompactsBackingStore due to brittleness. Re-enabling is tracked in https://crbug.com/1071292. Original change's description: > IndexedDB: Re-enable large value wrapping. > > This CL removes the feature flag gating IndexedDB large value wrapping. > The feature will be rolled out using Chrome's standard waterfall release > model. > > Bug: 844782 > Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741600} TBR=dmurph@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071257, 844782, 488851 Change-Id: I1ba9fc1402c1831dd7daaa4b88fde68821a9d1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151885 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759515}
-
John Z Wu authored
- Also removed some unnecessary setup code Change-Id: I65f46565e6c2c1f21da4e8db22b876125c2d6c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151089Reviewed-by:
-
