- 29 Dec, 2020 40 commits
-
-
Hui Yingst authored
[iOS]Re-enable [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] for iPad testing. [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] is only flaky on iPad. This CL re-enable this test for iPhone. Bug: 1162301 Change-Id: I8b53271babcca2b561ecf9b8169eaa3b83dc18b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606626 Commit-Queue: Hui Yingst <nigi@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#839662}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie5eb6d9e312cb37190ebdf28540558e1cc546dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606348Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839661}
-
Dylan Cutler authored
This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Make CanonicalCookie's constructor private. Bug: 1102874 Change-Id: I124942d0aea21cc26a9ee36f35032bde3cb6fba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595450Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#839660}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I37d9caff3d8fee1d226419441068d0a227ec26f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606686Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839659}
-
Toni Barzic authored
The goal is to avoid excessive image load requests if the backing file gets modified multiple times in quick succession. BUG=1139115 Change-Id: I5ecf0171d28c5c2882f660039a6923e0951ed68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606383Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839658}
-
Jeffrey Kardatzke authored
This adds UMA stats for the following: 1. Selection between Chrome CDM and platform CDM (Beanstalk) 2. System codes for rejected promises from platform CDM (to distinguish these from the same errors w/ a browser CDM) 3. Status for output protection query/result (to distinguish these from the same data w/ browser CDM) BUG=b:153111783 TEST=Builds and runs, histogram presubmits pass Change-Id: I7a51b49594b6ac36500b52d602252bdd29b4c1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597899 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839657}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67a477b85b60..fe4611c18e9d 2020-12-29 reed@google.com Alias two sets of enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Iec3cb68ef03731808a99f6d9c7017f45540e4259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839656}
-
chrome://file-managerNoel Gordon authored
image_loader_client.js re-writes the requesting client's origin to the image loader exension's origin before sending the request to the image loader extension (using chrome.runtime.sendMessage). Add a re-write RegEx for chrome://file-manager. Note that this assumes chrome://file-manager has enabled chrome.runtime.sendMessage. Bug: 1113981 Change-Id: I8381eb60bdacb958521f1b34bfceb0e00bff2b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602963 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839655}
-
Clark DuVall authored
This was needed because the libraries were in the feed module, but have now been moved to the base module. This will hopefully fix a crash loading the libs on some devices. Bug: 1160654 Change-Id: Ie33114d6f5963325c096dea9f60e029d7d40e19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606187Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839654}
-
chrome://file-managerNoel Gordon authored
Allow chrome://file-manager to connect to the image loader. Note: this assumes chrome://file-manager has enabled chrome.runtime.sendMessage. Since the manifest.json "externally_connectable" permission is used to allow chrome://file_manager access, we must now list all the extension |ids| that are allowed to connect to the image loader extension in the "externally_connectable" permission. The ids are taken from the static ImageLoader.ALLOWED_CLIENT_ORIGINS list. Also add 'chrome://file-manager' to ImageLoader.ALLOWED_CLIENT_ORIGINS list, which is still used to allow (or block) connecting sources based on their URL origin. Bug: 1113981, 1123261 Change-Id: I96b0db1a0155510f95285cda8f5c7c62e6fece9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600433 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf79653b86f0..2f81d75f9eee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1160654 Tbr: huiyingst@google.com Change-Id: I8086e4ffcdec56897d670f413d253439ce3bcec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606744Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839652}
-
Yi Chou authored
BUG=b:175781791 Change-Id: I70cec4f96accb0b24ae079ab0fab4e6441ecf671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597523 Auto-Submit: Yi Chou <yich@google.com> Reviewed-by:
-
evliu authored
Bug: 1158463 Change-Id: I6d9c29a72fae0e4cab62660883fa0b93d842b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606381Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#839650}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I0d457b5d7b251fd552c50617a9d3520aa8e965b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604947Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#839649}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2847bbcf303..47ee6a7b096a 2020-12-29 penghuang@chromium.org Add build flags to disable desktop gl backend 2020-12-29 jmadill@chromium.org Vulkan: Make shader variable info maps a class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ia74b26db14201c05cfe134dc8860cf0eef507686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606382Reviewed-by:
-
Kyle Horimoto authored
Before this CL, this loadTimeData boolean was missing in OOBE, resulting in a console error. This CL moves it to a shared location which is called from both OOBE and settings. Fixed: 1162251 Change-Id: I42e9504e903ff3fa26d797b26c8bf19967f022c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606708Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839647}
-
Lukasz Anforowicz authored
The UMA was only needed to evaluate the safety/risk of shipping the feature. The feature has been enabled since r798414 / Aug 2020. Bug: 917457 Change-Id: Ieb73cb32d9dce587ef40a0d3b85de5956333bf72 Fixed: 1160833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600396Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Hui Yingst authored
[iOS] Disable [PasswordViewControllerTestCase testIPadTappingOutsidePopOverDismissPasswordController]. TBR=javierrobles@chromium.org Bug: 1162296 Change-Id: I1ee3f801b18dd8d950e9ba021b01571c34dcda93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602255Reviewed-by:
Hui Yingst <nigi@chromium.org> Reviewed-by:
-
Austin Eng authored
Bug: 1162117 Change-Id: I6aae742dae7330cc35234c5982ca619316e6b1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605885 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Evgenii Stepanov <eugenis@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#839644}
-
Matt Reynolds authored
Bug: 1030841 Change-Id: Ie79eba7a869784ece023aea5ab499b7618128dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582628 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839643}
-
Michael Ludwig authored
This simplification was requested as part of feedback to: https://chromium-review.googlesource.com/c/chromium/src/+/2527768 Bug: skia:9310 Change-Id: I487d38decc258201767e8a7849f1051ced983163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600380Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#839642}
-
David Roger authored
The MergeSession flow will be deprecated soon, it's better to keep the histograms, as they may help in checking that the deprecation is going well. Fixed: 1140090 Change-Id: Ife217655abd9026f4eeecaf5ef5b136f7739d8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595746 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c14f809140e4..bf79653b86f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: I344eed6d5609b8cac62660d932fe45fb9d9e5195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605420Reviewed-by:
-
Kyle Horimoto authored
In this context, "effective" means that (1) a failure followed by a successful retry is counted as a success, and (2) repeated failures (e.g., due to users stuck in an unrecoverable state due to Bluetooth issues) are only counted as a single failure. Bug: 1159963, 1106937 Change-Id: If7ba88cbc1d4247300541ec579c2c55825b8a8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601756 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0fd98ecdfd38fc04fa04ecf116ffc1f79583ad3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605334Reviewed-by:
-
David Maunder authored
Canary is showing we have some OutOfMemoryErrors. These will be handled in the same way as TabPersistentStore/TabState - we will not save the CriticalPersistedTabData/ShoppingPersistedTabData files. This will be achieved by serializeAndLog() returning null in the event of an OutOfMemoryError and a null response resulting in the file not being saved. Bug: 1161980 Change-Id: I403751dae99b3b3e532686f288a803cb91aecdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605614Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839637}
-
Miriam Zimmerman authored
We've made the relevant decision on a timeout and no longer need these metrics. Code sending this metric was removed in https://crrev.com/c/2605214. BUG=1156196 TEST=CQ Fixed: 1156196 Change-Id: I28fe2abb37980d22fd351e8ed55f68f074b9d3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606369Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
BUG=1146646 TEST=Verified new string in UI Change-Id: Ia45dade605890c7cb024f660798490ca97f54d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605288 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/368db7cde02e..67a477b85b60 2020-12-29 johnstiles@google.com Remove stale FrExp test files. 2020-12-29 reed@google.com Use sampling in bitmapdevice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: I8eba035c8e00310d9b4942eeb7a500147678c212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606374Reviewed-by:
-
Jeroen Dhollander authored
The |Service::Context| object is used by |AssistantManagerServiceImpl| but it was destructed first during teardown, causing a use-after-free error. Bug: 1162128 Test: compiled Change-Id: I44a6a52387879602d67057dafc482a50d482d265 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605578 Commit-Queue: Tao Wu <wutao@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#839633}
-
Clark DuVall authored
I saw some of the class loader mismatch crashes came back after adding preloading. This will hopefully fix those crashes. Bug: 1146745 Change-Id: I9e9364ba6d0a69bb38267905461961c018e73133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606193Reviewed-by:
-
Kyle Horimoto authored
This CL creates url_constants.h/cc files in //chromeos/components, where they can be accessed from both //ash and //chrome, and removes constants which were previously in both those spots. Note that the content at that URL does not yet contain Phone Hub information; this will be added before launch. Fixed: 1144053 Bug: 1106937 Change-Id: I434d2b42b54b64ea299aaace97e12c5b53af7410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605613 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839631}
-
Toni Barzic authored
Refactors HoldingSpaceImage, and adds support for requesting image refresh (i.e. image reload using the async bitmap resolver). Refreshing the image creates a new ImageSkia representation for the holding space item, so HoldingSpaceTrayIconPreview has to be updated to better handle changes to the backing image skia. When the holding space item image is updated, HoldingSpaceTrayIconPreview just creates a new ImageSkia to be used to draw the icon, instead of tracking changes in an ImageSkia specialization (and having to invalidate existing image representations). On HoldingSpaceImage side, the ownership of AsyncBitmapLoader had to be moved to HoldingSpaceImage, so it can be passed to the new image skia. While here, I did some additional cleanup: * Moves logic to request image from image skia source to the HoldingSpaceImage implementation (this will be useful to support item file path changes). * Removes image caching from HoldingSpaceImage::ImageSkiaSource. ImageSkia already caches its representations, so there is no need for another caching layer on top of it. Also, adds some unit test for HoldingSpaceImage. TBR=xiyuan@chromium.org For a trivial change in ash/public/cpp/BUILD.gn BUG=1139115 Change-Id: Ic94bd5890a095010291546ae880b7bb50dbc6392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605836 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
Devlin Cronin authored
We have a shiny new docserver, and no longer rely on the server in the Chromium repo. It served us well for many years. Wish it a grand farewell, and remove it from the codebase. This removes *everything* under chrome/common/extensions/docs/server2, as well as the docserver tests introduced in https://crrev.com/031fdd9a8941a3f6ce45140aad4156f9ddd13606. Bug: 1161364 Change-Id: Idb18fac9c00decf6c7c46a3f4c1dcb8547d73edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601680Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839629}
-
Hui Yingst authored
[iOS] Disable flaky test [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField]. TBR=javierrobles@chromium.org Bug: 1162301 Change-Id: Ia706d997b20bb1b33d00ef63d02b7050b1e5edb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606191Reviewed-by:
Alan Screen <awscreen@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839628}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609241635-1a5deaa23ae88856f623544afdac379b41a9d7db.profdata to chrome-mac-master-1609264741-782c7fdabb35af8d5bad4658593c39d1b6051717.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I634c2b19ca45a92194babd8b44e9b84d3a34039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606373Reviewed-by:
-
Daniel Cheng authored
Frame::Swap() would previously call DetachDocument(), save some state, and then complete detaching old frame by calling Detach(). However, this left the old frame in a semi-inconsistent state between DetachDocument() and Detach() and could trigger some weird edge cases (such as in the printing code). Instead, since Detach() already takes a FrameDetachType, improve the coordination between Detach() and Swap() so that detaching a frame for swap preserves the state that Swap() will adopt. By doing this, Frame::Swap() no longer needs to call DetachDocument() at all. Bug: 1061686, 1063150 Change-Id: I937bbf9d0a6d0de911aa4bd4743a16b86df1b4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597169Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839626}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609241635-e4b96f72ae58e1971ec4cf3bb5311f454317b912.profdata to chrome-linux-master-1609264741-3c5a3a442fc29468a5cb13e2f3f40377429cca30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I788a9d40630255af96b41340309693eb5e65bf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606372Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c73806bc052..c14f809140e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: I990fa15dd37ad35053d41a81e37cf3fe89eac89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606585Reviewed-by:
-
Kyle Horimoto authored
This CL removes an Observer interface and related functions which are no longer used. They previously were used to facilitate the "Locate phone" feature, whose implementation was changed to no longer need this functionality. Fixed: 1156382 Bug: 1106937 Change-Id: Ic3c7b4208388c6ac96e307a3a7364c4171edd378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605844 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
