- 06 Aug, 2019 40 commits
-
-
Antonio Gomes authored
BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icfae38257a342453542f7685d43020875c834159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736835 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#684300}
-
Ivana Zuzic authored
Enable calling the native ChangeSavedPassword method from the Java side. Bug: 377410 Change-Id: I7d83090c9ca04032a308a61e40c0e51af1162dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735585Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#684299}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bdc909653e31..7ba3b81ff5da git log bdc909653e31..7ba3b81ff5da --date=short --no-merges --format='%ad %ae %s' 2019-08-06 nisse@webrtc.org Delete class PlatformFile. 2019-08-06 kron@webrtc.org Fix RtpFrameReferenceFinderFuzzer to not generate invalid input 2019-08-06 tommi@webrtc.org Fix CallStatsUnittests to update the RTT on the process thread (as in production). 2019-08-06 nisse@webrtc.org Split out RtcpCnameCallback from RtcpStatisticsCallback 2019-08-06 nisse@webrtc.org In ChannelReceive, use AcmReceiver directly, not AudioCodingModule 2019-08-06 tommi@webrtc.org Call Call::GetStats() from the correct thread in our bandwidth tests. 2019-08-06 tommi@webrtc.org Fix RampUp tests to call Call::GetStats() from the right thread - and remove the need for a dedicated polling thread. Created with: gclient setdep -r src/third_party/webrtc@7ba3b81ff5da The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:989856 Change-Id: I53c3b88f75bf2efd62cf097aeefc3570d8ace740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684298}
-
Alexander Dunaev authored
Ozone platforms used DesktopBrowserFrameAura that lacks X11 integration code, which resulted in that the frame looked wrong, and the 'Show system title bar' option didn't work. This CL switches Ozone to use DesktopBrowserFrameAuraX11 that has the aforementioned integration. As DesktopBrowserFrameAuraX11 is now used in all Linux desktop builds, it is renamed into DesktopBrowserFrameAuraLinux. Bug: 987935 Change-Id: Ibce554525eadee93e92ca8b1154f8f3bb8ab4bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726056Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#684297}
-
Antonio Gomes authored
CL also switches VideoDeviceCaptureCapabilities away from std::vector and moves media_stream_constraints_util_video_device.h out of the Blink exposed API. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I53997a8de421f6c30e8d0c893502ff3334fb739d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736847 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bfd2c8eb302..f3e8b89c4fe8 Created with: gclient setdep -r src-internal@f3e8b89c4fe8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7486e64f6ee02f6f324c9d416137bdbb88f15bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738988Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684295}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5c00781543cc..131b9f32457c git log 5c00781543cc..131b9f32457c --date=short --no-merges --format='%ad %ae %s' 2019-08-06 perezju@chromium.org [Telemetry] Fix typo Created with: gclient setdep -r src/third_party/catapult@131b9f32457c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:985712 Change-Id: Id3deb854da8fced5f84056ced82313fef8e823ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738986Reviewed-by:
-
Dominick Ng authored
BUG=None Change-Id: I859ffac541cf895c3317579454ca21bbd8b4593d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738148 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684293}
-
Mugdha Lakhani authored
Allow 'periodic-background-sync' when the runtime feature is enabled. We currently deny 'periodic-background-sync' permission if the base::Feature kPeriodicBackgroundSync is disabled. Since the permission can't be parsed at all if the runtime feature is disabled, this check is unnecessary. Furthermore, this check prevents users with origin trials enabled from using the feature. Bug: 991145 Change-Id: Icf88c854ecb39d22d1878556a4c5a5b17350e321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738370 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684292}
-
Jan Wilken Dörrie authored
This change adds a network::SharedURLLoaderFactory member to the AuthenticatedLeakCheck class and modifies the PasswordManagerClient to make this class accessible. The SharedURLLoaderFactory will be required to talk to the identity leak look-up endpoint. Bug: 986298 Change-Id: Icdf32dc2e0d8dd927294316c288b9b94a54ed9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736678 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This change adds metric to track calls to: ChromeActivity.onGetDirectActions, which is made by the system when the user triggers the assist app while Chrome is the foreground app. This is mapped to a user action. ChromeActivity.onPerformDirectAction which is made by the system when the user triggers the assist app while Chrome is the foreground app. This is mapped to a enum histogram, to be able to track the different outcomes of such a call: - the action was not recognized - the action was recognized and performed and which action that was Since the set of direct actions is open, there's a catch-all "other", which shouldn't be triggered, as all actions allowed by the DirectAction feature are part of the histogram value. Bug: 959841 Bug: b/138918753 Change-Id: I833bfbeb03e832e2c770e104685b34afb56bd55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736354 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#684290}
-
Ruslan Burakov authored
Bug: 990342 Change-Id: I54c4ca1c0212ad737d67ba67828914ebfafdc7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733488Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ruslan Burakov <kuddai@google.com> Cr-Commit-Position: refs/heads/master@{#684289}
-
Takashi Toyoshima authored
If FileURLDirectoryLoader has a net::DirectoryLister instance running, it continues to call MaybeTransferPendingData() until the listing finishes. If a connection error happens on the mojo interface, it results in resetting |data_producer_|, and it causes a null pointer dereference. This issue was introduced after the last branch-cut. So only m78 is affected. Bug: 990579 Change-Id: I58f73d59022f89c82409e5fc10a6cb2a419b94d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735241Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#684288}
-
Yuki Shiino authored
Implements grouping of union types. Bug: 839389 Change-Id: I0b309eb5bdd3a63b719eef35e0a3cd21e8068b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733586 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#684287}
-
Omer Katz authored
With concurrent marking and without TryMark, the same object can be marked and pushed to the worklist more than once (i.e. by both mutator and visitors), meaning the object will be traced multiple times. Bug: 986235 Change-Id: I6d0d8a9da79da9d459b137082f91c9125fafd8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731838 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684286}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c3c17c8711c..0bfd2c8eb302 Created with: gclient setdep -r src-internal@0bfd2c8eb302 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: If091fda4ebbcb7939434a7ae15a9b4b435dbe188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738327Reviewed-by:
-
Adam Rice authored
In the JavaScript API for underlying sinks, they usually capture the controller if they need it in the start() method. However, the C++ UnderlyingSinkBase needs to store the controller internally for its own use. It's wasteful for subclasses to take their own copy. Instead expose it to subclasses directly via a protected getter. This getter will be used by the implementation of WebSocketStream. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit. Also fix a bug in the generic version of WritableStreamDefaultControllerInterface::Error(). BUG=983030 Change-Id: I5339f9117f52b78947592b417cb595b2fa496c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734738Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#684284}
-
Robbie Gibson authored
Bug: 976664 Change-Id: I8b1cdcd88d5a76a91433f86c68f2a728770777d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731844Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684283}
-
Tanmoy Mollik authored
Bug: 959157 Change-Id: Ic8d53f154c0065a14a9841fbe2eea44b87f1250f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735381Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#684282}
-
Gyuyoung Kim authored
This CL introduces ChooserResourceLoader class to replace Platform::Current()->GetDataResource(name) with UncompressResourceAsString. ChooserResourceLoader class supports static functions which return a string of the given style sheet or javascript. But, Android doesn't support IDR_FOO used by the choosers in blink_resource.grd. So, this CL just returns String() because Android port doesn't use the resources. Bug: 983396 Change-Id: I2a836cc3868e2bccfd4da1449aee217396073438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714624Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Richard Knoll authored
This adds metrics when we receive a web push message to see how often the device is in doze mode and if messages are sent with the high priority flag. Bug: None Change-Id: I2b37c20320e3e40dfd6e8d7ec3f050fe0ce1d801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730453 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#684280}
-
Javier Ernesto Flores Robles authored
Bug: 976645 Change-Id: Ib1de554f07a3bb4a7fb63b6a57e19fe26dc7e331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735384Reviewed-by:
-
Javier Ernesto Flores Robles authored
This color is also going to be used in popup menu. Bug: 976645 Change-Id: I7259415ba23aa7bbad24a5eb79794da0a3100389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735377 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#684278}
-
Andrei Chulkov authored
Change-Id: I0e4a85bc3c6558ff8a5dd0b3e0b2369ac5491c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736363 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#684277}
-
Robbie Gibson authored
The code in OmniboxPopupRow wasn't actually doing anything. The default UIKit method of row highlighting is to insert a view in the table cell's subviews at index 0, so the cell's background color is always covered. Setting selectedBackgroundView is the modern way of controlling this color. Bug: 976662 Change-Id: If0d18fc3edc82f6cb2eda0324dabe23e9ba9a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735164 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684276}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/558f1a9df6d3..5c3c17c8711c Created with: gclient setdep -r src-internal@5c3c17c8711c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iad14291c568e725e26d85c22e7a83378bfb495f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738567Reviewed-by:
-
Vadym Doroshenko authored
Now, form manager is created only for password forms. In order to fill username field during username first flow, form manager needs to be created for username-only forms. This CL implements it. Bug: 959776 Change-Id: I2252c8e07aa04c606dfb5edadaea6675fecc96d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735575 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
data URLs are now handled in blink, so we don't need to use WebURLLoaderImpl for data URL handling in tests. Remove |default_loader| param from WebURLLoaderMockFactory::CreateURLLoader. That allows us to expect non-null |resource_dispatcher_| and |loader_factory_| in WebURLLoaderImpl. Remove the redundant code. Bug: 751425 Change-Id: Iddcc5178b641c37aa563dce65b0626472d710d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704717Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#684273}
-
Javier Ernesto Flores Robles authored
Changes .com to .org Change-Id: I12e6035b4f71109a668048a49bf5882ed87456a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738846 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684272}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf176a0d6db9..74ec0afe01ec git log bf176a0d6db9..74ec0afe01ec --date=short --no-merges --format='%ad %ae %s' 2019-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 4f14b4c8cc25..698b56a8f024 (1 commits) Created with: gclient setdep -r src/third_party/angle@74ec0afe01ec The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I41a0df7e925bc3515b94e848afee7eb8216845dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738309Reviewed-by:
-
arthursonzogni authored
Understand for every failing content_browsertests, why they are failing with the BackForwardCache. Bug: 990354 Change-Id: Iafcf568be7cde737a86f8753442ed4c390c6aea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731948 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#684270}
-
Eugene But authored
This CL adds file to EG2 target and updated includes. Other changes has been already landed in separate CLs. Bug: 987646 Change-Id: I7b44b28d0d20a9bef24e7ec1aba5c78f27cba22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726412 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Matthias Körber authored
Increased the expiration version of the PasswordManager.PrefilledUsernameFillOutcome histogram to M82. Bug: 984245 Change-Id: I1fa829aa1f29273306d14101721d1f84fa38a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722539Reviewed-by:
-
Vaclav Brozek authored
As described in the design doc [1], a new class, CSVPasswordIterator, is introduced as an abstraction for consuming CSV data line by line, representing each line as a CSVPassword. [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I3477a600abad1c41f27a2ebca6c9c150da560818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700049 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#684267}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/206270625a4a..c59652b94a7e $ git log 206270625..c59652b94 --date=short --no-merges --format='%ad %ae %s' 2019-07-15 acostinas system_api: Add key_name_for_spkac 2019-07-25 akhouderchah shill: technology: Make all type names part of the D-Bus API 2019-06-26 sjzhong cryptohome: Allow user to selectively remove keysets. 2019-07-24 isandrk system_api: Add kSessionManagerStartRemoteDeviceWipe 2019-07-26 benchan system_api: shill: remove 'kPRLVersionProperty' constant 2019-07-16 xiaochu system_api: add sub OWNER file for update_engine 2019-06-28 khegde power: Add new battery metrics to PowerSupplyProperties 2019-07-23 ljusten system_api: Build Kerberos Go protos 2019-07-15 kimjae dlcservice: Modify install API to take protobuf list of DLC ids 2019-07-23 zuan cryptohome: Add UpdateCurrentUserActivityTimestamp() to UserDataAuth 2019-07-25 kimjae system_api: Install indication signal from update engine 2019-07-23 benchan system_api: add OWNERS for more sub-directories Created with: roll-dep src/third_party/cros_system_api Bug: 988367 Change-Id: Ia58014f74bd41f31dbb6c8a484444e0478f4e718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736671 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684266}
-
Raphael Kubo da Costa authored
Rather than having several mappings for sensor-specific settings and providing methods to change them in MockSensorProvider, move all of them to a separate SensorTypeSettings class. This makes it easier to note which methods are really MockSensorProvider's and which are changing sensor-specific settings for when MockSensorProvider gets to create a MockSensor. Bug: 987639 Change-Id: I57daa09506e15af16d747a48e6250f53f3644e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718378 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#684265}
-
Raphael Kubo da Costa authored
Also group them together. This makes it easier to know which values must be returned and which functions are not Mojo function implementations. Bug: 987639 Change-Id: Ia21b98acaed90902dcf42e798a6c37077e4cc8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718333 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Creates a local colorset for the separator. Bug: 976645 Change-Id: I8e5168c18fe01095537c4d34cdba151db11f2d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735162Reviewed-by:
-
redatawfik authored
1)Creates new class AutofillAddCreditCardCoordinator as a coordinator for add new credit card. 2)Initiates AutofillAddCreditCardCoordinator with BrowserState. 3)Creates new Interface CreditCardValidationDelegate. 4)Implements CreditCardValidationDelegate in AutofillAddCreditCardCoordinator. 5)Creates new class AutofillAddCreditCardMediator. 6)Creates new Interface AddCreditCardViewControllerDelegate. 7)Initiates AutofillAddCreditCardMediator with PersonalDataManager and AutofillAddCreditCardCoordinator as a delegate. 8)Initiates AutofillAddCreditCardViewController with AutofillAddCreditCardMediator as a delegate. 9)AutofillAddCreditCardMediator creates and saves new credit card object. Bug: 984545 Change-Id: I36e390f1e84c3cf54c4491780f73cdfdb142a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724073 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
-
Anton Bikineev authored
Calling destructors explicitly in FinalizerTrait revealed some warnings clang emits when the non-virtual destructor gets called on a polymorphic type. Many of the changed classes inherit from abstract NameClient, but making the destructor of NameClient virtual would be suboptimal as it would increase the number of finalizers. Bug: 990913 Change-Id: I06bffd838ac4917920caa7ecb6db6b8610b32685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736890 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
