- 12 Aug, 2019 40 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I14a63161ad7c37da12d6c2ed79e18e10c0dac6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686167}
-
Henrik Grunell authored
Enables features AudioServiceOutOfProcess and AudioServiceOutOfProcessKillAtHang by default on Mac. Also * Fixes audio process study names for Win and Linux in field trial config. * Sets default audio service teardown to 15 minutes on all platforms since it has been launched on all platforms (corrects a miss in some of the previous launches). This change is similar to the previous launch for Linux: https://chromium-review.googlesource.com/c/chromium/src/+/1648499 Bug: 974450 Change-Id: I6aae36d0635266187cee2081c1105a7b323aa244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745992Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/36eb20a7aba8..aba68fe5a5cc git log 36eb20a7aba8..aba68fe5a5cc --date=short --no-merges --format='%ad %ae %s' 2019-08-12 cjmcdonald@chromium.org parallel_emerge_old: Set both SYSROOT and ROOT via --board arg Created with: gclient setdep -r src/third_party/chromite@aba68fe5a5cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibaa6f0213629c87cb79f3dc6c9636d0db0235ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749605Reviewed-by:
-
Josh Nohle authored
Adds metrics to track the result--success, failure, timeout--of async function calls during the CryptAuth v2 Enrollment flow. Bug: 899080, 936273 Change-Id: Id60e1025e012e04b5bc8d984559a313fa0aedff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
ProfileManager doesn't need its own boolean tracking whether all browsers are being shut down as it can just check browser_shutdown::IsTryingToQuit(). Thus it doesn't need to listen to NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and NOTIFICATION_BROWSER_CLOSE_CANCELLED. It also doesn't need to save the active profiles when those notifications are sent out because saving the profiles when a browser is opened or closed should be sufficient. Bug: 268984 Change-Id: I2a81be1c1f04440ee4e8fc05375742d52cac9169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730191Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686163}
-
Robert Ogden authored
Bug: 969163 Change-Id: I3e437c9927a339a5d5fe5be68e8d057434d893c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748081Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#686162}
-
Hector Carmona authored
Refactored how the toolbar shows toast to avoid having two toasts. Also noticed bug in cr-toast-manager that would try to announce an element instead of its textContent. Bug: 27175 Change-Id: I1128106498f159242c5e0011d5e879641cf863fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740652Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#686161}
-
Andrew Grieve authored
Wasn't quite unused - but was used only for Android Studio's layout previewer. I don't know of a good way to have non-shipped resources, so deleting is probably the best option for now. Bug: 988047 Change-Id: Ic002ed2cbf2408100b70110436c01a9922a0fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749705 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686160}
-
Adrian Taylor authored
Also, pointing at a chromium.org copy of the source document which is accessible outside Google without individual access requests. Change-Id: I4caef90f2a77127173251d014adef4b6f72be801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747790 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#686159}
-
Kristyn Hamasaki authored
Adds test coverage for toggling bubble locking and debug rectangles, and sources. Change-Id: Id03f45888467a8791c113dece1d4648db88e41a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747147 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#686158}
-
Sammie Quon authored
Test: manual Bug: 991933 Change-Id: I0215fc86997fe17f07fec11263f358b9b3cf756c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743877Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686157}
-
behdad authored
Values used in this patch are the 99 percentile of the last 200 perf results of runs of GPU fyi bots. https://docs.google.com/spreadsheets/d/1vYnVrG0QnBl5_zQ9fVuzYW80xPhIGsXowOMiNtn0DGc/edit?usp=sharing Bug: chromium:982769 Change-Id: Iad3c2bd99714f9ffb9eae11619b5447c9d40809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748793Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686156}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31fc760897f7..c90cf387b1a9 git log 31fc760897f7..c90cf387b1a9 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 tsepez@chromium.org Remove unused cpdf_formcontrol.h from cpwl_wnd.h. 2019-08-12 thestig@chromium.org Remove unused CPDF_CMapManager* parameters. 2019-08-12 tsepez@chromium.org Remove some spurious includes from fpdfsdk/cpdfsdk_interactiveform.cpp 2019-08-12 tsepez@chromium.org Fix some IWYU of cba_fontmap.h in cffl layer. 2019-08-12 tsepez@chromium.org Replace FWL timer infrastructure with CFX_Timer. Created with: gclient setdep -r src/third_party/pdfium@c90cf387b1a9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iffa83c9cf398de23d2b54ebc53a5814cdcb62251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749478Reviewed-by:
-
Roger Tawa authored
WebRtcVideoDisplayPerfBrowserTests/WebRtcVideoDisplayPerfBrowserTest.MANUAL_TestVideoDisplayPerfH264/2 WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp9/0 Bug: 993020 Change-Id: Ica9095a50096f9b7667e8d4f7774ed249460537b TBR: tommicli@chromuim.org, hbos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749626Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686154}
-
Ella Ge authored
This reverts commit b24859d8. Reason for revert: fixing the test and reland Original change's description: > Revert "Make touchevent timestamp update on every non Stationary touch points" > > This reverts commit 2131ec3a. > > Reason for revert: Seems to have broken WebKit Linux Leak build. > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2981 > > Original change's description: > > Make touchevent timestamp update on every non Stationary touch points > > > > Touch event's timestamp is set from the |first_touch_pointer_event|'s > > timestamp. But in the case that this touch point is not changing but > > the others changed, this timestamp is not the latest pointerevent's > > timestamp. > > This CL changes it to use the the latest timestamp of the pointerevents > > in |touch_attribute_map|. > > > > Bug: 973545 > > Change-Id: I08be3f58e886f40eca17d515b36ec3a6424a38ef > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705051 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#685612} > > TBR=bokan@chromium.org,nzolghadr@chromium.org,eirage@chromium.org > > Change-Id: Id5a4657d566006597c9b6db06e3736240899e8ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 973545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746789 > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685638} TBR=bokan@chromium.org,sclittle@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973545 Change-Id: Ia6ba0e493f8f0c495c462c2dbe5cdf4cdfa50171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747736Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#686153}
-
Khushal authored
This reverts commit 677de3b2. Reason for revert: Investigation done. Original change's description: > Revert "viz: Defer BeginFrame throttling everywhere." > > This reverts commit 86f28deb. > > Reason for revert: Temporary revert to confirm this is responsible for crbug.com/982863 > > Original change's description: > > viz: Defer BeginFrame throttling everywhere. > > > > The initial change [1] restricted the delay in BeginFrame throttling to > > SurfaceControl to allow the change to be merged to M76. But this > > throttling policy is better in general so enable it everywhere. > > > > [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1675464 > > R=ericrk@chromium.org > > > > Bug: 973703 > > Change-Id: Ia26c23786b1e827fa22126c06a474fca65d20280 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684216 > > Auto-Submit: Khushal <khushalsagar@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Reviewed-by: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#673856} > > TBR=khushalsagar@chromium.org,ericrk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 973703,982863 > Change-Id: I3a042f8f2bdc721c0c5a20472156679d373a7bbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740731 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684647} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973703, 982863, 991855 Change-Id: I3d16236e4d7199fe2080200d897dd6c1bfb4f24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748082Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686152}
-
Maksim Ivanov authored
This CL builds the missing integration between the C++ code (starting from the handler of the PIN requests made by extensions) and the JavaScript code on the SAML sign-in page: * dynamically enabling/disabling this UI when the SAML sign-in begins/ends; * sending the PIN request parameters from C++ to JS; * replying with the entered PIN from JS to C++. The proper error displaying and other UI improvements will be done in follow-up CLs. Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, check that the PIN dialog appears on top of the SAML page, enter the smart card PIN, check that the login completes Change-Id: I95c2d5e5110a967ca6b7d8f957bbc8422f62d758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742233Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686151}
-
Chris Lu authored
Bug: 976901 Change-Id: I0751d935e2aa0307bd354b888e78408810d1f195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746601 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#686150}
-
Virender Singh authored
Accessibility actions like scroll and click are not forwarded to plugin. In this CL we create a pipeline between mimehandler and plugin process to pass accessibility actions. This will enable plugins to receive and handle actions. This CL focuses on enabling just kScrollToMakeVisible for PDF. This pipeline can be extended to handle other Accessibility actions. Note: RenderAccessibilityImpl::ScrollPlugin method is removed because of three reasons - It was not used by anyone at this moment. - It does not give correct scroll behavior because it is only able to scroll an embed tag in view port. However, we require scrolling within the Plugin content. - The action handling pipeline being introduced here is different from the HTML path ScrollPlugin uses to scroll. Bug: 769940 Change-Id: I6f04467e2798c4a60ae08329b271480134427f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692574 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686149}
-
Wez authored
Add bug numbers in TODO comments, for easier tracking. Bug: 953958 Change-Id: Ia6a40836aa06339af0651851fea7c993ab194d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747803 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686148}
-
Sammie Quon authored
On entering overview, windows that are stacked above the snapped window need to stacked underneath, otherwise when we scroll it will scroll over it. Also changed the aspect ratio maintaining codes to account for the overview margin and overview header. Test: manual, added test Bug: 981188 Change-Id: I99c368d5ab50931a1eabe7bc70bf8a5b738c2bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747027 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686147}
-
Cammie Smith Barnes authored
We walk up the render frame tree via RenderFrameHostImpl::GetParent() and then use GetLastCommittedOrigin() of the frame tree's root as top-frame origin for the network isolation key. This change is to address a potential race condition where the root frame tree node may have been now associated with a different document. Bug: 986167 Change-Id: I9196f70939f82c6c9ac62d5828329688db97bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741644 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#686146}
-
Tommy Li authored
This reverts commit 116a3030. Reason for revert: Failures here: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/28076 Original change's description: > Adding metric to track the source of empty automatic setup events > > In order to track down the root cause of https://crbug.com/964120 this > metric is being added. In this case we're concerned with printers > somehow being configured with a PPD while not having any make and model > information filled in. If an automatic setup meets this "empty" > criteria, then we track from which of the following 4 possible sources > it may have come from: > > 1. Print Preview > 2. Printer Settings > 3. Arc Print Service > 4. Automatic USB Printer Configurer > > BUG=chromium:964120 > TEST=None > > Change-Id: If49d58663f254b726ede57754f8dbc4a17793de4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732029 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Commit-Queue: David Valleau <valleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686078} TBR=stevenjb@chromium.org,bcwhite@chromium.org,skau@chromium.org,valleau@chromium.org Change-Id: I397d417239094941fc006c6485ad3b6b1804908b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:964120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749729Reviewed-by:
-
Ken Rockot authored
The only client is Content's Download Manager, so this CL has Download Manager explicitly start a service process or an in-process service instance as needed, rather than using Service Manager via a Connector. Download Manager still uses a Connector to connect to the Device Service, but that dependency will be eliminated when Device Service moves off of Service Manager too. Bug: 977637 Change-Id: I583fc3139e371fdda31462794a58cfeb0f40c88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742396 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686144}
-
Chris Lu authored
Adds sczs@ as secondary owner as well. Bug: 976901 Change-Id: Idf814b98addffd4b543cd9166d24faf2eae06a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748078Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#686143}
-
Sammie Quon authored
Now that it handles desks related gestures as well. Test: ash_unittests Bug: 988173 Change-Id: Id9a07ccf8633c4a35d253c6f3a88b08c69c2a53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747086 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Wez authored
This test flakes under e.g. the Fuchsia x64 bot, seemingly due to a timer unexpectedly firing, suggesting that the test is inherently racey. TBR=tommycli Bug: 991035 Change-Id: I99bb125c63e985339b4f210784c771fa5fadc438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749762Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686141}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/192e8a67cfe4..d6186f993681 git log 192e8a67cfe4..d6186f993681 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 ehmaldonado@chromium.org depot_tools: Run Python scripts using vpython (Part 1) Created with: gclient setdep -r src/third_party/depot_tools@d6186f993681 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I74bbab021b9556879b85c3ff36f57058beaf3129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749002Reviewed-by:
-
behdad authored
As a result of increasing thread priority of gpu process for performance tests on mac (https://chromium-review.googlesource.com/c/chromium/src/+/1637522), the upper values need to be updated, to match the new values. Values used in this patch are the 99 percentile of the last 200 perf results of runs of GPU fyi bots. https://docs.google.com/spreadsheets/d/1AfP6a0LZ3DHF26LAA6mFAdc0okqI7HFb_-j8Nt_5b-g/edit?usp=sharing Bug: chromium:992550 Change-Id: I644375e32e46138fe4f932566dc77074c119ffc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746949Reviewed-by:
-
John Budorick authored
I misconfigured this previously to trigger on commit *and* nightly. This removes the commit trigger. Bug: 961025,922145 Change-Id: I52ebf58a584087524551600acfa1525d74d531c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747395Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686138}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/c6c3c1b498..4ef574064e Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/c6c3c1b498..4ef574064e Bug: None Change-Id: Idfa04070603a5a01718a937d1cdde15c0e2b7eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748889Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#686137}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/703b48c36369..f0fc887f5682 git log 703b48c36369..f0fc887f5682 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 lalitm@google.com Merge "ci: experimental perf testing framework" Created with: gclient setdep -r src/third_party/perfetto@f0fc887f5682 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I2d8fd2b4ecb704d3a53b06b38346cafbf5e1acf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747970Reviewed-by:
-
Natalie Chouinard authored
The AppCompat bug that made this workaround necessary (see original bug: https://crbug.com/474695) was fixed >4 years. Cleaning up now that it's no longer applicable. Tested UI on KitKat, Lollipop and Pie. Change-Id: I6fb6b73a2c96d8d4fab0ef28710503011e86e77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747030Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 552c8814. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" 7486899f "Fix bug where composite: replace did not replace previous effects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifc61c9a443bdf6547b3f9522c2a03c2b88141b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749524Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686134}
-
Daniel Murphy authored
The connection request code lived in the IndexedDBDatabase, which already has a lot of it's own code and caused that class to be huge and confusing. This patch is the first step towards refactoring that part of the code out into its own class. It is a purely non-functional change which moves the code into a new class 'IndexedDBConnectionCoordinator' and simply delegates calls from IndexedDBDatabase to this new class. R=cmp@chromium.org R: cmp@chromium.org Bug: 992474 Change-Id: Ia3d394e097fe245fc6ecf0b57ca35986faa45670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745840 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#686133}
-
Sean Kelker authored
Added ARMENIAN SMALL LETTER SHA (U+0577), ARMENIAN SMALL LETTER CHEH (U+0573), BOPOMOFO LETTER J (U+3110) to confusable mapping Bug: 896453 Change-Id: I45b0b2dff9eeb0faeff5f8a10ce4829440124ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740614 Commit-Queue: Sean Kelker <seankelker@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686132}
-
Elly Fong-Jones authored
Currently, DownloadItemView's view hierarchy looks like this: DownloadItemView (button-ish) Filename (text) Status (text) More options (real button) DownloadItemView is not a real views::Button, because Button does not support having child views in this way. As a result, DownloadItemView reimplements a lot of the event-handling logic from Button. After this change, the hierarchy is instead: DownloadItemView (view, role = group) Open (button) Filename (text) Status (text) More options (button) Which un-confuses VoiceOver and allows removing a lot of the Button reimplementation from DownloadItemView. One extra complexity is drag events: DownloadItemView is intended to be draggable, but after this change drag events will instead land on the open button, which does not have the local state to implement dragging. The open button therefore forwards these drag events to the DownloadItemView so it can implement dragging. Bug: 957352 Change-Id: I5cbcd1ccd13a83126e6e4579a5d9c9fe2b9b9b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745460 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686131}
-
Reilly Grant authored
The serial_number field of UsbDeviceInfo is optional. A couple places were missing checks. This was exposed by r678566 which removed code that previously guaranteed that this string would always be present (but empty). Bug: 992656 Change-Id: I825f0cac256adc6ab509f43cbc8ce4df69390fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749452Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686130}
-
Ryan Sturm authored
This holdback records histograms as it normally would, but holds back the actual preconnect. Bug: 992542 Change-Id: I38b62a04ab817d802a8519816d4b0c48aa767a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747032Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686129}
-
Joey Arhar authored
After http://crrev.com/c/1636110 this class became unused and should be deleted. Bug: 882467 Change-Id: I1cc5c1bd593ac383f6c7494452c801adf5b4645c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721028 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686128}
-
