- 01 Dec, 2018 40 commits
-
-
chrome://Dan Beam authored
The Size column of Network panel shows "0 B" for every request when no bytes are actually transferred over the network. Enabling "large rows" is great as it shows the resource size as well, but sorting doesn't take the resource size into account as a secondary factor. This CL fixes that. I also added a summary view of the resource sizes (very similar to the network bytes transferred summary) to the bottom start end of network tab. Screenshot: https://imgur.com/XQRYtWj R=alph@chromium.org BUG=907289 Change-Id: I35d69cb617113b0094f6cc2a368b6180c90c2772 Reviewed-on: https://chromium-review.googlesource.com/c/1345232Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#612937}
-
Jazz Xu authored
Add "pip-presented" CSS class to menu list and track list when picture in picture is enabled. Remove the CSS class when pip is disabled. So that we can have different menu width depending on whether we have pip button in menu. Bug: 901738 Change-Id: I08c0c480fef221f19917637fc9538e66f99f79ca Reviewed-on: https://chromium-review.googlesource.com/c/1357601Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612936}
-
Adrienne Walker authored
This has turned up some bugs, but is being incredibly noisy on the bots. Remove the crash report until this is solved. Bug: 910772 Change-Id: I9f2a7f7a1a758abe20a2304ad10da4a12fb4b9db Reviewed-on: https://chromium-review.googlesource.com/c/1357619Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612935}
-
Ben Kelly authored
When a simple disk_cache is in APP_CACHE mode eviction is disabled and access times do not need to be tracked. This means that it should be possible to perform read-only operations without triggering any index disk writes. This CL implements this optimization by making the following changes: * Avoid updating access times in APP_CACHE mode. * Avoid writing a clean index to disk when closing the backend. * Avoid dirtying the index when a size update does not make a change. * Avoid dirtying the index when opening an entry that is in the index. * Avoid dirtying the index when dooming an entry not in the index. With these changes its possible to use simple disk_cache to perform read-only operations in cache_storage without any index writes. Bug: 905351 Change-Id: I8eed0a72ed166e7b1b3623a7f4c17f7cec7f96d4 Reviewed-on: https://chromium-review.googlesource.com/c/1351539 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#612934}
-
Ben Wagner authored
This is a minimal change to cover most cases. In particular this does not take @font-face font-feature-settings into account, but does make letter-spacing with a non-default value disable optional ligatures for all cases except when enabled directly by font-feature-settings. It also makes optimizeSpeed force the default setting for optional ligatures to off. This avoids using or changing TypesettingFeatures, leaving blink::kLigatures to only affect the use of the word shaper. The use of the word shaper can be modified independently and will involve rebaselines and consideration of the performance impact (since common fonts like Arial, Times New Roman, and DejaVu Sans use spaces in GPOS or GSUB). Bug: chromium:896033 Change-Id: I764b1a7eed6d9f06ff8df31c4225dee2ea860684 Reviewed-on: https://chromium-review.googlesource.com/c/1292436 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#612933}
-
Eugene But authored
Change-Id: Ife2616f947a3251d88ee156af9780d9df2690177 Reviewed-on: https://chromium-review.googlesource.com/c/1355198 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612932}
-
Victor Costan authored
Disable two SQLite features that aren't used in Chrome, saving 9KB of binary size. Change-Id: I87ff8c454eed8fe554a6ba93f3cc28d10b91258e Reviewed-on: https://chromium-review.googlesource.com/c/1341492 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612931}
-
Parastoo Geranmayeh authored
The secondary members should not be considered while comparing profiles. Change-Id: I767ea18ab39ed7c5ad6771338aedf39f620bd477 Reviewed-on: https://chromium-review.googlesource.com/c/1357576Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#612930}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d007d7c4f11..0cc11b4b947e git log 0d007d7c4f11..0cc11b4b947e --date=short --no-merges --format='%ad %ae %s' 2018-11-28 magjed@webrtc.org Android: Bump stack trace logging severity from debug to warning 2018-11-28 yura.yaroshevich@gmail.com Added user-defined predicate to filter video codec implementations. 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82a8b043..28d61688 (611537:611644) 2018-11-28 gustaf@webrtc.org AEC3: Fix ENR in the dominant nearend detection 2018-11-28 devicentepena@webrtc.org AEC3: Optimizing the Update method of the FilterAnalyzer class. 2018-11-28 aegolden@google.com Don't clear self.videoFrame when setting up OpenGL in the EAGL video view. 2018-11-28 artit@webrtc.org Fix webrtc-internal ios json config 2018-11-28 robin@opticaltone.com Adding WinUWP compilation support to WebRTC. 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b04e513f..82a8b043 (611432:611537) 2018-11-28 zstein@webrtc.org Reland "Delay call to Destroy until after SignalDone has finished firing." Created with: gclient setdep -r src/third_party/webrtc@0cc11b4b947e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:909007,chromium:None,chromium:905542 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I98fcd8196b69f3530655fee12d869c96a26c618e Reviewed-on: https://chromium-review.googlesource.com/c/1357744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612929}
-
siyua authored
Currently the credit card icon is visible when flow step is PROMO_BUBBLE or CREDIT_CARD_ICON. When user navigates away when bubble or credit card icon is shown, the flow step is not correctly set so the icon will always show even if the bubble is gone. Bug: 897998 Change-Id: I8a966cbb76775aaedc8b766306ec6d5c9602c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352358Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#612928}
-
Clark DuVall authored
This flag is necessary to enable DRP with network service. Adding the flag to DRP tests allows them to pass when run with network service on the Android mojo bot. Also updates the changed files to use @EnableFeatures/@DisableFeatures. Bug: 721403 Change-Id: Ibf75db48c4ab64ac47bd493e1a5e04f899ac19e9 Reviewed-on: https://chromium-review.googlesource.com/c/1352476Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612927}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7efdde5887a..b05d24c8ae07 git log f7efdde5887a..b05d24c8ae07 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 dgarrett@google.com chromeos_config: lakitu-master-release -> master-lakitu-release Created with: gclient setdep -r src/third_party/chromite@b05d24c8ae07 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic2860ea9ee64a3af837ec0b929a9f8564e0584dc Reviewed-on: https://chromium-review.googlesource.com/c/1357434Reviewed-by:
-
Shao-Chuan Lee authored
Units should be milliseconds instead of seconds. Bug: 904282 Change-Id: I406a6d0f5808b2dc2662c77e7d4b9783e3a07e7e Reviewed-on: https://chromium-review.googlesource.com/c/1355305Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612925}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/179db44c2586..8b07e43dadf8 git log 179db44c2586..8b07e43dadf8 --date=short --no-merges --format='%ad %ae %s' 2018-12-01 enga@chromium.org Let DeviceBase know about Completed and LastSubmitted command Serials Created with: gclient setdep -r src/third_party/dawn@8b07e43dadf8 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9ec6734272c0124f4070b81031ca181c9b41e6f5 Reviewed-on: https://chromium-review.googlesource.com/c/1357663Reviewed-by:
-
Andrew Xu authored
Fix the rounding error in code for coordinate conversion from native host coordinate to screen DIP coordinate. In the original code, when mouse cursor is in the warp region of secondary display, its screen DIP coordinate which is computed by ConvertHostPointToRelativeToRootWindow may be out of secondary display due to rounding error. It is also found that this rounding error only happens with specific display zoom factors and display rotation degrees. test: ash_unittests Bug: 905035 Change-Id: I36af26afe4e210d70b6812a1bddb1a95feb7235f Reviewed-on: https://chromium-review.googlesource.com/c/1343249Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612923}
-
John Lee authored
Bug: 866641 Change-Id: Ie958bd21f9ea24d3ed7fd74f18e70feb238d61c8 Reviewed-on: https://chromium-review.googlesource.com/c/1357305Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612922}
-
Maggie Chen authored
For protected video, it must be protected and decoded by hardware through Direct Composition overlay swap chain. It's fine if the blend mode is not handled correctly. Bug:843814 Change-Id: I07c3ed40716fd9979f3f83c395a593fa1f0b5dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1357647Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612921}
-
Dan Erat authored
This reverts commit e13e5485. Reason for revert: Appears to break chromeos-chrome build on Chrome OS: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8928371933715353664 Original change's description: > Migrate chrome services to ServiceBinding > > Migrates most remaining chrome & chrome OS services from ServiceContext > to ServiceBinding. > > Bug: 891780 > Change-Id: Ib67772b549a58a4b2549840e90f719daa3370215 > Reviewed-on: https://chromium-review.googlesource.com/c/1356312 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612911} TBR=jam@chromium.org,rockot@google.com Change-Id: I56ab0458a7ac05eef69c9afabdc4a280fa77cff4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780 Reviewed-on: https://chromium-review.googlesource.com/c/1356906Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#612920}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I8f2763c3e8a603e785eb976ead4058da8fc38faf Reviewed-on: https://chromium-review.googlesource.com/c/1357334Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612919}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b0154c4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I9ca1fda5e6445d48932d546dd5a585dfc5fc8255 Reviewed-on: https://chromium-review.googlesource.com/c/1357646 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612918}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/026f32dd6f27..3f8fc4984231 Created with: gclient setdep -r src-internal@3f8fc4984231 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I674a2b7f241d24961c5486afbf75e4bcba8b87b6 Reviewed-on: https://chromium-review.googlesource.com/c/1357662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612917}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9dbc7de52fe5..4fbd264904eb git log 9dbc7de52fe5..4fbd264904eb --date=short --no-merges --format='%ad %ae %s' 2018-12-01 tsepez@chromium.org Remove wide string literals in cxfa_node_statics.cpp. 2018-12-01 tsepez@chromium.org Remove CXFA_Node::ElementToName(). 2018-12-01 tsepez@chromium.org Remove some wide string literals in cxfa_fmlexer.cpp. 2018-11-30 tsepez@chromium.org Remove wide string literals from XFA_AttributeEnumInfo. 2018-11-30 tsepez@chromium.org No need for string literals in cfgas_formatstring.cpp Created with: gclient setdep -r src/third_party/pdfium@4fbd264904eb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2cfc0f5cd39823880850978913d3196a1ef5661d Reviewed-on: https://chromium-review.googlesource.com/c/1357739Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib099f5c86bd17dd4b5dd136fd0ac30397e8f09fd Reviewed-on: https://chromium-review.googlesource.com/c/1357661Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41dc60067326..6f862e54f2a0 git log 41dc60067326..6f862e54f2a0 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 dtu@chromium.org [pinpoint] Fix CIPD arguments. Created with: gclient setdep -r src/third_party/catapult@6f862e54f2a0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905807,chromium:906853 TBR=sullivan@chromium.org Change-Id: I8e77873299ed2fd217b1fdc66d74d17ffe60d5e2 Reviewed-on: https://chromium-review.googlesource.com/c/1357660Reviewed-by:
-
Dale Curtis authored
This takes the runtime of the demuxer for the linked bug from 70s to 3.5s; there is a small risk this will block the blocking_thread_ for a longer time, but that's a dedicated thread for this demuxer, so that's fine. BUG=852093 TEST=fuzzer R=tmathmeyer Change-Id: I01d1dab399059caaa7cf5b2a280484c0f9d4cc42 Reviewed-on: https://chromium-review.googlesource.com/c/1357631Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612913}
-
Kyle Horimoto authored
These classes are are shared among several features and are being moved to a new //chromeos/components/multidevice directory. This is part of the effort to clean up //components/cryptauth; see go/multidevice-directory-structure-cleanup. Change-Id: Ia96718f0e11e46706ed4156e4de85d0514929d57 Reviewed-on: https://chromium-review.googlesource.com/c/1355774Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#612912}
-
Ken Rockot authored
Migrates most remaining chrome & chrome OS services from ServiceContext to ServiceBinding. Bug: 891780 Change-Id: Ib67772b549a58a4b2549840e90f719daa3370215 Reviewed-on: https://chromium-review.googlesource.com/c/1356312 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#612911}
-
Ted Meyer authored
Bug: 836557 Change-Id: Icba7ea7c07f59f2307d8389350cc761364a37560 Reviewed-on: https://chromium-review.googlesource.com/c/1357509 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612910}
-
Regan Hsu authored
A new change on the Android side now causes the phone to respond with LAST_PROVISIONING_FAILED if the last attempt to run provisioning failed. This CL addresses the case for when the device was offline last time it checked, or there was some sort of network error when checking. Bug: 872473 Change-Id: Ia28f9077990a5a991b3968a6da100222940c11be Reviewed-on: https://chromium-review.googlesource.com/c/1357656 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#612909}
-
James Darpinian authored
When we emulate GL_LUMINANCE_ALPHA using GL_RG and swizzles, we need to make sure to update the swizzles whenever the base level of the texture changes, because different levels can have different formats that need different swizzles. Fixes WebGL test conformance2/textures/misc/copy-texture-image-same-texture.html Bug: 809233 Change-Id: Iccda944688982ca1d67203b885cd3ea5236c7e26 Reviewed-on: https://chromium-review.googlesource.com/c/1356330Reviewed-by:
-
Eric Roman authored
Bug: 721403 Change-Id: I5f6cf64be0a85e3d5ef8bf88d8dda1deea924635 Reviewed-on: https://chromium-review.googlesource.com/c/1356941Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b0ee5ee22d88..61ea30737c65 git log b0ee5ee22d88..61ea30737c65 --date=short --no-merges --format='%ad %ae %s' 2018-12-01 ehmaldonado@chromium.org git-cl: Remove unused settings. Created with: gclient setdep -r src/third_party/depot_tools@61ea30737c65 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: I307ebc5be3bfc635802fbf580676a82769b809f8 Reviewed-on: https://chromium-review.googlesource.com/c/1357659Reviewed-by:
-
Mitsuru Oshima authored
Make PIP window non activatable by default on ChromeOS. Bug: 910323 Test: Manual. unittest T.B.D. Change-Id: Ibd444a182c731c4e585c428938bbc4cc0d03d9a2 Reviewed-on: https://chromium-review.googlesource.com/c/1354410Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612905}
-
John Lee authored
Bug: 867169 Change-Id: Ib92bcc9a46653181fda1fd23ea6da63daf3b081d Reviewed-on: https://chromium-review.googlesource.com/c/1354485 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#612904}
-
Benoît Lizé authored
Adds support for brotli compression to the compression_benchmark test tool. Results below are taken from a sample of JS files found on the web (see the linked bug). Overall, at comparable compression ratios, brotli is slower than zlib for decompression but faster at compression, on Android and Linux. Tested on Pixel (Android) and Xeon "broadwell" (linux). For instance, for a 32kiB chunk size: - Linux Zlib Size = 32768 Compression Compression ratio = 2.97379 Throughput = 35.7633MB/s Latency (size = 32768) = 916.246us Decompression Throughput = 329.092MB/s Latency (size = 32768) = 99.5711us Brotli Size = 32768 Compression Compression ratio = 2.81762 Throughput = 52.4092MB/s Latency (size = 32768) = 625.234us Decompression Throughput = 159.92MB/s Latency (size = 32768) = 204.903us - Android Zlib Size = 32768 Compression Compression ratio = 2.97379 Throughput = 18.7666MB/s Latency (size = 32768) = 1746.08us Decompression Throughput = 204.837MB/s Latency (size = 32768) = 159.971us Brotli Size = 32768 Compression Compression ratio = 2.81762 Throughput = 30.1437MB/s Latency (size = 32768) = 1087.06us Decompression Throughput = 85.4071MB/s Latency (size = 32768) = 383.668us Bug: 907489 Change-Id: Ia6b0877fa6964098bd99e8d2dea3ff09e316d910 Reviewed-on: https://chromium-review.googlesource.com/c/1356549 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612903}
-
Aga Wronska authored
Time limits feature allows to lock the device of child user. When device is lock child user should not be able to authenticate to the session. To achieve that request to disable authentication should not be passed directly to views lock screen UI. Instead request is passed to ScreenLocker that disable authentication attempts (password, fingerprint, PIN) for the requested user. Bug: 910332 Tests: ScreenLockerTest + manually Change-Id: I41b49e98f20e149945b35da18216896fb265fec4 Reviewed-on: https://chromium-review.googlesource.com/c/1355921 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#612902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b881d5ca610..026f32dd6f27 Created with: gclient setdep -r src-internal@026f32dd6f27 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Id57cb5027bd3cbfbea56380a0d3f8d1649d6363d Reviewed-on: https://chromium-review.googlesource.com/c/1357436Reviewed-by:
-
Kenneth Russell authored
This can be used in Release builds without dcheck_always_on=true, and allows the --enable-gpu-client-logging command line argument to work. Bug: 910783 Change-Id: I0720b7eb0c735de4d08ba50d69b41060eb387d63 Reviewed-on: https://chromium-review.googlesource.com/c/1357623Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612900}
-
Wez authored
Mojo's PlatformChannel implemented its own mechanism to allocate PA_HND identifiers, and used the PA_USER0 namespace. Separately we had some callers expecting to use statically-defined PA_USER0 identifiers to pass application-specific handles, creating potential for clashes. For features like base::FieldTrialList we also need a mechanism to pass a handle to a child process at startup, for which we'd ideally have a well-known path location in the FDIO namespace supplied to the child. Since FDIO namespaces do not yet support non-file/directory handles, we need a safe way to allocate an id that the FieldTrial implementation can pass via the command-line, similarly to Mojo. We add an AddHandleToTransfer() helper that appends a handle to a handles-to-transfer vector with a unique id, and returns the id, and add comments to clarify that PA_USER1 is used for these ids, leaving PA_USER0 (and others) free for application use. Bug: 909851 Change-Id: If9b8ffaf98155f72cc7a52e5ef0c51ef19048d66 Reviewed-on: https://chromium-review.googlesource.com/c/1354398Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612899}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d60b5907958e..9dbc7de52fe5 git log d60b5907958e..9dbc7de52fe5 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 tsepez@chromium.org No need for string literals in XFA_ExecEventParaInfo. 2018-11-30 tsepez@chromium.org Make CJS_EventHandler::Name() and Type() return bytestrings. 2018-11-30 tsepez@chromium.org Use EqualsASCII{,NoCase}() and narrow literals in many places. 2018-11-30 tsepez@chromium.org Make the unused string literals in cfx_cssdata.cpp be narrow 2018-11-30 tsepez@chromium.org Remove wide literals from xfa_basic_data_element_script.cpp 2018-11-30 thestig@chromium.org Mark kFoo variables const, or rename them if they are not. 2018-11-30 tsepez@chromium.org Move ASCII string operations to string_view_template.h Created with: gclient setdep -r src/third_party/pdfium@9dbc7de52fe5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8abc80e5926cfbe154e36d207ba0aa5b05adff77 Reviewed-on: https://chromium-review.googlesource.com/c/1357433Reviewed-by:
-
