- 04 Nov, 2020 40 commits
-
-
Christian Dullweber authored
This reverts commit ba7d8814. Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 Original change's description: > [AF] Add account indication footer to AutofillSaveCardInfoBar > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > Screenshot with feature enabled in light mode: > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > Screenshot with feature enabled in dark mode: > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > Bug: 1135847 > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > Commit-Queue: Anne Lim <annelim@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#823710} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com Change-Id: I5f235bc5843acf4ea504a78762907a019576e656 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823942}
-
Igor Britsky authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): ../../components/autofill/core/browser/data_model/ autofill_structured_address_regex_provider.cc: In function 'std::__1:: string autofill::structured_address::{anonymous}:: ParseFirstMiddleLastNameExpression()': ../../components/autofill/core/browser/data_model/ autofill_structured_address_regex_provider.cc:270:61: error: no matching function for call to 'CaptureTypeWithPattern(autofill:: ServerFieldType, const char [953], <brace-enclosed initializer list>)' Bug: 819294 Change-Id: I6149c53fda0f5357f66eae56446d61f010bccb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506573Reviewed-by:Dominic Battré <battre@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#823941}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc1c1cb562bb..265c5fa9a7e0 2020-11-04 syoussefi@chromium.org Vulkan: Fix scissor update in FramebufferVk::syncState If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I47720da0eab8c8e93e7b3d68bceab648b4bcaee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823940}
-
Sylvain Defresne authored
The CL https://gn-review.googlesource.com/c/gn/+/10140 was brought by the roll of gn. This CL causes the --root-target to have two conflicting meaning. Remove the parameter from //ios/build/tools/setup-gn.py to allow the script to successfully generate an Xcode project. The drawback is that more target than necessary may be built when building "All" in Xcode. Bug: 1133101 Change-Id: I97073fffbea37c0f61691b9599ff0982e4c027c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517585 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823939}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4314.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0c582170559f3a344ae5922dd5ba902ead37061c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519353Reviewed-by:
-
Wei Lee authored
When there are multiple requests for setting photo options callbacks, pushing the callbacks into a queue instead of storing the latest one only. Bug: 1142931 Test: https://1142931.glitch.me/?timeout=100 Change-Id: Ia4feac88de5600b696cf05f31fd0cea7c2612223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513809Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#823937}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: I1b30c374cdc95632f42080cad20d121127abad42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517439Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823936}
-
Ioana Pandele authored
Bug: 1092444 Change-Id: I6e22b168718cb6271171d4a219301e9fa2f55101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516541 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823935}
-
Henrik Boström authored
With eshr@'s libyuv::MJPGToNV12() being rolled into chromium, it is now possible to do MJPEG -> NV12 with a single libyuv function. This CL gets rid of the MJPEG -> I420 -> NV12 paths and makes use of the new libyuv function. This also simplifies the MJPEG -> I420 path. Bug: chromium:1132299 Change-Id: Ia7271703e70b731391873baea009684c00764828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516703Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823934}
-
Luciano Pacheco authored
Files: - util.js - mock_entry.js - files_app_entry_types.js Bug: b/172300267, chromium:1133186 Change-Id: I8819f4ce6fbf1ab4bd137d4edaa6a87ea5955928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519331 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#823933}
-
Ziran Sun authored
The test that fails in Chromium related to calc() serialization is due to: https://bugs.chromium.org/p/chromium/issues/detail?id=1050968 The test that fails in Firefox related to resolving percentage grid rows is due to: https://bugzilla.mozilla.org/show_bug.cgi?id=1481876 BUG=767015 R=jfernandez@igalia.com Change-Id: Ie219396d0e62181056ddf6c84b7b60f8251aeb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436821 Commit-Queue: Ziran Sun <zsun@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#823932}
-
Kent Tamura authored
In LayoutNG, selection background is painted to fill the line-height. The <span> in the test should be inline-block so that its height contains line-height. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Bug: 1040826 Change-Id: Ib64c337645f82e7fd54f3a0ba31347a94f85e475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517193 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823931}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9876740171a399762b3506beb7dee742ab71ce41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519391Reviewed-by:
-
Jan Scheffler authored
The cl in devtools-frontend: https://crrev.com/c/2514441 Bug: chromium:1138757 Change-Id: If6c14fd84e3650f143a968abe97fd6a38ed9e934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517680 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823929}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68ad76f4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox external/wpt/css/css-sizing NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I8fb95994790436f1fa855cff59284d69cb97cec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519270Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823928}
-
Hua, Chunbo authored
Bug: None Change-Id: I961d82b32465546f935fcec5047b005fdec370a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513352Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#823927}
-
Hiroki Nakagawa authored
This reverts commit 0ae8a002. Reason for revert: This is a speculative revert to fix compile failures on Android bots: https://ci.chromium.org/p/chromium/builders/ci/android-official/2647 Original change's description: > Roll AFDO from 88.0.4312.0_rc-r1-merged to 88.0.4314.0_rc-r1-merged > > This CL may cause a small binary size increase, roughly proportional > to how long it's been since our last AFDO profile roll. For larger > increases (around or exceeding 100KB), please file a bug against > gbiv@chromium.org. Additional context: https://crbug.com/805539 > > Please note that, despite rolling to chrome/android, this profile is > used for both Linux and Android. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/afdo-chromium-autoroll > Please CC gbiv@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Tbr: gbiv@chromium.org > Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823885} TBR=gbiv@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: If97762d7a58a5628dfd375b23c369621f32a7031 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517352Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823926}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604447854-866c4fbc99bb4ac6773d7af35f2f82c41a890e4c.profdata to chrome-linux-master-1604468747-3cefb59c2b4481c91d9a2d5b4d4a31bc448420c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia36eec03336b5e7bce91cd41c24629d2cfe2e027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519351Reviewed-by:
-
Krzysztof Olczyk authored
Before the change, the "Time" struct from //mojo/public/mojom/base/time.mojom is marked as a Stable interface, while the other two testructs (TimeDelta and TimeTicks) are not. This adds consistency and allows stable interfaces to depend on these basic types. Change-Id: Icae41a542bddde9e6e8ab7b63cb01d4af3a4662f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517479 Commit-Queue: Krzysztof Olczyk <kolczyk@vewd.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823924}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604447854-0203f3947ee8f5c9986d886d20c69f4a07395a41.profdata to chrome-mac-master-1604468747-33d374fd721b6c3bc2da01359a5fc589bd022b47.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I587ec630b5063882b9f411707853f5f86c218ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518909Reviewed-by:
-
Keishi Hattori authored
ImageResourceTest.CancelWithImageAndFinishObserver had two problems: - ResourceFinishObserver::NotifyFinished was not getting called because blink::test::RunPendingTasks() doesn't run tasks in FakeTaskRunners. - Test failure was treated as passing because EXPECT_CALL was checked in the MockImageObserver destructor which runs in a GC after the test. This CL replaces RunPendingTasks() call with FakeTaskRunner::RunUntilIdle() to fix the first issue. And adds an explicit GC in TearDown so EXPECT_CALL gets checked inside the test. Bug: 1138819 Change-Id: Ic0d0c089cab5e728d65f3e947e0b9b36a066395f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507314Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823922}
-
Philipp Hancke authored
and rename the file BUG=webrtc:12029 Change-Id: I52753f98686715a19f910d7d0ff883e55a840722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500842 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#823921}
-
Hirokazu Honda authored
Since MT8173 decoder doesn't support multiple NALUs, it is necessary to split them before feeding them to the driver. The procedure of splitting doesn't detect filler and SPS extension NALUs. Therefore, for example, PPS and filler NALUs are fed fed together to the driver. This fixes the issue by adding Filler and SPS extension NALUs as filtered NALUs in the pre processing. Bug: b:171846172 Test: local loopback in https://appr.tc/?vsc=h264&vrc=h264 on elm Change-Id: I792261d8c349518f15232d1cd50d9bf6c27d464e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517348Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#823920}
-
Peter Marshall authored
This has coverage in the frontend unit test Trie_test.ts already. Change-Id: Id0551f888e82f64ac78edfd91bee07cea543b022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518851Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#823919}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ea2dd438732..944e8f15ba21 2020-11-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I04aba88422dd76ba74d0a0a6a4d02855632b9057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518903Reviewed-by:
-
Luciano Pacheco authored
This is a preparation for follow up CLs migrating to JS modules which will use those modules in externs as JS modules instead of using as externs. This is due to limitations on Closure compiler working with JS modules and externs. BUG=chromium:1133186, b/172300267 Change-Id: Ic983ba08b050f161c6b6e2e9b287f19584409982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517350 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Austin Tankiang authored
This is done to notify the pinned toggle to update when toggling the pinned state of a file. Fixed: 1141665 Change-Id: I9d273f849ad870b0fb8277a5e21ffbdd5cf7ea28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519230 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#823916}
-
Henrik Boström authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/19d71f6b351f..f014dbd87ab0 $ git log 19d71f6b3..f014dbd87 --date=short --no-merges --format='%ad %ae %s' 2020-10-30 libyuv-ci-autoroll-builder Roll chromium_revision df9aecfc..5aaa70b5 (820568:822628) 2020-10-28 fbarchard PlaneScale, UVScale and ARGBScale test 3x and 4x down sample. 2020-10-27 fbarchard MJPGToNV12 added and build files sorted Created with: roll-dep src/third_party/libyuv TBR=fbarchard@chromium.org Bug: chromium:1132299 Change-Id: I2e35b8505910ea88a9f2dd1da0224f7758ebe4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516362 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823915}
-
Hiroki Nakagawa authored
This reverts commit d761a60e. Reason for revert: Code added by the original CL causes use-of-uninitialized-value on the Linux ChromiumOS MSan Tests bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8864606879521783696/+/steps/browser_tests/0/logs/Deterministic_failure:_All__x2f_ArcAuthServiceTest.AccountRemovalsArePropagated__x2f_0__status_CRASH_/0 Original change's description: > KeyPermissions: Add ARC key permissions manager delegate > > This CL introduces ARC key permissions manager delegate which observes > changes that affect ARC usage allowance of corporate keys residing on a > specific token. If an ArcKpmDelegate observes a change in the state of > ARC usage allowance, it notifies all observers. ArcKpmDelegates are > utilized by key permissions managers to keep key permissions updated in > chaps. > > Bug: 1113115, 1127284 > Change-Id: Ib7636c83f313904c7d5a23f91baca6bf43907344 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479706 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Long Cheng <lgcheng@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823681} TBR=lgcheng@google.com,pmarko@chromium.org,omorsi@google.com Change-Id: I9e375757495af9ad2c778f9b42477629a4093d79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113115 Bug: 1127284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519333Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604415585-c8905f6123c6046ea03b2e75cc15c5d923d8f1b6.profdata to chrome-win64-master-1604447854-94cc190ab0ce9114e706f7027e39b9e22ef628e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1973018a083490c8ae05b4390b835804daec1a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518935Reviewed-by:
-
Nidhi Jaju authored
This CL adds the WebIDL files and relevant C++ stubs for the ReadableStreamBYOBReader class according the the Streams API Standard[1]. It also adds a ReadableStreamBYOBReadResult dictionary needed by the read() function in the reader. This feature will be runtime enabled under the flag "ReadableByteStream". [1] https://streams.spec.whatwg.org/#readablestreambyobreader Bug: 614302 Change-Id: I91fea585574e12bc868bf35931c6e0783177e687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513952 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#823912}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/31e28d20f878..47c3ca108898 2020-11-04 capn@google.com Resolve MSan symbols dynamically If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5c3ef7d5516a948e318e352ae7f7f3b665ef36bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519250Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I3943eb42472f207354c3ef26ce40c10c7416ecc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515802 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823910}
-
Wojciech Dzierżanowski authored
The Linux failures were due to https://crbug.com/1035382, which is now fixed. Thw Windows failures also seem to have been an unrelated issue that affected hundreds of other tests in the same testrun: [6532:7132:0731/151510.560:FATAL:service_process_host_impl.cc(57)] Check failed: iter != processes_.end(). Bug: 1001538 Change-Id: Ia87c54b7f71fd102cf49551db43541d74066846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513654 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#823909}
-
Daniel Libby authored
Some plumbing for the content::DisplayFeature concept (which is used to expose dual screen and foldable device layout information to the web) exists in the content layer but currently is only emulated through devtools. This change adds plumbing to RenderWidgetHostViewAndroid to punch out to the Java layer via ViewAndroidDelegate JNI to retrieve this information, and to convert the Window-relative device-pixel coordinates to view-relative DIPs. Due to current issues with the androidx.window support library, the integration will land in a separate CL. This is queried when synchronizing visual properties so that we can send one atomic update for both the resize and window segment changes. Introduce a MockDisplayFeature that allows for cross platform setting of an emulated value for tests. On Android this actually mocks out the ViewAndroidDelegate call to test more of the code. Bug: 1039050 Change-Id: I543615d3b42a328668b1fd518cf0e99acadb0069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427156Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823908}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1604316477-benchmark-88.0.4312.0-r1 to 88-4296.0-1604316477-benchmark-88.0.4314.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I470eb0f1ba2822e19ada5fca5969520c870aa865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519350Reviewed-by:
-
Frank Tang authored
This is a reland of 38e15fd1 Original change's description: > Roll ICU to 68-1 > > See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2511803 > for the actual changes and the details of the data size changes. > > > Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel > > Bug: 1138555,854201,927703 > Change-Id: I8f1b6157f2f1c13c2864836b38e36a37b8c778bf > Binary-Size: 40K ICU increase due to increase version of ICU. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474093 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823458} Bug: 1138555 Bug: 854201 Bug: 927703 Bug: 1145094 Change-Id: I1ba81ab75224a3264da0d50481b48766965efccc Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518034Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823906}
-
Asami Doi authored
When a timeout happens in ServiceWorkerEventQueue, the error status transfers to ServiceWorkerFetchDispatcher::OnFetchEventFinished(), but the callback of an offline capability checker (ServiceWorkerOfflineCapabilityChecker::OnFetchResult) can't catch the error status. This CL set a flag `is_timeout_event_` when the timeout happens and if the flag is set, call DidFail() with the error status instead of DidFinish() which is called in a successful case. Bug: 965802 Change-Id: I9b38c8332f3bfc539d16b0f101143e7af3db66f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437081 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823905}
-
Jérémie Boulic authored
Moving interfaces definitions in files_app_entry_types.js to ui/file_manager/externs/files_app_entry_interfaces.js. This is part of the preparation for the migration of Files app JS code to JS modules. Due to Closure compiler limitations with externs and JS Modules we'll generate modules for some externs files and use as modules instead of externs. This fixes a circular dependency where the implementations in files_app_entry_types.js depend on volume_info.js which depends on these extracted interfaces. BUG=chromium:1133186, b/172300267 Change-Id: If2643c1bc50732c847d0dc99ae19bc4918c5be3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517186Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e54309477ac..938932225cef 2020-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 959f41988a18 to 31e28d20f878 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I7688dbe7e92ccec25ab64d29f9b7e5e69f638998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519210Reviewed-by:
-
