GitLab

BUG=

Review URL: https://codereview.chromium.org/413353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285771 0039d316-1c4b-4281-b951-d872f2087c98

A regression where we stopped showing the manifest error was introduced in
r283852. Fix it.

TBR=finnur@chromium.org

BUG=397467

Review URL: https://codereview.chromium.org/422533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394940

Review URL: https://codereview.chromium.org/408633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285769 0039d316-1c4b-4281-b951-d872f2087c98

This is an implementation of session APIs without wifi passwords. Will add wifi passwords in separate CL.

BUG=

Review URL: https://codereview.chromium.org/411783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285768 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for out-of-process iframes, move almost all accessibility
functionality from RenderView to RenderFrame, and from RVHI and RWHI
to RFHI.

In addition, the accessibility mode is moved to WebContents, and changing
the mode triggers changing it on all frames.

BUG=368298
R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org

Review URL: https://codereview.chromium.org/273423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285767 0039d316-1c4b-4281-b951-d872f2087c98

Screenshots:
https://docs.google.com/file/d/0B9q2eN9gDoUIUUhrMlpydVNTVXc/edit?pli=1
https://drive.google.com/file/d/0B9q2eN9gDoUIMjdhQ1p3M05zNDQ/edit?usp=sharing

BUG=389749

Review URL: https://codereview.chromium.org/368143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285766 0039d316-1c4b-4281-b951-d872f2087c98

histogram.

Possible reasons are: no/empty server config, expired server config,
invalid server config and corrupted server config.

R=rch@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/416983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285765 0039d316-1c4b-4281-b951-d872f2087c98

In doing so, fix a bug in tlslite's TLS_FALLBACK_SCSV support; the fallback
alert should be sent with the client's version. Otherwise OpenSSL reports
SSL_R_UNSUPPORTED_PROTOCOL and doesn't report the alert. This behavior is
probably not wrong as, if the server responds with a TLS version higher than
what is supported, we can't really be sure of the parse.

BUG=388425

Review URL: https://codereview.chromium.org/418553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285764 0039d316-1c4b-4281-b951-d872f2087c98

This has the side effect of fixing the crash in 396368

BUG=396368
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285393

Review URL: https://codereview.chromium.org/411813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285763 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/417113010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285762 0039d316-1c4b-4281-b951-d872f2087c98

- Fix and partially disable the RenderText unit tests to make sure RenderTextHarfBuzz passes the tests. Call EnsureLayout() in GetGlyphBounds() since it has been made public by r252873.

- Add a "--disable-harfbuzz-rendertext" switch to make enabling RTHB by default easier.

BUG=321868
NOTRY=true

Review URL: https://codereview.chromium.org/419753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285761 0039d316-1c4b-4281-b951-d872f2087c98

As a result of this I uncovered some things we shouldn't have been
doing. I had to update a number of tests accordingly.

BUG=396804
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/421693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285760 0039d316-1c4b-4281-b951-d872f2087c98

This will produce Breakpad symbol files that have CFI data when building for
64-bit.

BUG=393594
R=mark@chromium.org

Review URL: https://codereview.chromium.org/419813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285756 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285754 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285753 0039d316-1c4b-4281-b951-d872f2087c98

Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it.

R=agable@chromium.org, maruel@chromium.org
BUG=395196

Review URL: https://codereview.chromium.org/415323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285752 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=395196

Review URL: https://codereview.chromium.org/413223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397762
TEST=compile with no errors
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/413393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285741 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285740 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:

Causes a slew of devtools failures: 
17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(1) 
[17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(1) 
[17:19] <mpearson> http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20ChromiumOS%20Ozone%20Tests%20(2) 
[17:19] == tapted_ [~tapted@121.211.79.93] has quit [Quit: tapted_] 
[17:19] <mpearson> http://build.chromium.org/p/chromium.win/waterfall?builder=Vista%20Tests%20(1) 



failed 4 
stdio 
TestConsoleOnNavigateBack 
TestDeviceEmulation 
TestNetworkSyncSize 
TestScriptsTabIsPopulatedOnInspectedPageRefresh 

browser_tests 
browser_tests 

> Blink roll 178929:178950
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178950&mode=html
> TBR=haraken@chromium.org,jchaffraix@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/417293002

TBR=blink-deps-roller@chromium.org

Review URL: https://codereview.chromium.org/424483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285739 0039d316-1c4b-4281-b951-d872f2087c98

Previously the host and client were running on the main thread, so they
both would compete for it and that skews the perf numbers, particularly
with NSS SSL sockets because they use a separate thread.

BUG=394067
R=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/414443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/420553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285737 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/382633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285735 0039d316-1c4b-4281-b951-d872f2087c98

scottmg told me to do this.

> Block on LaunchProcess failing on specific bot
> 
> Block in a loop if we get a specific failure on a particular bot.
> See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference.
> 
> Timeout raise attempted at https://codereview.chromium.org/410353004/ so
> that there will be time to attach a debugger.
> 
> R=brettw@chromium.org
> BUG=340422
> 
> Review URL: https://codereview.chromium.org/411223002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/414363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285734 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/415773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285730 0039d316-1c4b-4281-b951-d872f2087c98

time. In particular, do not call XConvertSelection() till SelectionNotify is
received for the current request (or the current request has timed out).

This is part #1 of implementing support for receiving selection data in multiple
chunks via the INCR property. In particular, when data is transmitted via the
INCR property, the transmission is not complete when the SelectionNotify event
is received.

BUG=367549
TEST=None

Review URL: https://codereview.chromium.org/391593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285729 0039d316-1c4b-4281-b951-d872f2087c98

- Fix menu bg asset to properly allow the menu to overlap the anchor
- Turn on dismiss button in menu
- Fix some animation code related to the dismiss button in the menu
- Make overlapping an RTL item work properly

BUG=394898
NOTRY=true

Review URL: https://codereview.chromium.org/419673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/411143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285727 0039d316-1c4b-4281-b951-d872f2087c98

There may be more than one favicon if loading an extension favicon,
which loads for all supported scale factors immediately rather than
in an as-needed fashion.

BUG=397341

Review URL: https://codereview.chromium.org/421633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285725 0039d316-1c4b-4281-b951-d872f2087c98

Since ozone builds removed X11, they get identified as "unknown" in the user agent string and as a result calendar and potentially other things don't work.

This CL brings identification back in line with other linux builds.

BUG=394335

Review URL: https://codereview.chromium.org/394233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380313

Review URL: https://codereview.chromium.org/417043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=asvitkine@chromium.org, isherman@chromium.org, thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/365253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285722 0039d316-1c4b-4281-b951-d872f2087c98

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285446

Review URL: https://codereview.chromium.org/418723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279351
TBR=armansito@chromium.org

Review URL: https://codereview.chromium.org/419683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285720 0039d316-1c4b-4281-b951-d872f2087c98

Apparently, OS X allows commas as separators between hostnames in the hosts
file. Treat commas the same as whitespace to support this. (Hostnames and IP
addresses will never contain commas, so this shouldn't break anything.)

BUG=396309

Review URL: https://codereview.chromium.org/415153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285718 0039d316-1c4b-4281-b951-d872f2087c98

Current host warning "Read and modify your data .." should say "Read and change your data .." to maintain consistency with other strings.

As part of the overall effort to cleap up extensions/app warnings we need to ensure the consistency of the wording. All write access should say "change", thus this CL fixes this for hosts permission.

BUG=386224
R=jww

Review URL: https://codereview.chromium.org/415293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285717 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke a ton of tests:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14823

Original issue's description:
> Run android tests through runtest.py.
> 
> BUG=329102
> R=qyearsley@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285667

TBR=qyearsley@chromium.org,jbudorick@chromium.org,klundberg@chromium.org,navabi@chromium.org,yfriedman@chromium.org,eseidel@chromium.org,zty@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329102

Review URL: https://codereview.chromium.org/423593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285716 0039d316-1c4b-4281-b951-d872f2087c98

app_host.exe was removed in r220555. This change removes some dead code
that was left behind. Specifically:
- chrome_launcher_support no longer exposes any methods related to the
  AppHost.
- Chrome's uninstall prompt no longer has a special case to handle
  suppressing the "delete your profile" checkbox.
- Chrome and its installer no longer have a dependency on
  launcher_support.
- The installer no longer supports installing items from the webstore.
- GetUntrustedDataValue no longer has consumers and is gone.

BUG=297647
R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org
TBR=grt@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/419913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396785
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/417813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285714 0039d316-1c4b-4281-b951-d872f2087c98