- 02 Aug, 2017 40 commits
-
-
Eric Noyau authored
First patch just removes the flag and the command line, the second removes all the associated code. Change-Id: Iad8fd182655dca68be28f00c8a55e200dd7557f8 Reviewed-on: https://chromium-review.googlesource.com/598234Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491397}
-
nednguyen authored
This also modifies convert_legacy_wpr_archive script to also automatically run "git add .*wprgo" for the users upon succesful uploading. Bug: 730036 Change-Id: I9c26a65b7ec72cd5b55136a5ef6be975caeba541 Reviewed-on: https://chromium-review.googlesource.com/598268Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491396}
-
Duc Bui authored
We need to keep track of tabs which are being restored by session restore (instead of other mechanisms like reopening closed tabs). This CL adds new API to SessionRestoreObserver and makes TabManager to keep track of the session-restoring tabs. Bug: 731901 Change-Id: I0d415a689d2b8e49b58cb2af6623ad7fad7ea50a Reviewed-on: https://chromium-review.googlesource.com/588168Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Commit-Queue: Duc Bui <ducbui@google.com> Cr-Commit-Position: refs/heads/master@{#491395}
-
Luna Lu authored
This reverts commit b4ee3ace. Reason for revert: suspect breaking tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla_expected_failures%2Fmarvin%2Fbackgr_fixed-bg.html&testType=webkit_tests https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9 The test has been consistently failing on Mac OS 10.9 Original change's description: > Position fixed backgrounds in table sections correctly > > Bug: 35697 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62 > Reviewed-on: https://chromium-review.googlesource.com/594987 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491294} TBR=wangxianzhu@chromium.org,robhogan@gmail.com,eae@chromium.org Change-Id: Id2939cb178de44d6b601f353ca1acc8145802ced No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 35697 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/598407Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491394}
-
Matt Mueller authored
Remove unused x509_certificate_model.h include from chrome/browser/chromeos/options/vpn_config_view.cc Bug: none Change-Id: I37bd44bc9ddebf88f7916e21cb90122db870b2b0 Reviewed-on: https://chromium-review.googlesource.com/596715 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491393}
-
Anna Maria authored
[Local media Casting] Correcting issue where local media cast files will not work with media remoting. This is because tab:0 is an invalid source, so we correct that to use the actual tab number in the source. This requires a different create route flow because it seems up to now that there has been an assumption that sources do not change, but for the local file case this is not so because the tab must be opened. Bug: 721802 Change-Id: I69ec9d1dd981e7d445a1bb823f301911cd37058c Reviewed-on: https://chromium-review.googlesource.com/596607Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Anna Maria <paezagon@chromium.org> Cr-Commit-Position: refs/heads/master@{#491392}
-
Morten Stenshorne authored
Causes problems for Jumbo builds. TBR=nverne@chromium.org Change-Id: If4a37cff9ae787ec0c750b652663fd2d8d6b1a66 Reviewed-on: https://chromium-review.googlesource.com/598090Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491391}
-
nednguyen authored
Bug: 730036 Change-Id: I3087cf1897d639cd3425f4906b3b02cb12ebc648 Reviewed-on: https://chromium-review.googlesource.com/598190Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491390}
-
Morten Stenshorne authored
Multiple definitions in various .cpp files causes problems for Jumbo builds. TBR=chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I907fc4bbba428de44579c9466a8884270102483b Reviewed-on: https://chromium-review.googlesource.com/598070 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#491389}
-
Raphael Kubo da Costa authored
libxslt's source code was moved to src/ in commit 6f776b2a ("Check in the libxslt roll script"), but README.chromium wasn't updated to point to the license file's new location. Bug: 708393 Change-Id: I041569545e3c9d536b826bfaa198605ba5ca6a88 Reviewed-on: https://chromium-review.googlesource.com/597848 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491388}
-
Scott Graham authored
There's no documented handle limit on Fuchsia, and it looks like this function is used for questionable purposes anyway, so just return ::max(). Bug: 743296 Change-Id: I4e85f31eb519d5dc2d96882d793b9e2c4afc7851 Reviewed-on: https://chromium-review.googlesource.com/597008 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491387}
-
Fady Samuel authored
Registering a FrameSinkId delimits the beginning of the lifetime of a FrameSinkId. From Viz's perspective that ID is valid until InvalidateFrameSinkId is called. RegisterFrameSinkId also bundles a HostFrameSinkClient (was FrameSinkObserver) that listens for new surfaces submitted to the registered FrameSinkId. This CL allows us to replace multiple call sites to RegisterFrameSink / InvalidateFrameSinkId in content that go directly to FrameSinkManagerImpl with calls to HostFrameSinkManager, taking us closer to a point where content does not directly use FrameSinkManagerImpl. This CL is also a prerequisite for using HostFrameSinkManager in the window server because it introduces a mechanism for listening for events pertaining to a particular FrameSinkId which is a requirement for the window server. This interface will be used for events as well in the future. Bug: 657959 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I3e1343ea6cfbe6b3d39ba2fcd23d193dd2c3e4a0 Reviewed-on: https://chromium-review.googlesource.com/595147Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491386}
-
gambard authored
When the device is rotated, the layout should be invalidated in order to have the Most Visited tiles to have the "correct" alignment, i.e. 4 tiles per row. It also prevent the omnibox from being unfocused on rotation. Bug: 751237 Change-Id: I305eff881d226ea692b8f8767dfb52557ce61f82 Reviewed-on: https://chromium-review.googlesource.com/597629Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491385}
-
gambard authored
The user needs to be able to opt out of Content Suggestions if needed. Android is coupling the Omnibox suggestions and the Content suggestions setting but it is probably clearer to have it separated. However the names are misleading and need to be changed. TEST= Toggle the switch Settings->Privacy->"Show Content Suggestions". - When enabled the suggestions are shown as expected. - When disabled, the remote suggestions("Articles for You") currently displayed are removed. When opening a new NTP the Articles for You section is empty. The Reading List section is unaffected. Bug: 751623 Change-Id: I076f2f25697741e6f351a90da500a6ef33b21bf1 Reviewed-on: https://chromium-review.googlesource.com/598069 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491384}
-
Francois Doray authored
ScopedAsyncTaskScheduler is deprecated. Bug: 708584 Change-Id: I795e7d07947369c202ea767b05543bb44474ff47 Reviewed-on: https://chromium-review.googlesource.com/591788Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491383}
-
Tsuyoshi Horo authored
WorkerFetchContext implements all virtual methods of BaseFetchContext now. Bug: 443374 Change-Id: Ib8071cd74963c0fff5298a05d0d70a0728aace29 Reviewed-on: https://chromium-review.googlesource.com/597558Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491382}
-
Vitalii Iarko authored
As treib@ pointed out, my usage of DCHECKs to check our assumptions about server provided data was inappropriate. This CL replaces DCHECKs with LOG(WARNING) and then return. Bug: Change-Id: I905cf99079f5075c633b4aa3d7e85381f552f3e2 Reviewed-on: https://chromium-review.googlesource.com/597855 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#491381}
-
Pavol Marko authored
If an empty login_screen_input_methods policy is sent from the client, treat it as if the policy was not present. Don't restrict input methods in this case. BUG=750572 TEST=browser_tests --gtest_filter=LoginScreenPolicyTest.* Change-Id: I83109bb5c7648ac6a7f81da414879745bf905abb Reviewed-on: https://chromium-review.googlesource.com/589436Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491380}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/82d97bdbfc0a..50f7a1e4abea $ git log 82d97bdbf..50f7a1e4a --date=short --no-merges --format='%ad %ae %s' 2017-08-02 fmalita Add another sweep gradient tiling test Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Idec1c3d7d4146fc5b33c56236553073b1d6d52c9 Reviewed-on: https://chromium-review.googlesource.com/598147Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491379}
-
Raphael Kubo da Costa authored
The anonymous named getter is not part of the spec, and we are trying to figure out how much it is actually used. The existing counter is triggered whenever code tries to access a named property, this second counter is triggered only when a property is found and should give us a better idea of when named properties are not accessed by accident. Bug: 689687 Change-Id: I7f255593d2a998a83a62ca60d814751b938db0af Reviewed-on: https://chromium-review.googlesource.com/596975Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#491378}
-
Leonard Grey authored
When BookmarkContextMenuCocoaController is (re)creating menus, it first creates a BookmarkContextMenuController, then takes the the menu model created by it, and uses it to create a MenuController. If these objects exist already, the old ones are destructed/dealloced when the smart pointers holding them are reset with the new ones. As the BookmarkContextMenuController holds the menu model in a unique_ptr, this briefly leaves the MenuController with a dangling pointer to its model. Unfortunately, as part of its dealloc, if the menu is still open, MenuController will close it, and notify the model. Most of the time, this doesn't happen, but something about VoiceOver requesting a bookmark button's menu can make a reset happen before the menu closes. It would probably be better to rearchitect around this, but nothing good is coming to mind right now, so work around by manually calling |cance| on MenuController before resetting, to ensure that the menu is closed before dealloc. Bug: 749213 Change-Id: I0890b341115487fe92b18d9c067e1f662b3f4958 Reviewed-on: https://chromium-review.googlesource.com/596793Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#491377}
-
John Budorick authored
Bug: 745086 Change-Id: Ibf50d8eccd106357d00b955417fd17bfb07c3f20 Reviewed-on: https://chromium-review.googlesource.com/592701 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491376}
-
Dominik Röttsches authored
Allow ranges for font-weight in @font-face, compare https://drafts.csswg.org/css-fonts-4/#font-prop-desc Bug: 749091 Change-Id: I7e3fffe6f71d95ad5bc0703d4e01edbbb108cfd0 Reviewed-on: https://chromium-review.googlesource.com/581149Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491375}
-
Vitalii Iarko authored
This CL adds a function to push an article suggestion to the top of Articles section in RemoteSuggestionsProvider. Also a button added to snippets_internals to push a dummy suggestion. Bug: 742225,735402 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic41f831884d9487a7e567db21b83371ae1834655 Reviewed-on: https://chromium-review.googlesource.com/585127 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491374}
-
Matt Menke authored
Two more of these were recently, both of which are failing, and all the old tests using the fixture are failing, too, so simplest just to disable them all. TBR=yzshen@chromium.org NOTRY=true Bug: None Change-Id: I7e4751021dce0d2383e46a63ab7305b5e6e58676 Reviewed-on: https://chromium-review.googlesource.com/598111 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491373}
-
Hans Wennborg authored
It was currently built at "optimize for size", which means important function such as FMAC_C weren't getting autovectorized and unrolled. Since this file is performance sensitive, using max optimization seems reasonable. BUG=750923 Change-Id: Id38e66365ee1b8b636e391ba07b83a804142eba1 Reviewed-on: https://chromium-review.googlesource.com/597017Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491372}
-
Raphael Kubo da Costa authored
Set it to "NOT_SHIPPED" since googletest is only used for running tests. Not setting it makes //tools/licenses.py complain. Change-Id: I5146c7d6a7a64bcd19a194246bc24fcc47f12f32 Reviewed-on: https://chromium-review.googlesource.com/597907Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#491371}
-
gambard authored
The titles should be shown only if there are more than two sections. This applies only to the section from ContentSuggestionsService. Bug: 749125 Change-Id: If9d8320baa9f5cad287d47b70202cbe203f06727 Reviewed-on: https://chromium-review.googlesource.com/596050 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#491370}
-
gogerald authored
Bug: 751226 Change-Id: I84b42c04c16d3b5662ed6a5bf5d491b031b3c84a Reviewed-on: https://chromium-review.googlesource.com/597014Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#491369}
-
Francois Doray authored
The FILE thread is deprecated. Bug: 689520 Change-Id: I57db0b1e7150f2ec7ee4fbdb538912b1928cd9dc Reviewed-on: https://chromium-review.googlesource.com/595030Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491368}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b7658d8..5c85b29c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie0526f93764f4b79c280e5e3dc66fa3da3a66630 Reviewed-on: https://chromium-review.googlesource.com/597831Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491367}
-
Tommy Martino authored
Bug: 749815 Change-Id: Ife1a72146c3f75020286fb588f5e78a12e8d747a Reviewed-on: https://chromium-review.googlesource.com/596412Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#491366}
-
Guido Urdaneta authored
This reverts commit 3dd3e056. Reason for revert: Relanding original CL since the revert did not fix the bot. Original change's description: > Revert "Moved parsing logic to property APIs for grouped longhand properties" > > This reverts commit 264ba723. > > Reason for revert: Speculative revert. Suspect of causing tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html to fail reliably on WebKit Mac10.9 bot. > > Sample failed build: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/48635 > > Will reland if it does not fix the problem. > > Original change's description: > > Moved parsing logic to property APIs for grouped longhand properties > > > > This patch: > > - Moved parsing logic to property APIs for the following grouped > > properties: > > border-image-repeat > > border-image-slice > > border-image-outset > > border-image-width > > background-clip > > background-image > > background-origin > > -webkit-transform-origin-x > > -webkit-transform-origin-y > > -webkit-perspective-origin-x > > -webkit-perspective-origin-y > > -webkit-mask-box-image-repeat > > -webkit-mask-box-image-slice > > -webkit-mask-box-image-outset > > -webkit-mask-box-image-width > > -webkit-mask-image > > - Replaced the bool literal argument in BorderImageUtils with a > > new enum class to comply with the style guide > > - Added #includes to PositionUtils that should have been there > > when the file was created. For some reason this only started > > causing build errors in this patch > > > > Bug: 668012 > > Change-Id: I796f0967e4222689c14700b12d7726df7ab35170 > > Reviewed-on: https://chromium-review.googlesource.com/597378 > > Reviewed-by: meade_UTC10 <meade@chromium.org> > > Commit-Queue: Bugs Nash <bugsnash@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#491288} > > TBR=meade@chromium.org,bugsnash@chromium.org > > Change-Id: I1c6e1a29a52dfb99aaa6cb7fa1f064104fecc91e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 668012 > Reviewed-on: https://chromium-review.googlesource.com/597888 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491346} TBR=guidou@chromium.org,meade@chromium.org,bugsnash@chromium.org Change-Id: I719f967cb722285f771fd123042da35996f4d284 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 668012 Reviewed-on: https://chromium-review.googlesource.com/598167Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491365}
-
Stephen Chenney authored
The names are confusing, leading to bugs. Try to make them more obvious. R=pdr@chromium.org BUG=739228 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5fe6b1c4432818279f4758397d07b581a0fbe408 Reviewed-on: https://chromium-review.googlesource.com/596847Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491364}
-
Michael Lippautz authored
We previously only kept the wrapper alive as long as the scope had timers attached. This requires us to kept explicit hidden references to event listeners to prevent them from being garbage collected. Relying on wrapper tracing requires us to keep the scope alive as long as its context is alive. This is a dependency for https://chromium-review.googlesource.com/c/576472/ Bug: Change-Id: I82c177f6e93a7ed15697e574f4e0e001957dff7a Reviewed-on: https://chromium-review.googlesource.com/584875 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#491363}
-
Bo Liu authored
All generated RegisterNativesImpl functions are no-op already. Remove all manual jni registration code in ui that calls these generated RegisterNativesImpl calls. TBR=garykac@chromium.org,zmo@chromium.org Bug: 749244 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iebbb9d91e5cc78d62b323113c5ccecd59a7311a8 Reviewed-on: https://chromium-review.googlesource.com/592333 Commit-Queue: Bo Liu <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491362}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/21171e50f486..82d97bdbfc0a $ git log 21171e50f..82d97bdbf --date=short --no-merges --format='%ad %ae %s' 2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 44183ccea..b0761934b (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ifd9ed9292d20b18cffd1968504cc7acd5df39fb8 Reviewed-on: https://chromium-review.googlesource.com/597967Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491361}
-
Nicholas Verne authored
Bug: 712963 Change-Id: I9d88fb2153c9de3ff01c5542923a7d4e832ac382 Reviewed-on: https://chromium-review.googlesource.com/597610 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491360}
-
Guido Urdaneta authored
BUG=751543 TBR=pkasting@chromium.org Change-Id: I9e33b2f01f0c71bb7b032d16ec4e16443fadf0b2 Reviewed-on: https://chromium-review.googlesource.com/597853Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491359}
-
gambard authored
In order to have the feature accessible, all the actions using gestures (long press, swipe to dismiss) must have custom accessibility actions. Also adds action sheet to Read Later cells. Bug: 749131 Change-Id: I49171acf34b897035c998b8f0f8186bc6484d878 Reviewed-on: https://chromium-review.googlesource.com/597600Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491358}
-