- 22 May, 2019 40 commits
-
-
Liquan(Max) Gu authored
The spec[1] says "If the global object is not a Window object, throw a TypeError". We should check whether the global object is a window object when converting a performance-timing name to timestamp. If it is not, throw a Type Error. [1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp Bug: 953869 Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662216}
-
Robert Ma authored
Landing this manually because of issue 958017. Using wpt-import in Chromium 51dfc6b4. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" c4fa33ec "CSS: WPT for scroll-padding computed value" 9200fa90 "Add WPT test for sctp.maxChannels" 297e5505 "Bring reference space naming/interfaces up to spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc kojii@chromium.org: external/wpt/css/css-text/line-break external/wpt/css/css-writing-modes meade@chromium.org: external/wpt/web-animations mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I89e163e716b5d3c0dcdbf47c675a2ba401c13713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624946Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#662215}
-
Koji Ishii authored
This patch changes |NGPhysicalFragment::GetLayoutObject()| to return |const LayoutObject*|. There are 18 places where we need mutable objects. |GetMutableLayoutObject()| is added to support them. We'd like to eliminate them over time. Original discussion at a review comment[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1614732/14#message-6290a1c82a1344f0dda119af20225e0b5fa867c9 Bug: 635619 Change-Id: I0aae9d9bb5d1eb9c9c34e149edbecc3c59a7870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616834 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#662214}
-
Lukasz Anforowicz authored
This CL temporarily disables one of SavePageOriginalVsSavedComparisonTest tests to enable landing of a change to //testing/variations/fieldtrial_testing_config.json that enables MimeHandlerViewInCrossProcessFrame everywhere in preparation for shipping this feature to the stable channel in M76. The test failure seems mostly understood and the test should be re-enabled within a week or two. Bug: 964364 Change-Id: I3006897f260301bcc5eff52e828c08702517bea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620700Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662213}
-
Friedrich Horschig authored
This CL generalizes helper functions used in the following tests * PasswordAccessoryControllerTest, * AddressAccessoryControllerTest (https://crrev.com/c/1614200), and * CreditCardAccessoryControllerTest (https://crrev.com/c/1599927) Bug: None. Change-Id: Ief1ad6cb78e14d558e2202cf874d8dbbaa54e9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615464 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#662212}
-
Lucas Tenório authored
One of the paths that determines eligibility is during onboarding. Bug: 958995 Change-Id: I58056f8edea1b9da2f9ddd4b0ff0ae9ef6d1bcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621397 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662211}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/23aff9b73788..b32f2c7f57cc git log 23aff9b73788..b32f2c7f57cc --date=short --no-merges --format='%ad %ae %s' 2019-05-22 danilchap@webrtc.org Publish rtc event log api and default factory for it in api/ Created with: gclient setdep -r src/third_party/webrtc@b32f2c7f57cc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I60c30034f3c40738946905907871a2229fe98dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662210}
-
Eric Stevenson authored
This CL moves the arrays of locale pak files out of BuildConfig.java into a new file, LocaleConfig.java. This file is generated with a unique package which allows Chrome and Webview to have different versions in Trichrome. Bug: 960025 Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#662209}
-
Peter K. Lee authored
Bug: 961120 Change-Id: Ic0315eb4a99c9ccc3dcc22207de5838c2fb5fe2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624945 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662208}
-
Eric Stevenson authored
Copied from //build/android/.style.yapf. Ran "yapf -r -i --style base/android/.style.yapf base/android", fixed a couple instances where the suggested changes weren't nice due to complex statements, and fixed two long line issues. Also updated testREForNatives to not have an unused variable. Bug: 846432 Change-Id: Ic11f0bf808adaae03fbd2b2d6e819169f4e9bd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622909Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662207}
-
Nektarios Paisios authored
This patch removes the deprecated accessibility selection code from Blink. This is timely, because the new selection code has been on for 1.5 weeks and no major regressions have been encountered. R=aleventhal@chromium.org, dtseng@chromium.org Bug: 639340 Change-Id: Ibdf8a7575e229407fe3418a4efd5eed96b7b8540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620967Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#662206}
-
Victor Hugo Vianna Silva authored
For history webuis and the recent tabs menu, we offer the possibility of using requests to Google's favicon server as a fallback mechanism, instead of requesting from sync. We use LargeIconService to achieve it. This behavior is guarded by a feature flag disabled by default. We also fix a minor formatting issue in chrome/browser/about_flags.cc. Bug: 955475 Change-Id: I1ff64611cfde1e995a14b36ea2496b33d214eea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603444 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#662205}
-
A Olsen authored
If a notification is dismissed but not dealt with, then show it again after 1 day. If a notification is not dismissed, and password is not changed, then notification is updated after one day, since the text showing the how urgent it is should change. Deleted some code that special cased the "expired" case - this case actually has the same logic as "about to expire" case, so it doesn't need a special case. Added more unit tests for SAML password expiry notification. Bug: 930109 Change-Id: Ie035ec788ee083d07261bca0e19f216e6bc7d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620642 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662204}
-
David Roger authored
The cookie was a domain cookie, but host cookie is preferred. This allows simplifying and re-enabling the test. The test was failing with net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN. This CL removes the DNS rule and the SSL configuration (which were required for the domain cookie, but can be removed for a host cookie), which makes the test simpler and hopefully more robust. Bug: 964264, 965993 Change-Id: I03412b9046b79a2cbb56ebdb95dd1661d67fb938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617360 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#662203}
-
Sebastien Marchand authored
Also remove the base writer interface as it's not needed. Bug: 961336 Change-Id: Ie942c35079ba45c37b549a977e952470a95d529c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613881 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#662202}
-
Andres Calderon Jaramillo authored
This CL adds a workaround for the advertised supported VAImageFormats in Intel's media driver (iHD). Right now, the driver is advertising some formats that it actually doesn't support. Until this is fixed, we are conservative and remove all the formats other than I420 or NV12 from the list of advertised formats. Some additional cleanup is done per https://crbug.com/956581. Test: VaapiJpegDecoderTest.* pass on eve. Bug: 955284 Change-Id: I734581ef7c533251559c66355755d9e7766239cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623491Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#662201}
-
Vadym Doroshenko authored
Old parser is disabled is final state of the launch of the new parser, so everything should work for it. PasswordManager::ProvisionallySavePassword sends ReportMissingForManager metric even if old parser is disabled (and then it sends it incorrectly). This metrics is sent for NewPasswordFormManager in PasswordManager::ProvisionallySaveForm. Along the way extracted sending of SubmittedFormFrame metric to a separate method and called it for NewPasswordFormManager. Bug: 831123 Change-Id: If170658a030e2b34b8aa7b9bd70cc048d8de0fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624573 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662200}
-
Finnur Thorarinsson authored
Bug: 956459 Change-Id: I8c4c305347b9bc98f8f032c5f738baf3e728c940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621139 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#662199}
-
Aga Wronska authored
CalculateIdealBounds() updates member variables and their properties. It should not be marked as const method. Remove the call from CalculatePreferredSize() that is const. It is not needed, because CalculateIdealBounds() is called when bounds change. Tests: Existing shelf tests + manually Change-Id: Iadf330ee25542fb329065df058d930a9cca5cb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622385Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#662198}
-
Xi Han authored
Disable: - WebXrVrDeviceTest#testForNullPosesInInlineVrFromNf - WebXrVrDeviceTest#testForNullPosesInInlineVrOnNavigation - WebXrVrDeviceTest#testForNullPosesInInlineVrPostImmersive These tests are failing on Nougat Phone Tester and android-pie-arm64-dbg. TBR=bsheedy@chromium.org Bug: 758296 Change-Id: Ide558551413af934fba02c68ed5a8e5e7a5933da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624827Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662197}
-
Lucas Tenório authored
This change also makes the supervision server flags simpler, since we are getting close to a final server implementation. Bug: 958995 Change-Id: Ic3c07ef4a992faf6238bbd2a492848d26174a461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621010 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#662196}
-
Tommy Steimel authored
This CL creates a new AudioLauncherActivity alias to the MediaLauncherActivity that handles audio intents (while the main intent handles video and images). We disable AudioLauncherActivity on Android Go while leaving it enabled on enterprise-managed devices. This allows us to continue to handle video and image intents on Android Go without breaking the memory restrictions imposed on music players on Android Go. TESTED=Able to open video/audio/image files with Chrome on an enterprise-managed device. Able to open video/image files with Chrome on an Android Go device, but not given the option to open audio files with Chrome. Bug: 965166 Change-Id: Ia2b774a048ac430b658c29b8fb11bf8835709842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620610Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662195}
-
Aaron Leventhal authored
Bug: None Change-Id: Ifd0b059157fa7e32a60fc90707d51a409f89ded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620287 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#662194}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ebe38ca9..927eded5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbbefd3863b71fea73e80773c740a0c87be74770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624825Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662193}
-
Jérôme Lebel authored
Renaming from MDCLegacyInkLayer+Testing.h MDCLegacyInkLayer+Private.h ios/third_party/material_components_ios/BUILD.gn https://critique.corp.google.com/#review/248588133 Bug: 965882 Change-Id: I8a98c74440ee2edcb39bf9b1d6f8ed4c7e042de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624185Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662192}
-
Rouslan Solomakhin authored
Before this patch, developing on http://localhost would not skip the browser payment sheet, even though all requirements were met: single URL-based payment method was requested without any additional data from autofill, the method had a default payment app, and show() was called with a user gesture. If the hostname was changed to https://not-localhost.com, then skip UI would trigger. This patch adds an exception for http://localhost to be classified as a valid URL-based payment method for the purposes of the skip UI check. After this patch, developers on http://localhost have the ability to skip the browser payment sheet. Bug: 965141 Change-Id: Idd639ceabf093ab8a82ccf52dd278bf142d42630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620511Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662191}
-
Mihai Sardarescu authored
This CL updates MainController to use a regular _settingsNavigationController when presenting the Google services settings. This ensures that when the user attempts to open an URL from the Google services settings, the regular close settings and open URL command is executed. Bug: 963436 Change-Id: Ibec138d6cd3baf34c43f713f43c1e9cb908a8382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621132 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#662190}
-
David Benjamin authored
Bug discussion suggests the issue was fixed, and NoTrackDoubleFieldsForSerializerScope no longer exists. Remove the suppression. Bug: v8:3143 Change-Id: Ic8bcea8d111ad8334914a817ca46a5f4a83558fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618147 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#662189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2efe6ea070c5..e66f7aeb4a32 Created with: gclient setdep -r src-internal@e66f7aeb4a32 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Iff6bb88968f1436a61f6ba6673179e4da5fc63bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625005Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662188}
-
Xiyuan Xia authored
Bug: 965517 Change-Id: Ic059d5b5a0c70701b657d66424d47f5c4de9ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623496Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662187}
-
Toni Barzic authored
TBR=alemate@chromium.org Change-Id: I9377203afcf10794cd542af6192dceedd4f2ffd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618078 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662186}
-
Steven Bennetts authored
Ths CL renames TrayNetworkStateObserver -> TrayNetworkStateModel to better reflect its purpose. Bug: 862420 Change-Id: I129419cb6278401bd2f6f710aecf633e8e71501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622427Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662185}
-
Mario Bianucci authored
A CL[1] over a year ago added an if check that caused autoscrolling to stop if the cursor left the page and the middle button wasn't held in. Since other Windows apps allow auto scrolling to continue in this case, it makes sense to match that behavior and also allow it. [1] https://crrev.com/5971e47dc08dbb773f58fd6fb13b1df7917fd295 Bug: 806562 Change-Id: Id7259b5242f21c2042f300d7f0a606179be89b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618141 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662184}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1af92be6b977ca537ba668573029b03518e9e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662183}
-
David Bokan authored
We can't assume a FrameOwner's content view is a local frame view here since we might be removing a root scroller because it's no longer valid; it could be that it once was a LocalFrameView but has since been replaced by another type of view. No test since this came from the fuzzer and only causes an issue when run under UBSan. Bug: 961597 Change-Id: Ia24c000ac53a795d0325c2aa8825e901344f3ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618203Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662182}
-
Moe Ahmadi authored
Removes the Translate Settings entry from the Content Settings page if the Language Settings UI feature is enabled. Bug: 957688 Change-Id: Iee16ac5ca00bae2f14f398e80427cbcd23ac3984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622988Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662181}
-
Moe Ahmadi authored
Bug: 957688 Change-Id: I3d4afd4dadbabfb544b7741ae9365aac8bee29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622326Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662180}
-
David Bokan authored
The root scroller doesn't account for non-overlay scrollbars correctly. This will be a non-trivial fix and require some more time to think through so this CL disables root scroller on non-Android platforms until the issue can be fixed. Bug: 948059,953285 Change-Id: I2425c907d7a2c9363cce39e69183063fafbed65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617378Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662179}
-
Mark Cogan authored
This CL creates public/browsing_data/ and moves these headers into it: browsing_data_removing_util.h system_cookies_store_util.h To match this, in //ios/web/, the following files are moved from net/cookies to browsing_data/: system_cookie_store_util.mm system_cookie_store_util_unittest.mm READMEs are added as well. Bug: 942244 Change-Id: I509c1fc170952f8a4a72977dcc2b8d880b837610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624571 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#662178}
-
Hans Wennborg authored
This should pass now. Bug: 961204 Change-Id: I78274311f576bb22ee96526e14cf16352c218090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624907 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662177}
-