GitLab

Add a new feature flag, that when enabled, uses the IME shared library
for physical typing in languages based on latin script.

Bug: 1019541
Change-Id: Ib3a84fe19028164c82947f4257c2787005cb4b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371064
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804017}

getDeviceEnterpriseInfo() could run callbacks synchronously if a result
is cached. This could lead some reentrancy problems for consumers of the
class.

This CL modified getDeviceEnterpriseInfo() to always run callbacks
asynchronously.

Testing: Built and ran Chrome(ium) on a managed Android emulator
and observed that "EnterpriseCheck.IsFullyManaged2" indicates
managed.

Bug: 1120955
Change-Id: I122ecbc07946129220776de063a224d5173f1540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385640
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804016}

Bug: 960012
Change-Id: I1852e992c7573845e0ddb8ccc24e1f4a0254ed1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387177Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804015}

https://swiftshader.googlesource.com/SwiftShader.git/+log/e1051cbaad46..3c0e0582acfa

2020-09-02 capn@google.com Skip texel address sample offset if zero
2020-09-02 srisser@google.com Fix enum-hashing build error on Ubuntu 16.04

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Idd18caa93232766e44ef48bf2f04022b02c8817e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804014}

This shouldn't have any functional changes, just a nice to have
all references in the same order :)

Bug: 1123668
Change-Id: I503650e9520e823941e92f9037ee193034a60d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391729
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804013}

Launch approval in crbug.com/1077038.

Bug: 1069623
Change-Id: I2c739c82aecfcefbb76a9fe9a142362412bde8bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391724Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804012}

This adds MeasurementMode::kEagerForTesting, which can only be used if
SetEagerMemoryMeasurementEnabledForTesting is called. This mode causes
an instrumented GC as soon as the measurement request is sent, so the
measurement times are more predictable in tests.

R=fdoray

Bug: 1122131
Change-Id: I7901f3021cea1e133a9c20c94ad7082bad114fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386775
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804011}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Ie5df7ae4672bd39945ccce51d163835b254a43fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387020
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804010}

Bug: 1116207
Change-Id: I320664402cd84cee47a8f5cb89ddbc500656f6a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380816Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Chris Cheng <chriscycheng@google.com>
Cr-Commit-Position: refs/heads/master@{#804009}

Refactor PrintSettingsFromJobSettings to return a unique pointer.
Also add unit tests for the print settings conversion functions.

Test: ./printing_unittests
Change-Id: I4afd3e7ff466948cea9a372293dbff93ca2a12bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337953
Auto-Submit: Pranav Batra <batrapranav@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804008}

These test are flaky, marking them as such,
and then will investigate issue.


Bug: 1122037
Change-Id: I739c88f40c12cbaf95a777642280f9b2b645ae7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391502Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804007}

https://chromium.googlesource.com/angle/angle.git/+log/6b2639b023f9..84bd9dade9cb

2020-09-02 syoussefi@chromium.org Vulkan: Allow pbuffer usage if no window support
2020-09-02 geofflang@chromium.org Add a frontend feature to disable anisotropic filtering.
2020-09-02 syoussefi@chromium.org Vulkan: Don't break the RP on masked/scissored clears
2020-09-02 sugoi@google.com Make copyTexImage2D robust when source area is out of bounds
2020-09-02 syoussefi@chromium.org Vulkan: Fix resolve with different formats
2020-09-02 syoussefi@chromium.org Vulkan: Fix resolve-with-subpass with non-zero read attachment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1034840,chromium:1123524
Tbr: cwallez@google.com
Change-Id: Icf79fe2ec8d251015215e21e800877538092f27c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391373Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804006}

Turn on strict closure compiler check and fix all related errors.

Bug: 1122444
Test: tast run <DUT> "camera.CCAUI*"
Change-Id: I8411d21a7a84b2e0172108ad71275a0c6c93b1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383592
Commit-Queue: Shik Chen <shik@chromium.org>
Auto-Submit: Inker Kuo <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804005}

Adds a named guide for the Discover feed header menu gear icon. This
guide is meant to be used in the feed IPH message.

Bug: 1124448
Change-Id: If86cc3d5d0d9b3934d135f56a1e3b85954618aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391542Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804004}

Introduces Node::InvalidateIfHasEffectiveAppearance to handle what
this function did previously.

There should be no behaviour change.

Change-Id: I93c1a1a4112df5dcc395010b1812927e8d1f6c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369505Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804003}

Elision can be broken for URLs in which the tld appears separate from
the rest of the host, which can happen for some bidirectional hosts.
This disables elision completely for any URL with a bidirectional
host component while the bugs are fixed.

Bug: 1117631
Change-Id: Ib47b77ec8331b82810383d8c558c33912aad992c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388910Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804002}

Files app doesn't open in the Downloads folder by default since MyFiles
folder has been introduced. So the implicit expectation from ARC++
bridge that Files app would show Downloads is broken. This CL fixes it
by passing the Downloads folder when opening Files app.

NOTE: To have the whole workflow working other changes in Files app and
App Service are required and will be tracked on Issue:1090211

This issue was noticed in the Google Photos Android app, which shows a
link to open the Downloads folder after user has clicked "Save to
device" in a photo. See comments #10 and #11 in crbug.com/1090211#10

Test: Manually from Google Photos Android app
Bug: 1090211,607411
Change-Id: I1a320987f58961e069eb49f5b2de7c204bc5211c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381332Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804001}

Failures fixed by
https://chromium-review.googlesource.com/c/angle/angle/+/2390781

TBR=bsheedy

Bug: 1123524
Change-Id: I583adf0ac6117b8d4b5e7e03b3da12cea244e054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391617Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804000}

This patch cleans up the code and removes DisplayLockLifecycleTarget.
The reason for this is that for kSelf the checks always return true,
so it's only meaningful for children. This patch updates the function
names to indicate this and removes the enum.

R=chrishtr@chromium.org, szager@chromium.org

Change-Id: Ic17c69e414ece0f0e23fe0d5e20687fea0f8e589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391385Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803999}

Mark crosapi.mojom.Bitmap as stable (it's simple and controlled by the
lacros project).

Mark crosapi.mojom.Notification as stable (its only interesting
dependency, ImageSkia, was recently stabilized).

Bug: 1113889
Test: presubmits
Change-Id: I0dbf3663d3bd4af72184d360be1f6f4269a5eab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388907Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803998}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /components/gwp_asan

This CL was uploaded by git cl split.

R=inferno@chromium.org

Bug: 1110266
Change-Id: I1d55608a65e101e9809d5691c1d6ff4dab2152fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370290Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803997}

Bug: 958381
Change-Id: I91df6f992533deffb8192d38d167f7bdd20cd6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385926
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803996}

Adds a script that can be used to find unexpected passes of tests suites
on the CI bots. The intended use case for this is to cut down on the
number of stale test suppressions in the GPU tests, but it could
potentially be useful for other test types.

Bug: 998329
Change-Id: Iac09971a8545721bdf1c7e877477e4a56b2a7969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386423
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803995}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/56048e67ae15..e4dd8ba9285c

2020-09-02 nodir@chromium.org Roll dirmd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: If63857c85859db2b877f1806e1deccb82da6bf53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391670Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803994}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I244182d237f154c8d3d670ed3fda27bf71824122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392141Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803993}

Some of the generated files depend upon mojoms in
//media/medi, but there is no dep. Without the dep the
build is flaky, and recently failed on arm64:

[63355/105864] CXX clang_x64_v8_arm64/obj/third_party/blink/renderer/bindings/modules/v8/v8/v8_midi_input.o
FAILED: clang_x64_v8_arm64/obj/third_party/blink/renderer/bindings/modules/v8/v8/v8_midi_input.o
/opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -...(too long)
In file included from clang_x64_v8_arm64/gen/third_party/blink/renderer/bindings/modules/v8/v8_midi_input.cc:8:
In file included from clang_x64_v8_arm64/gen/third_party/blink/renderer/bindings/modules/v8/v8_midi_input.h:12:
../../third_party/blink/renderer/modules/webmidi/midi_input.h:34:10: fatal error: 'media/midi/midi_service.m

BUG=none
TEST=none

No-Tree-Checks: true
Change-Id: Id72b0d095bf363fe6538205942d1612c64bf50c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391597
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Dana Fried <dfried@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803992}

This reverts commit c02e4409.

Reason for revert: ios-simulator-noncq is consistently fails due to WebShareTestCase failure.
Failing build: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/11637

Original change's description:
> Restrict web share feature to URLs with http/https protocols
> 
> Bug: 1122059
> Change-Id: Id9644b9dff7e9854f20218f09750fbf191d5a318
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378274
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803970}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

Change-Id: I54b308b6462b1659a5cc86818b5e420d5323845f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391943Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803991}

This reverts commit 00d4ff28.

Reason for revert: the waterfall fails to build.

Original change's description:
> [PRImpl] PaymentRequestImpl retains the values it needs
> 
> Context:
> CL[1] moved some PRImpl's parameters it needed into CPRImpl, and
> retrieved them from CPRImpl when PRImpl needs it. This is problematic,
> because PRImpl could outlive CPRImpl, and so doing it could cause
> NullPointerError (see the bug). This CL partially reverts CL[1] but
> keeps the changes of the constructor signature because this is more
> succinct than passing each one of the parameters. Since CPRImpl would
> take over the PRImpl logic going forwards, passing only CPRImpl would
> avoid the frequent change of the PRImpl constructor's signature.
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/2357630
> 
> Change:
> * Before: CPRImpl retains the values that PRImpl need; after: PRImpl
> keeps a reference of the value that itself needs
> * Added a few null check or assert for mComponentPaymentRequestImpl
> in case it's used after release.
> 
> Bug: 1122148
> 
> Change-Id: I00ac6e4ca3fccccd114132209465757f52fa0dc9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378538
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803902}

TBR=danyao@chromium.org,maxlg@chromium.org

Change-Id: Ia852083d85d574b8d37f6b8a11f0fd1fee1957c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391904Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803990}

This reverts commit 1bdd8df6.

Reason for revert: the waterfall fails to build.

Original change's description:
> [PRImpl] Remove OnDoneCreatingPaymentApps() from PRImpl#initAndValidate()
> 
> Context:
> PaymentRequestImpl#initAndValidate() depends on
> OnDoneCreatingPaymentApps() which unnecessarily depends on a lot of
> PRImpl's members. It's error-prone and make it hard for PRSpec to
> implement the PaymentRequestParams interface. So I write this CL to
> remove initAndValidate()'s dependency on OnDoneCreatingPaymentApps().
> 
> Change:
> * initAndValidate() no longer depends on OnDoneCreatingPaymentApps()
> * When origin is unsafe: BEFORE PRImpl#initAndValidate()
> ended early but not close the mojo pipeline. AFTER: when origin is
> unsafe, PRImpl#initAndValidate() ends early and close the mojo
> pipeline.
> * When origin is unsafe: it's the blink PR (after) instead of PRImpl
> (before) rejects promise for the subsequent calls of show(), return
> false for canMakePayment(), hasEnrolledInstrument().
> * Update the documentation on payment_request.mojom, changed
> because the asynchronous nature of the Mojo IPC is an important design
> consideration. Making it explicit can make future change less
> error-prone.
> * CanMakePaymentQuery.java is changed because
> PaymentRequestImpl#mQueryForQuotachange's change makes the 'query'
> parameter not nullable.
> 
> Bug: 978471, 1102522
> 
> Change-Id: I367a7df795fb87ea0f79649d405f7fd6be65694e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372888
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803982}

TBR=kenrb@chromium.org,rouslan@chromium.org,dpranke@google.com,maxlg@chromium.org

Change-Id: I1706ac06e87251df193d80214c3bfc2c19a2825a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 978471
Bug: 1102522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391598Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803989}

This reverts commit a5cc0feb.

Reason for revert: the waterfall still fails to build.

Original change's description:
> [PRImpl] Not to assert getCertificateChain
> 
> Since  mCertificateChain is provided by CertificateChainHelper,
> PaymentRequestImpl should not assert its existence.
> 
> Bug: 1122148
> 
> Change-Id: I48b8ec4c6559bd3a95596d90fc2cf670ad167f87
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391725
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803986}

TBR=estade@chromium.org,maxlg@chromium.org

Change-Id: I2e52f57fd63dbab112a2d127414e333329ee7909
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391901Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803988}

Disables Blink test:
external/wpt/pointerevents/compat/pointerevent_mouse-pointer-preventdefault.html

No-Tree-Checks: true
TBR: liviutinta@chromium.org
Bug: 1124378
Change-Id: I295122b3f5136cc03eada8541b32ead3121c346b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391386
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803987}

Since  mCertificateChain is provided by CertificateChainHelper,
PaymentRequestImpl should not assert its existence.

Bug: 1122148

Change-Id: I48b8ec4c6559bd3a95596d90fc2cf670ad167f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391725Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803986}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/test/data/webui/settings

This CL was uploaded by git cl split.

R=dschuyler@chromium.org

Bug: 1110266
Change-Id: I3f47d833cdd11223ffad0240c2b815a80e4d0506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370287Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803985}

Hides tooltips from web content when the Chrome_RenderWidgetHostHWND is
being reparented on Windows.

Normally, mouse input messages over the Chrome_RenderWidgetHostHWND are
forwarded to the host window, where they are processed as events and
used by the tooltip controller to manage tooltip visibility.

However, when the legacy Chrome_RenderWidgetHostHWND is hidden or
occluded, it is reparented to a global hidden window, and messages are
no longer forwarded to the host window. If a WM_MOUSELEAVE message did
not arrive before this happens, the tooltip controller would not handle
it, and any open tooltips would stay open. Thus, we must explicitly
close tooltips during this reparenting step.

Bug: 724538
Change-Id: I4e4273ed451ff97c49b146e6b0499db3951baf88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242951Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#803984}

See attached bug.

TBR: rouslan@chromium.org
Bug: 1115091
Change-Id: I54a433ed5ce6321df2d906fa55584ed51ca55365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391607Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803983}

Context:
PaymentRequestImpl#initAndValidate() depends on
OnDoneCreatingPaymentApps() which unnecessarily depends on a lot of
PRImpl's members. It's error-prone and make it hard for PRSpec to
implement the PaymentRequestParams interface. So I write this CL to
remove initAndValidate()'s dependency on OnDoneCreatingPaymentApps().

Change:
* initAndValidate() no longer depends on OnDoneCreatingPaymentApps()
* When origin is unsafe: BEFORE PRImpl#initAndValidate()
ended early but not close the mojo pipeline. AFTER: when origin is
unsafe, PRImpl#initAndValidate() ends early and close the mojo
pipeline.
* When origin is unsafe: it's the blink PR (after) instead of PRImpl
(before) rejects promise for the subsequent calls of show(), return
false for canMakePayment(), hasEnrolledInstrument().
* Update the documentation on payment_request.mojom, changed
because the asynchronous nature of the Mojo IPC is an important design
consideration. Making it explicit can make future change less
error-prone.
* CanMakePaymentQuery.java is changed because
PaymentRequestImpl#mQueryForQuotachange's change makes the 'query'
parameter not nullable.

Bug: 978471, 1102522

Change-Id: I367a7df795fb87ea0f79649d405f7fd6be65694e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372888Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803982}

This reverts commit 3e67e586.

Reason for revert: switchTabBetweenDifferentPeekModes is still failing:
https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2545

Original change's description:
> [Autofill Assistant] Fix for failing tests.
> 
> Bug: 1123958
> Change-Id: Ie0ba79cc3ace8d7a115dac30888b2430972239d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390205
> Commit-Queue: Michele Mancina <micantox@google.com>
> Reviewed-by: Marian Fechete <marianfe@google.com>
> Cr-Commit-Position: refs/heads/master@{#803874}

TBR=marianfe@google.com,micantox@google.com

Change-Id: I7811d2019d025844dd3964553ad0ca3b1086b522
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1123958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391645Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803981}

This change tweaks the look and feel of the button to open the audio
device picker. Screenshots of this button are on the crbug.

Bug: 1117160
Change-Id: Idc0faa6685b73ab4246a0544bdead23b1aeccef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382872
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803980}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2b9e3dd7..8395751f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id863efe9d2b9ad3ad73c1aff1f76459b2df6b299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390804Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803979}

Currently, each HashMap uses a unique type to represent each key and
value. These types are then converted to IdentifiableTokens just before
metrics are recorded. These types (mainly structs) can be confusing,
with fields remaining unused in certain code paths.

We convert FontMatchingMetrics to instead use an IdentifiableToken as
both its key and value, simplifying the work at publish time and
improving readability. To enable its use as a key, the IdentifiableToken
is wrapped in a simple struct.

This change does not change functionality, although the change in token
generation method will affect the exact hashes recorded. This new
approach will simplify a future refactor that does make functional
changes (see crrev.com/c/2376037).

Bug: 1121669
Change-Id: I6c7ba2b6f42c62d7ae007d2c9b9519323edc24cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388002
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803978}