- 24 Jul, 2018 40 commits
-
-
Ryan Hamilton authored
TBR=asvitkine@chromium.org Bug: 862555 Change-Id: I87b37b6c2ebfd27d86e3116693dd71f18e608aaa Reviewed-on: https://chromium-review.googlesource.com/1147513Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577420}
-
Koji Ishii authored
Following bot results are included. 8184 8185 8186 8193 8195 8196 8197 8203 8207 8211 8217 8222 8232 8240 8253 8258 2 lines were removed and 4 lines were deflaked by consecutive results since 8195. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I043a191621b414909e17b48d34c6e1815ef28ef9 Reviewed-on: https://chromium-review.googlesource.com/1146121 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577419}
-
Luciano Pacheco authored
Re-enables the call to |notifyEntriesChanged| and refresh all required metadata which includes "share", "modificationTime" and "size" among others. The method |notifyEntriesChanged| invalidates all metadata, so we should update all required metadata fields. This fixes the issue where file list (RHS) wouldn't display modification time column, because sometimes when it would try to display the metadata had been invalidated due to the call to |notifyEntriesChanged|. |notifyEntriesChanged|, so the fact that they're all passing now it's the the actual test. Test: Several tests were failing when re-enabling Bug: 857343 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5a1e243c22c4040530c55d3d41708740dd617d88 Reviewed-on: https://chromium-review.googlesource.com/1117966Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I896d5cd0bdc2f76cc139717c2d8d4b625e46039c Reviewed-on: https://chromium-review.googlesource.com/1147710Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577417}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8eeb808d84f..903fb041a2f8 git log b8eeb808d84f..903fb041a2f8 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 94c91a95358b..522095f7d7fe (6 commits) Created with: gclient setdep -r src/third_party/skia@903fb041a2f8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I920b1d59d2b324868922865cd9edfc6140146468 Reviewed-on: https://chromium-review.googlesource.com/1147721Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577416}
-
Sergey Ulanov authored
VideoCaptureSystemImpl expects to have non-null VideoCaptureDeviceFactory, but it was getting nullptr value on Fuchsia. As result the browser was crashing Bug: 866669 Change-Id: I73ec5c850acdc392a7984f62d9f66edb0961809a Reviewed-on: https://chromium-review.googlesource.com/1147514 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577415}
-
Erik Luo authored
Screenshot: https://imgur.com/a/8u2tq05 Bug: 845449 Change-Id: Ibe8ca7b40133891cfe2701f90d26a2850b7d7497 Reviewed-on: https://chromium-review.googlesource.com/1077101Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577414}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1116ef0b1c45..c62aa207e9ac git log 1116ef0b1c45..c62aa207e9ac --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Tighten up ThisProxy casts. Created with: gclient setdep -r src/third_party/pdfium@c62aa207e9ac The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I70086cea92cab118a977e75a9ee23e97e49730a8 Reviewed-on: https://chromium-review.googlesource.com/1147723Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577413}
-
Koji Ishii authored
When layout is cached, this patch: 1. Skips marking full paint invalidation. 2. Ensures the DisplayClientItem ID (the pointer of the DisplayItemClient) is unchanged for paint system to track the identity and possible offset changes. We may be able to (or may need to) reduce paint invalidations in more generic SetPaintFragment function, but I'm starting from eliminating the simple case first. By reviewing the paint/invalidation test results, 73 tests have the same or less invalidations with this change. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2f6a06aeca4898ca2e5347be23596c811a389f2b Reviewed-on: https://chromium-review.googlesource.com/1146120Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577412}
-
Lei Zhang authored
Avoid confusion with another software project with a similar name. Change-Id: I1072b05c19c682a5a0b749ce6199db73a9dd68a6 Reviewed-on: https://chromium-review.googlesource.com/1147302Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577411}
-
Georges Khalil authored
This CL has 2 changes: - Change location to Google Policy/Enrollment - Derive filename from client ID (in case the home directory is mounted remotely) Change-Id: I5b3acafd20119f79deef24fb44e3e0514c693311 Reviewed-on: https://chromium-review.googlesource.com/1145627 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577410}
-
Lei Zhang authored
Change-Id: Ic9aae2a702866818c2b06aaae5710813b6335bfa Reviewed-on: https://chromium-review.googlesource.com/1135942Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577409}
-
Wei-Yin Chen (陳威尹) authored
Some tests are disabled for now. Bug: 853281, 865527, 865540, 865709, 865715 Change-Id: I4fda286ff877301704426820ee10d200cd54468b Reviewed-on: https://chromium-review.googlesource.com/1144305Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577408}
-
Kurt Horimoto authored
LegacyReadingListToolbarButton is actually a plain UIView superview of the UIButton handling touch events, so setting the a11y identifier on the superview was not passing touches to the underlying button in EG tests. This CL updates LegacyReadingListToolbarButton to take an a11y identifier that's applied to the underlying UIButton, allowing touches to be handled properly. Bug: 866012 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e98ae482bd21e1e913d500d53f43526fadb62af Reviewed-on: https://chromium-review.googlesource.com/1147310 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#577407}
-
Erik Luo authored
CodeMirror text editors try to reduce indentation on 'Shift+Tab'. However, this consumes the key event, preventing focus from leaving, even if nothing changed. This CL allows focus to leave when we are sure that no indentation should change. Shift+Tab can now move focus from Console prompt to toolbar and from SourceFrame's editor to the Sources TabbedPane. Bug: none Change-Id: I3660a48fe1c30a0972e2908514ee44fba7a51132 Reviewed-on: https://chromium-review.googlesource.com/1142519 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#577406}
-
Erik Luo authored
Anchors can precede a console message's content, which makes filters with start/end of line ('$', '^') fail. This CL evaluates any filter regexes on the message content separately from the anchor. Bug: 819799 Change-Id: I0957fd8fb3dea26f690e859cfabbc432cdda069c Reviewed-on: https://chromium-review.googlesource.com/1081561Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577405}
-
Chris Harrelson authored
Previously, in such situations we failed to mark the layer as needing layer requirements update, which already has code to issue an invalidation on the new backing of the content now that it lost squashing. Bug: 865415 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I807bf1426e45ce71ed42024512e9c77481f018cc Reviewed-on: https://chromium-review.googlesource.com/1145896 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577404}
-
sczs authored
Bug: 865044 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9099ae71217f68eb624332debb8260faa067991d Reviewed-on: https://chromium-review.googlesource.com/1145629Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577403}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ba1e9caeecb..6ec6d27f2d1b git log 5ba1e9caeecb..6ec6d27f2d1b --date=short --no-merges --format='%ad %ae %s' 2018-07-24 iannucci@chromium.org [led] Update to f8fd394bd671f4cf4da8064a1ee074018c275d15. Created with: gclient setdep -r src/third_party/depot_tools@6ec6d27f2d1b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If9fb52596690d667bd5c410fabfd53de8dbcb71c Reviewed-on: https://chromium-review.googlesource.com/1147720Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577402}
-
sczs authored
Changes the vertical stackView distribution to UIStackViewDistributionFillProportionally,so the stackView doesn't cut the subtitle label for lack of space. Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I524dacb378515088faae9e99c0db408ad3f9b4b0 Reviewed-on: https://chromium-review.googlesource.com/1147541Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577401}
-
tzik authored
ViewEventTestBase has no-op AddRef and Release for a historical reason, but they are no longer needed for years. Bug: 866456 Change-Id: Iea74ee9c87667f033fc90d47f2d331a202ab61d8 Reviewed-on: https://chromium-review.googlesource.com/1146538Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577400}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5bc35fd6c631..5389d34c833d git log 5bc35fd6c631..5389d34c833d --date=short --no-merges --format='%ad %ae %s' 2018-07-23 moragues@google.com config: Fix Build Break on firmware tryjobs on master branch Created with: gclient setdep -r src/third_party/chromite@5389d34c833d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4009ea047f37c083088e46a2a601e8477679d256 Reviewed-on: https://chromium-review.googlesource.com/1147071Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577399}
-
Amy Qiu authored
Update recordings for pages in simple_mobile_sites for rendering.mobile. Change the flickr url to an album to bypass the initial login screen (doesn't allow scrolling). Bug: 852530 Change-Id: I2bd71f512492cb306c47fea0f9bd857fae953338 Reviewed-on: https://chromium-review.googlesource.com/1146499Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#577398}
-
Erik Luo authored
Part 2: live updating pins - same JSAutocomplete, `await` processing, previews as ConsolePrompt - 250ms interval to update pins - prevent side-effects while editing text (editor has focus) Screenshot: https://imgur.com/a/zaPlRTC Bug: 849875 Change-Id: I0cd18101e58a6ff4e71e674633409ca0e015e1e7 Reviewed-on: https://chromium-review.googlesource.com/1096417 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577397}
-
Fritz Koenig authored
GL_FRAMEBUFFER_FLIP_Y_MESA will tell OpenGL to render the image upside down. Passing the buffer along like this will allow ChromeOS to scan out directly from the buffer. BUG=680851 Change-Id: I142cec041358af17652f7314ac89e82678b78d3b Reviewed-on: https://chromium-review.googlesource.com/1117365Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577396}
-
Clark DuVall authored
This test was modifying Set-Cookie and removing User-Agent, which is no longer supported with the network service (see crbug.com/827582). Bug: 827582, 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I977bcc767188eafb76c6d560bb959871ed73808a Reviewed-on: https://chromium-review.googlesource.com/1145941Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577395}
-
Joel Einbinder authored
This adds syntax highlighting, autocomplete, argument hints, and smart enter to the breakpoint editor Change-Id: I973be5e44ff94f36fbefdeb1eb472122ee2789a9 Reviewed-on: https://chromium-review.googlesource.com/1144195Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577394}
-
Tetsui Ohkubo authored
This CL makes following changes: * Increase the font size of a detailed view header. * Use medium style for Sign Out and Clear All buttons. * Replace help icons used for a11y detailed view header. TEST=manual BUG=863618,858947 Change-Id: I05f831247c19ceda004acb9c1103b1716503f254 Reviewed-on: https://chromium-review.googlesource.com/1141671Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#577393}
-
Scott Haseley authored
Bug: 822954 Change-Id: I8668f4003bff3fa47e1b542884f81cf1e13bffad Reviewed-on: https://chromium-review.googlesource.com/1147505Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#577392}
-
Peter Kasting authored
I've done enough work on them over time that I think I'm capable of reviewing changes here. Bug: none Change-Id: Ia3ed68a601b2a7c55ad4cd5918c18ed5f83700a0 Reviewed-on: https://chromium-review.googlesource.com/1147663Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577391}
-
Khushal authored
R=ericrk@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6871e01e0e531a13682c69ddde78de19db665d8b Reviewed-on: https://chromium-review.googlesource.com/1144603Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577390}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I38dbc355743a6bb8f2f04fb31f51b92ab3377bff Reviewed-on: https://chromium-review.googlesource.com/1146489Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#577389}
-
Xida Chen authored
The feature PaintTouchActionRects could introduce different behavior than today's code of computing the touch action rects. In order to prevent regression, this CL creates a new test suite for the tests under fast/events/touch/. The virtual suite run those tests with --enable-blink-features=PaintTouchActionRects. Bug: 853912 Change-Id: Ia07e93892e88dfb9e6c2ea078784da3985ef26a4 Reviewed-on: https://chromium-review.googlesource.com/1146764 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577388}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7b61abe..f0bf9a40 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7e97a0961ba28c3c69ea9fb051e32023f78577d Reviewed-on: https://chromium-review.googlesource.com/1146776Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577387}
-
Leo Zhang authored
Add more logic and make the service testing really works. Tested locally by enabling build flags (enable_cros_ime_service and enable_cros_ime_decoder), then pass the testings chromeos/services:chromeos_services_unittests Bug: 837156 Change-Id: I05f557f808c210e788630ce4749b5c261ed19b44 Reviewed-on: https://chromium-review.googlesource.com/1146537 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#577386}
-
Emil A Eklund authored
Fix border, background, and mask painting for inline blocks spanning two or more lines or that are otherwise fragmented across multiple entities. This involved refactoring the existing inline box painting code to allow code sharing between legacy and LayoutNG painting code. It also required changing LayoutNG painting to further distinguish between inline and non inline boxes as the background image painting code in particular require taking the other fragments for a fragmented object into account when the image offsets and clipping is computed. Finally, this cleans up the flow box paint logic for both legacy and NG. This reverts r561186 (01dda95e) which in turn was a revert of the original patch (r558871) which was reverted due to a performance regression in blink_perf.paint color-changes benchmark. To avoid the regression this patch moves construction of the box painter from the inline box painter constructor to the paint methods where it is needed, thereby avoiding the construction overhead in cases where cached drawings may be reused. It also limits the lifecycle of the box painter. Bug: 714962, 844624 Test: fast/backgrounds/border-radius-split-background-image.html Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87ae744fdd204133e40b50721eca6947c81da817 Reviewed-on: https://chromium-review.googlesource.com/1144216 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577385}
-
Justin Cohen authored
TBR: sczs@chromium.org Bug: 866730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70 Reviewed-on: https://chromium-review.googlesource.com/1147701Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577384}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2bfa78540c37..1116ef0b1c45 git log 2bfa78540c37..1116ef0b1c45 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Remove unused CFXJSE_Arguments::GetObject() 2018-07-23 tsepez@chromium.org Remove argument from CFXJSE_Value::ToHostObject() Created with: gclient setdep -r src/third_party/pdfium@1116ef0b1c45 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I01e1215ef5cfdc9d6b7b6a8f84232156c6e6f573 Reviewed-on: https://chromium-review.googlesource.com/1147069Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577383}
-
Victor Costan authored
This CL: * Adds SQLITE_OMIT_COMPLETE, removing command auto-completion logic * Adds SQLITE_HAVE_ISNAN, removing SQLite's custom implementation * Removes -ldl, which was only needed for runtime extension loading Change-Id: I065c2faba028379e336b2d691afad7093328d7c3 Reviewed-on: https://chromium-review.googlesource.com/1146290 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577382}
-
Fady Samuel authored
We close fallback surfaces in order to speed up the arrival of the primary surface from a child client. That logic was complex and difficult to follow. Now with SurfaceRanges, that logic can be simplified somewhat. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ied2efb4eac61f297fe6784825084f0a88e716dab Reviewed-on: https://chromium-review.googlesource.com/1147114 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577381}
-