- 17 Apr, 2020 40 commits
-
-
George Burgess IV authored
r758850 was a refactor of some code. Looks like it removed these functions from the `logging` namespace, but left the macros unchanged, causing clang-tidy errors. Bug: 1070788, 1070795 Change-Id: I15b209574674426e2a5fbbc37dc5fb4dc8f3559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154380 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#760036}
-
Majid Valipour authored
The test was moved but not its chrome specific automation script. Moved the script to correct folder and updated expectation file. Minor: Also rename the test to match the convention. FIXED: 912613 Change-Id: I44ddc7d5693df18f00400f79e63a95aeb626f03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150397Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#760035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29cf2b0cbb75..1261b5caa386 git log 29cf2b0cbb75..1261b5caa386 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 hbos@webrtc.org [Adaptation] Move EffectiveDegradationPreference to RA-Processor. 2020-04-17 mbonadei@webrtc.org Remove WebRTC-LibvpxVp{8,9}TrustedRateController. 2020-04-17 hbos@webrtc.org [Adaptation] Delete Processor Proof-of-Concept. Created with: gclient setdep -r src/third_party/webrtc@1261b5caa386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8a47c59b7a424f7d9d123b9a415cc790c98fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154553Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760034}
-
Owen Min authored
RetrieveDeviceSecret doesn't quit properly on Mac when password can't be retrieved. It invokes the |callback| twice and causes CHECK failure. Verify: 1) Install extension that has reportingPrivate permssion. 2) Open Console 3) Run following command: chrome.enterpriase .reportingPrivate.getPersistentSecret((i)=>{console.log(i);}); TEST: Manually Bug: 1068329 Change-Id: Ic12665c81a5794268e02d1208a20599aef48f500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153893Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760033}
-
Alex Rudenko authored
Currently, the Esc event does not reach the inspected page when the user highlights an element in the Elements pane. With this change, the Esc event will be marked as not handled to allow event propagation. As the result, on Esc the highlighting will be turned off and the page will handle the Esc button. Fixed: 994645 Change-Id: I8aeee3364ee8806f1dc1808ce74647fd75a8b97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152369Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760032}
-
Antonio Gomes authored
BUG=767015, 1063749 Change-Id: I793f33d54ae5b57643fc669664793eb7e848ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153265 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#760031}
-
Denis Kuznetsov authored
After changes in issue 1058022 the tests are much less likely to time out on dgb/*san bots. If tests will flake again, please disable them indvidually rather then by reverting this CL. Bug: 1034481, 1031545 Bug: 1058022 Change-Id: I9c736f865d6f3cd5fedd675f5b480f6e0a458d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152371Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#760030}
-
Trent Apted authored
We're migrating away from the old Gallery chrome app. When MediaApp is enabled, r759170 ensures we pick chrome://media-app over Gallery. E.g., for the task request that comes from the Camera app to open the camera roll. This CL updates the set of tasks shown in the files app to match that logic, And implements the product request to: - Hide the Gallery in any case where the Media App can handle a file, - (ignoring any explicit preference for Gallery in this case), and - Ensure Media App is the "default" handler if there is no preference for a different app (even if that app would normally be default merely through having been installed). IsFallbackFileHandler becomes simpler because MediaApp now "can't" be a fallback handler to apply that logic, which is now encapsulated in AdjustTasksForMediaApp(). Existing expectations FileTasksBrowserTest don't change, but there are now some extra checks: - Verify that for every test case, MediaApp and Gallery are never both presented as options. - New tests are added for the logic that ensures Media App is chosen over installed apps, unless that app is an explicit user preference. Bug: 1030935, b/153387960, 1071289 Change-Id: I942dd47712817c0bc8767de7ff28d858f5e11a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150528 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#760029}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4d2298bfd78a..9f46e3dd5e11 git log 4d2298bfd78a..9f46e3dd5e11 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 63069047+pmistryNV@users.noreply.github.com Add support for extension GL_ARB_shader_bit_encoding (#2183) Created with: gclient setdep -r src/third_party/glslang/src@9f46e3dd5e11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I00b0098ecaa0215beac97f1190bc01faa645c855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154552Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This is only a refactor and should not affect any existing Chrome behaviour. Change-Id: Iedceb619607d9ee63e3e6de66a7afe8934274494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148839Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760027}
-
Aaron Leventhal authored
Bug: None Change-Id: I509b0b94c2ceadce9de74d644096be4f3a1c8e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152408Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760026}
-
Jan Krcal authored
This CL removes any code in favicon_cache that related to favicon sync or that is not needed by the only remaining purpose of the class. This CL does not change behavior w.r.t. the remaining public API. Removing the class completely is left for follow-ups. Bug: 978775 Change-Id: Ibb69eb0258a78f056d762bf01b27a94b638a04d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144137 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760025}
-
Andrei Salavei authored
On secondary account sign-in, notify ARC that particular error is persistent and there is no reason to retry the sign-in request. Currently persistent errors are when user token become invalid or when requested account is missing in Chrome OS. Bug: b/146792085 Change-Id: I09addfb53968d83782390a7977c22ea1ba6b01d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108723 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760024}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f980265. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 2780c65f "[css-filters] Move effect-reference-turbulence-invalid.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I2adaf2c2ee2b880cb0dd33f251ce1b6682e3e207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153729Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760023}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib4be273ea7e3700445700765ad136b17bc3bec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154550Reviewed-by:
-
Julie Jeongeun Kim authored
This CL migrates grid-element-shrink-to-fit.html to external/wpt/css/css-grid/grid-model, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-size-shrink-to-fit-001.html. Bug: 1063749 Change-Id: Ie09d20498f7add1792cdcfc7342778c53b99662a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154431 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#760021}
-
Julie Jeongeun Kim authored
This CL migrates grid-element-min-max-height.html to external/wpt/css/css-grid/grid-model, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-min-max-height-001.html. Bug: 1063749 Change-Id: I883f37b92e69daf841f47eb3d93983c5c1ad7a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154363 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Boris Sazonov authored
This reverts commit 4eee5285. Reason for revert: base_unittests failures (https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25027). Original change's description: > Reland "[Clank SSM]: Implement NativeUnwinderAndroid." > > This is a reland of 38e3a62a > > Reason for revert: Official build failure crbug/1071307 > Fix: Compile NativeUnwinderAndroid + tests only on arm/arm64 > > Original change's description: > > [Clank SSM]: Implement NativeUnwinderAndroid. > > > > This CL implements NativeUnwinderAndroid & tests for android > > unwinding support. It also enables StackSamplingProfilerTest > > on Android. > > > > A new target source_set is added, native_unwinder_android > > that contains NativeUnwinderAndroid. > > StackSamplingProfilerTest depends on it for android. > > > > Bug: 989102 > > Change-Id: Ie38fd99ca5fb053e1881d0977924b70a6fbc1e9b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#759283} > > Bug: 989102, 1071307 > Change-Id: I03345dc46b205f3c1b211ffa9aeb6d51fdacaacf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151727 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759777} TBR=gab@chromium.org,thakis@chromium.org,wittman@chromium.org,etiennep@chromium.org Bug: 989102, 1071768 Change-Id: I90411b354f4f357de7a1dffcd194051eac2eb820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154186Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#760019}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4479a822c03f..29cf2b0cbb75 git log 4479a822c03f..29cf2b0cbb75 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 mbonadei@webrtc.org Fix link to prerequisite SW for Android development. Created with: gclient setdep -r src/third_party/webrtc@29cf2b0cbb75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifedb7e35860a321f281f34912c7edada00d2bb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154548Reviewed-by:
-
Matt Falkenhagen authored
This adds a histogram to the renderer similar to the browser one added in r758112. Testing locally there is up to ~1 second of delay because of main thread contention (JavaScript, layout, etc). Getting real-world data may be useful. Bug: 1017710 Change-Id: Ice19fd232ef99385f64f4ef4c1eb383ccfd8ac4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145387Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#760017}
-
Roman Sorokin authored
Stop honor the policy on the lock screen. Also tweaked LoginScreen*Policy tests a bit Fixed: 1071012 Bug: 1067260, 1071010, 1071779 Change-Id: Icaa5fd108b66dbe22fde738f000b3eff49236347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149357 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#760016}
-
David Roger authored
The cause of the flake is not known but it may be the combination of BrowserWithTestWindowTest and MOCK_TIME. Some tests in that suite need BrowserWithTestWindowTest, and one test needs MOCK_TIME. There is no test that needs both. This CL splits the tests in two groups: - tests that need BrowserWithTestWindowTest. They are now no longer using MOCK_TIME - test that needs MOCK_TIME, now no longer using BrowserWithTestWindowTest. Fixed: 1014790 Change-Id: I2ee2cce2b38f21c00de3d841913c7307b17b2a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151590Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#760015}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71edd921..a12377e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I325c3e119828bd08ed208b2739e83619852e529d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154451Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760014}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: I772e4c3651a35e0d47e945418aeb408250e50fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152450Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#760013}
-
Mario Sanchez Prada authored
This should have been added to wpt/css/css-grid/alignment already, but we missed that during review, so relocating it now. Bug: 767015, 1063749 Change-Id: Ie3219f191764db93915a8a3b76ccff5137366cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153113Reviewed-by:
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates the deprecated function at download classes. This CL also updates |DownloadManagerCoordinator#create| function by adding |isIncognito| param to pass the correct profile type (i.e., regular or incognito). Bug: 1041781 Change-Id: I8ecae53f09396067dbeaa1b89bd0a0c0840a9ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148749 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#760011}
-
Nazerke authored
InfobarManagerAppInterface and PerfTestWithBVC. This Cl removes unused properties for TabModel in PerfTestWithBVC and removes the use of TabModel for getting the WebStateList in CWTWebDriverAppInterface and InfobarManagerAppInterface and uses a browser instead. Bug: 1045575, 1050138, 1050135 Change-Id: I1d8d5b5e54c1ad636d14e80726dbc12067d17642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149646Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#760010}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8d981721371..e68c05a72371 git log d8d981721371..e68c05a72371 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 skyostil@chromium.org telemetry: Capture logs when symbolization fails Created with: gclient setdep -r src/third_party/catapult@e68c05a72371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I1f77bd843342bee7f28d81e6a90a24059097848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154546Reviewed-by:
-
Ewann authored
Bug: 1038919 Change-Id: I67d84abf0c78626af7ebc56a4ccffbe3c08c9117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152790Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760008}
-
Rainhard Findling authored
* Allows reusing time-based logic for when safety check ran (e.g. string construction) to be reused across platforms. Bug: 1015841 Change-Id: I6db5be39619d510f1a6c95d16767275146477c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144090 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760007}
-
Julian Pastarmov authored
This reverts commit a2086c05. Reason for revert: There is an issue with this check if the admin has configured maximal number of unsuccessful login attempts. Original change's description: > Reland "Check if user has password in security connect API" > > This is reland for https://chromium-review.googlesource.com/c/chromium/src/+/2039631 > The code is updated to match the latest SecureConnect native host > update. > > Check if user has password in security connect API > In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock > > secured flag now check if user has password on Windows. > > The code behavior matches SecureConnect native host: 291830502 > > Bug: 1047785 > Change-Id: Ib6ce74d4b10b50616057042e0e2c30a2336522d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078674 > Commit-Queue: Owen Min <zmin@chromium.org> > Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745516} TBR=pastarmovj@chromium.org,sacomoto@chromium.org,zmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047785 Change-Id: Ic43c11792fd48119b7aba86ac766038986ebdd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153031Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1071327 Change-Id: I902cf55c0463e05c64f8ec0e90f2aaa826e31ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152810 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#760005}
-
Roman Sorokin authored
Bug: 1068314 Change-Id: I5189e4dd76f6e168d9d17b2bd1bdfceeada68bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138072Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760004}
-
Koji Ishii authored
This patch extracts |NGTextType| from an inner enum of |NGPhysicalTextFragment| to an enum class. This is part of preparations to avoid creating intermediate |NGPhysicalTextFragment| when |NGFragmentItem| is enabled. This patch has no behavior changes. Bug: 982194 Change-Id: Id079dbf8afb6f14c322e92f6f5d58c6c280078df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153464 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760003}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f93cc8bda48d..c090ea78b262 git log f93cc8bda48d..c090ea78b262 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3682237cb326..50eaecd721a2 (1 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src e01f13e1f777..382bf3de06fc (1 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2430d665d3f2..d25ce8725224 (18 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 0d4857ea576a..454ab259c1b8 (1 commits) Created with: gclient setdep -r src/third_party/angle@c090ea78b262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ia03221e56ac1da55d4910c6d2e33af156ba4549d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153681Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/Eheze.....POv5E... Created with: gclient setdep -r src/third_party/aemu-linux-x64@POv5E... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ic5924efa16c248a1c786a2a9e42994c17b780234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153678Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ibd15ce759845f954dea022aa9fca97dfbc89406f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152827 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit ba7954e5. Reason for revert: This probably caused the failure in DevToolsBeforeUnloadTest.TestUndockedDevToolsClose https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8882815412590626512/+/steps/browser_tests_on_Windows-10-15063/0/logs/Deterministic_failure:_DevToolsBeforeUnloadTest.TestUndockedDevToolsClose__status_FAILURE_/0 Original change's description: > bluetooth: add BluetoothAdapter::IsPeripheralRoleSupported() > > It appears that on Windows, Bluetooth hardware does not generally > support the BLE peripheral role (i.e. BLE advertisements). Add a method > to BluetoothAdapter that returns the > BluetoothAdapter.IsPeripheralRoleSupported property [0] on WinRT and > true everywhere else, so that client code can detect these cases. > > [0] > https://docs.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothadapter.isperipheralrolesupported > > Bug: 1069140 > Change-Id: If8f2f448f30db6aaf720c10e00391dea3f65944e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152892 > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759836} TBR=reillyg@chromium.org,martinkr@chromium.org Change-Id: I993fe1e58bf4704977cd07b18cf61aba04f402ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153434Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759999}
-
Alex Rudenko authored
This change adds the accessible name, role and whether an element is focusable using keyboard to the overlay shown when you inspect elements. The attributes show up together with the contrast information at the bottom part of the overlay in a new section called Accessibility. Screenshot: https://i.imgur.com/Ax5nkeX.png Design doc: https://goo.gle/devtools-a11y-popover Fixed: 1040025 Change-Id: I411a79d2fedd04680f2efc0237f6c8272d922893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149356Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I375710146b28f9c023f4a225bf4c556088ed1f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154355Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759997}
-
