GitLab

Attempt to mimic the behavior of animated raster images (BitmapImage)
more closely wrt when the timeline is started and reset/rewound.

BUG=177277

Review URL: https://codereview.chromium.org/206033005

git-svn-id: svn://svn.chromium.org/blink/trunk@169694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the optimization not to create a composited layer for 0x0
plugins. Removing this optimization simplifies the CompositingReasonFinder and
removes a dependency on layout information. We've already removed a similar
optimization for 0x0 iframes.

This CL also removes RenderEmbeddedObject::allowsAcceleratedCompositing. This
function is redundant with RenderPart::requiresAcceleratedCompositing because
RenderPart is a base class of RenderEmbeddedObject.

Review URL: https://codereview.chromium.org/202523008

git-svn-id: svn://svn.chromium.org/blink/trunk@169693 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set the value of span to 1 if the given number is too big or zero.
Merged from WebKit (patch by Zsolt Borbely).
https://bugs.webkit.org/show_bug.cgi?id=129148

R=
BUG=351280

Review URL: https://codereview.chromium.org/194593005

git-svn-id: svn://svn.chromium.org/blink/trunk@169692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are possibilities where removeStyleSheetCandidateNode()
is called without addStyleSheetCandidateNode(). We should prevent this
because StyleEngine assumes that its call is balanced.

This change add a flag to ensure it being balanced.

BUG=353525
R=ojan@chromium.org, eseidel@chromium.org
TEST=style-onload-remove-crash.html

Review URL: https://codereview.chromium.org/203253006

git-svn-id: svn://svn.chromium.org/blink/trunk@169691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/203963005

git-svn-id: svn://svn.chromium.org/blink/trunk@169690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354405

Review URL: https://codereview.chromium.org/206743003

git-svn-id: svn://svn.chromium.org/blink/trunk@169689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove support for deprecated shape types and syntax. These have already been removed from the CSS Shapes specification, so this aligns the implementation with the specification.
    
The "new" tests below were simply moved from the old csswg directory, as they were the only tests there that applied to the current syntax.

Cheery-pick from http://trac.webkit.org/changeset/165472
BUG=354159

Review URL: https://codereview.chromium.org/200633005

git-svn-id: svn://svn.chromium.org/blink/trunk@169688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's more idiomatic to use a vector for a dynamically-sized array; it also 
provides a convenient opportunity to use inline capacity in the common case
where a gradient has a small number of stops.

BUG=

Review URL: https://codereview.chromium.org/201523002

git-svn-id: svn://svn.chromium.org/blink/trunk@169686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL begins to move CompositingReasonFinder to using a virtual function on
RenderObject instead of a nest of "if video, if canvas" branches. This CL only creates
two overrides, one for video and one for canvas. A future CL will create
overrides for plugins and iframes, but there's some cleanup work we need to do first.

Review URL: https://codereview.chromium.org/197533013

git-svn-id: svn://svn.chromium.org/blink/trunk@169685 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates the RenderLayer repainter code to be a no-op during
repaint-after-layout. The repainting of updated layers is handled in the
repaintTree method, the same as non-layer RenderObjects.

While making this change we discovered that the outline rect can not be
calculated from the repaint rect. So, we've had to add the old/new outline rects to the RenderObject so we can have the correct values.

BUG=320139
COLLABORATOR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/160903002

git-svn-id: svn://svn.chromium.org/blink/trunk@169684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org
BUG=347169
TEST=fast/frames/iframe-no-name.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304

Review URL: https://codereview.chromium.org/187103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a text query straddles multiple line boxes, only the first would be
considered, because |startPosition| would end up being negative.
Instead clip the character range to [0) (the following functions will
clip against the end position) and only reject ranges that are empty i.e.
that appear before the current fragment (logically.)

BUG=353462

Review URL: https://codereview.chromium.org/206663003

git-svn-id: svn://svn.chromium.org/blink/trunk@169682 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ArrayBuffer::create may return NULL if allocation fails.

BUG=353966

Review URL: https://codereview.chromium.org/206243002

git-svn-id: svn://svn.chromium.org/blink/trunk@169680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes an optimization whereby 0x0 iframes wouldn't get a composited
layer even if they would otherwise have been composited. This optimization was
causing a bunch of awkwardness because it introduced a dependency on layout
information in the CompositingReasonFinder, which caused the reason finder to
need to set a dirty bit in the RenderLayerCompositor.

This CL also prepares us to remove requiresCompositingForFrame into a
RenderPart-specific override of additionalCompositingReasons (after
https://codereview.chromium.org/197533013/ lands).

This CL also changes RenderLayerCompositor::enableCompositingMode to notify
iframes when the root layer is destroyed as well instead of relying upon the
CompositingReasonFinder to write the dirty bit.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/206243003

git-svn-id: svn://svn.chromium.org/blink/trunk@169679 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix the for loop to actually reset the multipliers in
all frames. Currently only main frame is reset inside
the for-loop multiple times.

Review URL: https://codereview.chromium.org/197313003

git-svn-id: svn://svn.chromium.org/blink/trunk@169678 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169659

BUG=273904
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/206713003

git-svn-id: svn://svn.chromium.org/blink/trunk@169677 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Repaint after layout will eventually do a tree walk that
utilizes LayoutState (or more accurately, something *like*
LayoutState) to quickly compute repaint rects while walking
the tree. In the course of building that functionality, I
got mired in the ugliness of LayoutState.

LayoutStateMaintainer is an RAII that is partially broken
due to the need to explicitly call "pop". RenderView would
explicitly create and initialize a LayoutState on the stack
then clear the pointer after layout. This patch fixes the
LayoutStateMaintainer issue (which necessitated some
refactoring in the rendering code) and introduces a
RootLayoutStateScope that takes care of RenderView's case.

BUG=343896

Review URL: https://codereview.chromium.org/196533012

git-svn-id: svn://svn.chromium.org/blink/trunk@169676 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename the IntRectExtent class to IntBoxExtent to match the naming of
the LayoutUnit and floating point versions of the same concept.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/206373006

git-svn-id: svn://svn.chromium.org/blink/trunk@169675 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add new FloatBoxExtent class (to complement existing int and LayoutUnit
versions) and update HarfBuzzShaper to use this class instead of four
separate float values to represent the glyph bounding box.

R=dglazkov@chromium.org
BUG=354165

Review URL: https://codereview.chromium.org/206403004

git-svn-id: svn://svn.chromium.org/blink/trunk@169674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turns out the entry wasn't needed.

BUG=273904
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/199733014

git-svn-id: svn://svn.chromium.org/blink/trunk@169673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In particular, don't do it if the dirty bits are going to be cleaned up during synchronous
Blink execution anyway. To achieve this, this CL adds an m_updatingLayoutAndStyleForPainting state bit
in PageAnimator to indicate that code is in progress which is guaranteed to call
RenderLayerCompositor::updateCompositingLayers() at its end, and therefore any compositing dirty
bits set before that call do not require a call to scheduleAnimation().

Unfortunately, in a small number of cases RenderLayerCompositor::updateCompositingLayers will set
*new* dirty bits when updating direct compositing reasons. So put in code to check each
RenderLayerCompositor instance in the frame tree for dirty bits after
RenderLayerCompositor::updateCompositingLayers has run and call scheduleAnimation() if so. In the
future we can remove this once the compositing code is fixed to not leave around dirty bits.

BUG=340679

Review URL: https://codereview.chromium.org/202533003

git-svn-id: svn://svn.chromium.org/blink/trunk@169672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352300
NOTRY=true

Review URL: https://codereview.chromium.org/199543004

git-svn-id: svn://svn.chromium.org/blink/trunk@169671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the ConsoleBase object into a garbage collected object if Oilpan
is enabled, avoiding its ref forwarding to either Console or WorkerConsole.

R=haraken@chromium.org,ager@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/206093005

git-svn-id: svn://svn.chromium.org/blink/trunk@169670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571
TEST=All layout tests still pass.

Review URL: https://codereview.chromium.org/203213008

git-svn-id: svn://svn.chromium.org/blink/trunk@169669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows the registering page, or pages loaded via the worker,
to send arbitrary messages to the worker script.

BUG=350103
R=abarth@chromium.org, adamk@chromium.org, kinuko@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/185643009

git-svn-id: svn://svn.chromium.org/blink/trunk@169668 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/206253005

git-svn-id: svn://svn.chromium.org/blink/trunk@169667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AffineTransform.inverse() unexpectedly returned an identity matrix when
the matrix was not invertible. This caused invalid rendering for e.g
scale(0) matrices in svg.

BUG=352603

Review URL: https://codereview.chromium.org/200053005

git-svn-id: svn://svn.chromium.org/blink/trunk@169666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When URL of an iframe changes from "unset" to "set", we don't want to
create new history entry. This worked for URLs without fragment
identifier but failed with it present.

This change takes the idea from the old code, before it was rewritten
in https://codereview.chromium.org/126453005

BUG=353096

Review URL: https://codereview.chromium.org/201773002

git-svn-id: svn://svn.chromium.org/blink/trunk@169665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As of chromium r254438 this method is never called.

[1] https://src.chromium.org/viewvc/chrome?view=rev&revision=254438

Review URL: https://codereview.chromium.org/205733003

git-svn-id: svn://svn.chromium.org/blink/trunk@169664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in anticipation of adding support for attributes.

BUG=352300,335247

Review URL: https://codereview.chromium.org/204873003

git-svn-id: svn://svn.chromium.org/blink/trunk@169663 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: fix navigation to Elements panel via context menu.

BUG=

Review URL: https://codereview.chromium.org/206123005

git-svn-id: svn://svn.chromium.org/blink/trunk@169662 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. (https://codereview.chromium.org/195953003/)

Reason for revert:
Breaking tests.

Original issue's description:
> Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types.
> 
> R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
> BUG=341815
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169652

TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341815

Review URL: https://codereview.chromium.org/205033007

git-svn-id: svn://svn.chromium.org/blink/trunk@169661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no need to manipulate the sorted state externally, we can
efficiently detect sorted color stops on the fly. This may also avoid
a sort pass in some cases.

R=pdr@chromium.org,schenney@chromium.org,rob.buis@samsung.com

Review URL: https://codereview.chromium.org/206493002

git-svn-id: svn://svn.chromium.org/blink/trunk@169660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes the outline a first class visual effect instead
of being applied manually in the code. This removes the crazy fudge
factor logic that would grow *ANY* repaint rectangle by the maximal
outline on the page.

All test changes are progressions apart from 2 multi-column tests
regressing due to http://crbug.com/348064:
- fast/forms/range/slider-in-multi-column.html
- fast/forms/number/number-spinbutton-in-multi-column.html
A fix is in progress for the underlying issue that will make them
pass again (thanks to Morten Stenshome).

BUG=273904

Review URL: https://codereview.chromium.org/176953008

git-svn-id: svn://svn.chromium.org/blink/trunk@169659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During RenderInline::splitFlow(), floats are cleared on an anonymous containingBlock() for
the inline being split. This is a problem if siblings of the block contain references to
the same floats, since the float removal code in markSiblingsWithFloatsForLayout() will not
later find them.

R=inferno@chromium.org
BUG=245727

Review URL: https://codereview.chromium.org/203483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method is a noop as we first collect names of shortcut edges and then iterate through all non-shortcuts whose names are also in the collection.

BUG=None

Review URL: https://codereview.chromium.org/204913005

git-svn-id: svn://svn.chromium.org/blink/trunk@169657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the partial layout code was removed this changed the conditional
for triggering repaintTree from m_doFullRepaint || !partialLayout.isStopping()
to just m_doFullRepaint. This caused repaint to not happen in a lot of cases
because, typically, !paritalLayout.isStopping() was true and would trigger
repaintTree. I don't think we need the check at all and should be
unconditionally triggering repaintTree and using the information from layout to
determine what repaints.

BUG=283623,320139

Review URL: https://codereview.chromium.org/206413003

git-svn-id: svn://svn.chromium.org/blink/trunk@169656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't actually need to rewind iterators. The iterators should be one-pass only and rewind just complicates the code.

BUG=None

Review URL: https://codereview.chromium.org/206393004

git-svn-id: svn://svn.chromium.org/blink/trunk@169654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This extracts everything related to our tabbed editor from the sources panel to the separate SourcesEditor class.
This class could be later refactored into the view that could be embedded in other places (e.g. Drawer).

R=pfeldman, lushnikov

Review URL: https://codereview.chromium.org/206063003

git-svn-id: svn://svn.chromium.org/blink/trunk@169653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/195953003

git-svn-id: svn://svn.chromium.org/blink/trunk@169652 bbb929c8-8fbe-4397-9dbb-9b2b20218538