- 24 Jul, 2018 40 commits
-
-
tzik authored
ViewEventTestBase has no-op AddRef and Release for a historical reason, but they are no longer needed for years. Bug: 866456 Change-Id: Iea74ee9c87667f033fc90d47f2d331a202ab61d8 Reviewed-on: https://chromium-review.googlesource.com/1146538Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577400}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5bc35fd6c631..5389d34c833d git log 5bc35fd6c631..5389d34c833d --date=short --no-merges --format='%ad %ae %s' 2018-07-23 moragues@google.com config: Fix Build Break on firmware tryjobs on master branch Created with: gclient setdep -r src/third_party/chromite@5389d34c833d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4009ea047f37c083088e46a2a601e8477679d256 Reviewed-on: https://chromium-review.googlesource.com/1147071Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577399}
-
Amy Qiu authored
Update recordings for pages in simple_mobile_sites for rendering.mobile. Change the flickr url to an album to bypass the initial login screen (doesn't allow scrolling). Bug: 852530 Change-Id: I2bd71f512492cb306c47fea0f9bd857fae953338 Reviewed-on: https://chromium-review.googlesource.com/1146499Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#577398}
-
Erik Luo authored
Part 2: live updating pins - same JSAutocomplete, `await` processing, previews as ConsolePrompt - 250ms interval to update pins - prevent side-effects while editing text (editor has focus) Screenshot: https://imgur.com/a/zaPlRTC Bug: 849875 Change-Id: I0cd18101e58a6ff4e71e674633409ca0e015e1e7 Reviewed-on: https://chromium-review.googlesource.com/1096417 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577397}
-
Fritz Koenig authored
GL_FRAMEBUFFER_FLIP_Y_MESA will tell OpenGL to render the image upside down. Passing the buffer along like this will allow ChromeOS to scan out directly from the buffer. BUG=680851 Change-Id: I142cec041358af17652f7314ac89e82678b78d3b Reviewed-on: https://chromium-review.googlesource.com/1117365Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577396}
-
Clark DuVall authored
This test was modifying Set-Cookie and removing User-Agent, which is no longer supported with the network service (see crbug.com/827582). Bug: 827582, 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I977bcc767188eafb76c6d560bb959871ed73808a Reviewed-on: https://chromium-review.googlesource.com/1145941Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577395}
-
Joel Einbinder authored
This adds syntax highlighting, autocomplete, argument hints, and smart enter to the breakpoint editor Change-Id: I973be5e44ff94f36fbefdeb1eb472122ee2789a9 Reviewed-on: https://chromium-review.googlesource.com/1144195Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577394}
-
Tetsui Ohkubo authored
This CL makes following changes: * Increase the font size of a detailed view header. * Use medium style for Sign Out and Clear All buttons. * Replace help icons used for a11y detailed view header. TEST=manual BUG=863618,858947 Change-Id: I05f831247c19ceda004acb9c1103b1716503f254 Reviewed-on: https://chromium-review.googlesource.com/1141671Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#577393}
-
Scott Haseley authored
Bug: 822954 Change-Id: I8668f4003bff3fa47e1b542884f81cf1e13bffad Reviewed-on: https://chromium-review.googlesource.com/1147505Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#577392}
-
Peter Kasting authored
I've done enough work on them over time that I think I'm capable of reviewing changes here. Bug: none Change-Id: Ia3ed68a601b2a7c55ad4cd5918c18ed5f83700a0 Reviewed-on: https://chromium-review.googlesource.com/1147663Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577391}
-
Khushal authored
R=ericrk@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6871e01e0e531a13682c69ddde78de19db665d8b Reviewed-on: https://chromium-review.googlesource.com/1144603Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577390}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I38dbc355743a6bb8f2f04fb31f51b92ab3377bff Reviewed-on: https://chromium-review.googlesource.com/1146489Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#577389}
-
Xida Chen authored
The feature PaintTouchActionRects could introduce different behavior than today's code of computing the touch action rects. In order to prevent regression, this CL creates a new test suite for the tests under fast/events/touch/. The virtual suite run those tests with --enable-blink-features=PaintTouchActionRects. Bug: 853912 Change-Id: Ia07e93892e88dfb9e6c2ea078784da3985ef26a4 Reviewed-on: https://chromium-review.googlesource.com/1146764 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577388}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7b61abe..f0bf9a40 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7e97a0961ba28c3c69ea9fb051e32023f78577d Reviewed-on: https://chromium-review.googlesource.com/1146776Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577387}
-
Leo Zhang authored
Add more logic and make the service testing really works. Tested locally by enabling build flags (enable_cros_ime_service and enable_cros_ime_decoder), then pass the testings chromeos/services:chromeos_services_unittests Bug: 837156 Change-Id: I05f557f808c210e788630ce4749b5c261ed19b44 Reviewed-on: https://chromium-review.googlesource.com/1146537 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#577386}
-
Emil A Eklund authored
Fix border, background, and mask painting for inline blocks spanning two or more lines or that are otherwise fragmented across multiple entities. This involved refactoring the existing inline box painting code to allow code sharing between legacy and LayoutNG painting code. It also required changing LayoutNG painting to further distinguish between inline and non inline boxes as the background image painting code in particular require taking the other fragments for a fragmented object into account when the image offsets and clipping is computed. Finally, this cleans up the flow box paint logic for both legacy and NG. This reverts r561186 (01dda95e) which in turn was a revert of the original patch (r558871) which was reverted due to a performance regression in blink_perf.paint color-changes benchmark. To avoid the regression this patch moves construction of the box painter from the inline box painter constructor to the paint methods where it is needed, thereby avoiding the construction overhead in cases where cached drawings may be reused. It also limits the lifecycle of the box painter. Bug: 714962, 844624 Test: fast/backgrounds/border-radius-split-background-image.html Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87ae744fdd204133e40b50721eca6947c81da817 Reviewed-on: https://chromium-review.googlesource.com/1144216 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577385}
-
Justin Cohen authored
TBR: sczs@chromium.org Bug: 866730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70 Reviewed-on: https://chromium-review.googlesource.com/1147701Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577384}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2bfa78540c37..1116ef0b1c45 git log 2bfa78540c37..1116ef0b1c45 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 tsepez@chromium.org Remove unused CFXJSE_Arguments::GetObject() 2018-07-23 tsepez@chromium.org Remove argument from CFXJSE_Value::ToHostObject() Created with: gclient setdep -r src/third_party/pdfium@1116ef0b1c45 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I01e1215ef5cfdc9d6b7b6a8f84232156c6e6f573 Reviewed-on: https://chromium-review.googlesource.com/1147069Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577383}
-
Victor Costan authored
This CL: * Adds SQLITE_OMIT_COMPLETE, removing command auto-completion logic * Adds SQLITE_HAVE_ISNAN, removing SQLite's custom implementation * Removes -ldl, which was only needed for runtime extension loading Change-Id: I065c2faba028379e336b2d691afad7093328d7c3 Reviewed-on: https://chromium-review.googlesource.com/1146290 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577382}
-
Fady Samuel authored
We close fallback surfaces in order to speed up the arrival of the primary surface from a child client. That logic was complex and difficult to follow. Now with SurfaceRanges, that logic can be simplified somewhat. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ied2efb4eac61f297fe6784825084f0a88e716dab Reviewed-on: https://chromium-review.googlesource.com/1147114 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#577381}
-
Sam McNally authored
As of https://crrev.com/170137, component extensions/apps are installed when their version changes, performing all the usual extension-install work, including registering the extension with ExtensionPrefValueMap. When a component extension is loaded without a version change, much of this is skipped, leading to ExtensionPrefValueMap::CanExtensionControlPref() hitting a NOTREACHED(). Fix this by including component extensions when initializing extension-controlled prefs, which includes registering the extension with ExtensionPrefValueMap. Bug: 454513 Change-Id: Ic478e5ac5367e3bb22cebd6e9422e9ca5bd48849 Reviewed-on: https://chromium-review.googlesource.com/897223Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577380}
-
Xiaocheng Hu authored
This patch moves the definition of NGOffsetMappingBuilder::SourceNodeScope to the beginning of NGOffsetMappingBuilder before all member functions for better coding style. Bug: 699017 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If0a6d9ea5fad9194a5a3148f4724a45861964d6c Reviewed-on: https://chromium-review.googlesource.com/1147547 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#577379}
-
Tetsui Ohkubo authored
According to UX mock, audio settings button shown on the right of volume slider is wide and has both headset icon and expand icon. Screenshot: http://screen/ei2trCkJcSA UX mock: http://shortn/_EMpEzaBIUx TEST=manual BUG=860600 Change-Id: I477243e757632881dc6ac9043838ebcfafcb69b4 Reviewed-on: https://chromium-review.googlesource.com/1141678Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#577378}
-
tzik authored
While DOMStorageNamespace::Clone constructs an instance, it binds it to a callback, post it to a task runner and returns the instance as a raw pointer. Note that base::BindOnce here retains a reference to |clone| and releases the reference when the callback instance is destroyed. However, if PostTaskAndReply there failed, the callback instance is destroyed immediately and DOMStorageNamespace loses the last reference. Then, DOMStorageNamespace::Clone may return a stale pointer. This CL converts the return value to scoped_refptr, and has Clone() to keep the reference to the resulting instance. Bug: 866456 Change-Id: Ic3a5a02e266bf55f8ad3c4f901eb1eebc2ea9d8e Reviewed-on: https://chromium-review.googlesource.com/1146409Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577377}
-
Ryan Hamilton authored
Change-Id: I74954583abe08aaf4e8211946d1ae96f0c593b12 Reviewed-on: https://chromium-review.googlesource.com/1131832 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577376}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1381813c377d..6a1002b4d937 git log 1381813c377d..6a1002b4d937 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 simonhatch@chromium.org Dashboard - Add nexus 5x to list of supported for Pinpoint 2018-07-23 dtu@chromium.org [pinpoint] Add "Android Go" bot to Pinpoint. 2018-07-23 benjhayden@chromium.org Upgrade PageStates for V2SPA. Created with: gclient setdep -r src/third_party/catapult@6a1002b4d937 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863995,chromium:866251 TBR=sullivan@chromium.org Change-Id: I90c1447744e601493ac2c8d2d8258975268d05e9 Reviewed-on: https://chromium-review.googlesource.com/1147068Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577375}
-
Tim Dresser authored
We no longer test non-webview Nexus 6. Bug: 736497 Change-Id: I22942bb8a57c63e3b295f6f71df570c3a3fc014d Reviewed-on: https://chromium-review.googlesource.com/1143584 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577374}
-
Tommy Martino authored
Currently, we don't draw the background on the separator. This is fine on Win and Mac, because by default we just see white anyway. But on Linux (specifically GTK+) we draw gray by default, giving an ugly gray splotch. Change-Id: I6f6d61d7ade28d30a659858a9a83bf0506aa3637 Bug: 866637 Reviewed-on: https://chromium-review.googlesource.com/1147158Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577373}
-
Erik Chen authored
This class will eventually be responsible for forwarding task and event metadata to the Calculator. This class spans the UI and IO threads, so the threading is tricky. This CL sets up the structure of the class, including all the of threading details, and reentrancy handling. Future CLs will hook up tasks and events. Bug: 859155 Change-Id: I7e8706e82dd07ae54ae9b150a6db7a8113ffdc9b Reviewed-on: https://chromium-review.googlesource.com/1144226Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577372}
-
Wei-Yin Chen (陳威尹) authored
This depends on crrev.com/c/1142484 for non-ARM build. Bug: 338784 Change-Id: If825ffbbf5df78063787bbb97c5e7d3599efdccb Reviewed-on: https://chromium-review.googlesource.com/1139894 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577371}
-
Scott Violet authored
This removes ScreenProvider, WindowManagerClient and most of the WindowManager interface as they are not needed. Additionally this cleans up a couple of functions in WindowTree. Doing this showed a couple of test failures in aura. I'm making them early out for now and will investigate after this. The failures are because previously even though mus was configured some tests created WindowTreeHostPlatform, when I changed that to WindowTreeHostMus the tests started failing. BUG=865689,842365 TEST=none Change-Id: Id5a67d7f513b2015a46a75745593ba122d17f6df Reviewed-on: https://chromium-review.googlesource.com/1146336Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577370}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c4668d00232..b8eeb808d84f git log 1c4668d00232..b8eeb808d84f --date=short --no-merges --format='%ad %ae %s' 2018-07-23 timliang@google.com added integration for non-moltenvk use of SkSLC MSL generator Created with: gclient setdep -r src/third_party/skia@b8eeb808d84f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I5ae3ff1b55afb2d082e2bd087bf484854dd27440 Reviewed-on: https://chromium-review.googlesource.com/1147067Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577369}
-
junweifu authored
The native request first locates all barcodes in the input image, then analyzes each to decode payload. The bounding box of the detected barcode are normalized to the dimensions of the processed image, so the coordinates need to be converted. Forward declaring the necessary symbols in sdk_forward_declarations.h. BUG=848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: I03b966a1886feaf64a87e778396ad96e3d16b85e Reviewed-on: https://chromium-review.googlesource.com/1142831Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#577368}
-
Devlin Cronin authored
Create a custom element for the runtime host permissions controls in the chrome://extensions page, rather than having them defined in the DetailView element. This will make it easier to test and expand the controls. Pull the controls into runtime_host_permissions.[js|html], and extract the tests from extension_detail_view_test.js to extension_runtime_host_permisisons_test.js. Also add an additional test to verify the runtime host permissions dialog is shown when the 'add' button is clicked. There should be no visible UI changes as a result of this CL. Bug: 844128 Change-Id: I741adc921af95253087dbf31be1800c01fb4185c Reviewed-on: https://chromium-review.googlesource.com/1146999Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577367}
-
Andrey Kosyakov authored
We previously reported redirect responses when the "Request" interception stage was enabled. Since they technically are responses, we will now report them only when the "HeadersReceived" stage is enabled. Change-Id: I5318f8b4167b662d11852b8d93bff4b9db960c8d Reviewed-on: https://chromium-review.googlesource.com/1147507Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#577366}
-
Min Chen authored
- Make fullscreened window can be dragged from the top of the display. - Keep shelf visible if a window is being dragged from the top of the display. - Fling the window from the top exceed the velocity threshold should drop the window into overview mode. - Update the window transform during drag. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiSnFza0t3bEluUnJ0VVBhUzFiSnNwN0k4eFpv/view?usp=sharing Bug: 847587 Change-Id: I7f9a423f511c65c083fe11a6deb5847afa4c9a35 Reviewed-on: https://chromium-review.googlesource.com/1134575Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577365}
-
Eric Karl authored
Currently, we never check for deleted entries until the client tries to lock an entry. In some cases (transfer cache), the client may never delete or re-lock an entry after creating it, relying on the service side to purge it. In these cases the client should eventually pick up these deletions allowing handles to be re-used. To handle this, we check for deleted entries any time we are about to allocate a new buffer. R=khushalsagar Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib4edbf7e339f213cff7a7df85771ecfeb5113936 Reviewed-on: https://chromium-review.googlesource.com/1147495 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577364}
-
Takumi Fujimoto authored
Replace help center URLs with p-links. There is no change in the actual destination pages. Bug: 852139 Change-Id: I85176c6c2076d331ae58e10f7150ccf9c42da03e Reviewed-on: https://chromium-review.googlesource.com/1147216Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#577363}
-
Eric Orth authored
This reverts commit e5a94e05. Original commit fac52799. Patchset 1 is a clean revert of the revert. Fixes in subsequent patchsets. Only change is fixing some work that was done inside a DCHECK in the tests. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic1649dc90711c23c33255cc5f1ed9d902eb29f07 Reviewed-on: https://chromium-review.googlesource.com/1147140Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#577362}
-
Kyle Horimoto authored
Previously, a log was only printed when the call to set/remove the host failed, but it was hard to tell if/when the call actually succeeded. This CL adds a log for this case. Bug: 824568 Change-Id: I1328460f141faea4f69bb11243403c04d02c86fd Reviewed-on: https://chromium-review.googlesource.com/1145832Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577361}
-