- 21 Apr, 2020 40 commits
-
-
Andrew Grieve authored
The package is not available by default on some Googler machines, and it was easy to remove. The only client was //media/tools/constrained_network_server/cns.py, which will now get cherrypy via vpython Bug: None Change-Id: If5dc02601691b68c0b6161cbf904837766a3e9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159406 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#761055}
-
Robbie McElrath authored
This CL splits SiteSettingsClient.launchHelpAndFeedbackActivity into launchSettingsHelpAndFeedbackActivity and launchProtectedContentHelpAndFeedbackActivity methods. The method originally took a "helpContext" string, which mapped to one of Chrome's constants defined in //chrome/android/java/res/values/values.xml, which were used to determine which Chrome help page to launch. These constants are specific to Chrome, and shouldn't be part of a //components API. Splitting the method into two allows the embedder to choose which help page to show the user. Bug: 1058595 Change-Id: I193dd6c0767fe53223afaa952f311d0fa045c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158408Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#761054}
-
ckitagawa authored
This CL adds support for plumbing a maximum capture size restriction to the PaintPreviewRecorde returning the size of the output. For now, TabbedPaintPreviewPlayer will use this to cap per SkPicture capture size to 5 MB. In a follow up the returned size information will be used to restrict the total capture size rather than the size per renderer. Bug: 1071446 Change-Id: Ib809d3156c11e6a8ee6144663794fe261f89f635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152957Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#761053}
-
Akihiro Ota authored
Bug: N/A Change-Id: Idc2bd9e15811692ba976c60a35c65e248a7aa8ca Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157775 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#761052}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Also, make WebAssociatedUrlLoaderImpl per-ExecutionContext, since it's an ExecutionContextLifecycleObserver. Change-Id: I325505bb3e97524636e76a21c6998f92afb3482f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107611Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#761051}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 42 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-18. TBR=bcwhite@chromium.org Change-Id: If1fecdced75154299051b8a4a4243980b578a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157054Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#761050}
-
Hua, Chunbo authored
This is a reland of 2f702ab1 kMediaFoundationAsyncH264Encoding flag is added as switch of the MFTEnumEx usage for asynchronous H.264 hardware MFT encoder. Also a new workaround item of GPU driver bug is added due to a known Nvidia GPU crash. In future, the hierarchy of hardware-accelerated video encoders on Windows is AsyncMFT>LegacyMFT>OpenH264. Original change's description: > Enable H.264 hardware MFT encoder on Windows > > Currently Microsoft H.264 encoder MFT is always used as WebRTC external > encoder without hardware acceleration. This change enables H.264 > hardware MFT encoder on Windows. > > Bug: 982799 > Change-Id: Ia33812508034daa99dd3dc1fb64b83cb1d7c8465 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777521 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745539} Bug: 982799 Change-Id: I54594322ded6b7434a8fe4d1b59f487b319b51e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124213 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#761049}
-
Alex Chau authored
- Clarified sender_guid requirement in SharingMessage Bug: 1044607 Change-Id: I5beb2a923041fdb6c39182a7ecb329e4c5c3872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153435Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#761048}
-
Reilly Grant authored
This change is preparing for a refactor of the BluetoothAdapterFactory internals. Those changes will move the factory state out of globals and into the singleton instance of BluetoothAdapterFactory. As a result it is easier to make methods like GetAdapter() non-static but this requires updating all callers. The return value of BluetoothAdapterFactory::Get() is changed from a reference to a pointer because the style guide recommends pointers for non-constant values. Bug: 1030549 Change-Id: Ie6da74fa5d17c586cbbd306f5a1e444b9d39260e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155465 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#761047}
-
Jarryd authored
Updates to the all sites page that were a part of the storage pressure UI project had unintentionally increased the height of origin line items to by using the "two-line" class. This change reverts the height by removing the specified class. Bug: 1071335 Change-Id: I1527c783ff53db5ea6874caafeaaaeaa18857217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157675Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#761046}
-
Dominique Fauteux-Chapleau authored
The previous implementation would result in the entire extension being used, so atypical ones like "foo.csv.gz" would check if ".csv.gz" had a corresponding mimetype instead of just checking ".gz". Bug: 1069347 Change-Id: Ieefb8f4726d4a268e3bc312592a1c53060007210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158973Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761045}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ib8c0c21b0f4f9b10d69c394366021f4d156cf678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108798 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#761044}
-
Sahir Vellani authored
This is a reland of 8e795d5b The previous CL was reverted because FlingControllerWithPhysicsBasedFlingTest in fling_controller_unittest.cc was flaky. It was found that occasionally a GestureScrollEnd would be incorrectly processed when a GestureScrollUpdate was expected. This CL addresses the issue by adding a check for a GSE in relevant areas of the test. Original change's description: > FlingBoost with experimental fling animation curve > > Currently, if physics based fling curve is enabled, even if the fling is > boosted, the scroll distance is capped by upper bound which is three > times the size of viewport. Thus it nullify the effect of fling boosting > and travels the same distance as it would if fling is not boosted. > > This CL fixes fling boosting with physics based fling curve. It does > so by increasing the upper bound every time a fling is boosted. > > Bug: 647137 > Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758878} Bug: 647137 Change-Id: Ief4dfc3068018ce5fecf168b7c191db5544b90d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151054 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761043}
-
Wez authored
Bug: fuchsia:49001 Change-Id: Ib2697acea8da7e0123cee2d5c9d9d21eb427da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145884 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761042}
-
Jeroen Dhollander authored
Previously this was all done in the |AssistantManagerServiceImpl|, but that class is already huge. To solve this I made the following changes: * split it out in a separate |AssistantDeviceSettingsDelegate| class. * Introduce helper |Setting| classes, 1 for each supported setting. * Add unittests for each of the supported settings. Bug: N/A Change-Id: Ia32aecb15e3200a183c72ad8e5bcfcd3b2b4dfbc Tests: new |chromeos_unittests| with filter |AssistantDeviceSettingsDelegateTest.*| Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147693 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761041}
-
Mike Wasserman authored
Use placeholder ordinal ids for now (0, 1, 2, ...); update tests. TODO: generate per-origin UUIDs that reset when cookies are deleted Test Screen.id values returned via window.getScreens() with: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Try https://michaelwasserman.github.io/window-placement-demo Bug: 994889 Test: Automated, Screen.id placeholder values Change-Id: I0c5b18b92fef251211822f3473ea85472a7ee945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155113Reviewed-by:
-
Haiyang Pan authored
Android devices with full-disk encryption will be encrypted on first boot, and then get decrypted to continue the boot process. Wait for this step to complete otherwise the avd may have "Encryption Unsuccessful" error. Also add debug tag "init" for avd create to print more debug message Need crrev.com/c/2153811 to land first Bug: 922145, 1057811 Change-Id: I2037d8f6a7f8edfa83e276e7ef94b93bebbb83ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150398 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761039}
-
Daniele Castagna authored
crrev.com/c/2069137 added support for visible_rect. Unfortunately it incorrectly computed the UV translation. It had two issues: - It was using right() and bottom() instead of width() and height() when scaling the UV translation part. - It was not scaling the translation part for the input UV. This produced incorrect UVs when a rect was not in the origin and/or the input UV were scaled. This patch fixes the computation using cc::MathUtil::ScaleRectProportional instead. in viz_unittests. Bug: 1059408, 1057953 Test: TextureDrawQuadTranslatedAndVisibleRectInsetTopLeftAndCustomUV Change-Id: Id852f3c43167364a001f33de07892905c7d3b768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149637 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761038}
-
Deepti Gandluri authored
Extending flag expiration milestones for WebAssembly features that are still in use by a year. Status of features gated by flags: * code caching - Enabled by default, okay to expire. * baseline/tiering - Ongoing finch trial * lazy compilation - Lazy compilation is still experimental * threads - Enabled by default in chrome, waiting on other browsers for complete implementations, so still useful for testing * simd - Still experimental, used for prototyping and gathering performance data. Change-Id: I51ae98b3dd784b1d619cebf15f81252c697f62a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158037Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#761037}
-
Xing Liu authored
CacheStrategy enum is defined in cached_image_metadata.proto, this should not be used beyond ImageMetadataStoreLevelDB. This CL adds a cpp enum that maps to CacheStrategy protobuf enum. Bug: 1067049,1058534 Change-Id: If13ac706e3c1f0a8cd2376ce1d7e5d26c5b571c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158064Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761036}
-
Dave Tapuska authored
The header file is included in various spots in blink and pulls in more than it should. Change-Id: Icabd4a00d7a19daf2c78cec032ff9742b7d6f43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156606Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#761035}
-
Anders Hartvoll Ruud authored
CSS declarations that are !important have higher priority in the cascade than animation effects. Unfortunately the information about which declarations were and weren't important is lost once the StyleCascade disappears. Specifically, it's not stored on the ComputedStyle. This causes a problem (once again) for the base computed style optimization, since we can't naively add animation effects on top of the base anymore. We might be overwriting something in the base that was important. The previous attempt at fixing this (flag on ElementAnimations) doesn't work properly. For example, it fails to detect the case where an animation initially doesn't conflict with important declarations, but then suddenly does via setKeyframes. To solve this, this CL stores a bitset containing information about important declarations alongside the base ComputedStyle on ElementAnimations. When we're considering whether the base can be used or not, we then check if there's any animation matching the set of important declarations. Persisting that many bits is slightly uncomfortable, but the only viable alternative I see is disabling the optimization when *any* important declaration exists in the base, which is probably a worse option. Sidenote: Initially I tried to always use the base, even when there were conflicts with important declarations. The bitset of important declarations is effectively a set of animations to be skipped, so we should still be able to use the base if we just don't apply the properties present in the set. However, it unfortunately didn't work due to visited/unvisited colors being animated together (crbug.com/1062217). Bug: 552085 Change-Id: I39e2879af8a858ce1bd97eaa2ceb6e222591df79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152449 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761034}
-
Katie D authored
UX spec changed after discussion with PM. Also fixes bug causing the bubble to end up in the wrong place when the window shrinks extremely small in height and grows again, by keeping the ratios from being calculated when the bubble is not visible. Bug: 1055150 Change-Id: I6f344e22a44ce57615994508897a79b69c1bae8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157985 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#761033}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/367d64f84c3c1d01381c18c5a239b85eef47633c..78987bb7bb4764ca3a8b08b0a6f7bd14b53c3e4f Bug: none Change-Id: I223ef4fc5e902700b7a046f4a2558a153523a05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158969 Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#761032}
-
dpapad authored
Change Grit's default behavior to gzip compress all such files, unless compress="false" is explicitly specified. In other words, compress="gzip" is now the default behavior, and same as not specifying a |compress| attribute. out/<out_folder>/resources.pak sizes before/after (with optimize_webui=true) Linux: 7.1MB -> 5.9MB, -4.9% CrOS: 21.0MB -> 18.0MB, -14.3% Bug: 1068407 Change-Id: I3fa63a4db6087b2f3502cbb8b76a6ca3b576e7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612333 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#761031}
-
Piotr Pawliczek authored
This is a part of implementation of class Uri. This CL contains implementation of URI parser along with normalization and validation. The file with unit tests was also included. Other CLs: - https://crrev.com/c/2103143 - https://crrev.com/c/2118426 BUG=chromium:821497 TEST=on my workstation Change-Id: Ieb9f3c105d842d4cb2a8f2678d34130e3b94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123640 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#761030}
-
Andrew Shulaev authored
This patch adds support for typed arguments on async events (using Perfetto's Track argument for trace macros), which will enable Bug: 149824486 Change-Id: I2fa599dfa037528bf2c04e3e5ec8cdfaf0eac56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096756 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#761029}
-
Robert Ma authored
Bug: 1073100 Change-Id: I2cddb15ae7e5ed1d76323db11fdbb20f3da6292a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159414 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#761028}
-
haozhe authored
This is a follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/2105754 This patch adds more reference rectangles to sticky ref-tests to catch when the main thread position is different from the sticky position. Bug: 1059272 Change-Id: Ib3101e58a95db134a427b2852bca4c4bd58f805e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137828Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e784d74686e7..d26075f0c381 git log e784d74686e7..d26075f0c381 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 janscheffler@chromium.org Fix Search in Folder regression Created with: gclient setdep -r src/third_party/devtools-frontend/src@d26075f0c381 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc4b6cb0aadd0fd6c186ef4ab41430148c602f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761026}
-
nancy authored
AppServiceAppWindowCrostiniTracker::OnAppLaunchRequested might be called when the window is not visible yet, so there is no shelf item yet in ash::ShelfModel items. model->ItemIndexByAppID(app_id) might return -1. So adding a checking for -1 (index < 0) to avoid system crash. BUG=1072870 Change-Id: I26aa2c2ba4fa7cf73af140792be94632a6953b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157438 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Garrett Beaty authored
This reverts commit 068d6078. Reason for revert: Causes compile to hang for https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder Original change's description: > Structured Headers: Include all public tests > > This imports all of the tests from the public test repository at > https://github.com/httpwg/structured-header-tests, which have been > automatically converted from JSON to C++ unit tests. > > Tests which were already present in structured_headers_unittest.cc > have been removed from that file, to avoid needless redundancy. > > Bug: 1069790 > Change-Id: I05536c36cb66c7dda43aab2f6c5ae77961120a6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146237 > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759015} TBR=iclelland@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069790 Change-Id: I398e00aaa9903872475f8c5cb5f2513f99e38b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159370Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#761024}
-
Yuki Shiino authored
Bug: 1060971 Change-Id: I180e012501bf308c30b9dcae2998160e0eeb4192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159174Reviewed-by:
-
Dan Harrington authored
This should help mmke it clear that you can't pass null for keys_to_remove. Change-Id: I63a86d6253cdd3b0e609942edf306ccd88b47a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148058Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#761022}
-
Andrew Xu authored
One recent CL (https://crrev.com/c/2055982) adds the option to use layer transformation for bounds animation. However, it fails to handle RTL properly. Different from View::SetBounds which handles RTL, View::SetTransform does not do that. This CL mirrors the start bounds and target bounds of transform animation when RTL should be handled. Bug: 1067033 Change-Id: I1c5aceec54e4f167ac2a80d93fc0c156e0afa9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140774 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Mohsen Izadi authored
Currently, the test uses base::TimeTicks::Now() for timings which makes it hard to verify timing expectations. This CL changes the test to use a mock time that can be advanced on demand. This unblocks adding more tests. Bug: 1054009,1057193 Change-Id: I68448ac591d86d26246459cddd64f36d42bd82f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159413Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#761020}
-
Sujie Zhu authored
Add sub-histogram CreditCard.WithServerNickname.SelectionDuration to log suggestion selection duration between the first time suggestion was shown and the first card is selected when any server nickname is available to see whether having a server nickname available helps user reduce the time spent on selecting the card they want. Note that same as the selection rate, we would like to compare selection duration only for the same group of users who have server nicknames, which means for the Control group we will also log selection duration if the user has any masked server cards with a nickname, but we won’t display the nickname in the UI. For Enabled group, we will log and show nickname when nickname is available. Add a timestamp and boolean to credit_card_form_event_logger to record the first suggestion shown timestamp and to ensure the selection duration is only logged once per form. Metrics design (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#heading=h.olagc6jelr42 Bug: 1059087 Change-Id: I0ac4eb8e758d693a8b8240144655d53c7560a259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151832 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#761019}
-
Clark DuVall authored
Now that TabSpecificContentSettings is componentized, it makes sense to share the logic in ContentSettingsManagerImpl. Bug: 1070825 Change-Id: I76cd324119640fd374b1ad2b474a665aa7fade7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157650Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761018}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/062833f38761..b009c0643f55 git log 062833f38761..b009c0643f55 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 apolito@google.com revert git to 2.24.1 Created with: gclient setdep -r src/third_party/depot_tools@b009c0643f55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070694 Tbr: agable@chromium.org Change-Id: I543cd894f357b23eb45979ed0a28e85d75cfaf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159137Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e30b9d80933d..09aea59a8d8b git log e30b9d80933d..09aea59a8d8b --date=short --first-parent --format='%ad %ae %s' 2020-04-21 fmayer@google.com Clarify incident_report_config error. Created with: gclient setdep -r src/third_party/perfetto@09aea59a8d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idb9a996beb3eb21a5ef33338c2cccc1c9bdd0cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159133Reviewed-by:
-
