- 09 Oct, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts mojo::StrongBindingPtr to SelfOwnedReceiverRef for network::mojom::NetLogExporter. Bug: 955171 Change-Id: I2848046e08671405f7c0940da775008e89498e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846616Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704012}
-
Bailey Berro authored
div for the dialog-title slot was mismatched, resulting in a bug where the error would not show. Bug: 1011586 Change-Id: Id35c21c1a5ff6c2c60845cd1f736fe713e301c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848479 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704011}
-
Julie Jeongeun Kim authored
This CL converts PdfToEmfConverterClient, PdfToEmfConverter, and PdfToEmfConverterFactory to new mojo types using PendingRemote, Remote. Receiver, and PendingReceiver. Bug: 955171 Change-Id: I9e76d7b9360856e7f415ec24d408fd9d6a21e227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827276Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704010}
-
Arno Renevier authored
Implement compression for "gzip" and "deflate". That implementation is hidden behing ExperimentalCompressionStream flag. For unit tests, we compress and stream and uncompress it with pako, and we make sure its output is the same as our original data. Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704009}
-
Min Qin authored
This will help us analyze why parallel download failed in some cases. BUG=1011427 Change-Id: Ib8fbe5a69ce1486f5516c21e737b008c8e76a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848368 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704008}
-
Wei Li authored
FullPanel has two child views which takes up 75% and 25% of the total width. This can be done by box layout manager instead of manually override Layout(). This CL refactors it into using a layout manager. BUG=1005568 Change-Id: Iaf01ebc6be64f449f793e60913bb1bf1ddca629f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848473 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704007}
-
Julian Watson authored
Change-Id: I76b792e1191d735788575cbeac646bddeb9e10e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840291 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704006}
-
Gyuyoung Kim authored
This is a reland of 5ccc40c0 Original change's description: > Reland "Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5" > > This is a reland of 5d024fd7 > > Missed including "ip_address_space.mojom-blink.h" > in worker_module_script_fetcher.cc > > Original change's description: > > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5 > > > > To reduce pre-processed size of header files have been including > > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > > .mojom-blink-forward.h in blink header files. > > > > This CL has no behavior changes and following CLs will > > continue replacing them more. > > > > Bug: 1001360 > > Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#703549} > > Bug: 1001360 > Change-Id: I5279e2fba33e46fa7eb002deeda34421c4176f53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846416 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703592} Bug: 1001360 Change-Id: I78f9572ce9543ca83920a033595b956b98690f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847695Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704005}
-
nancy authored
Currently, the uninstallation dialog head text is inconsistency for the ARC apps and extension apps. ARC apps use Uninstall, and Remove for the shortcut only, because for the shortcut, ARC apps use the extension apps' IDS_EXTENSION_UNINSTALL_PROMPT_HEADING. Per request from the bug, change the head text from Remove to Uninstall, and remove the quotes. Linux apps use Uninstall as well, so I think Uninstall sounds better. BUG=1010303 TBR=rdevlin.cronin@chromium.org Change-Id: I0e939943c37c295ebe2c8a73824c235420a98195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844756Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704004}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffcde0af0c6d..4e7bc8cf04b5 git log ffcde0af0c6d..4e7bc8cf04b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 engeg@google.com cbuildbot: set actual precq timeout to 12 hours Created with: gclient setdep -r src/third_party/chromite@4e7bc8cf04b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic26d2c905b0edd22443d3d781577ee7ab485e348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704003}
-
Nicolás Peña Moreno authored
Currently, TextPaintTimingDetector uses |invisible_objects_| to keep track of text paints which occupy a size of 0. It is an optimization: LCP does not care about these paints, so it does not need to queue them to obtain paint times nor store a full TextRecord for them. However ElementTiming wants to expose all of the text paints for elements that are annotated with the elementtiming attribute. It is confusing for an element that is painted when outside the viewport to never be reported. To solve this problem, there are two alternatives. One is to use a single |painted_objects_| map which would contain both the visible and the invisible objects, and hence no extra logic would be needed for ElementTimng to receive these objects (but some care might be needed so LCP does not report objects of size 0). This is simpler to code but is less efficient as it adds extra work and memory for the invisible objects. The second alternative is to use a new data structure for text nodes that are of size 0 but need to be reported to ElementTiming. Paint times for these are assigned in AssignPaintTimeToQueuedRecords() and then the TextRecords are deleted (the fact that the element has been painted is still being handled by |invisible_objects_| so there is no need to keep the records for longer). This is the alternative implemented in this CL. Bug: 1011009 Change-Id: I2d15393fc61134b08a5c15bd81d062d42dfb29e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838260Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#704002}
-
nancy authored
This CL is based on the review comments from crrev.com/c/1816495. To unify the enum on AppService, we prefer update the enum start from 0 to 10. BUG=1005640 Change-Id: Ifb70a24b1a3c1c4ac0693206c6df23cb190d067d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837551Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704001}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I22bb76ee37981fa241c268f868a8e5b36572e031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848344Reviewed-by:
-
Chris Davis authored
When importing bookmarks from an html file with a deep folder structure (>10k) we hit a stack overflow due to the recursive calls in JSONWriter. Fix is to check we do not exceed a max depth similar to JSONReader. Bug: 1007626,355722 Change-Id: Iedd9d543b7168a08af1a325059860d79d4900661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823809 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703999}
-
Joel Hockey authored
When dragging tabs of TYPE_APP to create a new Browser, the newly created Browser must be TYPE_APP. In order to achieve this, we save the CreateParams when a Browser is created, and we can then reuse the old params when creating a new Browser from a drag. Bug: 1012169 Change-Id: I6ffc4d87cec390cf5f39abbdf86dec0773598908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847235 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703998}
-
Rob Paveza authored
Accessibility Insights identifies an issue in which the iframe which contains the HTML preview of network requests does not have a title, which could present a difficulty for assistive technology. Because, particularly among HTML content, it's highly likely that the HTML content is going to be presented on the web application, and the preview itself is not intended to be interactive, this change adds a role="presentation" attribute. This is intended to make the element semantically meaningless to assistive tech [1]. [1] https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role Bug: 963183 Change-Id: I0f0fd02b13595f4787ebf0919abe8cf5a721884e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841940Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703997}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/457b1b9115f5..d8955c8337fc Created with: gclient setdep -r src-internal@d8955c8337fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:1004563,chromium:None,chromium:921048,chromium:None,chromium:None,chromium:1011937,chromium:None,chromium:None Change-Id: I543e0b3fbb10dbf83e282965d5999bb1f98ee181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848541Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703996}
-
Bettina authored
Send a sample ping for URLs that are on the allowlist for 1% of the time to Safe Browsing. Bug: 953106 Change-Id: Id71e25bb569a5e4553a6071634c479ab73753299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815764 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#703995}
-
meacer authored
Bug: 1009517 Change-Id: Ibc835b30a8e8f13dcbee1d07ea1dae17597b8f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846085Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703994}
-
Khushal authored
Using a color profile not supported by the platform results in fatal errors with SurfaceControl in the GPU process. The only case where we skip the platform check is if the color profile was forces through a command line flag. Ensure the check is done here as well to avoid noise from resulting crashes. R=boliu@chromium.org, oshima@chromium.org Bug: 997592 Change-Id: Ie442cb3eb594725ab71ecd4d10f8b161722d034e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847678 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703993}
-
Irina Yatsenko authored
depends on https://chromium-review.googlesource.com/c/v8/v8/+/1838927 Bug: chromium:1010312 Change-Id: I400537daf428e46180f15444d92a3dedab6aca3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838265Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703992}
-
Samuel Huang authored
This CL adds options to pak_util.py {extract, list-id, print} so that the .pak.info for the given .pak is used to translate ID to textual ID, which is then used. Details: * data_pack.py: Add GrdInfoItem type and ReadGrdInfo(). * extract command: Add --textual-id/-t to use textual IDs as filenames for extracted resources. * list-id command: Add --textual-id/-t to print textual IDs, and --path/-p to print resource paths, formatted as: ID[ = textual-ID][ @ path] * print command: Add --textual-id/-t to print textual IDs instead of IDs. Change-Id: I2086efc69867e56c8312aaec9545113e9a869266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846728 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703991}
-
Justin Cohen authored
Likely introduced in crrev.com/c/1002893, it is possible for a pending item to never commit (see steps to leak a WKNavigation in crbug.com/1010765). Normally this is a no-op, but if that pending item was copied into empty_window_open_item_ this can lead to a broken omnibox. Instead, simply clear the empty_window_open_item_ for all commits. Bug: 1010765 Change-Id: I24c8a3bc0d71ad3d96510a3fde8ed8c3941cf601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841618Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703990}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fcfd612..b45c693f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0cfaa4a158331251da1324e079bdc4e1966fcb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847747Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703989}
-
Ted Meyer authored
If the experiment to disable chrome://media-internals is enabled, then we need to tell users what is up, and how to access the new version. Of course this is dependent on the new UI getting checked in. Bug: 794255 Change-Id: I84f71e6034c53be97a943d4c3cbc3dc2c0a9aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767423 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#703988}
-
Daniel Murphy authored
These metrics are important for keeping track of leveldb error and corruption rates in the wild. R=mpearson@chromium.org Bug: 975513 Change-Id: Id88086bed09834c6a94a551f1174934230086e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846466 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703987}
-
Fergal Daly authored
This makes the code in each test more linear and comprehensible. This also allows moving the call to stopWaiting into test-running code rather than in each test. Also clean up the code to reset the scroll position so that it is in the test-running code. Change-Id: I1874a56217bab3bbea4194cf67fc04af57dd839b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846626 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#703986}
-
Justin Cohen authored
Add test for restoring a placeholder URL. Because WebTestWithWebState uses a placeholder to hack LoadHtml into working with SlimNav, an extra ErrorRetryStateMachine state was needed to ignore this hack. Bug: 1010264, 1011758 Change-Id: Iab10f4bc2160307352de3ff33f2d80df281aedad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819301 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
John Budorick authored
This also updates the generic_android23 and generic_android28 images with locally-built versions w/ these changes & the correct names. I'll update them again to bot-packaged versions after this lands & android-avd-packager runs. Bug: 922145 Change-Id: I9630cde9550b59d0f1db1969454f7fc528546808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839436Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703984}
-
Patrick Monette authored
The ServiceWorkerContextWrapper now keeps the list of running workers so that it can be accessed synchronously on the UI thread by the ServiceWorkerTaskProvider via GetRunningServiceWorkerInfos(). In addition, the OnVersionStartedRunning() function now provides a ServiceWorkerRunningInfo instance so that it nicely integrates with GetRunningServiceWorkerInfos(). Change-Id: Iba0a8d81bf39846abecb7d7d81241d5f180cc246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842552 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7a7f1c05edb..cef11fda71f6 git log b7a7f1c05edb..cef11fda71f6 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cef11fda71f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I8a705806ea3bd3a5c4c5309208b77a08f00b5ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847677Reviewed-by:
-
Nick Harper authored
This error was between CERT_BEGIN and CERT_END. Errors in that range have special meaning (which does not apply to this one), so it is now in the -300s with the rest of the QUIC errors. Change-Id: Iaba8443cf74df3b9b1896938c1107f9c7bcb3841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848054 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Andrew Xu authored
The current design does not leave space to show the ripple ring of the first/last app icon completely. This CL fixes such an issue by two ways: (1) Adding 2-pixel padding between the shelf container and the first app icon. It helps to show the first icon's ripple correctly. (2) Increases the scrolling upper bound by two pixels to show the last icon's ripple correctly. Bug: 1009368 Change-Id: I28210492f97f9c0ed33cdcaadced16bd00cfa72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842495Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703980}
-
Christy Chen authored
In the Console sidebar, the message titles are using concatenation depending on the number of the messages. This would cause the issue where the strings can not be properly translated since concatenation assumes word order, which can vary depending on the language, and the white spaces between words might not be needed in other languages. https://imgur.com/a/nC1Dbmt This change creates string maps for different cases (No message, 1 message, or more than one messages) to avoid concatenations. Grdp changes are generated automatically, with manually written descriptions Bug: 941561 Change-Id: Iad1803c3d3fadd76e9af3f7407a609e17cd708ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819648 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
-
Lei Zhang authored
This scoper takes care of calling PrintRenderFrameHelper::IPCReceived() and IPCProcessed() in its ctor and dtor, respectively. This makes it easier to correctly balance the calls. To make the scoper even better, give it a base::WeakPtr for PrintRenderFrameHelper instead of a raw pointer. Then the scoper can avoid accidentally calling IPCProcessed() if PrintRenderFrameHelper has already been destroyed. Change-Id: I81172fe2c9510bad2cbc3d0bfb3efe6fd530a9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842555 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703978}
-
Xiaohui Chen authored
Bug: 965415 Test: locally build and run Change-Id: I1748ab77bdb6b232225540a6e26ab8e3a439959c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847938Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#703977}
-
Trevor Perrier authored
Adding a 'Learn more' link to the Data Reduction FRE made <link> tags appear in the second run promo dialog. This change makes the 'Learn more' link clickable on the second run promo. Bug: 1010822 Change-Id: I82847539e30b419e59d0dcf44ec60c172182346a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845495Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#703976}
-
inglorion authored
crrev.com/c/1846084 temporarily added -Wno-error=bool-operation to prevent builds from failing on a newly introduced Clang warning. The code that triggered the warning has now been fixed, so we can stop suppressing the error. Bug: 1011810 Change-Id: I3d3818ae4805642e96bdcc19cff83a7ef5cf397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845484Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703975}
-
Avery Musbach authored
Test: manual Bug: 1012509 Change-Id: Ifd210885de279c26837f7b774ee0565b8d6d1237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848121Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#703974}
-
Adithya Srinivasan authored
To implement this, we reattach the DevToolsUIBindings for the current DevToolsWindow to the RenderFrameDevToolsAgentHost for the activated WebContents and reset the main connection in the frontend to reconnect with and enable the new agents. Bug: 992887 Change-Id: I0ca4e6cc7a6c633680bfd03d574a4030ab65d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788122Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703973}
-
