GitLab

This changes the mus interface to pass a CursorData instead of a
CursorType. The previous patch had mus clients create CursorDatas on
ozone platforms, and this patch passes CursorDatas across the mojo pipe
and passes it to the native ozone platform on the window server.

BUG=705037

Review-Url: https://codereview.chromium.org/2830703003
Cr-Commit-Position: refs/heads/master@{#467832}

BUG=710263,710264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844723003
Cr-Commit-Position: refs/heads/master@{#467831}

BUG=

Review-Url: https://codereview.chromium.org/2068843002
Cr-Commit-Position: refs/heads/master@{#467830}

This option is being removed from Cronet.

BUG=716108

Review-Url: https://codereview.chromium.org/2845093005
Cr-Commit-Position: refs/heads/master@{#467829}

To reduce path_from_webkit_base() usage.

- Remove rmtree()
  Only one callsite, and it called this function with an absolute path.

- Remove relative path resolution in remove()
  There are two callsites, and only one of them passed relative paths.

This CL should have no functional changes.

BUG=710535

Review-Url: https://codereview.chromium.org/2842393003
Cr-Commit-Position: refs/heads/master@{#467828}

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846973002
Cr-Commit-Position: refs/heads/master@{#467827}

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774

Review-Url: https://codereview.chromium.org/2841323003
Cr-Commit-Position: refs/heads/master@{#467826}

Allows derived classes to access/run the SessionExpirationUpdateCB that
gets passed in to Initialize(). This follows the same pattern as the
other session callbacks in CastCdm (OnSessionClosed(),
OnSessionKeysChange()).

BUG=

Review-Url: https://codereview.chromium.org/2847923002
Cr-Commit-Position: refs/heads/master@{#467825}

In order to void path_from_webkit_base() in test_expectations.py, this CL change
it to path_from_chromium_base(). lint-expectations messages will be changed from:

LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:3319 and LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html

to

third_party/WebKit/LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines third_party/WebKit/LayoutTests/TestExpectations:3319 and third_party/WebKit/LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html

BUG=710535

Review-Url: https://codereview.chromium.org/2850433002
Cr-Commit-Position: refs/heads/master@{#467824}

Fix https://crrev.com/aee5ec5b3423c48e79c296a054636d60473cfa8d

BUG=704700,711414

Review-Url: https://codereview.chromium.org/2841403003
Cr-Commit-Position: refs/heads/master@{#467823}

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to enable
explicitly the GMScore provider, and uses it
from Chrome.

[1] https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src/android/webkit/cts/GeolocationTest.java

Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed: https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546a44f5603b99c

patch from issue 2809813002 at patchset 260001 (http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM PS1

Review-Url: https://codereview.chromium.org/2836213002
Cr-Commit-Position: refs/heads/master@{#467822}

On Android, we currently always tell Blink that we will be using
fullscreen overlays. However, the MediaPlayerRenderer does not support
them, and does not attempt to use them.
The result is that Blink avoids drawing any gutter, which causes the
default background color from the LayerTree to be show instead. When no
overlay has been created, the default color is white.

This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true
when we are not using the MediaPlayerRenderer.

BUG=711888
TEST= manually tested on an HLS and non HLS video.

Review-Url: https://codereview.chromium.org/2840973002
Cr-Commit-Position: refs/heads/master@{#467821}

link to the document from extension.h

BUG=None

Review-Url: https://codereview.chromium.org/2823033002
Cr-Commit-Position: refs/heads/master@{#467820}

This CL to introduce a WebThread to run WebAudio graph rendering.

FYI: with the box 2d demo on my local machine (MacPro), the release
build of this patch was able to render 50 cubes concurrently before
glitch, which is similar to the current stable build that runs only on the
audio device thread. No significant performance regression is observed.

Design doc: https://docs.google.com/document/d/1WnqZHcA2TQjS1aKvzx2nnJ2y2tWK1Xp_0BhFGpsryaQ/edit#

BUG=706133

Review-Url: https://codereview.chromium.org/2777903005
Cr-Commit-Position: refs/heads/master@{#467819}

The original_display_ field in ComputedStyle currently has generated
storage, but not copy and compare. This patch makes it use generated
copy and compare. Previously, 'has_custom_compare_and_copy' was set
to true, so the generator did not generate a compare and copy for
OriginalDisplay. By removing that line, we fall back to the default
value of false, which means the generator will now generate a
compare and copy.

This patch does not change behaviour, as the newly generated code is
the same as the code being removed.

Diff of generated files:
https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2831933003
Cr-Commit-Position: refs/heads/master@{#467818}

This patch fixes many NPEs in PepperWebPluginImpl where Sergeant
Pepper forgot to check the instance before using it. The instance
may be null due to re-entry and a comment has been added about this.

BUG=715747

Review-Url: https://codereview.chromium.org/2835193008
Cr-Commit-Position: refs/heads/master@{#467817}

During cross-process navigation after crash, RenderFrameHostChanged is
called early with new RFH, and the old one goes away. This happens before
ReadyToCommitNavigation and we should change current RFH to avoid accessing
the stale one.

BUG=711451

Review-Url: https://codereview.chromium.org/2841123002
Cr-Commit-Position: refs/heads/master@{#467816}

All instances of ManagedTetherProperties are replaced by (non-managed) TetherProperties. This change is due to the fact that tether properties are not managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847453002
Cr-Commit-Position: refs/heads/master@{#467815}

- Add the floor, ceiling and grid quads.
- Add the content backplane to avoid reticle jumping around the edges.
- Configure the scene reticle distance limit based on content.

BUG=715573
TEST=Verified background on regular page; no background in WebVR.

Review-Url: https://codereview.chromium.org/2844313002
Cr-Commit-Position: refs/heads/master@{#467814}

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual

Review-Url: https://codereview.chromium.org/2844933003
Cr-Commit-Position: refs/heads/master@{#467813}

BUG=690020

Review-Url: https://codereview.chromium.org/2842163003
Cr-Commit-Position: refs/heads/master@{#467812}

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2852493002
Cr-Commit-Position: refs/heads/master@{#467811}

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549

Review-Url: https://codereview.chromium.org/2849483002
Cr-Commit-Position: refs/heads/master@{#467810}

This is in preparation for updating/adding tests for the change to support
run-time switch of decoders.

- Move decoders to be selected to a vector to avoid duplicate code.
- Add |decoder_| to track the currently selected decoder.
- Remove DECODER_INIT pending state since this is rarely used.
- Allow FakeVideoDecoder to use different display names. This is needed
  to check what decoder has been selected.

BUG=695595
TEST=Refactor only. No changes to existing tests.

Review-Url: https://codereview.chromium.org/2835203006
Cr-Commit-Position: refs/heads/master@{#467809}

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090

Review-Url: https://codereview.chromium.org/2847793003
Cr-Commit-Position: refs/heads/master@{#467808}

This CL primarily removes the internal WindowsNdisApi class
which is only meant to be used for the unsupported Win XP and
Vista, and leaves only WindowWlanApi internal class in place.

Furthermore it simplifies the remaining WindosWlanApi code
by linking directly against wlanapi.dll, which makes unnecessary
a number of other file-static functions, the factory method
and the library functions defintiions and variables, yay!

It also removes a chunk of file-static functions that became
unused; only one GetNetworkData() remains.

PS4 UPDATE: this CL actually could not remove the dynamic loading
of wlan_api.dll because it's not available by default in
some/all Server 2008 R2 installations, including some of our
win_chromium_rel_ng slaves, which failed. See
https://www.bonusbits.com/wiki/KB:Wlanapi.dll_missing_on_Windows_Server_2008_R2

(However, we can remove the WindowsNdisApi class because those
Server2008R2 installations would explicitly enable WlanApi.dll
to access Wifi anyway).

BUG=714477

Review-Url: https://codereview.chromium.org/2842613002
Cr-Commit-Position: refs/heads/master@{#467807}

Review-Url: https://codereview.chromium.org/2844603002
Cr-Commit-Position: refs/heads/master@{#467806}

This adds a 'Open file' option in the DevTools 3 dot menu and updates the
style of the Sources placeholder text with a new entry
'Ctrl-Shift-P Run command'.

BUG=700184

Review-Url: https://codereview.chromium.org/2716683006
Cr-Commit-Position: refs/heads/master@{#467805}

ImeController::CanCycleIme() and ImeController::CanSwitchIme() should first
check if IME state is NULL and if it is, ignore the cycle / switch action
because it does not make sense before IME initialization.

BUG=703510

Review-Url: https://codereview.chromium.org/2806613002
Cr-Commit-Position: refs/heads/master@{#467804}

The executable path can have spaces so just splitting by space doesn't
work. It can be quoted or not depending on platform so using a regex
doesn't work either.

R=kbr
BUG=580050

Change-Id: I2707a257c6e89169f5486e2364c5b4045d142d9e
Reviewed-on: https://chromium-review.googlesource.com/489603Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467803}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/67894d267da3..770ad6af2778

$ git log 67894d267..770ad6af2 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 dtu [pinpoint] Add repo mappings to Dep object.
2017-04-27 ashleymarie Rewrite path to suppress a blocking crash resume dialog on mac
2017-04-27 simonhatch Dashboard - Default improvements to showing on group-report-page.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I3dd325aec09ce0831d6a462637c34751c4d267a7
Reviewed-on: https://chromium-review.googlesource.com/489606
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467802}

https://pdfium.googlesource.com/pdfium.git/+log/827db14d7f3d..f452f56021f2

$ git log 827db14d7..f452f5602 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 caryclark move pdfium skia build forward to match chrome
2017-04-26 tsepez Remove more |new|s, part 2

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ic822c1ec46a7c5cab27de3992aa49e62f554f9b7
Reviewed-on: https://chromium-review.googlesource.com/489664
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467801}

TBR=tandrii@chromium.org
BUG=716089

Review-Url: https://codereview.chromium.org/2848653004 .
Cr-Commit-Position: refs/heads/master@{#467800}

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716089
TBR=dpranke@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2847903002 .
Cr-Commit-Position: refs/heads/master@{#467799}

Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of https://codereview.chromium.org/2837233002/ )

Reason for revert:
Bot breakages

Original issue's description:
> Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ )
>
> Reason for revert:
> Fixing build issues
>
> Original issue's description:
> > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ )
> >
> > Reason for revert:
> > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29
> >
> > First seen here:
> > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590
> >
> > Original issue's description:
> > > SafeBrowsing: change interstitial sizes
> > >
> > > This CL changes the CSS max-height, max-width, etc. dimensions for
> > > determining when to use mobile vs. desktop interstitial layouts. In
> > > particular, it targets:
> > >
> > >  * wide and short views -> mobile landscape
> > >  * skinny and tall views -> mobile portrait
> > >  * wide and medium-height -> mobile landscape (w/ details on the same page)
> > >
> > > The phablet layout has been removed because it seems to actually be better
> > > to just use the mobile layout instead.
> > >
> > > This also allows the mobile layout to remain centered even for very wide
> > > views (parts of it were left-justified before), and reduces the
> > > top-margin for the icon in the mobile layout, since we were leaving a
> > > huge gap.
> > >
> > > BUG=707481
> > >
> > > Review-Url: https://codereview.chromium.org/2788323002
> > > Cr-Commit-Position: refs/heads/master@{#466746}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51
> >
> > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=707481
> >
> > Review-Url: https://codereview.chromium.org/2842633002
> > Cr-Commit-Position: refs/heads/master@{#466811}
> > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9
>
> TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=707481
>
> Review-Url: https://codereview.chromium.org/2837233002
> Cr-Commit-Position: refs/heads/master@{#467789}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d24118ad102f00

TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481

Review-Url: https://codereview.chromium.org/2848483004
Cr-Commit-Position: refs/heads/master@{#467798}

Reason for revert:
CQ draining actually doesn't work :(

Original issue's description:
> CQ: start draining CQ.
>
> TBR=dpranke@chromium.org,andybons@chromium.org
> NOTRY=True
> NOPRESUBMIT=True
> BUG=716089
>
> Review-Url: https://codereview.chromium.org/2850553003
> Cr-Commit-Position: refs/heads/master@{#467795}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae8025b8658d55b0f6b74956f1b2381695a3c991

R=dpranke@google.com
TBR=andybons@chromium.org, dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716089

Review-Url: https://codereview.chromium.org/2850703002 .
Cr-Commit-Position: refs/heads/master@{#467797}

Tested by enabling clipboard provider and the clipboard interactively on a device.
Clipboard suggestions are persisted to and restored from prefs, which works
even if I kill Chrome.
I also added LOG(INFO) lines during this and saw the writes and reads happening
at the correct time and with the right values.

BUG=711574
R=bauerb@chromium.org, dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2832263002 .
Cr-Commit-Position: refs/heads/master@{#467796}

TBR=dpranke@chromium.org,andybons@chromium.org
NOTRY=True
NOPRESUBMIT=True
BUG=716089

Review-Url: https://codereview.chromium.org/2850553003
Cr-Commit-Position: refs/heads/master@{#467795}

Fixes recent tablet failures.

We have two tablet tests on long-press having the selection become
empty after a sequence that includes selecting.  For some reason
the latest CS seems to change to an empty string instead of null
so the tests fail on M.  Not sure what the underlaying cause is,
but seems to work fine to just check that the text is empty rather
than checking explicitly for null.

BUG=715978

TBR=twellington

Review-Url: https://codereview.chromium.org/2844063006
Cr-Commit-Position: refs/heads/master@{#467794}

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2836703003
Cr-Commit-Position: refs/heads/master@{#467793}