- 07 Jan, 2021 40 commits
-
-
Harald Alvestrand authored
Performance improvements have been landed, and limits reduced after testing on a weak cloudtop system in debug mode. This may be enough. Bug: chromium:1160616 Change-Id: I5ca85af0dd8bbd99f094025d979dbb7b1617d698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611714Reviewed-by:
Tal Pressman <talp@google.com> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#840962}
-
Eugene But authored
Flag has expired in M88 Change-Id: Ie67fc34e530e0cd4727dee064398de035948e8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597877Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840961}
-
Alice Wang authored
This CL moves SigninPromoController to signin.ui module. Bug: 1159833 Change-Id: I2a65cf55b81cd928c8b93dc21fd61729560c0fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598913Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840960}
-
Alice Wang authored
This CL cleans up usages of toCoreAccountInfo in account picker tests. Bug: 1147417 Change-Id: I0f77d76032701f281ea56cb298f76830ea50f3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612885Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840959}
-
Maksim Sisov authored
When CreateDmabufBasedBuffer call fails, it calls a gpu terminate callback internally, which must be installed before the host buffer manager is used. Bug: 1160261 Change-Id: I90ea974ce9dbec5f36c3fae63002e573e80c7a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609827Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#840958}
-
Luciano Pacheco authored
This reverts commit 74ee693e. Reason for revert: Submitted with the wrong CL description. Original change's description: > Files app: Move global entities used from foreground > > Move launchFileManager() from `launcher` namespace and registerDialog() > from global namespace to the interface FileBrowserBackgroundFull. > > This keeps consistent all access from foreground page going through this > interface. > > Bug: 1133186 > Change-Id: I91157545620013baeef6eaa0143a5758a289a8ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612254 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Auto-Submit: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Jeremie Boulic <jboulic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840950} TBR=lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jboulic@chromium.org Change-Id: I70623d88b81d98d33009db117d6771c09ee29149 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612790Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#840957}
-
Rakina Zata Amni authored
Currently we only track the latest same-document NavigationRequest in RFHI, so if a new browser-initiated same-document navigation got into the commit stage before an older browser-initiated same-document navigation's DidCommit IPC gets processed, we'll delete the older NavigationRequest and re-create the NavigationRequest later with NavigationRequest::CreateForCommit, which incorrectly assumes that it's for a renderer-initiated same-document navigation, getting the wrong values for browser-initiated navigations-related attributes such as intended_as_new_entry and nav_entry_id. Bug: 1155414, 1133115 Change-Id: I4d4658d34982f1bb895d6b3dba497bbc6db7341c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599677 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#840956}
-
Min Qin authored
BUG=1154456 Change-Id: I0164f8a4ffd2364ee25f480caa3d5647d80226ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613556 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46d3f02acfab..ca94d1da8597 2021-01-07 syoussefi@chromium.org Vulkan: Refactor generated code in xfb emulation path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ic9a4eb4c4cb1024e8b491c893eae8ef3e3a0e73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840954}
-
Thomas Guilbert authored
This CL converts SyncFileMetadataCallback and SyncFileStatusCallback to OnceCallbacks. It also deletes the unused SyncFileSetCallback. Bug: 1152272 Change-Id: Ib85b776c602cdffb871f79ad158f0726c7ed9594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606603 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#840953}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ae206b8b8d3f..d9d7213a6c08 2021-01-07 fancl@chromium.org chromeperf: Validate the first row_id If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1151222 Tbr: nuskos@google.com Change-Id: I576f96f5fbaa7d2cab5475ec775452b8c3f9d4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614215Reviewed-by:
-
Yusuke Sato authored
Since we're going to move the logic to arc-setup soon, browser tests won't really do the expansion. Instead, we should simply mark it "done". BUG=chromium:1163122 TEST=try Change-Id: Ie27ca7ac73e593bdd8ca42bb367a0807ababbf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612496Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#840951}
-
Luciano Pacheco authored
Move launchFileManager() from `launcher` namespace and registerDialog() from global namespace to the interface FileBrowserBackgroundFull. This keeps consistent all access from foreground page going through this interface. Bug: 1133186 Change-Id: I91157545620013baeef6eaa0143a5758a289a8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612254 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840950}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609977525-c6db9a955637b88d5134fbbd1dcc888c0f8d0465.profdata to chrome-win32-master-1609988385-4b9eeae9cba8aed26e55c5712ae60d144fa0441b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40609f307522067634afeb825764bc708643d9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614146Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609966729-f10b4c89116276ddc6d9d2f94d5dc003384dbd78.profdata to chrome-win64-master-1609988385-9c096aa1bc5d021f182b9150cd47fcb15e7461d7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I76d843eb6953d0ed2143234e3b40fad6f8e9149b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614148Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iab046dfc93d36f02607143f86c7ae54db2b04a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614027Reviewed-by:
-
Shakti Sahu authored
This CL adds rounded corner for the GIF animations in the IPH cards Bug: 1117148 Change-Id: I81e8914ffa3fea8398df32a8cc226046a699e0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611998 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/756995baea50..d64a3193cd49 2021-01-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a84acc4fcca8 to fac169113df7 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I043d1f23e90b0dc2aa7a9a319f414ad8bc7603db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614025Reviewed-by:
-
Matt Falkenhagen authored
This is a reland of 6be1b3d6 It was reverted as a suspected cause of AutofillPrivateApiTest.GetCountryList browser_test failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/59127 But that test has been flaky from before the CL and is now disabled, see https://crbug.com/1155072 and https://crbug.com/1162474. Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (1/3) > > ServiceWorkerMainResourceLoaderInteceptor doesn't need to delegate > to ServiceWorkerControlleeRequestHandler to create subresource > params. It can access the ServiceWorkerProviderHost directly. > > This simplifies calling the loader callback. > > Bug: 1138155 > Change-Id: Ibf31c379a755c9c94471c707633a582bf7cba85d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602965 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840506} Bug: 1138155 Change-Id: Ied37cad31bd0dcc027cf7e90f9044071014ff914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612553Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840944}
-
Bartek Nowierski authored
Bring back synthetic PartitionAllocEverywhere experiment, scheduled for 1/8. Also add synthetic BackupRefPtrAndPCScan experiment, scheduled for 1/12. This requires disabling PCScan when BackupRefPtr is in use. Bug: 1073933, 11297512 Change-Id: I5a575c4d60ff6d6eb196e0508851f279ce1fb7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612307Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840943}
-
Ken Rockot authored
Fixed: 1162198 Change-Id: Ief850903a7e6ba3d7c5c0129704d1f80aa3467ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612085 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840942}
-
Anton Bikineev authored
PCScan (and cache purging) was redundantly performed for each partition root. This CL moves these routines out of the root loops. Change-Id: I42eabeb024126100c47b7c757121aa5b969d4493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610588 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Fergal Daly authored
Bug: 1163509 Change-Id: I5f8df01e1a81c65b1a959258b6f95740981d4913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612657 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#840940}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_RequestPrintPreview message to RequestPrintPreview() in mojom::PrintManagerHost. Since PrintHostMsg_RequestPrintPreview is a message to request a print preview, a Preview ID is not generated yet when the message is requested. So, the converted message is added to mojom::PrintManagerHost, not mojom::PrintPreviewUI. This change also updates PrintPreviewDialogControllerBrowserTest to use TestPrintViewManager instead of RequestPrintPreviewObserver::OnMessageReceived. Bug: 1008939 Change-Id: Id5db2862ddb01a91f80cf5534fde71e88c2d2b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593847Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#840939}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/7ca666453540..5f87855f34ce 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 480f6039e072 to 3de5cfe50ede (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I0a72b8ef5c3e6a3b9f14adc05b9641364957387a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613523Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ceb5ca2f26dc..18e4d8661753 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: Ifa26f70224b55475cc49c66ab132f51ed83a69fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614147Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840937}
-
Luciano Pacheco authored
Remove unnecessary import for MockEntry. Add metrics to test_util_base to expose to runtime_loaded_test_util.js. Bug: 1133186 Change-Id: I2bb6143d5670d6096b88ba8345af847a726404fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613844 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bd38fed1b9e..7f2db542af0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7c3e8d09a8b35d1c7ae26492e39ecef11a760749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614109Reviewed-by:
-
Wanming Lin authored
This is a follow-up fix for https://chromium-review.googlesource.com/c/chromium/src/+/2600274/3/chrome/test/data/webui/test_util.js#135 - Reverted change to chrome/test/data/webui/test_util.js - Make history_list_focus_test.js work better with actual setTimeout 0 Bug: 402694 Change-Id: I564a7d45678505ef7fe2af3820f7bfeb1101c256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600327Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#840934}
-
Tsuyoshi Horo authored
This reverts commit eb3c1fae. Reason for revert: This CL made DiceWebSigninInterceptorBrowserTest.InterceptionTest flaky Bug: 1163727 Original change's description: > [profiles] DiceInterceptedSessionStartupHelper calls multilogin directly > > This CL changes the way DiceInterceptedSessionStartupHelper adds the > account on the web. > Previously it was mostly waiting for the reconcilor to trigger, and > making sure that the process is not stuck (by forcing calls to list > accounts). > > The new behavior is more proactive: when the profile is new, it blocks > the reconcilor and forces a call to multilogin directly. > The advantages are: > - it is easier to control and hopefully it should be less brittle. > - it should be faster: > * the previous flow was doing an extra /ListAccounts call after the > reconciliation, which is now removed > * the previous flow was using MergeSession while the new flow uses > multilogin, which should be faster on desktop (no need to fetch an > access token) > > When the profile is not new, it's not possible to simply use multilogin, > as there may already be accounts in the profile. The reconcilor is still > used in this case, as it has the logic to handle this. > > Note: it would be possible to use MergeSession instead of Multilogin, as > this would work for all profiles (including existing profiles). However > MergeSession is now discouraged and thus we avoid adding a new usage > here. > > This CL also improves histograms. > > Bug: 1151313 > Change-Id: I4871eb123eb37081595164bd5280adf2b0b1290b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600909 > Commit-Queue: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Auto-Submit: David Roger <droger@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840690} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idef04b25e362b8c56c7ac51bf373d4c702cd11ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613846Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#840933}
-
Tommy Li authored
TemplateURLService::GetDefaultSearchProvider() can sometimes return nullptr. This condition occurs more frequently on startup, before the TemplateURLService has loaded the sqlite3 keyword table. This condition is made more frequent (temporarily) since my recent patch: https://chromium.googlesource.com/chromium/src/+/ecae40df17fd8eaea5e45ad62eae8e5c906e3aa7 This CL fixes a crash by making RepeatableQueriesService check whether the DSE is nullptr and gracefully early exiting in that condition. Bug: 1163453 Change-Id: I2ac2b9ca205ed7b3ecfa81cdf425b246ea2f1d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613387 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840932}
-
Tsuyoshi Horo authored
This reverts commit 475e9c81. Reason for revert: Test failed on linux-chromeos-chrome bot Bug: 1163791 Original change's description: > Add installability test for when start_url has no offline response > > The following case should not pass the offline capability check: > - manifest's scope: /banners/ > - manifest's start_url: /banners/manifest_test_page.html?ignore > - service worker's scope: /banners/ > > Bug: 1157242, 965802 > Change-Id: I2832fbc102fd931aecc9d42394f5429e4c66e6aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596902 > Commit-Queue: Asami Doi <asamidoi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840905} TBR=dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org Change-Id: Ic9ee9b7c0c61ae2c1016e6e2bbad0bfd62bda381 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157242 Bug: 965802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612552Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b9e179f1f239..7b2f93895418 2021-01-07 capn@google.com Fix implicit inexact conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8e3bc116e53777aefa1cd6f7258b9ae274e4bf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613932Reviewed-by:
-
Eric Willigers authored
We add browser tests to test the remoteAddress and remotePort attributes of TCPSocket. Bug: 909927 Change-Id: I5e6207a06d1082993e4fb773379d7bb854e2dcd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612631 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840929}
-
Preethi Mohan authored
Bug: 1082907 Change-Id: I9f206e14cc7ac92616bd8b6b01388fa204eebbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568600 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#840928}
-
Thomas Guilbert authored
This CL adds avcOptions, which allows user to choose between H264 stream formats. By default, the encoded chunks will follow the AVC format, but users can now choose to chunks converted into "Annex-B". Bug: 1132050 Change-Id: I38ecfe9d2acec986050cc856a93d49d751152f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587596 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#840927}
-
Cattalyya Nuengsigkapian authored
Bug: 1163716 Test: Manual test, ash_unittests --gtest_filter=*DesksRestoreMultiUserTest* and browser_tests --gtest_filter=*SessionRestoreTestChromeOS* Change-Id: I4962fa62d202c6fa08cf6b8eb5b0b5306421de44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613964Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#840926}
-
Kuo Jen Wei authored
Bug: b/172340545 Test: tast -verbose run <DUT> "camera.CCA*" Change-Id: I335453587a3e79083b64b9fbd8409cbd3b0d0978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596588Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840925}
-
Ahmed Fakhry authored
Implement the proposal presented in the design doc http://go/window-capturing to make the FrameSinkVideoCapturer able to record non-root windows. tl;dr The idea is to tag the layer of the non-root window with a unique ID (of type viz::SubtreeCaptureId) that will result in forcing this sub layer tree into a render surface that draw into a render pass identifiable by that ID to the FrameSinkVideoCapturerImpl on the viz side. BUG=1143930 TEST=- Manually. - Added new tests: - (viz_unittests) CompositorFrameSinkSupportTest.CopyRequestOnSubtree - (aura_unittests) WindowTest.*Capturable* - (ash_unittetss) CaptureModeTest.WindowRecordingCaptureId - (browser_tests) RecordingServiceBrowserTest.RecordWindow - (cc_unittests) *LayerTreeHostCaptureTest* - Modified many tests else where. Change-Id: Iede1b923db391e6f390bb78a1d1aaf848ad7ab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593724 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9730dc4041f5..756995baea50 2021-01-07 bsalomon@google.com Revert "Revert "Fix GPU improved noise impl and add to perlinnoise GM."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Idbe4e3e1f6489c6526dcf011020098c21162dc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613929Reviewed-by:
-
