- 30 Aug, 2020 22 commits
-
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I77f9140c2c573a0f969c09f9eb5adc46e2b1d503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384029Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802957}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598754079-67fc4d590254f5ab7174427f2cc7e0ef0963cb7e.profdata to chrome-win32-master-1598764957-5a770d69b5bcb78eee1093900663c67b4c4c4cf4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1cea1cbe01f48105973f90b6c7ace1bad965dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802956}
-
Rouslan Solomakhin authored
Before this patch, invoking PaymentRequest.show() for secure payment confirmation on a device without credentials would reject with "User closed PaymentRequest UI" error message instead of the more correct "Payment method not supported", if show() was called after PaymentRequest.canMakePayment() returned. This is detrimental to measuring the success of the secure payment confirmation dialog. This patch changes the secure payment confirmation UI controller to not invoke PaymentRequest::UserCancelled() when PaymentRequestState has finished looking for credentials and found none. This allows payment_request.cc to correctly the no-apps state by rejecting PaymentRequest.show() with the correct error message. After this patch, a device without credentials always rejects PaymentRequest.show() with "Payment method not supported" without implying that the user interacted with the UI dialog and cancelled it. Bug: 1123082 Change-Id: Idba82354f413c926c1f835ec34e50d3c29080bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383812 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#802955}
-
Monica Basta authored
Fixed: 1123093 Change-Id: I09935ef9c9ff0bb4104d887c0314653327faced2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382590 Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802954}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id612719ebdeadce1f9c3b6d17ae17bb81dd11a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384137Reviewed-by:
-
kdillon authored
When the frame is detached, the receivers are reset. This makes it possible for BindToReceiver and its variants to be called while the frame is detached. This is an issue because the frame scheduler also gets reset on detach so when we try to call 'GetTaskRunner' (which invokes a method on the frame scheduler) it can crash. To prevent bindings from occurring when there is no execution context, this CL checks whether the frame is detached before binding a pending receiver. Bug: 1103594 Change-Id: I8179ee81b5ca992f88dbb627be1fec5eeeb0a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303777Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802952}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8702b8f4444f..d5961b33e87f 2020-08-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I4cdc6cf033202ca32265f4fdaf8f3357df7ed687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384129Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.12-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0d1ffdea3314c9db397d8749d5bd3793a6e323a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384138Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598680344-aa469a0f04e08491eb84b2521bf3eecf90475733.profdata to chrome-mac-master-1598764957-579002e6a76f5560b11ec6e2a28ec9eef139de77.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4bd7a072982d73bc43413f145fd913990767dbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384134Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10bfd34d3ceb..39f016ab802e 2020-08-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6338404430582136b4679b1383bf39effdfe4949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384130Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598751363-29d99da61a85f02ed5804a976cf96426ad8a9d5e.profdata to chrome-win32-master-1598754079-67fc4d590254f5ab7174427f2cc7e0ef0963cb7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I103ed6a9e63cc25b318ef460619e89b90c81d4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383999Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/48b9a3aff08a..10bfd34d3ceb 2020-08-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b285e81ef0d480d4c9c8130e4cb1e11c713f1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383998Reviewed-by:
-
chrome://multidevice-internalKyle Horimoto authored
Previously, logs would extend a few pixels past the horizontal width of the page, resulting in an overflow and making it possible to scroll left and right. This CL fixes that, and also cleans up some code in the <log-object> element. Change-Id: I5f5d191368f2c4e7717ae2d9aaedf3c9990a3f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383790 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802945}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598726469-07b09bb3ded797552790f7356358abc2345a2e3e.profdata to chrome-win32-master-1598751363-29d99da61a85f02ed5804a976cf96426ad8a9d5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8243e95329fda6c7bab941b95b7bd94be9c20653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383997Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8d412db25c17..a0d048a4023f 2020-08-30 syoussefi@chromium.org Vulkan: Fool-proof usage of GL and VK level indices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Iff9e79502dd6e6b8eeabb0b234709a008c0689a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383996Reviewed-by:
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I652e1814e73eef60a5722eee48c39a25f5782e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383830Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#802942}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: If0ff0f7b6fdb71d5d3c718e6086f71683b2db960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383819Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802941}
-
Joel Hockey authored
Refactor CrostiniApps and GuestOsRegistryService so that PluginVM apps are registered as type PluginVm by PluginVmApps. When I recently changed the icon handling, it was a mistake to register PluginVM apps as crostini. Bug: b/158617133 Change-Id: I0877e75b9b087c6ece34cbe8642399b5cc2764c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379407Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#802940}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icc095944226895ba997fe8ca0fe124d09c7b4807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383991Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f71283c987e8..8d412db25c17 2020-08-29 jmadill@chromium.org Revert "Convert unordered_map to absl::flat_hash_map for select files" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I8409102a0e8785d7094f9ff9234fc563c794d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383788Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598716151-c6631225049a2220e70028e087f4c38c43ce234c.profdata to chrome-win32-master-1598726469-07b09bb3ded797552790f7356358abc2345a2e3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I1b5ba6c8d3b51e3dabbd46dd2b979b4e2369ad1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383783Reviewed-by:
-
Ian Kilpatrick authored
Previously tables ignored the given fixed-inline-size. However due to a fix for grid/flex: https://chromium.googlesource.com/chromium/src/+/a0b54e201c5ae7f2a5d2a769531adb9c47ff54ba they started respecting them. The uncovered a bug in the NG out-of-flow calculation, (given that these set a fixed-inline-size on children). After a bit of research it appears that Blink/WebKit/EdgeHTML limit the available-size for the shrink-to-fit calculation to the container's available-size. Firefox appears to be the odd one only applying this limit in certain circumstances. This applies the limit, and adds tentative tests. Bug: 1122428 Change-Id: Ie8079aa598931b4054afd663f67f7377c97e4e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380102 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802936}
-
- 29 Aug, 2020 18 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/460ee9c8dc88..3479e999694c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I630ea03d108485788b45343a012cd6ed43737e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383782Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802935}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I100649cc857aebcc46c202ea72c4bc0293147af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382811Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802934}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter.cc This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1110266 Change-Id: I92ac28914d3263dd50cf5a845f509e1cfade9479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371253Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#802933}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598712808-09df931579252487b94010e4a09d388ad40a3578.profdata to chrome-win32-master-1598716151-c6631225049a2220e70028e087f4c38c43ce234c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic5623379710754e62a0e93e9b23e4c746c1d038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383629Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5692b2cbc2f8..460ee9c8dc88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ida32cbf2e00700b00c1f63256adcbb2ba6d1467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383752Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9515efae60d93ede65aa3b8de11f6ee05828e109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382812Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802930}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I35684eca30719b00c226ab5d27d1d909649802b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382831Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802929}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 714f7bad. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I95a837b3becbcc2a4fbd9a990b98dd25d0adac9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802928}
-
Rouslan Solomakhin authored
Before this patch, calling PaymentRequest.canMakePayment() after its value has been calculated would return "false", ignoring the fact that secure payment confirmation is being requested, for which canMakePayment() should return "true" if an authenticator device is available, even if there are no credentials on file. This patch changes PaymentRequestState::CanMakePayment() to use GetCanMakePaymentValue() after all apps have finished queried. This method takes into account whether secure payment confirmation is being requested and an authenticator is available. After this patch, PaymentRequestState.canMakePayment() always returns "true" for secure payment confirmation when an authenticator is available (if the secure payment confirmation feature is enabled). Bug: 1123148 Change-Id: I4bb4895cbc1c7db1d84a19c9d753d5766769ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383693Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1110266 Change-Id: Iddf90171933636e81053e57d94696f57bf8af85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371254Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/776538aab025..f71283c987e8 2020-08-29 jmadill@chromium.org Fix EGLContextCompatibilityTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ie7816aba67d297ca74d0e11b66453aec2e82e315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383750Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d3314c53ce5..8702b8f4444f 2020-08-29 reed@google.com don't return unknown from computing-convexity, as documented If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ia53c6408e8db59c0a9ef725c376e7b9f927e228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383627Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.12-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifbb83a8cbae9ec46723d98517bc57d28ae3f945f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383754Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6ac65bab7ec72870f4a6a2396b9edefbb46c86e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383691Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802922}
-
Lijin Shen authored
When "system settings" method is used under P-, the app crashes because the system does not have "change default" settings. This CL skips when the system does not have such settings. Bug: 1122907 Change-Id: I6133e83ee15074cd48bd4db6c098005428cb088b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382895 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#802921}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.12-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I64a0379039fd1951a6d2c32fbbb65894aa921180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383751Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598692662-51dd0188d114bd684377b7bf15f0aec233b129c0.profdata to chrome-win32-master-1598712808-09df931579252487b94010e4a09d388ad40a3578.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6398b1e44c211b57824290b8a8f53b0363b14844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383622Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4efc051da9d..776538aab025 2020-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 11fcbbf5d7cc to 3b3f93c206dc (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ifcad5d30adada1bf4f79020fe49d6e6f6c98d3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383621Reviewed-by:
-
