- 28 Sep, 2020 40 commits
-
-
Rohit Agarwal authored
The code which should close the regular tab was behind an assert and assertion check gets removed in release build which effectively made the code of closing the regular tab non-existent in release build. TabModelImpl#closeTab returns a boolean indicating whether the tab was found which is ambiguous on whether the tab was closed. Hence the assertion on "found the tab" may be misleading for "closed the tab". Bug: 1132000 Change-Id: I15eba93453a58beaa32770017545f045b5b310e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435085Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811198}
-
Omar Morsi authored
This CL changes KeyPermissionsService interface such that no key locations arguments are expected and all functions are async. KeyPermissionsService now identifies key locations itself, which is why it also gets a dependency on PlatformKeysService. Making the functions asynchronous will also be helpful in a follow-up where setting/getting corporate flag will require a call to chaps. Bug: 1130479 Change-Id: Idfb3d36283d22b90109c74a664d4aca60b0f6168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421704 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811197}
-
Pavol Drotar authored
A WebApk checks for this category to display a site settings shortcut. This category is therefore a switch to turn site settings on/off. Bug: 1128985 Change-Id: Id2678b957bd3f21e8cafa47ca2c10a2b269b3621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434326 Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811196}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I726c9e62ea49fad1f992f184841a3f15b1f6f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435146Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#811195}
-
John Lee authored
Fixed: 1131152 Change-Id: Idb6b22c002b87748da4a9248b54bb5d288de75f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429226Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811194}
-
Matt Falkenhagen authored
Change-Id: I348e13cf443af481479000d0b15874bb9a8f2dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425931 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#811193}
-
arthursonzogni authored
We know the navigation's can have an initiator_routing_id, but with no corresponding RenderFrameHost, even at the beginning of the navigation. We know this is true, but it turns out this isn't covered. This is shown by this tryjob: https://chromium-review.googlesource.com/c/chromium/src/+/2413265/3 This patch adds it. Bug: 1059959 Change-Id: I0bf0e4d86ffd056b00e647a8c01c9ec3710e26f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414172 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811192}
-
Swapnil authored
This is a reland of 7ff62f12 Original change's description: > Report installation stages in increasing order > > This CL reports the installation stages for force installed extensions > in an increasing order. This is done in order to investigate > the extensions stuck in CREATED stage. > > Bug: 989526 > Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809777} Bug: 989526 Change-Id: Ic101b2deea496c86b6618f13466b5381e6369c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426592 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811191}
-
Morten Stenshorne authored
When a float in an inline formatting context fragments (or just gets pushed to the next fragmentainer), it won't become a fragment item there, but rather a regular box fragment child. See crrev.com/2264367 This fix allows us to remove a DCHECK that would otherwise cause the following tests to fail: * virtual/layout_ng_block_frag/fast/multicol/float-big-line.html * virtual/layout_ng_block_frag/fast/multicol/vertical-lr/float-big-line.html * virtual/layout_ng_block_frag/fast/multicol/vertical-rl/float-big-line.html Bug: 1132619 Change-Id: I86268da4c146dba89bd7ec36df166ad90b2b5f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433926Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811190}
-
Dana Fried authored
This has been a feature request from a number of people for a long time and was fairly simple to implement. Change-Id: I7d25a563f654b3fd07f1d4c15cd274dcac65236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430766 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811189}
-
Tal Pressman authored
Flows that were previously handled via `RenderThread::Get()` are now handled by the AgentSchedulingGroup (which, for now, just forwards them to the RenderThread). Bug: 1111231 Change-Id: I64957c18ca2ea07580cdaa45e76e8b8e1a9edfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377177 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811188}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/131d306fc1d9..1fb6b3e1b5c0 2020-09-28 szuend@chromium.org [ts] Type-check devices/DevicesView.js with TypeScript 2020-09-28 patrick.brosset@microsoft.com Guard against malformed URIs when creating a binding for a resource If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132305 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87d87f6372df95f4fee0f7e9b239e7eeca6d68fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811187}
-
Titouan Rigoudy authored
This change does away with the existing LoopbackEmbeddedIn(Non)SecureContext WebFeature, replacing it with more specific versions for each combination of: (client address space, resource address space, secure context bit) Note that this UseCounter only counts resources that were allowed through by CORS-RFC1918 checks in services/network. Fixed: chromium:1124358 Change-Id: I74ba85650c274779417f7c088180f482e6475981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424246 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#811186}
-
Paula Vidas authored
When SyncSendInterestedDataTypes, UseSyncInvalidations and this flag are enabled, new invalidations will be used for Wallet and Offer-related types. Otherwise, those types are excluded from interested data types (even if they are enabled). Unsubscribing from old invalidations for these types will be added in a separate CL. Bug: 1082115 Change-Id: Ia9dc759580095129ad04d455c8162b2324c81856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431426Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#811185}
-
Niels Möller authored
Was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1862449, and needed for relanding of webrtc cl https://webrtc-review.googlesource.com/c/src/+/185122 Bug: webrtc:9378 Change-Id: I73e4203795c6879f989ac2fc722848db55f89ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434926 Commit-Queue: Niels Möller <nisse@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Niels Möller <nisse@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811184}
-
Johann Koenig authored
This reverts commit 67468f66. Reason for revert: causes win-chrome builds to fail: [10171/23886] CXX obj/device/vr/vr/oculus_device.obj FAILED: obj/device/vr/vr/oculus_device.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../device/vr/oculus/oculus_device.cc(65,17): error: no member named 'id' in 'device::mojom::VRDisplayInfo' display_info->id = id; ~~~~~~~~~~~~~~^ 1 error generated. https://ci.chromium.org/p/chrome/builders/ci/win-chrome Original change's description: > Stop sending XRDeviceId with VRDisplayInfo > > This value is not used by Blink, and does not need to be communicated > over the mojo interface. The XRDeviceId enum should not be removed > because it is used for usage stats. > > Bug: 1017477 > Change-Id: I5e8cfff00c374f48495290c5dfb8911a1824a2de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424684 > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Auto-Submit: Brandon Jones <bajones@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810958} TBR=palmer@chromium.org,bajones@chromium.org,bialpio@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017477 Change-Id: Ic5db77eb272086c7e51c900e8f23f722209dedb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434019 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811183}
-
Joel Klinghed authored
Add support for handling an accept filter such as "image/*, image/png" as if it was just "image/*". The Android file selector dialog can only set one type filter so the accept filter contains multiple filters we have to fallback to a generic filter for the selector. However, we can detect overlap, for example "image/*, image/png" can still use "image/*" as a filter without any problems. "image/png, image/jpeg" is handled as before, only when at least one generic type is involved is overlap considered. Bug: 1106651 Change-Id: I9bc74ed18e253b139f7fb7eb456dbc64fba7c3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302751 Commit-Queue: Joel Klinghed <the_jk@opera.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#811182}
-
Maxim Kolosovskiy authored
(in CompromisedCredential*) has_script is going to be divided into |has_script| and |has_auto_change_button|. It will be done in several steps for easier reviewing: 1. The existing |has_script| will be renamed to |has_auto_change_button| (this CL) 2. A "new" |has_script| will be introduced, where |has_script|== |has_auto_change_button|. 3. Implement special logic for the new |has_script|. Bug: 1132230 Change-Id: I684921dc2e4aedaea20ac467c67512915dfa3590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429409 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#811181}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f521921351e..d2f6cc6f606c 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1ba024ed to 30cee4f4 (638 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I02e79dc49f30a26e13ddb7b5c458d04ddd1cf1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434505Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40640de5f50e..77397c4f2930 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0412c0f8d22f8b614caff4a363f433f02d6de626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435248Reviewed-by:
-
Swapnil authored
We have several install creation stage that the force installed extension must go through. We want to add install creation stage event to the existing events for the event based reporting for force installed extensions. This is added to investigate the extensions stuck in CREATED stage. Bug: 1124808 Change-Id: Ifa20a96f6da2078639e98c85362eb51db707cd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421675Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564, not having a sources assignments filter is the default. No behavior change. Bug: 1018739 Change-Id: Ia0f215c50d4381f74e3a5ae8db539312b7f391b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434084Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811177}
-
Alan Cutter authored
This CL updates the preinstalled web app to exclude configs that want to uninstall_and_replace preinstalled Chrome apps that have been uninstalled by the user. Bug: 1123435 Change-Id: I5522523680d4a5a20fa3f1f615bd6b2824692e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425604 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#811176}
-
Leo Lai authored
The comment used to points readers to a deprecated cryptohome client API; corrected it to the right one. BUG=b:158955123 TEST=build ok. Change-Id: I31e99fb8c0b466e04584911ada227af06eaca96f Change-Id: I5e7657d7f02abb7398b639206c0830792de857b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430685Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#811175}
-
Alan Cutter authored
This is a reland of 02f9f701 The original change uncovered an incompatibility with the test profile generated by AccountManagerUIHandlerTest and chromeos::ProfileHelper::IsPrimaryProfile(). This change uncovered it by changing the timing of when it gets called resulting in flaky failures. The AccountManagerUIHandlerTest tests were disabled in the meantime due to flakiness. A follow up CL re-enables the tests and disables the ExternalWebAppManager start up flow such that it doesn't trigger the incompatibility with the custom test profile: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 Original change's description: > Refactor ExternalWebAppManager config loading flow > > This CL splits ExternalWebAppManager's config loading flow into discrete > steps and removes the various testing entry points that omit or > duplicate logic used by the real thing. > > Tests can now inject data (file_utils, config_dir, configs) into the > config loading pipeline instead of having separate mini pipelines just > for them. > > This change is in preparation for adding a new "FilterExtensionIds" step > to the config loading flow. Without this refactor there would be > duplication of logic between real and test code code paths that would be > prone to bitrot and missing real coverage. > > Bug: 1128801 > Change-Id: Ie5e87b26ab47782fab6589a4127df3ea5e876fec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423823 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810025} Bug: 1128801 Change-Id: I345ea879861dd62ee38f4e04a72b968f38e2bb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428539Reviewed-by:
-
Matthias Körber authored
This CL adapts import related tests to work with structured addresses. Change-Id: I6c851d4a4a15714f633eaa4d33f997fd82348a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431946 Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#811173}
-
Asami Doi authored
Previously, the frame only stores the map of ServiceWorkerContainerHosts keyed by uuids. This CL adds a weak pointer of ServiceWorkerContainerHost so that we can keep track of the latest one without uuid. Bug: 1017034 Change-Id: Ifbc31f5f9d26d2d6079cf593a60e6638b8ec771d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409013 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/296dd3b4062e..79c5fa7eebcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I35399b06b2cc7e7ce4e589866efa2ede22c003f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434702Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811171}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6444c825797..131d306fc1d9 2020-09-28 janscheffler@chromium.org [WebAuthn] Disable invalid options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131055 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb542b0b59b2edfcc6a091d55141d6bbdce52f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434700Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: Id6f5ba3f7db83bc7b59e2ca393448c1447ea150a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432086Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#811169}
-
Mitsuru Oshima authored
Bug: None Change-Id: Icdadb57d7a6c9b4ac952dbb68aa6b79f6d9b9484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432425Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the trait collection of the View/ViewController is used instead of the key window as the key window could be wrong with multi window. Bug: None Change-Id: I6704bccc7245e10b30892f88f355505a227a6f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424303 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#811167}
-
Noel Gordon authored
◦ Emscripten has a core github these days: — update links to point to the core github and the .org docs ◦ Document which emscripten version built the piex-wasm release: — builder of last piex-wasm release was emscripten 1.38.27 Bug: 1132695 No-try: true Change-Id: I703e1e7652ddebe98fb4328996fe6835f808f7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435128Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26fef59eda82..40640de5f50e 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I38f43fed760646416c8f679ad0a3f11e67286868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434698Reviewed-by:
-
Nohemi Fernandez authored
Following crrev.com/c/2418576 the CHROME_CONNECTED cookie is added when navigating to accounts.google.com. Chrome previously only sent domain names to the ChromeConnectedHeaderHelper (e.g. google.com) meaning that the URL would never be accounts.google.com. This patch ensures that we send full URLs instead of domain names to ChromeConnectedHeaderHelper so that we can benefit from crrev.com/c/2418576. Bug: 1125631 Change-Id: Ic020cb90cee8764d6d56c72f3143d058d5d5f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426488 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811164}
-
Ramin Halavati authored
"EnableEphemeralGuestProfilesOnDesktop" feature and flag are added to control the ephemeral Guest profiles on Windows, Linux, and Mac. Bug: 1125474 Change-Id: Ie297617f4f2c965c6b90b8cb2ff4f2ff91579c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424153 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811163}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0e7fe4d35baf..4b07d50cd9a0 2020-09-26 antonikarp@google.com spirv-fuzz: Fix bug in TransformationDuplicateRegionWithSelection (#3819) 2020-09-26 andreperezmaselco.developer@gmail.com spirv-fuzz: Support OpNot bit instruction case (#3841) 2020-09-25 afdx@google.com spirv-fuzz: Return IR and transformation context after replay (#3846) 2020-09-24 paulthomson@users.noreply.github.com spirv-fuzz: fix test (#3845) 2020-09-24 afdx@google.com spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) 2020-09-24 ehsannas@gmail.com Start SPIRV-Tools v2020.6 2020-09-24 ehsannas@gmail.com Finalize SPIRV-Tools v2020.5 2020-09-24 ehsannas@gmail.com Update CHANGES 2020-09-24 vasniktel@gmail.com spirv-fuzz: Support dead blocks in TransformationAddSynonym (#3832) 2020-09-24 vasniktel@gmail.com spirv-fuzz: Move IRContext parameter into constructor (#3837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ide53bd1a7338602ee3a5bcbf08a75c210dead45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434425Reviewed-by:
-
Yuki Shiino authored
Supports stopping the old bindings generation of IDL callback functions so that we can enable the new bindings generator. Bug: 839389 Change-Id: Ic84f8b6630d2f77983e551083a93c2de3423f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434184Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811161}
-
Noel Gordon authored
The global object could be window, self or global, depending on the JS environment piex-wasm runs in (Web Page, Web Worker, NodeJS, etc). The |globalThis| object points to the global object in all cases. No change in behavior (for files app), no new tests. Bug: 1132695 Change-Id: I8c6f3d21de29bce63f88352fbe89364d8a76c6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434077Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811160}
-
Raymes Khoury authored
Previously we weren't actually recording launches of Google Photos as we were for other apps. Change-Id: I39deebdf470d91cc787936d15b2f90e18303cd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434123Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811159}
-
