- 14 May, 2018 40 commits
-
-
Jeffrey Yasskin authored
I left one instance of "whitelist" in shared_modules, where it's actually part of the public API. BUG=842296 Change-Id: I63c8533c88801c283af5a6ddca710c2a246ce6bf Reviewed-on: https://chromium-review.googlesource.com/1056027 Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558375}
-
Sorin Jianu authored
The retries are set to 3, as most of the Chromium code using the url fetcher does. Bug: 842364 Change-Id: I0f6e295231c36301c6ca44806233f841d316b58e Reviewed-on: https://chromium-review.googlesource.com/1056222Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558374}
-
Koji Ishii authored
Following CL:986982 that optimizes re-layout for inline by re-using previous items, this patch invalidates the re-use when the resolved direction is changed. The resolved direction is an input to HarfBuzzShaper that such items need to be reshaped. This patch is on top of another invalidation fix CL:1056647 to avoid conflict in FlagExpectations. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic5fd81985db1aa0f05762fda63430d96a632ea89 Reviewed-on: https://chromium-review.googlesource.com/1056648 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#558373}
-
Ben Pastene authored
When a test command is specified, the run_cros_vm_test will run the vm sanity test. This test is baked into the VM and smoke checks the system browser by loading empty pages and running some simple javascript. Since it depends on the system browser, we need to first deploy a locally built Chrome to the VM (via the --deploy arg). The deploy script needs to know the gn args that built the browser to know which libs to copy over. Since we don't have the full set of args at test-time, give it a dummy set of args to trigger the default deploying behavior. Bug: 832374 Change-Id: I84f7fdd94672fcb220eaa4d9625395c1d0ab7636 Reviewed-on: https://chromium-review.googlesource.com/1050981 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558372}
-
Victor Vasiliev authored
Merge internal change: 195841296 Merge internal change: 195910638 R=rch@chromium.org Change-Id: Id9681a3360ced19d329b68e161ff897e17ef43e7 Reviewed-on: https://chromium-review.googlesource.com/1055756Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#558371}
-
nednguyen authored
TBR=charliea@chromium.org NOTRY=true # test covered by CQ Bug: 838504 Change-Id: I8ec5666a5b15df157ec552f06c1504a3592ef482 Reviewed-on: https://chromium-review.googlesource.com/1057954Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#558370}
-
Koji Ishii authored
Following CL:986982 that optimizes re-layout for inline by re-using previous items, this patch invalidates the re-use when LayoutText is moved. LayoutObject::InsertedIntoTree() catches the most cases, but we have an optimization to skip the notification when LayoutObject is moved within the same tree. The inline items need to be invalidated in this case as well, because they depend on context and in which inline formatting context (LayoutBlockFlow) it belongs to. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia65d3e1e948c4eb0079cf81027e84ac5a90b339e Reviewed-on: https://chromium-review.googlesource.com/1056647 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Sandeep Vijayasekar authored
Test: cast_shell_junit_tests Fixes: removes unnecessary code Change-Id: I1debe20ff2cddf6818c2c2861bb77251a56a4118 Reviewed-on: https://chromium-review.googlesource.com/1056169Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558368}
-
Joe Downing authored
This feature controls whether the low-level keyboard hook is enabled when keyboard lock is requested. I wanted to separate browser and system level keyboard lock functionality as I get closer to launching the blink api for keyboard lock. This will allow us to release browser-level keyboard lock w/o the system hooks if needed and will also give us the ability to target a finch kill switch for the system-level functionality if needed. BUG=680809 Change-Id: I2d522046c90fd8776bfb1d9c53978f2c41e1c7cc Reviewed-on: https://chromium-review.googlesource.com/1046154Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558367}
-
Eugene But authored
- use EmbeddedTestServer instead of web::HttpServer - do not assert inside test helpers - inherit fixture from WebTestWithWebState - replace deprecated base::test::ios::WaitUntilCondition with testing::WaitUntilConditionOrTimeout Bug=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e7fbd67193f68fc5575fc529a7ac1f80d89126c Reviewed-on: https://chromium-review.googlesource.com/1055777Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558366}
-
Mark Pilgrim authored
Bug: 842484 Test: CommonNameMismatchBrowserTest.NoCrashIfBothSubdomainsHaveCommonNameErrors Change-Id: I6551dfbc129a544e449040c12a30236c6a57efe8 Reviewed-on: https://chromium-review.googlesource.com/1057417Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#558365}
-
Daniel Bratell authored
Unfortunately there are two i18n namespaces, including one global one, so if you are in ::autofill, referring to i18n is ambigious if the compiler knows about both of them. This happens in jumbo builds which means that my previous jumbo fix here didn't actually work. Change-Id: I7467ff958e93433581da0134d9a6e8ddd21bde49 Reviewed-on: https://chromium-review.googlesource.com/1057728Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#558364}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df79808d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17628 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Ia28c569855eb9bfde15cc3300936177394cb190a Reviewed-on: https://chromium-review.googlesource.com/1057419 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558363}
-
Stephan Stross authored
comparative_tester.py contains the initial comparative testing script, designed to accept a list of test targets, compile and build the targets(and generate them with default args using gn if necessary), build them using ninja and goma, and then execute them, sending targets one at a time to both linux and fuchsia NUCs to be executed. Once a test is completed, its output is filtered for informational lines, they are collated, and written to csv. Bug: 839491 Change-Id: I287470ae9f50f169fbd1d9296c69ee9560318837 Reviewed-on: https://chromium-review.googlesource.com/1031294 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558362}
-
Farah Charab authored
Change-Id: I0ab635c48c63ff68a8aeca1d725904d0f4eb56b9 Reviewed-on: https://chromium-review.googlesource.com/1053774Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558361}
-
Ryan Sleevi authored
//components/certificate_transparency is logically stuff that would belong in //chrome/browser/net ideally, and //net potentially in the much longer term, but for various reasons lives in between. Update the OWNERS to reflect that BUG=none Change-Id: I1046e6cda5b9233d3aa20cabb77f69fe79cbada1 Reviewed-on: https://chromium-review.googlesource.com/1055737Reviewed-by:
Eran Messeri <eranm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558360}
-
erikchen authored
This CL is a refactor with no intended behavior change. Previously, observers were using the |index| parameter and comparing against TabStripModel::active_index() to determine if the detached tab was active. This relies on assumptions about the timing of TabDetachedAt(), which will soon be changed. Bug: 842194 Change-Id: I282bcd42a17701f8f3347d535b2bebfa6d7fd8fa Reviewed-on: https://chromium-review.googlesource.com/1055748Reviewed-by:
-
Corentin Wallez authored
https://chromium-review.googlesource.com/c/chromium/src/+/655801 modified the code tweaking the GPU Info with driver-provided information and added a an ASSERT that didn't exist previously. It gets triggered probably because the driver returns information that doesn't match our SystemInfo. BUG=chromium:842650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife295b97d050814d6173ca96626fe1cc7c4bd3a5 Reviewed-on: https://chromium-review.googlesource.com/1057421Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558358}
-
Peng Huang authored
Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5457797bc7166e9af193c3ff3f248c146833c58d Reviewed-on: https://chromium-review.googlesource.com/1055615Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d936a701..d58b7e0b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5bc1844c2601ac3f373d7b5c071be58252a9c7ec Reviewed-on: https://chromium-review.googlesource.com/1057463Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558356}
-
Bailey Berro authored
Adds username and password as parameters to SmbSerice::Mount and the corresponding internal functions. Bug: chromium:757625 Change-Id: I8e5f9ea4f9779746703d066098408afc4489f620 Reviewed-on: https://chromium-review.googlesource.com/1054690 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558355}
-
Eugene But authored
Wait until the navigation is committed before stopping the load. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f8d65bd2ee6e4a6617257ad83e19cc9a9ba5c2e Reviewed-on: https://chromium-review.googlesource.com/1054707Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/e20f0c4938f8..22c24441a3a4 $ git log e20f0c493..22c24441a --date=short --no-merges --format='%ad %ae %s' 2018-05-14 npm Merge some values of JBig2_Result Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcc8a73f0133d64caa10b840b94e93eca5b24ea5 Reviewed-on: https://chromium-review.googlesource.com/1057690 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558353}
-
Emily Hanley authored
Bug: 840427 Change-Id: I80c13fefb4e5594ad29a6511845415584d7ea11a Reviewed-on: https://chromium-review.googlesource.com/1047854Reviewed-by:
-
Brian Osman authored
There are only 7 ColorFormat values. Bug: chromium:842483 Change-Id: I92e10ed9147b8df607fd5ea62e9a0a5f2300c14c Reviewed-on: https://chromium-review.googlesource.com/1057452Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#558351}
-
Charlie Andrews authored
R=nednguyen@chromium.org Bug: 842232 Change-Id: Idf15bbf2fe41f79b173b79ab5d290002d8ef65c7 Reviewed-on: https://chromium-review.googlesource.com/1057828Reviewed-by:
-
Sarah Hu authored
This contains the fix for Msan failures. This CL adds some basic fingerprint UI to views lock screen to support fingerprint fishfood. The detailed specs are not ready and may be subject to change. So it may need to be polished in the future for adding animation, adjusting styles etc. Current mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw TBR=tsepez@chromium.org Bug: 835357 Change-Id: I5daed01a18b2235e8331c3d48bbfe5b63c491672 Reviewed-on: https://chromium-review.googlesource.com/1047958Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#557254} Reviewed-on: https://chromium-review.googlesource.com/1054091 Cr-Commit-Position: refs/heads/master@{#558349}
-
Michael Giuffrida authored
Adds an ML model to score tabs based on whether they will be reactivated. Currently this is only used in tests; a future CL will add an experiment to use these scores as part of the tab discarder's tab selection algorithm. The model includes hard-coded weights generated by tf.native. This is documented in tab_ranker/native_inference.md. Bug: 836898 Change-Id: I6445de4d80fa5c5c1487d4fa2a90e9f118f9c691 Reviewed-on: https://chromium-review.googlesource.com/1028583Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
James Cook authored
Previously we were using the "root location" as the screen coordinates for events sent to pointer watchers. This was sometimes incorrect on secondary displays. Instead, plumb around the display id for the event and compute the correct screen coordinates in the //ui/views/mus layer. This is needed to get the touch hud app working with the new Window Service on Chrome OS. TBR=tsepez@chromium.org Bug: 608547, 840380 Test: added to views_mus_unittests and aura_unittests Change-Id: I46e90b76ec1562a5277a5679d8a4a9d64fd4333c Reviewed-on: https://chromium-review.googlesource.com/1056205Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Ian Vollick authored
Like bindings, we now recur updating anims if we are or will be seen. Also removes flag to disable truncated treewalks. Bug: 842644 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I26ac8a140c86b3ef223d00677a710709ca207cea Reviewed-on: https://chromium-review.googlesource.com/1057347 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#558346}
-
Emily Hanley authored
Bug: 840427 Change-Id: Icd9263f3f03ef9f38a4bc2fbc52ea5da28e520a2 Reviewed-on: https://chromium-review.googlesource.com/1057435Reviewed-by:
-
Wez authored
This test previously used the WaitingURLFetcherDelegate helper's APIs to run a RunLoop on the main thread, and wait for it to be quit by a fetch completing on the Sequence. However, this violated the constraint that the RunLoop may only be created, run and destroyed from the same thread. Bug: 729716 Change-Id: I4b699d17da7888527ef8d22f8e73a7f91236ef23 Reviewed-on: https://chromium-review.googlesource.com/1056265 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558344}
-
xlai authored
This CL uploads the markdown doc and diagrams. It does not cause behavior change to code. Bug: None Change-Id: Ica44a4a82c8af951b5ad6d79e760ebeb0cceae71 Reviewed-on: https://chromium-review.googlesource.com/1054165Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558343}
-
Dirk Pranke authored
If //build/vs_toolchain.py is changed (or any file it imports, including gn_helpers.py), we should bypass `analyze` on the trybots because we may need to rebuild everything. (Technically, we only need to do this on Win hosts, but we don't have a good way of filtering that at the moment). This is needed when updating the VS toolchain, including SDK updates. This change makes it so that a full build will be requested. The build will be a NOP unless the toolchain has actually changed, in which case the changed command lines will make all of the compile commands dirty. Bug: 842111 Change-Id: I2222798c7c8fd691383a0eca1414d1e8afdb55f8 Reviewed-on: https://chromium-review.googlesource.com/1055869Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558342}
-
Hans Wennborg authored
The test does pass on some bots, e.g. [1], and it's not clear why it was being excluded. If there's a legitimate reason for it not running on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the test to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 Change-Id: Ib7fdf46abf1ddf6b9fdb63c908c1f35040e4d468 Reviewed-on: https://chromium-review.googlesource.com/1057727 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558341}
-
Alexander Timin authored
Do not apply resource load throttling to background pages with active websocket or webrtc connection to prevent breakage and disconnects. Change-Id: Ifd603a2b55cae415b113095df9145217da2b4196 Reviewed-on: https://chromium-review.googlesource.com/1042313Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558340}
-
Bailey Berro authored
The username and workgroup of ChromAD users will now be passed to the SmbProvider Mount function in the smbprovider Dameon. The ParseUserPrincipalName function and corresponding tests are adapted from AuthPolicy's SambaHelper. BUG=chromium:757625 TEST=unittests Change-Id: Ia25396224d9c873161adb2da3741c54cdd1209cf Reviewed-on: https://chromium-review.googlesource.com/1052914Reviewed-by:
-
Sahel Sharify authored
This will be helpful in narrowing down the root cause of wheel scroll issues. Change-Id: Icf0e9e157f7d9a5224652ecc51d99f22008de8fb Reviewed-on: https://chromium-review.googlesource.com/1054495Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558338}
-
Benoit Lize authored
Only sends page load metrics to sessions that are allowed to get them. Bug: 842648 Change-Id: Ifc82941096d02f448af261656811aca4c9097b2b Reviewed-on: https://chromium-review.googlesource.com/1057232 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Joe Downing authored
We've received 3 LGTMs for our blink I2S so I'm enabling the API: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/isXS3f3Tqo8 I am marking the API as 'stable' for M68 and will remove the runtime flag after the next branch point. BUG=680809 Change-Id: If805053651d5ffb3d9963bf176faf9c67dfa5e40 Reviewed-on: https://chromium-review.googlesource.com/1054329Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558336}
-
