GitLab

Recent change caused passphrase dialog to show "On - sync everything" instead
of "Signed in as <email>" on Passphrase dialog on android. I'm reverting this
behavior.

R=maxbogue@chromium.org
BUG=674733

Review-Url: https://codereview.chromium.org/2584973002
Cr-Commit-Position: refs/heads/master@{#439478}

Use use_partition_alloc=false GN arg in Cronet

BUG=674570
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2577173002
Cr-Commit-Position: refs/heads/master@{#439477}

https://skia.googlesource.com/skia.git/+log/a8b1e6d0688c..746cc0b92290

$ git log a8b1e6d06..746cc0b92 --date=short --no-merges --format='%ad %ae %s'
2016-12-18 update-skps Update SKP version
2016-12-17 reed simplify generatescaledpixels

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2580393002
Cr-Commit-Position: refs/heads/master@{#439476}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2580333003
Cr-Commit-Position: refs/heads/master@{#439475}

Sk{Dilate,Erode}ImageFilter::Make take the radii as integers (int), so
make sure to convert the float FEMorphology stores avoiding overflow.

BUG=675164

Review-Url: https://codereview.chromium.org/2585233002
Cr-Commit-Position: refs/heads/master@{#439474}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2588733002
Cr-Commit-Position: refs/heads/master@{#439473}

This is a follow on to: https://codereview.chromium.org/2559213002/ (Add suppression for GPU Pixel test in preparation for Skia CL)

The Skia CL https://skia-review.googlesource.com/c/5747/ (Add antialiasing to SkDropShadowImageFilter's shadow draw) finally rolled into Chrome at 437566 on 12/9/2016.

BUG=672527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573803002
Cr-Commit-Position: refs/heads/master@{#439472}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2587023002
Cr-Commit-Position: refs/heads/master@{#439471}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9c4767f..af5c10c8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2587913003
Cr-Commit-Position: refs/heads/master@{#439470}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2589583003
Cr-Commit-Position: refs/heads/master@{#439469}

Instead of having a 2 seconds timeout, using a combination of setTimeout
of 0 and requestAnimationFrame.

BUG=513398
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2586223002
Cr-Commit-Position: refs/heads/master@{#439468}

For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and battery.

BUG=668052
BUG=606766

Review-Url: https://codereview.chromium.org/2551223003
Cr-Commit-Position: refs/heads/master@{#439467}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2589803002
Cr-Commit-Position: refs/heads/master@{#439466}

This patch fixes a bug introduced by r438239 where the
ui::PlatformEventSource was destroyed before entering the GPU message
loop.

BUG=674350

Review-Url: https://codereview.chromium.org/2584513002
Cr-Commit-Position: refs/heads/master@{#439465}

https://skia.googlesource.com/skia.git/+log/64b70b096ac2..a8b1e6d0688c

$ git log 64b70b096..a8b1e6d06 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 rmistry Revert of Generate Signed Distance Field directly from vector path (patchset #23 id:440001 of https://codereview.chromium.org/1643143002/ )

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2586983002
Cr-Commit-Position: refs/heads/master@{#439464}

Metric added in: https://codereview.webrtc.org/2530393003/

BUG=

Review-Url: https://codereview.chromium.org/2540323006
Cr-Commit-Position: refs/heads/master@{#439463}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2590473002
Cr-Commit-Position: refs/heads/master@{#439462}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2588713002
Cr-Commit-Position: refs/heads/master@{#439461}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2586993002
Cr-Commit-Position: refs/heads/master@{#439460}

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898

Review-Url: https://codereview.chromium.org/2582363002
Cr-Commit-Position: refs/heads/master@{#439459}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/13995c3e..a9c4767f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582353002
Cr-Commit-Position: refs/heads/master@{#439458}

Review-Url: https://codereview.chromium.org/2586173003
Cr-Commit-Position: refs/heads/master@{#439457}

Headless Shell is a command line application so it has a good excuse to
print out console messages.

BUG=546953

Review-Url: https://codereview.chromium.org/2581643004
Cr-Commit-Position: refs/heads/master@{#439456}

Upstream part of Chrome on iOS source code. Nothing is built yet,
just new files added. The files will be added to the build as part
of the last CL to avoid breaking the downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2580363002
Cr-Commit-Position: refs/heads/master@{#439455}

Upstream part of Chrome on iOS source code. Nothing is build yet,
just new files added. The file will be added to the build as part
of the last CL to avoid breaking downstream tree.

BUG=653086

Review-Url: https://codereview.chromium.org/2585233003
Cr-Commit-Position: refs/heads/master@{#439454}

In the resource_prefetch_predictor, the maximum number of concurrent
prefetches is set to 24. This is too high, as:
- It defeats the prioritization of resources in the database
- It was shown to slow down page loads in some case on slow connections
  by starving the page load resource fetches. (local testing using WPR
  and tools in tools/resource_prefetch_predictor)

BUG=631966,655980

Review-Url: https://codereview.chromium.org/2589713002
Cr-Commit-Position: refs/heads/master@{#439453}

This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.

This change also removes the requirement on having {asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.

BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2580313002
Cr-Commit-Position: refs/heads/master@{#439452}

This CL:
1) Adds CategoryRanker interface;
2) Adds a default constant category ranker implementation (based on
   CategoryFactory);
3) Replaces CategoryFactory with a new ranker;
4) Factory methods are moved to Category.

This is the initial step of moving to personalised section order.

BUG=673659

Review-Url: https://codereview.chromium.org/2568033005
Cr-Commit-Position: refs/heads/master@{#439451}

It's unused

BUG=610176

Review-Url: https://codereview.chromium.org/2589653002
Cr-Commit-Position: refs/heads/master@{#439450}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/78033db9..13995c3e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2584393002
Cr-Commit-Position: refs/heads/master@{#439449}

Currently, the update prompt only refers to password manager as "Smart Lock" if
the PasswordBranding experiment group is SmartLockBranding. The save prompt and
both prompts on all other platforms (desktop + iOS) also accept the group
SmartLockBrandingSavePromptOnly.

This CL fixes the Android update prompt to follow the rest.

R=dvadym@chromium.org
BUG=674969

Review-Url: https://codereview.chromium.org/2582613003
Cr-Commit-Position: refs/heads/master@{#439448}

ActiveDOMobjects were renamed to SuspendableObjects.
This CL updates the comment accordingly.

BUG=610176

Review-Url: https://codereview.chromium.org/2584383002
Cr-Commit-Position: refs/heads/master@{#439447}

Revert of Fix webview preloading in zygote. (patchset #1 id:1 of https://codereview.chromium.org/2583913002/ )

Reason for revert:
Realised after the fact that we can't set the process type because the zygote may spawn renderers for Chrome.

Original issue's description:
> Fix webview preloading in zygote.
>
> We weren't setting the process type, which is fetched via JNI during
> JNI_OnLoad. Set it by constructing the LibraryLoader singleton, but
> don't actually call any methods of LibraryLoader, which need to be on
> the right thread, have a Context, have a CommandLine initialised, and
> other setup we can't (or at least, don't currently) do in the zygote.
>
> BUG=
>
> Committed: https://crrev.com/db6be0f685e774c56eef7d03a8ab19736023d8bb
> Cr-Commit-Position: refs/heads/master@{#439213}

TBR=rsesek@chromium.org,sgurun@chromium.org,torne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2586193002
Cr-Commit-Position: refs/heads/master@{#439446}

This method returns the VirtualURL of the current navigation and is used at some
places where GetURL should be used instead.
Remove the method to avoid confusion.
Further CLs will audit which usage should be VirtualURL and which should be URL.

BUG=671964

Review-Url: https://codereview.chromium.org/2581193002
Cr-Commit-Position: refs/heads/master@{#439445}

Downside of this change is that it'll rerun the latest scan after
marking the duplicate files. Though, the second scan is faster than
the first one as it'll not find any new files, thus can skip
de-duplication by content hashes. It may increase the scan time
especially when having large number of files in a media and doing the
"manual copy to Drive" operation like noted in the bug comment.
https://bugs.chromium.org/p/chromium/issues/detail?id=476684#c16

BUG=476684
TEST=manual test as noted in the bug. Confirm content-duplicate files marked as backed up after scan.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564343002
Cr-Commit-Position: refs/heads/master@{#439444}

This CL changes the Share Extension string from "Add to Reading List" to
"Read Later" in order to be consistent with the other usages.

BUG=673689

Review-Url: https://codereview.chromium.org/2574263002
Cr-Commit-Position: refs/heads/master@{#439443}

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920

Review-Url: https://codereview.chromium.org/2572373003
Cr-Commit-Position: refs/heads/master@{#439442}

The comment is too out-dated and I don't understand.
It would be better to remove the comment.

BUG=

Review-Url: https://codereview.chromium.org/2589633003
Cr-Commit-Position: refs/heads/master@{#439441}

In metadata box of Quick View, we show year recorded metadata in mp3
files in any.
This CL also populates track metadata from the metadata in mp3 if any.
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=636191#c22

BUG=636191
TEST=
1. Download a mp3 file from Google Music.
2. Open the file on Quick View
3. Confirm year recorded metadata is shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2581133002
Cr-Commit-Position: refs/heads/master@{#439440}

Use the new Reload() method with a ReloadType from everywhere, and
remove old Reload*() methods.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=bajones@chromium.org, jam@chromium.org

Review-Url: https://codereview.chromium.org/2561983002
Cr-Commit-Position: refs/heads/master@{#439439}