- 03 Feb, 2018 32 commits
-
-
Hwanseung Lee authored
CSSUnitValue.unit should be immutable to prevent cyclic references Bug: 803687 Change-Id: I35f79ec2491277fcb2d02ce85a2e9c6ecd8c3a07 Reviewed-on: https://chromium-review.googlesource.com/897177Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#534237}
-
Steve Kobes authored
These baseline paths are no longer applicable now that the REF is status: experimental (http://crrev.com/533694). Bug: 417782 Change-Id: I9712a2da081252cc1aa159418f40cbc9a0d309d6 Reviewed-on: https://chromium-review.googlesource.com/897824 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#534236}
-
Sadrul Habib Chowdhury authored
Set up a startup sampling-profiler for the compositor thread in the renderer process. Notable changes: . Callback to the RendererClient when the compositor-thread is created. The client uses this callback to set-up the sampling profiler. . Allow the renderer processes to connect to the browser to report the profiler data over mojom. Add the --start-stack-profiler flag to the renderer's cmd-line so that it can initiate sampling profiler. Select every fifth renderer for collecting the profile data from, so that we can still get enough useful data, but don't overburden bandwidth or memory usage. BUG=788808 Change-Id: I478184502a17f4dbb83f03a67a7ef482c92c0a78 Reviewed-on: https://chromium-review.googlesource.com/894848Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#534235}
-
Nico Weber authored
Fixes a bug where middle mouse clicks where ignored when remoting into a Chrome OS device. Also found https://chromium-review.googlesource.com/c/chromium/src/+/899585 Bug: 177475,808537 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I64e259f1e2d2c817364ee9249e72cb24abc395be Reviewed-on: https://chromium-review.googlesource.com/899984 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534234}
-
Kevin Marshall authored
Fuchsia tests run under two layers of virtualization which carries a significant performance penalty. The DiskCacheBackendTest load tests specified values which were too computationally intensive, causing the tests to time out. Bug: 807882 Change-Id: I1f44436a9f0967b072aa9da160b5fc15bc7f730f Reviewed-on: https://chromium-review.googlesource.com/898006 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#534233}
-
rbpotter authored
- Make dialog fixed height - Remove show all button - Improve highlighting speed - Do not scroll search box - Fix problem with footer disappearing Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d19b7fa4b2e8246eb34e8c60d10382688e6a747 Reviewed-on: https://chromium-review.googlesource.com/898347 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534232}
-
Ryan Tseng authored
* recipes.cfg no longer exists here * jbudorick@ approves cq.cfg changes, so it'd make sense if he was an owner. * dpranke@ should be in here too. Bug: Change-Id: I6540c1f6f39c92e76abc301f67987096f50ada95 Reviewed-on: https://chromium-review.googlesource.com/899511 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#534231}
-
Thomas Anderson authored
This reverts commit a3dd29b2. Reason for revert: Causing DownloadContentTest.DownloadAttributeBlobURL to fail on Linux Tests, Linux Tests (dbg)(1), and Linux Tests (dbg)(1)(32). https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/66991 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/47823 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/70044 Original change's description: > Bounce Blob URL revoking through the UI thread to give navigation a chance. > > Navigation IPCs are handled on the UI thread so if a blob URL is revoked > immediately after navigating the revocation will almost always happen before > the navigation code has had a chance to post a task back to the IO thread to > actually perform the request. With this change revocation is hopefully > delayed just long enough to make navigation work again. > > Bug: 807639 > Change-Id: I2afde86dd203c61cbb03cc02ac62ec21c7e7d704 > Reviewed-on: https://chromium-review.googlesource.com/899666 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534119} TBR=mek@chromium.org,jochen@chromium.org Change-Id: Ia460136d52f214d3d2914a8004ebe65c87e90bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807639 Reviewed-on: https://chromium-review.googlesource.com/900442Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534230}
-
https://chromium.googlesource.com/native_client/src/native_client.git/+log/476698afdd0b..b48266b051f5 $ git log 476698afd..b48266b05 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 dschuff PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS 2018-02-01 dschuff Update gsutil used by gsd_storage on the buildbots 2018-02-01 dschuff Fix CMake C_COMPILER_LAUNCHER command 2018-02-01 dschuff Update Goma command for toolchain host build Created with: roll-dep src/native_client BUG=none The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I8eb7860327e6d0b72ce5c775bc0201be904a2f1b Reviewed-on: https://chromium-review.googlesource.com/899958 Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534229}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d5f22ce9d6f..3a998d1b232f $ git log 5d5f22ce9..3a998d1b2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4a2b41468c3611b57f8758f7824119ae249abe5b Reviewed-on: https://chromium-review.googlesource.com/900292 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534228}
-
https://pdfium.googlesource.com/pdfium.git/+log/bbeb10daef8b..b1d7872faacb $ git log bbeb10dae..b1d7872fa --date=short --no-merges --format='%ad %ae %s' 2018-02-02 thestig Teach the presubmit check to look for checkdeps in other places. 2018-02-02 thestig Remove third_party/build/build_config.h. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb5eca6dc20419a3aec04d1777e87421e178f95f Reviewed-on: https://chromium-review.googlesource.com/900313 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534227}
-
Stefan Zager authored
BUG=808341 R=skobes@chromium.org Change-Id: I298ffd2134ec5021682bc443a5c6a9ba4a9cc13c Reviewed-on: https://chromium-review.googlesource.com/899928Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#534226}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f936675..ac7384b3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3968c6930e40e08e22f70186c9938c30e478ca1d Reviewed-on: https://chromium-review.googlesource.com/900245Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534225}
-
Tim Brown authored
This is to simplify our status icon code. Ubuntu Zesty has been EOL'd, so that has been removed too. Bug: 799144 Change-Id: I325144461a330b6321a087e4357e9033d7fdd880 Reviewed-on: https://chromium-review.googlesource.com/899867Reviewed-by:
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7da1eb6af56c5a6dbf6c8c6ea73d1e738df26de0 Reviewed-on: https://chromium-review.googlesource.com/898203Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534223}
-
Bence Béky authored
This will be used by HttpStreamFactoryImpl::Job to find a SpdySession that supports Websocket over HTTP/2. Bug: 801564 Change-Id: Idac6a13743094c59a7ffa2a43e1fed7554361dd8 Reviewed-on: https://chromium-review.googlesource.com/896982 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#534222}
-
Jinsuk Kim authored
In preparation of moving the class ContentView out of content, this CL makes the interface SmartClipProvider implemented by ContentView public, and updates dependencies accordingly. With this change, ContentView doesn't use non-public class any more. Also found that there's no embedder using the public interface SmartClipCallback. So deleted it. Bug: 807155 Change-Id: Icac5956ccab217095d2216d65176e2e0d1665184 Reviewed-on: https://chromium-review.googlesource.com/894967Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#534221}
-
https://webrtc.googlesource.com/src.git/+log/cc7125f2400b..8eca1ff5107e $ git log cc7125f24..8eca1ff51 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I825d48a891f789647b25b1501bf87759e7065c0b Reviewed-on: https://chromium-review.googlesource.com/899652 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534220}
-
Menglu Huang authored
Change-Id: Ice14942fc6f16198a62d6aaa15d1ba5a80f9c040 Reviewed-on: https://chromium-review.googlesource.com/896369 Commit-Queue: Menglu Huang <huangml@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534219}
-
Peter Boström authored
Bug: chromium:807886 Change-Id: I1050d89178fb6682cafa3a03327a9c1245203b26 Reviewed-on: https://chromium-review.googlesource.com/900064Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534218}
-
Peter Boström authored
Also removes a stale promo string that has been replaced. Bug: chromium:807886 Change-Id: I63d64ec65573eb2742fcb59cea790a720fae0a41 Reviewed-on: https://chromium-review.googlesource.com/900053Reviewed-by:
-
Miguel Casas authored
Gpu FeatureInfo::FeatureFlags.chromium_image_xr30 doesn't work on Swiftshader because it doesn't support GL_BGRA(_EXT) for glImage2D(), making our texture uploads fail. This failure is legit because GLES 3.0 supports only GL_RGBA data format. So this CL disables chromium_image_xr30 until the swiftshader bug is addressed (adding a TODO), and also corrects the OpenGL version where GL_EXT_texture_type_2_10_10_10_REV was inlined, which is 3.3 and not 4.2 as I wrote erroneously before, oops! (see http://go/gl3.3) Bug: 808172, swiftshader:95 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0c6952b14ff53fb504bf292c51a8bc2ffe612918 Reviewed-on: https://chromium-review.googlesource.com/899462Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#534216}
-
Jeffrey Kardatzke authored
This allows desktop capture to also include the mouse cursor without having to induce a separate compositing stage for desktop capture itself. Bug: b:38452042 Change-Id: Ibfa75454ef44b8329d643dcfcc94a1b7b65018e4 Reviewed-on: https://chromium-review.googlesource.com/899606 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#534215}
-
Min Qin authored
This CL is the ongoing effort to make download a standalone component BUG=803135 Change-Id: I0b4c740d3785712b7106026cb624c29db0e6fcfb Reviewed-on: https://chromium-review.googlesource.com/897967Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534214}
-
Bin Zhao authored
We are moving DIAL sink query logic from extension side to browser side. Added a feature to enable/disable in-browser sink query. - Added EnableDialSinkQuery feature - Added enable_dial_sink_query field to MediaRouteProviderConfig in media_router.mojom Bug: 779892 Change-Id: Ib05013b1124f22a45a3647765f026f20614e8d4f Reviewed-on: https://chromium-review.googlesource.com/896265Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534213}
-
Christian Fremerey authored
A previous CL [1] added feature switches for determining if the video capture service is supposed to run in a dedicated process or in the Browser process. This CL adds the code for registering the video capture service as an embedded service for the Browser process. It uses a task runner from the base Task framework via base::CreateSingleThreadTaskRunnerWithTraits() in order to have the service methods execute on a thread that allows blocking IO. [1] https://chromium-review.googlesource.com/c/chromium/src/+/759412 "--enable-features=RunVideoCaptureServiceInBrowserProcess,MojoVideoCapture", navigate to https://webrtc.github.io/samples/src/content/getusermedia/gum/ and verify that video capture works. Shut down Chrome and verify there is no crash or DCHECK triggered. Tested and confirmed working on Android, Linux, and Windows. Test: Run chrome with flag Bug: 792621 Change-Id: I404e9f2bca14c238b5969e680a38dc004a815486 Reviewed-on: https://chromium-review.googlesource.com/894443 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#534212}
-
Saman Sami authored
This reverts commit a438b798. Reason for revert: Causes crbug.com/808282 Original change's description: > content: Send ResizeParams in ViewMsg_WasShown > > Don't send any WasResized messages when the RenderWidgetHostImpl is > hidden, and once it's visible, send the ResizeParams along with the > WasShown message. When a WasShown message that has ResizeParams > arrives in the renderer, the resize will be performed before setting > the visibility to true. This CL makes it easier to send a new > LocalSurfaceId to an evicted background tab when it becomes visible. > (Allocating a new ID will happen in a subsequent CL) > > Bug: 777881 > Change-Id: Ibbc1a3604fb93806059d6beb3e51872f5aeaad4c > Reviewed-on: https://chromium-review.googlesource.com/894262 > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533357} TBR=fsamuel@chromium.org,tsepez@chromium.org,piman@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 777881,808282 Change-Id: I71691467ef1868042d43bc4280bb55a0d71e859d Reviewed-on: https://chromium-review.googlesource.com/899924Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534211}
-
Xianzhu Wang authored
Previously subframe printing was not testable in layout tests. We had to create ManualTests to test subframe printing, but it's hard to maintain. Add testRunner.setPrintingForFrame(frame_name) to allow testing subframe printing. This won't automate testing of anchor printing though, because location of anchor is invisible. That still requires viewing the generated pdf file. R=dmazzoni,bokan TBR=dmazzoni@chromium.org (already lgtm'ed) Test: printing/print-subframe.html Bug: 808219 Change-Id: I1f927c5ea500a6da8fe558139433b7d548bc2e2e Reviewed-on: https://chromium-review.googlesource.com/898244 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534210}
-
Zhiling Huang authored
Bug: 726431 Change-Id: Ia8b6e3ccbf2f66b1038c6a15be03899367859965 Reviewed-on: https://chromium-review.googlesource.com/896570Reviewed-by:
-
Ryan Hamilton authored
This reverts commit 1e31ca06. Reason for revert: v41 is going to be deprecated Original change's description: > Enable QUIC v41 by default > > Change-Id: I12c2ce5551bcd2630af75ac9e9f6e15758c3a7e6 > Reviewed-on: https://chromium-review.googlesource.com/889639 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Buck Krasic <ckrasic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532785} TBR=rch@chromium.org,ckrasic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I932329a83dc70e7da7ba8750a87e4e7e71cd544a Reviewed-on: https://chromium-review.googlesource.com/900102Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534208}
-
https://chromium.googlesource.com/catapult.git/+log/ec32a8f0bee7..f601e519d114 $ git log ec32a8f0b..f601e519d --date=short --no-merges --format='%ad %ae %s' 2018-02-02 simonhatch Dashboard - Associate bisects with the alerts they were started from. 2018-02-02 eakuefner [Metrics] Switch RHB in loading_metric to RNM Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9d4ece8cfa180bc9910f3a6ee652cb95f137f2e2 Reviewed-on: https://chromium-review.googlesource.com/900139Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534207}
-
Ryan Tseng authored
Bug: 731552 Change-Id: I4fc33ca2343d180d7920992ab4a7b5d3cadc7657 Reviewed-on: https://chromium-review.googlesource.com/899872Reviewed-by:
-
- 02 Feb, 2018 8 commits
-
-
Daniel Cheng authored
Prior to C++17, it's not defined if the LHS or RHS of an assignment is evaluated first: the only that's defined is the evaluation of the LHS and RHS happen before the assignment. Bug: 805881 Change-Id: Ieece0dd53f174d82a8e32ff41418e894f0c27ddd Reviewed-on: https://chromium-review.googlesource.com/899948Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534205}
-
Daniel Cheng authored
Bug: 805881 Change-Id: I29434a3e34a816412696188674ae9ecf47e6fed6 Reviewed-on: https://chromium-review.googlesource.com/899945Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534204}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ff23b06. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11528 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibe46494f52534ad2da439936157d29b07e83c547 Reviewed-on: https://chromium-review.googlesource.com/899468 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#534203}
-
Miguel Casas authored
Minor cleanups around GVAF & co: - const/constexpr - early return - use = default iso {} [1] Otherwise no new code, unit tests and such should cover it all. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/qgU4mh_MpGA Bug: 803975 Change-Id: I7a14a28a3b7ee3703885e40ec0829cc6b4453592 Reviewed-on: https://chromium-review.googlesource.com/897707 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534202}
-
Mike Dougherty authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia4cdf1f83336fc4f1c5b8dff8891e323ad4c0a14 Reviewed-on: https://chromium-review.googlesource.com/883042 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534201}
-
wutao authored
This cl implementation allows the client to provide custom views to styled label and set the horizontal alignment. Features: 1. The client can provide any view. 2. The client can set the horizontal alignment. 3. All views in a line are center aligned. 4. The custom view is one unit, cannot be wrapped into different line. 5. If width is not wide for the custom view, the custom view will be cutoff. bug. Bug: 793414 Test: Tested with different views and layout. Examples are posted in the Change-Id: Icf7d70da812c9e40362e20cbc30dc118cdf6d77b Reviewed-on: https://chromium-review.googlesource.com/888543 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534200}
-
Christian Fremerey authored
In Issue 807887, ClusterFuzz provided a very useful stack trace demonstrating a use after free, which is likely the same as Issue 777608. Root cause was a Mojo connection error getting invoked on a base::Unretained() pointer to a deleted object. I added a unit test case the reproduced the issue before the fix. There are two possible fixes. 1. In ~DeviceMediaToMojoAdapter() call Stop() in order to reset the connection error handler before it gets invoked. 2. Use base::WeakPtr. I am opting for option 2. because seeing/proving that solution 1. is effective is unreasonably complex and also requires more code. Test: services_unittests --gtest_filter="DeviceMediaToMojoAdapterTest.*" Bug: 807887, 777608 Change-Id: If42094796fbb095caccad7af9f72263b1d5f3ed6 Reviewed-on: https://chromium-review.googlesource.com/898256 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constant twice with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch inlines the constants in chrome_visibility_observer.cc and desktop_session_duration_tracker.cc. Bug: 746957 Change-Id: I1b7d4b2f4a83a8a75c248f07199af6f4e72e87f5 Reviewed-on: https://chromium-review.googlesource.com/897533 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#534198}
-
