- 23 Sep, 2020 10 commits
-
-
manukh authored
This feature was meant to autocomplete suggestion titles. It was fairly limited and was superseded by RichAutocompletion. This CL remove the code, feature, & flag associated with AutocompleteWithTitle. For reference, the CL implementing this feature: crrev.com/c/1711634 . Bug: 549677 Change-Id: I1da4e4ec744a3d1e2bdadf455991b3376c0ad82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417490 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809598}
-
Olivier Yiptong authored
This change consolidates the cache building code in the base class: FontEnumerationCache. Aside from being the right thing to do, this will allow for easier finalization features e.g. the sorting of fonts before caching, and any finalization step. Bug: 1043306 Change-Id: Ie43885a376e3412157799c0e1c2dbcf7576c45f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422456Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#809597}
-
Scott Violet authored
This allows tracking the scrollTop of the page. BUG=1109035 TEST=covered by tests Change-Id: I34dd29cacb2569704176d8d3027347cdbd9be734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422650 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809596}
-
Bailey Berro authored
This change defines and implements the SystemDataProvider interface. This interface will be used by the Diagnostics App to provide telemetric information about the system. go/cros-diagnostics-dd - Creates mojo interface for SystemDataProvider. - Implements GetSystemInfo() method. Additionally functionality to be implemented in follow up CLs. - Will be called by Diagnostics UI in a follow-up CL. Bug: 1128204 Change-Id: If2a490b2a91dd9a0627f28dc523d195d4f148b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402183 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#809595}
-
Eric Orth authored
Fixed: 1085384 Change-Id: I698840ca0d6cc283f2634ae3e3a53aadd9fb5fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416887Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#809594}
-
David Roger authored
This CL adds the histograms: ProfilePicker.StartupTime.BeforeCreation: time between Chrome startup and ProfilePickerView::Display(). ProfilePicker.StartupTime.FirstPaint: time between web view creation and first paint. ProfilePicker.StartupTime.MainViewInitialized: time between web view creation and javascript initialized. ProfilePicker.StartupTime.WebViewCreated: time between ProfilePickerView::Display() and web view creation (includes system profile initialization). Bug: 1063856 Change-Id: I70612bec4daed2384a4f82713abb2140e98b7ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412334Reviewed-by:Jesse Doherty <jwd@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809593}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I93b526a4105bfc4c313b19d2cb006f375b005ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424516Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#809592}
-
Richard Li authored
Tone mapping is a necessary process for playing HDR video in accurate color. This CL pass HDR metadata through VideoFrame->YUVVideoDrawQuad-> DCLayerOverlay->DCRendererLayerParams at the end to SwapChainPresenter. VP will do tone mapping when receiving proper HDR metadata. Bug: 1122910 Change-Id: Ie72fff2744de4ace3e8b6b77594d3aa21b4c18bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397001Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#809591}
-
Alexander Alekseev authored
This CL updates description of Launch.FlagsAtStartup and Login.CustomFlags to better describe what they do. It also makes both of them never expire. Bug: 1130121 Change-Id: I2b744e70419127358a639d73a4116d7ba0cd7058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424552Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#809590}
-
Robert Ogden authored
Bug: 730587 Change-Id: I7985b8ce16d4d63af643cd084993e2589e563ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425204Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#809589}
-
- 22 Sep, 2020 30 commits
-
-
Zentaro Kavanagh authored
- Simplifies implementing fake observers - Currently only supports a single observable value Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Idcddbbe30e220ecab8e7218450630062fb69c8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420769Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809588}
-
Eric Orth authored
Fixed: 1107800 Change-Id: Idf182da4b57b667a33410d78b2f356454237e629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417250Reviewed-by:
-
Allen Bauer authored
Bug: 938501 Change-Id: Ie2633c0062b957bcead52fc8e507105394591122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424515 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#809586}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If17328c857dc51d92921e7d9a6d318e72402486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809585}
-
Haiyang Pan authored
This reverts commit 1de470a5. Reason for revert: Likely caused a lot of test failure due to StrictMode. An example build is https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27067 Original change's description: > Android: Remove StrictMode usage from //chrome > > Removes direct usage (StrictModeContext left for follow-up) > > These suppressions are safe to remove now that StrictMode handling in > chrome has been switched to a filter-based approach. > > Bug: 1038384 > Change-Id: I59ee33bd1e34249c6be7973e5d759007ec0b2533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410537 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809402} TBR=agrieve@chromium.org,pkotwicz@chromium.org Change-Id: I6277029a7154c53d2ea1bc0f4d7cc6b9aacb0e62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424989Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#809584}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9ff58ddd0adf..b44af6625286 2020-09-22 courtneygo@google.com Vulkan: Fix racy access to VkPipelineCache 2020-09-22 cclao@google.com Vulkan: Add a alpha to coverage test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I81513cb6f9443f73f870fc140f4990dec22f64a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424727Reviewed-by:
-
Angela Yoeurng authored
Bug: 1129612 Change-Id: I5f3ac715e136a616f2cdd6c9906c1f7cd5998a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422481 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#809582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/041c9519..7b2a8dea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf5888c212c4dde93c7da86a98c1960a9e7e59b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424074Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809581}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5638cdb0e9556a9030f3a04b6c5c0420cec3a5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420570Reviewed-by:
-
Patrick Noland authored
The existing code mistakenly sets the ThemeColorProvider to the TabThemeColorProvider, which is wrong for CustomTabToolbar, and is redundant considering we now constructor inject it. Bug: 1128337 Change-Id: I8c2e7c402d433a56f14218c1cdbe46554dcf13fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422340 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#809579}
-
Darwin Huang authored
This reverts commit 54ad18ef. Reason for revert: fuchsia-x64-trunk compile failure, closing trunk. First failure: https://ci.chromium.org/p/chrome/builders/ci/fuchsia-x64-trunk/49414 Bot: https://ci.chromium.org/p/chrome/builders/ci/fuchsia-x64-trunk Original change's description: > [fuchsia] Exclude SwiftShader and Vulkan libs from CastRunner. > > Removes large libraries that were pulled in as a result of an indirect > but necessary dep on Blink. > > The exclusions can be removed along with the Blink MessagePort > dependency, once a fix for crbug.com/1126571 lands and is > integrated with NamedMessagePortConnector. > > Bug: 1131102 > Bug: 1126571 > Change-Id: I7b25d50470d667f44424b925d3982efa268c24ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424512 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809544} TBR=wez@chromium.org,kmarshall@chromium.org,fdegans@chromium.org Change-Id: Iccd0f471883dbe13535dfa63989100c3d26c3bdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131102 Bug: 1126571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424804Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809578}
-
Allen Bauer authored
Update metadata and builder for the views::Button class. Bug: 938501, 1130078 Change-Id: Iac9c92d39bdb2a1ec0619c8a062f0cc9421fca1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419388 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#809577}
-
Henrique Nakashima authored
The device module is a "higher level flags" target, which dictates if broader features should be turned on or off based on the device, command line, and some feature flags. Change-Id: I9842eb8236966af5308bcc29c0ca0ccd1315d812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382670Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#809576}
-
Maggie Chen authored
Clip the surface damage rect before adding it to |damage_rects_union_of_surfaces_on_top_|. This is how we produce |root_damage_rect_|. Bug: 1117235 Change-Id: I83b11d2b79490fd072c3bc5484f7cb38a43f2037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412634 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#809575}
-
Josiah K authored
(Fixing accessibilityPrivate.on* names to only be used for events 2/3) No functional changes - should be mechanical only. AX-Relnotes: N/A Change-Id: Ie31e44e0cdcce932865f2039c4cac5f9b6f9cb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422651 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Mark Pearson authored
Change-Id: Ic21b4ca4f360c391e28d15251a325468f8c4a815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424686 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
This CL updates the lookalike interstitial to use the safety tip allowlist instead of its own allowlist. The original allowlist was tab-specific, versus the safety tip one, which is profile-wide. This paves the way to also possibly persist the allowlist in the future, too. This is a very minor change on the interstitial, but required some minor rewiring for Safety Tips. All on-close metrics are now recorded by the OnSafetyTipClosed callback. This is probably better anyway (or at least more uniform). Bug: 1122139 Change-Id: I91a4aa8f03dea3a65b74b389cb216c35511fd23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422471 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809572}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/187b04b35777..a5f3c3149033 2020-09-22 johnstiles@google.com Create VariableExpression struct for referencing inlined variables. 2020-09-22 robertphillips@google.com Fix a GrThreadSafeUniquelyKeyedProxyViewCache test 2020-09-22 johnstiles@google.com Fix crash when swizzling a bvec with constant 0/1s. 2020-09-22 johnstiles@google.com Add unit test for swizzling booleans. 2020-09-22 jvanverth@google.com Make sure we release all refs in GrD3DTextureResource::releaseResource. 2020-09-22 nifong@google.com Reland "include freetype in wasm build, see cl/332073924 for complete change" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: I29fcd563fd7a41cad16def0f695978fe4039bc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424971Reviewed-by:
-
Mike Dougherty authored
This metric was used to validate the feature when it was added but are not required to be monitored long term. There is still a UserAction in place for the opening of chrome://inspect. Bug: 1088882 Change-Id: I09808825c3a43f54829e620a95ba5246ca0ee1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421432Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809570}
-
My Nguyen authored
Remove dialog based on UX review feedback (see question 4 in http://go/cros-lang-settings-ui-review-reply) Current view: http://screen/BV97nrhiu94mME6 Bug: 1113439 Change-Id: I0865a9d6385661e99c1d560db446904b47c9d31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423824Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809569}
-
David Bertoni authored
This test was disabled a long time ago, with a comment that it was broken by a related change. This test seems to work now, so I've enabled it. The related bugs seem to indicate the feature is no longer planned, so perhaps this test be removed, per the comment, if it's not really testing anything worthwhile. Bug: 159932 Change-Id: I36950024b8448c56e669c371380a3daf450e96f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414772Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809568}
-
Christopher Cameron authored
There exist separate tolerances for desktop ARM64 (Windows and Fuchsia) already. They are needed for macOS as well. Bug: 1128443 Change-Id: I93b14ea6acf26c1d1aea6748134988690fa9990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424712Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#809567}
-
Sebastien Marchand authored
Bug: 1131200 Change-Id: I04b3fce954c66a2e7299d1e7cfa102754f1dc459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425126 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Daniel Classon authored
Refactors the stub device sync to fix a conflict with the fake device sync (used in testing). Renames SetForTesting method to reflect it being used in non-testing code. Enables the use of stub device sync when in Linux CrOS, i.e. while running on emulator. Fixed: 1085459 Change-Id: Ib075405e39d323a9e04954f0dfb7a6259136da87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406855 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Darwin Huang authored
This reverts commit a099d2db. Reason for revert: NewTabPageModulesDummyModuleTest.All failing. bot failures on linux-chromeos-chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8711 Original change's description: > [ntp][modules] Disable dummy modules in NTP for official build > > Bug: 1130814 > Change-Id: If8d93fb7c134637f399735637ff031abbe31ebc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411671 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809463} TBR=tiborg@chromium.org,aee@chromium.org,yuezhanggg@chromium.org Change-Id: I4537af0a34a5cc61a1f7b228a5047127862e2a0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425207Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/679e180840fc..efa0f60c03cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1130885 Tbr: huangdarwin@google.com,lgrey@google.com Change-Id: Ief9da4602418d30a7ccd77316e12700370225861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424726Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809563}
-
Collin Baker authored
SetNextFocusableView() doesn't update previous_focusable_view_ on the pre-existing next view in the focus list. As a result, it is easy to run into situations where v->GetPreviousFocusableView()->GetNextFocusableView() doesn't return v, which is clearly wrong. SetNextFocusableView() is inherently unsafe since all callers must ensure they don't break the list. This CL replaces it with safe routines. Bug: 928905, 942478 Change-Id: I26338ad592225b1a3ea04b3d1368288e0dc56bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033665 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#809562}
-
David Black authored
Per change in product requirements, the "Copy to clipboard" context menu command is now "Copy image" and will only be shown for holding space items which are backed by an image file. When executed, "copy image" will read, decode, and write the backing file's image contents to the clipboard buffer so as to be available to the user for pasting. Bug: 1126274 Change-Id: I4575589c01fd5702cbefae0d5830362269df7e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419920Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#809561}
-
Michael Thiessen authored
Reland as 3-sided patch to avoid downstream break. Original change's description: > Migrate NavigationHandle from String URLs to GURL > > Migrates NavigationHandle to use GURL internally and adds getUrlString > for callsites that still need URLs to be a string (to be fixed in > followups). > > Some unit tests needed to be moved to Instrumentation tests, one > requiring a change to CriteriaHelper to allow checking for a condition > after every task. > > QualityEnforcerUnitTest was too difficult to migrate to Instrumentation > tests, so it now uses JUnitTestGURLs to use GURL in junit tests. > > Bug: 783819 Bug: 783819 Change-Id: Ic2043b8e871a4cb8a6d59ed7d6334486bd7ebe59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424986Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#809560}
-
Joel Hockey authored
RunArcExternalProtocolDialog takes a callback rather than creating the ExternalProtocolDialog directly. This is to allow further logic to be added consistently in the case where arc does not handle the URL. Bug: b/168506505 Change-Id: I82e74112870cb727e46b0a3ab987e7117a4ac7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423067 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
-
