- 01 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98218e9219b1..d628ffbd8f1d 2020-10-01 kimstephanie@google.com Revert "Reland "Add optional enforce_fetch kwarg to fetch and refresh git cache"" 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-10-01 kimstephanie@google.com Reland "Add optional enforce_fetch kwarg to fetch and refresh git cache" 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8c085d09143677063ca31c5a7dd11518a3cd184e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812913}
-
harrisonsean authored
Add overall interaction metrics (with actions) and individual metrics for each of the checks. Bug: 1078782 Change-Id: Ic778e9ef54e9f358e28eab5b4b7ac30a7ad5d99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442531Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#812912}
-
Chan Li authored
Bug: 1108016 Change-Id: I1d394ec317ec1674905c1dfd92e83e5547d033fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441737Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812911}
-
Steven Valdez authored
This change plumbs the protocol_version and id from the key commitment to allow it be used to determine what crypto method to use and to include in requests via the Sec-Trust-Token-Version header. Design: https://docs.google.com/document/d/197OckoDGNe9-gSlB3dq9bufYoVimuFdon80ERHgK87E/edit# Change-Id: If7e06fa7ce74d7584230566898db74528d843c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425432 Auto-Submit: Steven Valdez <svaldez@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812910}
-
Dave Tapuska authored
Change to use gfx::Size over WebSize for WebWidget. Use MainFrameViewWidget instead of the public API MainFrameWidget where available because then we will be able to remove APIs from the public blink API but still allow the internal tests to access WebViewFrameWidget APIs. BUG=738465 TBR=jbroman@chromium.org Change-Id: I48417ad4803153564c8b26d2c4b24cd9e8bc31a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436582 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812909}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Iac8393f186ce16b126543906b0f3260cf159f14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442502 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812908}
-
Azeem Arshad authored
This CL addresses issue with "Other" APN values getting erased when changing APN options. This is fixed by saving APN value that are not in the APN db to the pref store. This list is made available in cros_network_config mojo api as a new custom_apn_list property. This also fixes issue with "Other" apn text fields getting overwritten because of managed property changes. Bug: b/167297672 Change-Id: I0ffb497be6d274eba99835f56c79e2d4a3004639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435978 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812907}
-
bttk authored
Only changing files related to ToolbarLayout. This correction came when moving LocationBarPhone.setUrlFocusChangePercent to the LocationBar interface. The move of the method will depend on this change. Bug: 1133482 Change-Id: I222175e8c39b39a75d87a05a3993d6c3cdae1bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439109 Auto-Submit: who/bttk <bttk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812906}
-
Brandon Wylie authored
Currently ToolbarManager pokes at LocationBar from the observer there. Instead, LocationBar now observers the service directly and the interface method can be removed. Bug: 1132073 Change-Id: Ie56487252c4142f78f618fe6cb7c93ab173d6a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441682Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812905}
-
Alex Newcomer authored
For clipboard history, only render img or table tags when a new flag is enabled. This flag will be enabled via finch at a later date so we can compare usage. Bug: 1131691 Change-Id: I21aa05c4daa5a80f0037c8507e0e32eda1f04bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441258 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812904}
-
Mei Liang authored
This is a follow up of crrev.com/c/2442479. This CL early returns when TabModelFilterProvider().getTabModelFilter() is not a TabGroupModelFilter to avoid the casting exception in TabGroupUiCoordinator.recordSessionCount(). This CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchPolishEnabled. Bug: 1133922 Change-Id: I830b6721e15b6ca558e79b66dcd7a1b783186f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443395Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812903}
-
Xinghui Lu authored
Regression is still seen at 50% Stable: http://uma/p/chrome/variations?sid=a3d201c28d29aab0568c58c18fca2e40. Currently 85% of get token requests finish within 50ms. http://uma/p/chrome/histograms?sid=1c472f87b67d1fe3197bdde7cb56db0e Waiting for a full second for acquiring tokens is too long. We should use an empty token if the token cannot be acquired in 50ms. In this CL, reduce the get token timeout to 50ms to see if it mitigates the issue. If the issue is still there, we will look into other solutions such as fetching the token in the background. Bug: 1070324 Change-Id: I744c775e88162b9c8814bf4a4efab98085c94da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442010Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812902}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ca55b2704b0f..cdeac3d48653 2020-10-01 jophba@chromium.org Duplicate sources for standalone_receiver e2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id5b8fd7d61b852363241cbc628a53c267862781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812901}
-
Garrett Beaty authored
Change-Id: Ic04dbb979d49437347ccb46e31f134b826165dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432860Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#812900}
-
Jeffrey Young authored
Useful for testing ambient mode on development builds. BUG=none Change-Id: I014797dcce9a2ffe62e80e6df196f50d243de8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443510Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#812899}
-
Trevor Perrier authored
This reverts commit 78a5b827. Reason for revert: Pinpoint identified startup time increases because of this. Need to put all logging behind flags. https://crbug.com/1134079#c6 Original change's description: > [Android] Add logging for AppLocaleUtils > > This CL adds some simple logging in AppLocaleUtils to observe what > language splits are available to the application and what the override > locale should be. > > Bug: 1128698 > Change-Id: I925cd84d384602e2f0beedd63ecd551f87c24b09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440976 > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812522} TBR=sclittle@chromium.org,megjablon@chromium.org,perrier@chromium.org Change-Id: I957ab8aeb01ae21b772e332941cb95e06a7f80ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128698, 1134079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443217Reviewed-by:
Trevor Perrier <perrier@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#812898}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601553580-dedfc7e09ce8d42299369759d9da080930ec4031.profdata to chrome-mac-master-1601575120-30d2ff52ccba123fa446e04afa93e5dc42388f0f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia29a4ca5b58570ff81e7e318952767d3529ae167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812897}
-
Jeffrey Young authored
BUG=none Change-Id: I84e392bf47da6641e266f7568c1da80ec154b127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441264Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#812896}
-
Daniel Rubery authored
Responses served from the cache follow a very similar code path to responses from the server, but we probably don't want to treat them the same in metrics, so this CL breaks the metric in two. Change-Id: I80fc9ebbfa8afc39237dc57727f13f5be68cabcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438889Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812895}
-
Yusuf Sengul authored
Bug: 1133036 Change-Id: I9a24db72f8f111c4509dc874aa1de5b44b6f4e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436780 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#812894}
-
wutao authored
This patch sizes the preview to cover the img element while keeping the aspect ratio. Bug: b/169434370 Test: manual Change-Id: If54cd536d037e1cc9a6a75335fe1ea7e93d24a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442488Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#812893}
-
David Black authored
Holding space views are failing to repaint when being updated async. Bug: 1134284 Change-Id: I573e44f4256d11a437d5c7a239ed48553443787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443451 Commit-Queue: David Black <dmblack@google.com> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#812892}
-
Kartik Hegde authored
Add new util functions needed by HttpsLatency routine. BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsUtilTest* Change-Id: Ieae113b0df25f6b55658d701fd4b39b81948bd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442329 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812891}
-
Yann Dago authored
This new policy allows to periodically cleans some browsing data. Bug: 1026442 Change-Id: I33f1d4f8b462b89de54ecdb0a35230b5ed2ec3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324203 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812890}
-
Nate Fischer authored
This adds the java_cpp_features GN rule to autogenerate Java String constants representing C++ features. This refactors parts of java_cpp_strings so java_cpp_features can share it. This aims to address the most common syntaxes for declaring C++ features (string literal names, "brace" and "equals brace" initialization, with & without the "base::" namespace). Design: http://go/autogen-java-features Bug: 1060097 Fixed: 1091031 Test: vpython build/android/gpy/java_cpp_strings_tests.py Test: vpython build/android/gpy/java_cpp_features_tests.py Test: tools/md_browser/md_browser.py docs/android_accessing_cpp_features_in_java.md Change-Id: I5311f72f8837c122186148cf183f4219087df96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412840 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#812889}
-
John Lee authored
Bug: 1105862 Change-Id: Ia3b9cb7d06a88005321806c78f1dbcf93d4ba544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438929Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812888}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bce69fefbe63..72a6843cad22 2020-10-01 hjd@google.com Merge "ui: Improve track names even more" 2020-10-01 lalitm@google.com Merge "Update CHANGELOG for v8.0 release" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I84602a5a32b15fad131296c66e83fa0057f0113e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812887}
-
Bill Carr authored
When DirectCompositionChildSurfaceWin::EnqueuePendingFrame is called if swap_rect_ is non-empty a d3d11 query is created resulting in 3d engine work. Due to an optimization in DirectRenderer::DrawFrame (see https://source.chromium.org/chromium/chromium/src/+/master:components/v iz/service/display/direct_renderer.cc;drc=be67975e bd6cf67bbe1;l=402) we are not however currently clearing swap_rect_ by calling DirectCompositionChildSurfaceWin::SetDrawRectangle with an empty rect when there is no damage to the root. As a result after the first SetDrawRectangle call 3d engine work is performed for each queued frame. To help reduce the amount of 3d engine work we'll reset swap_rect_ at the end of SwapBuffers; allowing the d3d11 query to be skipped until the next new SetDrawRectangle occurs. Bug: 1133916 Change-Id: I84ccf81d18a8e45e1ce871484a763c20e5bb6418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443489 Commit-Queue: William Carr <wicarr@microsoft.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#812886}
-
David Bokan authored
A few small improvements found to this test while working on a CL that ended up being unrelated. Replace WaitFor with WaitUntilAnimationEndTimeBased since the former waits using rAF ticks which are artificially made very short in web tests. This means it doesn't actually wait very long in practice. The TimeBased version uses the wall clock so isn't affected by the rAF interval time. Bug: 915926 Change-Id: I5e68d9e6db47da5902538255cc36e5f242bd9a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442355Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812885}
-
Haiyang Pan authored
This reverts commit 37ba4241. Reason for revert: The test OverflowScrollInterruptedByWheelScroll consistently fails on a couple of android builders. For example: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2386 * https://ci.chromium.org/p/chromium/builders/ci/android-asan/8057 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2773 Original change's description: > Reland "Rewrite scroll interruption tests into browser tests" > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. We rewrite below tests > fast/scroll-behavior/main-frame-interrupted-scroll.html, > fast/scroll-behavior/overflow-interrupted-scroll.html and > fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests > because we cannot guarantee that the scroll arrives before the animation > completes. > > I disable the test when disable_threaded_scrolling_ is false, because we > do not know what is the final scrollTop value. > > TBR=bokan@chromium.org > > Change-Id: Ia9b68cd2e0c4f198968aa56482698c0c02edf452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441205 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812517} TBR=bokan@chromium.org,lanwei@chromium.org Change-Id: Ia4f0efbd3a203be16670ea10d54dcf8ae5820aad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443215Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812884}
-
Haiyang Pan authored
This reverts commit e855807b. Reason for revert: Likely the cause of the test failures described in crbug.com/1134292. These tests are failing on other android builders as well. For example: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2386 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27170 Original change's description: > Added a11y state description to ListBox on Android > > This CL updates the behavior of ListBox on Android. > > With this change, the state of a Listbox ("x items") will > now be read during swipe navigation when a node is initially > selected. For ListBoxItem, the state of the item will read > as "in list, item x of y". > > We append the state of the ListBox or items in the > stateDescription element of the node's corresponding > AccessibilityNodeInfo object. > > This CL also updates associated unit test expectations. > > > AX-Relnotes: ListBoxes and ListBoxItems now explicitly announce their count and item index. > Bug: 1101656 > Change-Id: I41bf46d2f11ea9fb0c744ccd3802855c028ecb79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436382 > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812477} TBR=dmazzoni@chromium.org,danakj@chromium.org,pdr@chromium.org,mschillaci@google.com Change-Id: I2e57b039c81e8a4cdaedd22383ac3d4cf5e60e61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443538Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c73bff39bd21..a0c82f08df58 2020-10-01 brianosman@google.com Revert "moved SkSL FloatLiteral data into IRNode" 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b042f4e70879 to 5e947adaf26e (4 revisions) 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cc47e0cd to 085332bf (612 revisions) 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ad421a248adb to da5828c06b4c (2 revisions) 2020-09-30 bsalomon@google.com Get GrBackendRenderTarget's sample count from MtlTexture. 2020-09-30 robertphillips@google.com Have the GrShadowRRectOp make use of the thread-safe view cache 2020-09-30 robertphillips@google.com Have GrMatrixConvolutionEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Update TextureEffect to avoid extraneous out variable. 2020-09-30 brianosman@google.com Add Variable::fBuiltin, to track Variables owned by pre-includes 2020-09-30 bsalomon@google.com Return GrBackendTexture from SkPromiseImageTexture by value. 2020-09-30 johnstiles@google.com Update MatrixEffect to avoid extraneous out variable. 2020-09-30 ethannicholas@google.com moved SkSL ExternalFunctionCall's data into IRNode 2020-09-30 johnstiles@google.com Simplify generated GLSL code for trivial FPs. 2020-09-30 senorblanco@chromium.org Dawn: remove persistent TextureView from GrDawnTexture. 2020-09-30 smoreland@google.com Avoid heap initialization for skia allocations. 2020-09-30 brianosman@google.com Move VariableReference ref-adjusting into helper functions 2020-09-30 robertphillips@google.com Make GrRectBlurEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Calculate texture clamping X/Y coordinates in parallel. 2020-09-30 johnstiles@google.com Inline trivial single-argument constructors directly. 2020-09-30 michaelludwig@google.com Fix GrClipStackClip::preApply to report kClippedOut 2020-09-30 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache (take 2) 2020-09-30 johnstiles@google.com Add ProgramWriter, a non-const version of ProgramVisitor. 2020-09-30 johnstiles@google.com Add unit test for inlining trivial arguments. 2020-09-30 ethannicholas@google.com moved SkSL Extension data into IRNode 2020-09-30 csmartdalton@google.com Don't cast emscripten pointers when assembling WebGL interface 2020-09-30 johnstiles@google.com Update nanobench SkSL tests. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL ExpressionStatement's data into IRNode"" 2020-09-30 bsalomon@google.com Add sample count field to GrD3DTextureResourceInfo. 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ec42b1438fd2 to fa082bb58ba7 (11 revisions) 2020-09-30 johnstiles@google.com Avoid creating temporary variables for nested trivial cases. 2020-09-30 johnstiles@google.com Revert "moved SkSL ExpressionStatement's data into IRNode" 2020-09-30 brianosman@google.com Revert "Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache" 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b2a4e87ad274 to ad421a248adb (2 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 339e4ec2 to cc47e0cd (351 revisions) 2020-09-30 johnstiles@google.com Allow more types of expressions to be directly inlined. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL Enum data into IRNode"" 2020-09-29 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache 2020-09-29 kjlubick@google.com [canvaskit] Add Initial Typescript definitions/types. 2020-09-29 ethannicholas@google.com moved SkSL ExpressionStatement's data into IRNode 2020-09-29 robertphillips@google.com Make the SW blurred mask path use the thread-safe uniquely-keyed view cache 2020-09-29 johnstiles@google.com Revert "moved SkSL Enum data into IRNode" 2020-09-29 ethannicholas@google.com moved SkSL Enum data into IRNode 2020-09-29 brianosman@google.com Fix swizzle-of-swizzle lvalues in ByteCodeGenerator 2020-09-29 brianosman@google.com Add a benchmark that measures SkSL::Compiler startup time 2020-09-29 jsimmons@google.com Add an API for clearing the SkParagraph font and paragraph caches 2020-09-29 ethannicholas@google.com moved SkSL Constructor's data into IRNode 2020-09-29 robertphillips@google.com Have GrCircleBlurFragmentProcessor make use of thread safe view cache 2020-09-29 bsalomon@google.com Add sample count to GrVkImageInfo. 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2a09e89113af to ec42b1438fd2 (63 revisions) 2020-09-29 herb@google.com minimize includes and forwards for remote glyph cache 2020-09-29 ethannicholas@google.com moved SkSL FloatLiteral data into IRNode 2020-09-29 jvanverth@google.com Move MacOS 10.13 Metal jobs to 10.15. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1018739,chromium:1096746,chromium:1108408,chromium:1130678,chromium:1132366,chromium:1133459,chromium:131355925 Tbr: brianosman@google.com Test: Test: Test: CQTest: Test: Test:Test: Test: CQTest: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: Manual verification of Skia 'gn gen' on WindowsTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: angle_end2end_test --gtest_filter=*ETC1CompressedImageNPOT*Test: Test: angle_end2end_tests --gtest_filter=*ETC1CompressedImageDraws*Test: Test: dEQP.GLES31/functional_separate_shader_validation_es31_*Test: Test: removes large hwuimacro regressions w/ heap initialiation Change-Id: Iab1d1bf0753fc3f2dafdb386f9c28aa99155d0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812882}
-
Siyu An authored
We found the offer data would be successfully synced down to client but would not be saved. After debugging we found the client tag hash for the offer data is missing in the update response. Similar to wallet data, every time offer data is updated, it will be a full update. So we need to set this manually. Bug: 1112095 Change-Id: I304a078f44f5647d4f3da26b7086f0ddec973ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441939 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812881}
-
Moe Ahmadi authored
Fixed: 1130864 Change-Id: I5ca24433cb2892a8a1e8f243b6f280f9389b66ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442092 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812880}
-
Anders Hartvoll Ruud authored
- The insertion point crossing flag needs to be reset in a similar way to the tree crossing flag. Otherwise flags may "leak" from one nested complex selector to another unrelated nested complex selector. - In ExtractInvalidationSetFeaturesFromSelectorList, don't return as soon as we encounter kRequiresSubtreeInvalidation, as this causes selectors following a :host-context to be skipped, for example we would ignore '.b' in ':is(:host-context(.a), .b)'. - We should also not propagate the kRequiresSubtreeInvalidation value from nested complex selectors, as it causes whole subtree invalid for _everything_ in the top-level rightmost compound, even the parts unrelated to kRequiresSubtreeInvalidation. For example, for ':is(:host-context(.a), .b)', .b would be marked as whole subtree invalid. Instead we rely on this being handled locally inside each call to UpdateInvalidationSetsForComplex. Bug: 568705 Change-Id: If54b7c006a4c1d886513a0bfb3e075fd4f71be63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438417 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812879}
-
Yusuf Sengul authored
Bug: 1133586 Change-Id: I791e4e900936fbc9349d0742c93bc2a3f13700d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439675Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#812878}
-
Klaus Weidner authored
Adds support for a per-view viewport scale factor, dynamically configurable on a per-frame basis. The feature is controlled by the WebXRViewportScale Blink feature, and can be enabled via chrome://flags#webxr-incubations or the --enable-features=WebXRIncubations command line flag. See https://github.com/immersive-web/webxr/pull/1132/files for the related spec changes. This CL does not yet implement a recommended scale factor which is an optional feature in the spec. The attribute just returns base::nullopt for now. In addition to the Blink experimental feature flag, the device backends also need to opt in by setting XRSession.supports_viewport_scaling via mojo response. Currently, only the GVR device enables the feature. Bug: 1133381 Change-Id: I5ccf3fd613eb78475e1f4512025cc3eab6fd149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438207 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812877}
-
Aya ElAttar authored
- Changed ClipboardDlpController to a singleton to decouple its ownership and lifetime from ui::Clipboard, which was previously unexpectedly destructed by DestroyClipboardForCurrentThread. - Removed Clipboard::GetDlpController and Clipboard::SetDlpController. - Changed DlpRulesManager to be responsible for controlling EnterpriseClipboardDlpController lifecycle. Bug: 1102332 Change-Id: I603f5d61c218290dbcc74a9292f89e78f08d7dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424086 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812876}
-
Yao Xiao authored
Switched to do ReadVarint64 from CodedInputStream. Each blocklist check would involve a file scan on the background. Bug: 1062736 Change-Id: I6b0153e8a8e39025a4bf9485a837897767b3abde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440305 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812875}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75b9ab6751f3..dba4db5668d6 2020-10-01 landrey@webrtc.org Revert "Reland "Reduce the amount of howling reduction in AEC3"" 2020-10-01 perkj@webrtc.org Refactor reporting of VideoBitrateAllocation 2020-10-01 peah@webrtc.org Reland "Reduce the amount of howling reduction in AEC3" 2020-10-01 landrey@webrtc.org Revert "Reland "Activating AVX2 support by default"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780bbb6fadb565c077cda665017c63b7d6f1499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812874}
-