- 02 Aug, 2017 40 commits
-
-
Charles Burnell authored
Simple guard to prevent tasks with pid 0 from being killable. If a user tries to kill a task with pid 0 there is a crash. By doing a simple check to see if the pid is 0 we prevent this. A pid should also only be 0 for a short period of time in certain race conditions. Bug: 749459 Change-Id: Iba63b63d6606dbf403cbae3bf2fef4c882f395c5 Reviewed-on: https://chromium-review.googlesource.com/594308Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Charles Burnell <cburn@google.com> Cr-Commit-Position: refs/heads/master@{#491424}
-
Bin Zhao authored
Currently we have CastSocket::OnOpenCallBack = base::OnceCallback<void(int channel_id, ChannelError error_state)>. We need to call CastSocket* socket = cast_socket_service_->GetSocket(channel_id); to get socket object in callback function, which seems unnecessary. Make CastSocket::OnOpenCallback take CastSocket* parameter instead. Callback is invoked by CastSocket object with 'this' pointer. Since CastSocket only runs on the IO thread, so do callback functions, no post task is involved, raw pointer seems safe. Resolve code review comments for: https://chromium-review.googlesource.com/c/575247 Bug: 749762 Change-Id: Iaab109774fa2c67d99a7fa5afffdf2315b32fd59 Reviewed-on: https://chromium-review.googlesource.com/590588 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491423}
-
Vasilii Sukhanov authored
PasswordStore uses SKIP_ON_SHUTDOWN for background sequence. That means that PasswordStore::DestroyOnBackgroundThread() can be skipped. In this case PasswordStore::* may be destroyed on the UI thread. It's not a problem for PasswordSyncableService. We just need to remove the check in the destructor. PasswordReuseDetector has this check implicitly via base::CancelableTaskTracker. Thus, we can just leak the object. Bug: 741660 Change-Id: Ic49cb068733c159bca55e8d76eb58f70793f5fbe Reviewed-on: https://chromium-review.googlesource.com/598008Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491422}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/33dd830890d3..aea80dcc0abc $ git log 33dd83089..aea80dcc0 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 hnakashima Remove CFX_ByteTextBuf from cpdfsdk_interform.cpp and others. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iae59aa9c663dd1b04b1ccb2bdd7e3b9d23b802ae Reviewed-on: https://chromium-review.googlesource.com/598315 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491421}
-
cburn authored
RenderProcessHosts. This is useful because it will track processes that are otherwise not included in the current task manager. An example of this is the NTP which has a service worker that lives beyond navigating away from the NTP. With this you can accurately see when the termination of the RenderProcessHost that is running this service worker. This version is requires the commandline flag of "--task-manager-show-extra-renderers" to be used. BUG=716609 Review-Url: https://codereview.chromium.org/2988453002 Cr-Commit-Position: refs/heads/master@{#491420}
-
Wenzhao Zang authored
The current implementation of animated avatar didn't consider small pods, resulting in the listed bug. Also sets a timeout for switch animation. Bug: 751343, 721647 Change-Id: I5b9cafc737c082865d33520cfafca2963554be4f Reviewed-on: https://chromium-review.googlesource.com/597051Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491419}
-
David Tseng authored
- the RendererAccessibility layer already queues up events - this interferes with scoping of user actions i.e. a posted task is no longer on the same call stack and is no longer identified as an action - cleans up some ChromeVox assumptions - extend ChromeVox read all to sync selection as it goes and enable it to work inside of editables Test: navigate with ChromeVox in a text field; perform a read from here Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2df30c907e01fba4760271ee0a3e86b031342f9b Reviewed-on: https://chromium-review.googlesource.com/592514Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491418}
-
Weiliang Chen authored
Always calls SetNew right after creating SharedQuadstate to set all the values on SharedQuadState. This is to help catch all cases when switching to use id in later CLs. R=danakj@chromium.org Bug: 739429 Change-Id: I029f73d2ff3b261ce12da65ba7eb49b6323f37c1 Reviewed-on: https://chromium-review.googlesource.com/596768 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491417}
-
Ryan Hansberry authored
Without being a system notifier, MultiUserNotificationBlockerChromeOS::ShouldShowNotification() returns false, preventing Tether notifications from displaying. It's appropriate to consider Tether a system notifier given that it is baked into the system tray and Settings. Bug: 747639, 672263 Change-Id: I0f0d9a4ce3da7c62b148af979c611eaca6682053 Reviewed-on: https://chromium-review.googlesource.com/596833 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491416}
-
spqchan authored
The WebTextfieldTouchBarController observes the autofill popup window to display the autofill items. This CL makes sure that it stops observing the old popup before it observes a new one. Bug: 750570 Change-Id: I8298a83f3cd1fae7363f6a3d16d9a15f24342cb7 Reviewed-on: https://chromium-review.googlesource.com/596915Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491415}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Bug: Change-Id: I6663a127e00f45975961e5cacf48c6be32facccf Reviewed-on: https://chromium-review.googlesource.com/596749Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491414}
-
Paul Jensen authored
It seems to have stopped working recently; this fixes it. Also, fix a pylint presubmit failure that looks like it started with crrev.com/465016 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I277083b181fed4f5491f11e551175f37ba9b38a3 Reviewed-on: https://chromium-review.googlesource.com/598115Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491413}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0327c967ed7f..65e2bf234545 $ git log 0327c967e..65e2bf234 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 loloangela Fixed errors related to bad-builtin Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I00c7faab4ae659bf428fb3aa4936d617df072c90 Reviewed-on: https://chromium-review.googlesource.com/598311 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491412}
-
nednguyen authored
Bug: 730036 Change-Id: If226169d647db5adc8714f70cef3de683591e9b2 Reviewed-on: https://chromium-review.googlesource.com/597729Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491411}
-
F . authored
This reverts commit d1bc5d0b. Reason for revert: Introduces new C++ static initializers. See crbug.com/751735 Original change's description: > Make downloads work when history database fails to initialize. > > Previously all download calls will be stuck when history database fails > to initialize. > > This CL assigns 1 as the first id when history database failed to load, > all downloads in this browser session will not be persisted to history > database. > > Bug: 736511 > Change-Id: If4db04ca518633a7dd999f45629e60e97fc78b1a > Reviewed-on: https://chromium-review.googlesource.com/587327 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490540} TBR=rkaplow@chromium.org,dtrainor@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 736511, 751735 Change-Id: Ifa73c694e919bda82eb37ea88020cf6b0ba89751 Reviewed-on: https://chromium-review.googlesource.com/598347Reviewed-by:
F . <zpeng@chromium.org> Commit-Queue: F . <zpeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491410}
-
Tina Quach authored
Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. The tests are disabled in debug mode and memory sanitizer mode due to timeout. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8715e83778409802849db38d90fef387db203f9b Reviewed-on: https://chromium-review.googlesource.com/592156 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491409}
-
Aaron Gable authored
This reverts commit f5345de1. Reason for revert: Breaks bots which run layout_tests not via swarming: https://crbug.com/751421 Original change's description: > Bump macOS SDK to 10.12. > > Bug: 669240 > Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d > Reviewed-on: https://chromium-review.googlesource.com/570459 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491060} TBR=thakis@chromium.org,erikchen@chromium.org Change-Id: I3b30bd3e18fa60f736078ed889a6c574b15c6467 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669240, 751421 Reviewed-on: https://chromium-review.googlesource.com/598449 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#491408}
-
Bruce Dawson authored
In order to enable clang-cl's printf format string mismatch checking we need to fix a few dozen existing errors. These are mostly places where DWORD (unsigned long) is printed with %X or %u - an 'l' is needed. R=thakis@chromium.org BUG=751171 Change-Id: Ieb1aeeedb14c5725b51d460fc34c418abcafe68f Reviewed-on: https://chromium-review.googlesource.com/596612Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491407}
-
Francois Doray authored
TBR=afakhry@chromium.org,creis@chromium.org Bug: Change-Id: Ife874db9ed1b7fa2e6251e12ce1bf7fcb348d675 Reviewed-on: https://chromium-review.googlesource.com/595868 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#491406}
-
nednguyen authored
Bug: 730036 Change-Id: I206502ba68ab413650d732d8e50424d60841b3b3 Reviewed-on: https://chromium-review.googlesource.com/598267Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491405}
-
Tom Sepez authored
Split off from https://chromium-review.googlesource.com/c/584857 so that the other non-mechanical cleanup work wouldn't be lost if this gets reverted. See that CL for signoff. Change-Id: Ic75adc756990d3182aba8a323021f328b8419754 Reviewed-on: https://chromium-review.googlesource.com/596070Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491404}
-
Steven Bennetts authored
Successful PFQ run: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/4672 Bug: none Change-Id: Ib07f0953b79311882212ab873a2af524ee8d7157 Reviewed-on: https://chromium-review.googlesource.com/594207 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491403}
-
Rob Buis authored
As part of Project Ribbon, separate the parsing logic for these CSS properties from the parser into an API: - block-size - inline-size - min-block-size - min-inline-size - -webkit-min-logical-width - -webkit-min-logical-height - -webkit-logical-width - -webkit-logical-height Bug: 668012 Signed-off-by:
Rob Buis <rob.buis@samsung.com> Change-Id: I1689c5df226f0dd0adf660705ba80c5ed4c7bd9e Reviewed-on: https://chromium-review.googlesource.com/589607Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#491402}
-
Tommy C. Li authored
Bug: 750867 Change-Id: I5d2a8093123ba7cd60010f5597c5fbaf3a193188 Reviewed-on: https://chromium-review.googlesource.com/594937Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491401}
-
Thoren Paulson authored
This flag prevents the collection of gpu info on the multi-process path, but not on the in-process path. This change makes the in-process path consistent with the multi-process path. This is needed by Cast for Android Things, which doesn't always have an implementation of EGL, so crashes when loading gpu info. Bug: None Test: CQ Change-Id: Ic700fe28c4c3b5af10cf860e76f43facba25d86d Reviewed-on: https://chromium-review.googlesource.com/596329Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#491400}
-
Maks Orlovich authored
Change-Id: I9d66473203995ff21d915b17cffa42c44f84a000 Reviewed-on: https://chromium-review.googlesource.com/598108 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491399}
-
Jialiu Lin authored
Fix flacky tests in SBNavigationObserverBrowserTest is caused by the non-deterministic iframe navigation order. This CL add checks to both possible orders. Bug: 739716,736354 Change-Id: I0b256d492500b8f2872485235eb0b826dae6c827 Reviewed-on: https://chromium-review.googlesource.com/594711Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491398}
-
Eric Noyau authored
First patch just removes the flag and the command line, the second removes all the associated code. Change-Id: Iad8fd182655dca68be28f00c8a55e200dd7557f8 Reviewed-on: https://chromium-review.googlesource.com/598234Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491397}
-
nednguyen authored
This also modifies convert_legacy_wpr_archive script to also automatically run "git add .*wprgo" for the users upon succesful uploading. Bug: 730036 Change-Id: I9c26a65b7ec72cd5b55136a5ef6be975caeba541 Reviewed-on: https://chromium-review.googlesource.com/598268Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491396}
-
Duc Bui authored
We need to keep track of tabs which are being restored by session restore (instead of other mechanisms like reopening closed tabs). This CL adds new API to SessionRestoreObserver and makes TabManager to keep track of the session-restoring tabs. Bug: 731901 Change-Id: I0d415a689d2b8e49b58cb2af6623ad7fad7ea50a Reviewed-on: https://chromium-review.googlesource.com/588168Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Commit-Queue: Duc Bui <ducbui@google.com> Cr-Commit-Position: refs/heads/master@{#491395}
-
Luna Lu authored
This reverts commit b4ee3ace. Reason for revert: suspect breaking tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla_expected_failures%2Fmarvin%2Fbackgr_fixed-bg.html&testType=webkit_tests https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9 The test has been consistently failing on Mac OS 10.9 Original change's description: > Position fixed backgrounds in table sections correctly > > Bug: 35697 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62 > Reviewed-on: https://chromium-review.googlesource.com/594987 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491294} TBR=wangxianzhu@chromium.org,robhogan@gmail.com,eae@chromium.org Change-Id: Id2939cb178de44d6b601f353ca1acc8145802ced No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 35697 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/598407Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491394}
-
Matt Mueller authored
Remove unused x509_certificate_model.h include from chrome/browser/chromeos/options/vpn_config_view.cc Bug: none Change-Id: I37bd44bc9ddebf88f7916e21cb90122db870b2b0 Reviewed-on: https://chromium-review.googlesource.com/596715 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491393}
-
Anna Maria authored
[Local media Casting] Correcting issue where local media cast files will not work with media remoting. This is because tab:0 is an invalid source, so we correct that to use the actual tab number in the source. This requires a different create route flow because it seems up to now that there has been an assumption that sources do not change, but for the local file case this is not so because the tab must be opened. Bug: 721802 Change-Id: I69ec9d1dd981e7d445a1bb823f301911cd37058c Reviewed-on: https://chromium-review.googlesource.com/596607Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Anna Maria <paezagon@chromium.org> Cr-Commit-Position: refs/heads/master@{#491392}
-
Morten Stenshorne authored
Causes problems for Jumbo builds. TBR=nverne@chromium.org Change-Id: If4a37cff9ae787ec0c750b652663fd2d8d6b1a66 Reviewed-on: https://chromium-review.googlesource.com/598090Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491391}
-
nednguyen authored
Bug: 730036 Change-Id: I3087cf1897d639cd3425f4906b3b02cb12ebc648 Reviewed-on: https://chromium-review.googlesource.com/598190Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491390}
-
Morten Stenshorne authored
Multiple definitions in various .cpp files causes problems for Jumbo builds. TBR=chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I907fc4bbba428de44579c9466a8884270102483b Reviewed-on: https://chromium-review.googlesource.com/598070 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#491389}
-
Raphael Kubo da Costa authored
libxslt's source code was moved to src/ in commit 6f776b2a ("Check in the libxslt roll script"), but README.chromium wasn't updated to point to the license file's new location. Bug: 708393 Change-Id: I041569545e3c9d536b826bfaa198605ba5ca6a88 Reviewed-on: https://chromium-review.googlesource.com/597848 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491388}
-
Scott Graham authored
There's no documented handle limit on Fuchsia, and it looks like this function is used for questionable purposes anyway, so just return ::max(). Bug: 743296 Change-Id: I4e85f31eb519d5dc2d96882d793b9e2c4afc7851 Reviewed-on: https://chromium-review.googlesource.com/597008 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491387}
-
Fady Samuel authored
Registering a FrameSinkId delimits the beginning of the lifetime of a FrameSinkId. From Viz's perspective that ID is valid until InvalidateFrameSinkId is called. RegisterFrameSinkId also bundles a HostFrameSinkClient (was FrameSinkObserver) that listens for new surfaces submitted to the registered FrameSinkId. This CL allows us to replace multiple call sites to RegisterFrameSink / InvalidateFrameSinkId in content that go directly to FrameSinkManagerImpl with calls to HostFrameSinkManager, taking us closer to a point where content does not directly use FrameSinkManagerImpl. This CL is also a prerequisite for using HostFrameSinkManager in the window server because it introduces a mechanism for listening for events pertaining to a particular FrameSinkId which is a requirement for the window server. This interface will be used for events as well in the future. Bug: 657959 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I3e1343ea6cfbe6b3d39ba2fcd23d193dd2c3e4a0 Reviewed-on: https://chromium-review.googlesource.com/595147Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491386}
-
gambard authored
When the device is rotated, the layout should be invalidated in order to have the Most Visited tiles to have the "correct" alignment, i.e. 4 tiles per row. It also prevent the omnibox from being unfocused on rotation. Bug: 751237 Change-Id: I305eff881d226ea692b8f8767dfb52557ce61f82 Reviewed-on: https://chromium-review.googlesource.com/597629Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#491385}
-