- 27 Nov, 2018 40 commits
-
-
Kent Tamura authored
- In web_tests, we mapped the keyword "file:///tmp/LayoutTests/" to the actual web_tests directory. This CL updates the keyword to "file:///tmp/web_tests". - In image decoder tests, we mapped the keyword "LayoutTests/" to the actual web_tests directory. This CL updates the keyword to "web_tests/". Bug: 843412 Change-Id: I6f4ef498a9052a701aa2211a180d87781f45d8dc Reviewed-on: https://chromium-review.googlesource.com/c/1351195Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611055}
-
Benoît Lizé authored
Parallel requests are initiated when an intent is dispatched to a CustomTabs activity. At that point, native is not guaranteed to be initialized, but the request needs the browser to be initialized, not merely the native library to be loaded. In this case, delay the call until this condition is fullfilled. To that end, add a delayed task mechanism to ChromeBrowserInitializer. Add tests to this class, and while in the neighborhood, convert Runnable to lambdas. Note that this is not exposed to clients yet, as enabling the feature still requires the browser to be initialized. This first CL introduces the mechanism and ensures that existing behavior is preserved. Bug: 901835 Change-Id: I184e1da5ae974458d19f6a88a3f26ba6c443cb57 Reviewed-on: https://chromium-review.googlesource.com/c/1349227Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611054}
-
Dan Elphick authored
Since BooleanValue cannot actually throw, the Maybe version of the function is now deprecated. Bug: v8:7279, v8:8238 Change-Id: Ic7fc9ff21d4cee2fe65de19cb800e76bce3d10bf Reviewed-on: https://chromium-review.googlesource.com/c/1350916Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611053}
-
Dan Elphick authored
Use MaybeLocal version of GetFunction in SandboxStatusExtension as original function is deprecated. Since the original code DCHECKs that other failure can't happen, I've used the same pattern rather than ToLocalChecked. Bug: v8:7295, v8:8238 Change-Id: I29178794660dc7c5cf6d6bba0c617dfbbb37757d Reviewed-on: https://chromium-review.googlesource.com/c/1348047Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611052}
-
Vaclav Brozek authored
The test currently passes by accident: it fails to check that a metric has a value. It also has two issues: one is mixing null and non-null drivers, and the other is calling old-parser-only ProvisionallySavePassword instead of OnPasswordFormSubmitted, while at the same time using the new parser. This CL fixes the test: * Activates the check, and * Fixes the issues, so that the test passes. Bug: 907794 Change-Id: Ia24518aa2bae3c0a25db7722c89eb59f70c61ef1 Reviewed-on: https://chromium-review.googlesource.com/c/1350898 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611051}
-
Gauthier Ambard authored
This CL creates the AutofillEditItem to replace the LegacyAutofillEditItem in UITableView. The support for Dynamic Type will be done later to keep this close to the legacy implementation. Bug: 894791 Change-Id: I9e0e9ab81498dbafe5357487a7249f23c7620df5 Reviewed-on: https://chromium-review.googlesource.com/c/1344062Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#611050}
-
Rob Buis authored
Fix error message by making it a proper sentence. Bug: 803774 Change-Id: I30feb2f5b9aa92653793db92556aaf29371673ec Reviewed-on: https://chromium-review.googlesource.com/c/1350962Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#611049}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/344c43de..483d8219 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. Passing a NOTRY because the mac_chromium_rel_ng and mac_optional_gpu_tests_rel bots experience an infra failure, see https://crbug.com/908729. All the others are green. NOTRY=true CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I330e6614a7d71247b3ee3bb16166209400a72bcb Reviewed-on: https://chromium-review.googlesource.com/c/1351797 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611048}
-
Mathias Carlen authored
Bug: 806868 Change-Id: I69bdb935ea8029e64fa05172762262e2167659ec Reviewed-on: https://chromium-review.googlesource.com/c/1347280Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611047}
-
Yang Guo authored
Bug: v8:7281 Change-Id: I51a26bd0d91e70abb77f5179b8b90aaff69b4a41 Reviewed-on: https://chromium-review.googlesource.com/c/1349343Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611046}
-
Aleks Totic authored
There are two tests that test this, but they are currently failing in Legacy too. virtual/android/url-bar/bottom-and-top-fixed-sticks-to-top.html virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html I've confirment manually that position:fixed, bottom:0 Elements stick to bottom on scrolling. There is one remaining problem. While scrolling is active, position:fixed, bottom:0 element does not stick to the bottom of the viewport. It gets positioned correctly after scrolling stops. Bug #906516 Bug: 870008 Change-Id: Ibe597141869794978865809caa3991cd4c2bd8a6 Reviewed-on: https://chromium-review.googlesource.com/c/1341127 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611045}
-
Mario Sanchez Prada authored
Move away from OAuth2TokenService and SigninManagerBase by implementing IdentityManager::Observer and using Identity Service's APIs only (i.e. IdentityManager, PrimaryAccessTokenFetcher). Bug: 905689 Change-Id: I68e971ddf8a23987abfdadb8e2daf7b17a4a6ddb Reviewed-on: https://chromium-review.googlesource.com/c/1340315Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#611044}
-
Ruslan Burakov authored
Experiment discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk Bug: 908272 Change-Id: I97a5d26996469d33b75afa4babf40e54eb830e6a Reviewed-on: https://chromium-review.googlesource.com/c/1350174 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#611043}
-
Yutaka Hirano authored
Introduce blink::WritableStream which is a ScriptWrappable. There are some compatibility issues: - Function lengths (e.g., WritableStream.prototype.abort.length) change. (external/wpt/streams/writable-streams/properties*) - attribute @@toStringTag is added to ReadableStream and TransformStream. (*global-interface-listing*) Bug: 894357, 888165, 902633 Change-Id: I93762fec72a4654759a7fbe4e80b4704befac2c3 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1337220 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#611042}
-
Vlad Tsyrklevich authored
GWP-ASan is a debug allocator intended to find memory errors in the wild. In order to detect as many as bugs as possible, it should start as early as possible, e.g. soon after it's dependency, FeatureList, has been initialized. Since content/ doesn't call into ChromeMainDelegate for child processes after FeatureList has been initialized, create a new delegate method for post-FeatureList initialization and enable GWP-ASan at that point. Bug: 896019 Change-Id: I9c081602cd32a71d5d9eb774bd9818757d9b7e95 Reviewed-on: https://chromium-review.googlesource.com/c/1343347Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611041}
-
Luciano Pacheco authored
Don't run dirRenameWithoutChangingCurrent with MyFilesVolume flag, since it was flaky crbug.com/908352. Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads folder: "" when MyFilesVolume is disabled, which means Downloads is the root; "/Downloads" when MyFilesVolume is enabled, which means that Downloads it's a folder at root. Change tests that uses entry.fullPath to prefix with RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag MyFilesVolume. Enable some tests to run with flag MyFilesVolumeEnabled which were failing before this CL. NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with /Downloads will be in-lined when MyFiles as Volume is fully rolled out. --gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*" --gtest_filter="CreateNewFolder/FilesAppBrowserTest*" Test: browser_tests Bug: 873539, 908352 Change-Id: Iaac6c8bd51c2bc8dc31e1c395f2f74d8533f4f9c No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/1351341 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611040}
-
Vaclav Brozek authored
Checking for values in UKM metrics is a lot of boilerplate in the password manager unittest, so this CL adds two helper methods for brevity. Bug: 907794 Change-Id: Iecf86eb564f9f0f239e7b337725a9666f59d56d4 Reviewed-on: https://chromium-review.googlesource.com/c/1350959 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611039}
-
Noel Gordon authored
Add helper to count the number of items on the MockProgressCenter. Use it in drive_sync_handler_unittest as an example, to remove a shed-load of closure compiler complaints about the following code: Object.keys(progressCenter.items) Move that code into the MockProgressCenter helper: getItemCount(), and the Closure compiler will be a happy koala. No change in test behavior, no new tests. Bug: 907964 No-try: true Change-Id: I3da5fda8226a64a0cad27dcb57b84fac6c7a43be Reviewed-on: https://chromium-review.googlesource.com/c/1351201 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611038}
-
Shakti Sahu authored
Transient downloads shouldn't show up on download home and hence should be filtered out. Bug: 908670 Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1 Reviewed-on: https://chromium-review.googlesource.com/c/1351717Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611037}
-
Adam Rice authored
With https://github.com/web-platform-tests/wpt/pull/14172 wpt streams tests now use the standard *.any.js format for multi-platform tests. As a result all the test filenames have changed and there are a large number of obsolete *-expected.txt files left behind. Delete them. Change-Id: Ia5ce3b89e3866745d19bd1d521c7fb731342e024 Reviewed-on: https://chromium-review.googlesource.com/c/1350552Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#611036}
-
Raphael Kubo da Costa authored
This fixes the GCC build after fdf95b6b ("CacheStorage: Refactor handle ref-counting"): ../../content/browser/background_fetch/storage/match_requests_task.cc: In constructor ‘content::background_fetch::MatchRequestsTask::MatchRequestsTask(content::background_fetch::DatabaseTaskHost*, content::BackgroundFetchRegistrationId, std::unique_ptr<content::BackgroundFetchRequestMatchParams>, content::background_fetch::MatchRequestsTask::SettledFetchesCallback)’: ../../content/browser/background_fetch/storage/match_requests_task.cc:29:25: error: use of deleted function ‘content::CacheStorageRef<TargetType>::CacheStorageRef() [with TargetType = content::CacheStorageCache]’ weak_factory_(this) {} ^ With GCC, having that noexcept marker would require all members to be marked with noexcept themselves (in this case, base::WeakPtr and its hierarchy). While that could also be possible, the style guide only explicitly mentions move constructors/assignment operators, and it is not clear if having a noexcept default constructor brings any benefits. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: I726cbc8d9e0d624c530a835373c0dbad32279b78 Reviewed-on: https://chromium-review.googlesource.com/c/1350954Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#611035}
-
Kenichi Ishibashi authored
Before this CL we didn't bundle WebRequestProxyingURLLoaderFactory to the default URLLoaderFactory for service worker. This means that fetches from service worker didn't go through webRequest extension API when NetworkService is enabled. Bundle the factory so that fetches from service worker go through extensions. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iabcc00674c8b62c9eae97e83f067d7a838a3d0fd Bug: 897060 Reviewed-on: https://chromium-review.googlesource.com/c/1333173Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611034}
-
Vlad Tsyrklevich authored
After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad UserStreamDataSource) is responsible for looking at the crash and 1) determining if the exception was related to GWP-ASan, and 2) adding additional debug information to the minidump if so. The crash handler hook determines if the exception was related to GWP-ASan by finding the AllocatorState address (using a crash key), reading the allocator state and seeing if the exception occurred in the bounds of the allocator region. If it did, we extract debug information about that allocation and report it in the minidump. CQ-DEPEND=CL:1339246 Bug: 896019 Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a Reviewed-on: https://chromium-review.googlesource.com/c/1330283Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#611033}
-
Yang Guo authored
Bug: v8:8503,821764 Change-Id: I0b541e06f0326f8270e14e0b7a685cab3c288882 Reviewed-on: https://chromium-review.googlesource.com/c/1350177Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611032}
-
Scott Violet authored
This is useful in debugging to attribute what a window is. BUG=none TEST=none Change-Id: If996333847d83c5102ddd81e4ecff25691c09eca Reviewed-on: https://chromium-review.googlesource.com/c/1351099 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#611031}
-
Zhiqiang Zhang authored
The crasher happens when the session is connected/disconnected. The code registers/unregisters RemoteMediaClient callback upon connecting/disconnecting. However it should check the availability of RemoteMediaClient of the current session. Bug: 711860 Change-Id: Ie4b29f507a0044ac8649b52b37f1541e4dc9b4ee Reviewed-on: https://chromium-review.googlesource.com/c/1350211 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#611030}
-
Per Åhgren authored
This CL removes command line switches for experimental features in AEC3 that now are deprecated. This CL also replaces the outdated CL (https://chromium-review.googlesource.com/c/chromium/src/+/1274905) Bug: webrtc:8671 Change-Id: I83582049ab8c144ff8654107e928e8e75fd1f4e0 Reviewed-on: https://chromium-review.googlesource.com/c/1350752Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#611029}
-
Katie D authored
This is the first step in a refactor, and moves only the TTS controller header but none of the logic, in order to keep changes relatively small. Refactoring the TTS controller to content is the first step in displaying the audio icon in tabs when TTS is speaking. BUG: 517317 Change-Id: Ic8c4c06e13001feec5c880691055ff0604127260 Reviewed-on: https://chromium-review.googlesource.com/c/1341154Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#611028}
-
Yuri Wiitala authored
Switches-over GLRendererCopier to use the new GLScaler and GLI420Converter when scaling and/or format-converting images for CopyOutputRequests. This change also addresses: 1. Simpler handling of cached GL resources (used across copy requests having the same requester). Rather than separate methods for each of the possible cached resources (with some duplicated logic), there is now one "ReusableThings" struct to hold them all (and is passed around on the stack). 2. Simplified the I420 code around handling of "packed textures" and "aligned rects". 3. Simplified the detection/execution of whether to byte-swizzle on the CPU (after readback) or GPU (before readback). Simplified the RGBA bitmap copy-from-pixel-buffer code (w.r.t. upside-down row-by-row copy and byte-swizzling). Testing: Confirmed existing unit and pixel tests are thoroughly-testing all possible code paths in GLRendererCopier. Manually confirmed tab and desktop capture (incl. CrOS), and screenshots work. Performance improvement: A local run of performance_browser_tests, on a machine with a high-end nVidia GPU, has shown a ~20% improvement in capture latency (i.e., the interval of time from when copy request was issued until an SkBitmap result is ready in system memory). http://chromeperf.appspot.com/ will reveal how other platform configurations are affected. Bug: 870036,810131,781986,758057 Binary-Size: Increase is temporary (linking in new impl, future CLs will switch-over other clients to stop using old impl). Change-Id: Ibcb16c1382ea0cffb00bc7605e0594b1fe28356a Reviewed-on: https://chromium-review.googlesource.com/c/1343247 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611027}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib41b9d039ce07a1387583c3444c93477b2266acb Reviewed-on: https://chromium-review.googlesource.com/c/1351722Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#611026}
-
Wenzhao Zang authored
This CL changes the behavior. Another CL (https://crrev.com/c/1341158) removes the resources, but for now we don't want to land the second one because the resources will be used by Discover. Bug: 903577 Change-Id: I004abeb0541f64c5ab8ba655cf8c7cf6736a7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/1341149Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611025}
-
Kent Tamura authored
This CL renames the following md files: - layout_tests_linux -> web_tests_linux.md - how_to_extend_layout_test_framework.md -> how_to_extend_web_test_framework.md - testing/layout_test_baseline_fallback.md -> testing/web_test_baseline_fallback.md - testing/layout_test_expectations.md -> testing/web_test_expectations.md - testing/layout_tests.md -> testing/web_tests.md - testing/layout_tests_in_content_shell.md -> testing/web_tests_in_content_shell.md - testing/layout_tests_tips.md -> testing/web_tests_tips.md - testing/layout_tests_with_manual_fallback.md -> testing/web_tests_with_manual_fallback.md - testing/writing_layout_tests -> testing/writing_web_tests.md No-Try: true Change-Id: Ied34815c92e449888b20818540a5ed0a76107bd1 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1350559 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611024}
-
Xi Cheng authored
Change-Id: I0ff4dbdf64ae3d2176a2e5bd1afe0ed353ebe223 Reviewed-on: https://chromium-review.googlesource.com/c/1343559Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#611023}
-
Kent Tamura authored
third_party/blink was forked from WebKit, so we should credit for WebKit. Move third_party/WebKit/LICENSE_FOR_ABOUT_CREDITS to third_party/blink. Remove third_party/WebKit/OWNERS because third_party/WebKit doesn't have files any longer. No-Try: true Bug: 622551 Change-Id: Icdf9b5a08e78848925cd4a7db48d076c1baa328a Reviewed-on: https://chromium-review.googlesource.com/c/1350011 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#611022}
-
Josh Pratt authored
Assigns owners for the following Crostini flags: crostini-usb-support disable-crostini-files enable-experimental-crostini-ui Bug: 897809 Change-Id: I077743a15cb65e552d38e23f189401193723006f Reviewed-on: https://chromium-review.googlesource.com/c/1345673Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#611021}
-
Collin Baker authored
This moves GetTab{Foreground,Background}Color() and ShouldDrawStrokes() to TabStrip. This also plumbs other necessary functions through TabStripController. Change-Id: Iff487d3d228ae4ea3101b713df16c79183fe53cf Reviewed-on: https://chromium-review.googlesource.com/c/1343255Reviewed-by:Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#611020}
-
Devlin Cronin authored
There's not really much point in the distinction between page and browser actions anymore, and we'd like to merge them. Make the declarativeContent.showPageAction API work with browser actions. A follow-up will introduce declarativeContent.showAction. Bug: 893375 Change-Id: Ib4651c225099c62070239f0c37cb4b075d124b1c Reviewed-on: https://chromium-review.googlesource.com/c/1270006Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611019}
-
dpapad authored
Bug: 847729 Change-Id: I31ab35f815a578d236eff6a75fdfa45a3a6df89f Reviewed-on: https://chromium-review.googlesource.com/c/1351507Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611018}
-
Scott Violet authored
The client is notified of changes to the window owner. BUG=756085,875111 TEST=covered by test Change-Id: I8cec4fe2b547bb1f9f31899e2bc2a9437c186d27 Reviewed-on: https://chromium-review.googlesource.com/c/1343507 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611017}
-
Kent Tamura authored
PRESUBMIT.py existed just for linting LayoutTest/TestExpectations. It's unnecessary now. No-Try: true Bug: 622551 Change-Id: I4e3d801ecfa829f3a99e187eb2058fa326aa7c67 Reviewed-on: https://chromium-review.googlesource.com/c/1350430 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611016}
-