- 19 Dec, 2019 40 commits
-
-
Xianzhu Wang authored
Increase difference between the test and the ref. Change-Id: I956a4ef3ee304c0ab25b62cebe1185d6c5e3a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975383 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726407}
-
Etienne Bergeron authored
This CL is rewriting the ElideText unittests. The goal of this rewrite is to allow adding more unittests. * ELIDE_HEAD * ELIDE_EMAIL * ELIDE_MIDDLE * Eliding with styles It is now using a templated tests to ease debugging. A change to the way glyph_width_for_test_ work was needed. Zero width codepoints will stay zero width, even if a glyph width is provided. This is required to ensures RLM and LRM (directional marker) stay with width zero. Otherwise a DCHECK is failing since the text can be larger with eliding (2 glyphs instead of 1 glyph). Bug: 1025561 Change-Id: I19f18fb99f52edbbb59d170f7b47bef3a3f3de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975056 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726406}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iba1bec6352c6659c0feceb7e20a29f5c03224de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726405}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8519d85b8ea..baf7a8617f37 Created with: gclient setdep -r src-internal@baf7a8617f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: I2be6e9dc422c7fda35813d3a0d23ec36ae58865b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976099Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726404}
-
Nina Satragno authored
As per the spec [1], the attestation certificate must have the C, O, OU, and CN attributes set. [1] https://w3c.github.io/webauthn/#sctn-packed-attestation-cert-requirements Fixed: 1035092 Change-Id: Iff61fe93136e45a0e20d42a0a08ddf5c34f0bc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974703Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726403}
-
Xiyuan Xia authored
- Add --trace-dir=PATH to chromeos/test_runner.py When present, test_runner script passes the switch with device local path (e.g. /tmp) to gtest to generate trace file on device and collects the trace files back to PATH on host afterwards. - Update run_gtest_benchmark.py to map the trace file path in the test result json collected by test_runner script so that processor scripts could find and computer metrics from the trace file. Example usage: For developers: tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --gtest_filter=All/OverviewAnimationsTest.EnterExit/7 --output-dir=/tmp/perf_output --output-format=histograms --dbus-stub --stop-ui For perf bots: testing/scripts/run_performance_tests.py --isolated-script-test-output=/tmp/perf_output/output.json --non-telemetry=true --use-gtest-benchmark-script --gtest-benchmark-name=interactive_ui_tests tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --output-format=histograms --dbus-stub --stop-ui Bug: 945711 Change-Id: Ia6911921b8354d7763be96c30a8877c9d598f103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974587 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:Ben Pastene <bpastene@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726402}
-
Yue Zhang authored
Some of the tests disabled by https://crrev.com/c/1951894 are due to unexpected device orientation change possibly caused by previously runned tests changing orientation but never resetting back. Now that we have reset orientation in http://crrev.com/c/1972942, re-enable these tests to see if the problem is resolved. Bug: 1033970, 1030561, 1030562 Change-Id: I41c7bfba8d3a8962423d571196190475e821bc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976014 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#726401}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77742c350371..d04ddcd6c518 git log 77742c350371..d04ddcd6c518 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 robertphillips@google.com Update GL and Vulkan backends to support compressed backend formats 2019-12-19 brianosman@google.com Runtime SkSL: API sketch for child shaders/effects Created with: gclient setdep -r src/third_party/skia@d04ddcd6c518 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I892b0ff95859422f011c84f6d1cb5143d600f7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976097Reviewed-by:
-
Dave Tapuska authored
In order for WebInputEvent to have virtuals and make the class less struct like we need to formally move it into common. This change was largely done via sed. BUG=836826 TBR=thakis@chromium.org, lazyboy@chromium.org Change-Id: I9db295f66f723cb0ea5dd69868d28de508bf056e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973197 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726399}
-
Rune Lillesveen authored
We should do the necessary invalidation from RemovedFromFlatTree() in the same method for light tree children, and marking nodes for style recalc from child insertions and slot assignment as necessary. Change-Id: Ibed7c1dc5243cf6524dd9fa8c2e214d9d8e1f04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975915Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726398}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c58ff87e3200..8b42807c6f1e git log c58ff87e3200..8b42807c6f1e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 andrewlamb@chromium.org replication_lib: Add trailing newline to JSON payloads. 2019-12-19 vapier@chromium.org cros_build_lib.run: clean up combine_stdout_stderr->stderr migration 2019-12-19 bpastene@chromium.org auth: Add support for fetching git creds via git-credential-luci. 2019-12-18 saklein@chromium.org commandline: Add servo device support 2019-12-18 tbegin@google.com packages: add uprev_ebuild_from_pin uprev handler 2019-12-18 mmortensen@google.com Update query_build_logs to fix verbose, include more fields. 2019-12-18 andrewlamb@chromium.org Remove sanity suite from Canary. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-18 saklein@chromium.org Goma: Fix log dir handling. 2019-12-18 mmortensen@google.com Update query_build_logs to show improved usage on errors. 2019-12-18 mnissler@chromium.org Provide virtio-rng device to guests. Created with: gclient setdep -r src/third_party/chromite@8b42807c6f1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I8cb350435a2fd30c88a0e4a9fc3950d34b76cbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976095Reviewed-by:
-
Scott Violet authored
It's the default and we started removing code that means we can no longer disable it. BUG=993813 TEST=none Change-Id: I9f65953bd5a696ad9281644285caa3f9ccba8c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975303 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Stephen Nusko authored
blink_perf.canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF everywhere and others on android, mac, and win. NOTRY=true TBR=crouleau@chromium.org BUG=1035865,978500 CC=aaronhk@chromium.org,fserb@chromium.org Change-Id: I747fb7924f9632edd3bf5f6582e99f028e4fb65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975923Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726395}
-
Robbie Gibson authored
A utility function for setting BOOL preference values was added recently, so this test no longer needs the test-specific AppInterface code setting these. Bug: 987646 Change-Id: Ic5b96b2b20667e218407663cf2d7e042371653ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972308 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726394}
-
James Hawkins authored
The registration in route.js does not include the 'apps/' prefix. R=dpapad@chromium.org Bug: 1029093 Test: none Change-Id: I4fed6fd3f98f647884604b81e518f7e483bf8fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974704Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#726393}
-
henrika authored
Extends existing logs related to media streams and media stream tracks and aligns the style with recent work in this area. Bug: 1017219 Change-Id: I88ed50cd4c0d9dd5e2f6104e8176a8ef99d6d46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960278Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#726392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/860e0e564df9..79994d4369cf git log 860e0e564df9..79994d4369cf --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com trace_processor: rename timestamp -> ts 2019-12-19 lalitm@google.com Merge "build: add example api target" 2019-12-19 lalitm@google.com Merge "trace_processor: revamp Android CPU metric" 2019-12-19 lalitm@google.com Merge "perfetto: remove redundant genrule in ipc target" Created with: gclient setdep -r src/third_party/perfetto@79994d4369cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I73286c4886054ef539ef6cb36fc5a47d82877f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976096Reviewed-by:
-
Finnur Thorarinsson authored
The small blue Play button was used when in full screen mode, but with this CL it changes to a centered large Play button. Bug: 895776, 656015 Change-Id: I502d77d0cc3d88a57e4b251b152651b1a4b6311f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970475 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726390}
-
Alex Ilin authored
This CL fixes monochrome build error that was introduced by unfortunate rebase in https://crrev.com/c/1974000/1..4 TBR: torne@chromium.org,cjgrant@chromium.org,estevenson@chromium.org Bug: 1035793, 1027573 Binary-Size: putting some missing assets back, no regression Change-Id: Ibeceacc9b876759c8ad179850ec89daea0dde613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975723Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726389}
-
ewannpv authored
- Adds new security indicator icons that are more visually balanced with the origin label. - Adds new share icon that is more consistent in weight to the other toolbar icons, and who’s scale is feels more appropriate inside the Omnibox. - Adds new toolbar icons that distinguish from Safari and are more GM2 compliant. Before: https://drive.google.com/a/google.com/file/d/1eAM4B9XFHt6iZx6c9Swks_7Qj9lL4FIF/view?usp=sharing After: https://drive.google.com/a/google.com/file/d/1Zxbv1RYuBuzjDrxSKS_QJ7ZOVQUHarNo/view?usp=sharing Bug: 1035850 Change-Id: I70cac1b64833fd9921bbc9db868862aedd797391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974090Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#726388}
-
Simon Zünd authored
This CL re-enables tests that are affected by V8's top-level await implementation. Manual wrapping of code in an async arrow function was removed from the frontend, so the 'unit' test for that wrapping code is also removed as part of this CL. Since we also correctly handle the completion value of async scripts, the top-level-await web test was rebaselined. All other tests can simply be re-enabled. Bug: chromium:1021921 Change-Id: I902f36fa5b662f7df549dc233eee94212aaeadb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962259Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#726387}
-
Demetrios Papadopoulos authored
Also moving wallpaper_browser_proxy.html/js to c/b/r/chromeos/ Bug: 1026455 Change-Id: I89e8fbcfff964fede0361e65346acce63ea8f1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975291 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726386}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. Since the value is only used for comparison, the implicit upcast to size_t will be rejecting too large sizes. This are only the trivial fixes, the complex fixes are covered in bug chromium:1030717. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=mkwst@chromium.org Bug: chromium:1008840 Change-Id: Ic6e4a07b55b1c0f37a31c8ab1de41c183032de60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964591Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#726385}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2d6ebb24. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia35e4c583199a2f1e32b85d6d105f66ff48c5c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975834Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726384}
-
Ben Kelly authored
Previously there were many different places where CacheManager() was being called like this: if (CacheManager()) CacheManager()->DoSomething(); This is problematic for two reasons. First, CacheManager() can begin returning nullptr at any time if shutdown is initiated on a separate thread. Second, CacheManager() will return a new object every time its called from a separate sequence which is wasteful in this pattern. This CL corrects these call sites to only invoke CacheManager() once and to use the returned reference instead. Bug: 1033251 Change-Id: I61c24fd9bbf20c8ad7791fdc5bb1698ea8a4c5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973998Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#726383}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c76ac8e325c7..77742c350371 git log c76ac8e325c7..77742c350371 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 brianosman@google.com Remove SkShader.Empty from CanvasKit Created with: gclient setdep -r src/third_party/skia@77742c350371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia5c1cc9b61f2456b9daf28daf53558d55fa21ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976093Reviewed-by:
-
Anand K. Mistry authored
Bug: 1007788 Change-Id: Id2118d76992100771ab28dbde2ff1c20d887e8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974296 Auto-Submit: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#726381}
-
Bence Béky authored
Change-Id: I8b30e88ec94b0aa4eac8e78af0a8d21df95902de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966278 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726380}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71befefb..121ebd03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie826ee61bd4b2e049499847c5bb10426860c25c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975833Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726379}
-
Jonathan Backer authored
GLContext::IsCurrent can result in driver calls which have a non-zero cost, as evidenced by recent sampling profiles. This happens frequently with virtual contexts on Android in the following circumstance: - {GL,Skia}Renderer gets a PassthroughImageTransportSurface |wrapper| for the display, which is a GLSurfaceAdapter wrapping |surface| - GLSurfacePresentationHelper::OnMakeCurrent picks up the |surface| and subsequently uses it to make a context current in GLSurfacePresentationHelper::CheckPendingFrames As we draw frames, we alternately make current with |wrapper| and |surface|, leading to unnecessary driver calls in GLContext::MakeVirtuallyCurrent. This CLs eliminates that by so that both the |wrapper| and |surface| are considered current whenever either one of them are. Change-Id: I153aff272b966c42a5066fb2016c9d353a1b3f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974316Reviewed-by:Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726378}
-
Yue Ru Sun authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1687059 to ensure that source ids are marked for deletion only if the navigation has succeeded, and that a same-document navigation committing does not mark the last full navigation source, which may still report events in the future. Bug: 1035493 Change-Id: Icd3af69fa28b809aac00459750e4c4b8fc43e0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935228 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#726377}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1cc63223019c..860e0e564df9 git log 1cc63223019c..860e0e564df9 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com Merge "trace_processor: migrate cpu stack profile table to db tables" 2019-12-19 fmayer@google.com Merge changes Ie41293bc,I3169ebdd,Ib8ef09a0 Created with: gclient setdep -r src/third_party/perfetto@860e0e564df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I85bfeda8962a5f3be49e761058ac29f203a78c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976092Reviewed-by:
-
Fredrik Söderquist authored
The pixel-snapping of the destination rectangle can end up distorting the geometry use for painting an SVG image preserveAspectRatio is used - the larger the aspect ratio, the larger the error. By passing the unsnapped rectangle to LayoutImageResource::GetImage, and using Image::SizeAsFloat() to compute the source rectangle of the image, e can minimize the error and allow the Image in question (an SVGImage) to perform compensation for the difference in aspect ratio between the snapped and unsnapped rectangles. This means that the painted result will better approximate the intended rendering. Also clean up accesses to the LayoutImageResource and ImageResourceContent by adding and using local variables for them. Bug: 812239 Change-Id: I0778648e7dd6fcca778a95123509f15b3519564c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969831Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#726375}
-
Francois Doray authored
This CL moves PageAlmostIdleDecorator from //chrome/browser/performance_manager to //components/performance_manager. The PageAlmostIdleDecorator doesn't depend on anything in //chrome. Additionally, this CL adds a function to create the PerformanceManager with default decorators. This allows the embedder to create a PerformanceManager with default decorators without knowing about these decorators. Bug: 1028291 Change-Id: I7115b5a7002585043d9905a440560cd82540b659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972612Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#726374}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: If0743e13be2dbe515c75d149498b59f975fdb541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970316 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/52cef46d51d3..451c28a14b36 git log 52cef46d51d3..451c28a14b36 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@451c28a14b36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17f6e093f02aa07848b370400a4c9bead6414b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976091Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at H264DPB. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin Change-Id: Ie42126e4957634c01fa78947d84a2fa98dd72acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974728 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726371}
-
Igor authored
The class contains four types of tokens, but only one token can be used. This change makes the class to keep the data in a single token and have an easy way to find the token type. BUG=None Test=None Change-Id: If9a73b5c6c2a6a5a2f6c9a6c5c7bb672e7eac765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943244Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726370}
-
Chih-Yu Huang authored
Bug: 1020668 Test: run vda_tests on kevin Change-Id: I5679d5ff65159f4f3bcb7dd62f5a3e1e09964739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974726 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Bo Liu authored
Android 10 has a bug in the app zygote implementation when used under secondary user like work profile. Update the manifest so only the the 0th service enables app zygote. Then dynamically choose between 0th and 1st service depending on if app zygote needs to be disabled. Bug: 1035432 Change-Id: Ifa3c1cb02fbc86595c7ad15c7feca35bf8ab0abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974571Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726368}
-
