GitLab

[CodeHealth] Convert chrome/browser/ui/views/tabs from base::Bind and base::Callback to Once/Repeating

Bug: 1152282
Change-Id: I4ab30e88b352645a9a32dcc834931c5a8089c87a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586155Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836761}

Screenshot: http://shortn/_JRLox4VlQe

Bug: 1156395
Change-Id: I079883b3f3557ccf6dad7cf5a39be737b8d6fec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578082
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#836760}

50% of canary dev traffic has Google Search URL modified here to add a
dark mode query param. We should only check the query is the same and
that the URL broadly matches DSE (so origin/alt origin match).

Bug: 1158466
Change-Id: Ib112dd2916e67c9fc075d4acb39e4f7e0a25ab02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588011
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836759}

Bug: 1007635
Change-Id: Ic21eacd6aa7760c94261e035871d97c1de6a8569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587351Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836758}

This reverts commit 42509254.

Reason for revert: Test ScrollNestedLocalNonFastScrollableDiv becomes flaky.

Original change's description:
> Fix ScrollNestedLocalNonFastScrollableDiv under ScrollUnification
>
> With Scroll Unification, in LayerTreeImpl::DidUpdateScrollOffset there
> are cases where a ScrollUpdate may be mutating a ScrollNode that:
> - has a MainThreadScrollingReason - the main thread needs to repaint it
> each time we scroll.
> - it isn't composited
>
> In this case, when ScrollNode is mutated we don't want to make a
> corresponding change in the associated TransformNode. Instead, we want
> to SetNeedsCommit so that the changed offset in the ScrollNode is
> committed to the main thread, then blink regenerates its side of the
> property trees and cc::Layers.
>
> In this test, we hit the first case. In order for the test to pass we
> need to wait for the main thread to sync.
>
> Bug: 1086625
> Change-Id: Icdc3eb5cc786ebdecd516f3cb0fd58d47077d6ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585765
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836593}

TBR=kenrb@chromium.org,bokan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,liviutinta@chromium.org

Change-Id: I935deae0ef3f55868d18e8f6406c9746404a375b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1086625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590426Reviewed-by: Liviu Tinta <liviutinta@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836757}

This is part of the work of migrating the existing functionality to use
the new infra components.

We factor the task management out of the context manager implementation
and into a transition called the Startup. This includes metrics
reporting as well, which make more sense in the context of the startup
object.

Bug: b/175360169
Change-Id: I49cc7e7740e76eda873ee7104924b3e344348154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584631Reviewed-by: Daniel Ng <danielng@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#836756}

This is a part of go/cros-bento which aims to improve virtual desks.

Currently a user can send the current active desk to an adjacent desk
using keyboard commands. However, they cannot send it directly to any
desk.

This CL allows users to send windows to any desk through the context
menu.

Test: manual
Bug: 1155370
Change-Id: I01d6199379a3a96ea78b5af1e3de4b8bc64fb7e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572978
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836755}

The holdback experiment ended on 2020-11-30 so this code is no longer
required.

This change mostly has no effect, assuming Finch isn't overriding the
default-enabled state of kNewSearchFeatures. The one exception is that
kLocalHistoryZeroSuggest, added in https://crrev.com/c/2581920, will now
affect Android.

Bug: 1073606
Change-Id: I251ba01c9546006dc717e5c8fc69721376d7e91c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586064Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836754}

This reverts commit d4e2b4da.

Reason for revert: Causes failures on the android-pixel4a_power-perf bot.

Original change's description:
> [tools/perf] Enable proxy power metric on Pixel 4a bots
>
> This CL supplies two command-line flags that are necessary to compute
> the proxy power metric (based on CPU usage and power profiles).
>
>  * --fetch-power-profile downloads the power profile from the cloud.
>
>  * --performance-mode=keep disables the Telemetry power management,
>  making it possible to collect cpu_freq events. Note that there will
>  likely be a drop in observed power rails metrics after this CL lands,
>  because devices will use more efficient CPU scheduling policy.
>
> Change-Id: I9aeecd80cda1a883e1994ba70b0a439cd83f8749
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566995
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
> Cr-Commit-Position: refs/heads/master@{#832770}

Bug: 1154788
TBR=johnchen@chromium.org,khokhlov@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ifdf838140e4cb2fb8bf5df321819a0d6901e299c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589858Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836753}

Original patch: http://crrev.com/c/2582997
Revert: http://crrev.com/c/2587604

Previous re-land caused MSAN failures due to uninitialized variable. This re-land has a one-line fix to initialize the value of stacking_order_ in accessibility_focus_ring_layer.h. Otherwise this patch is identical.

Tested with 'linux_chromium_chromeos_msan_rel_ng' try job. With fix, no longer get uninitialized variable failures.

Original change's description:
> Re-land: Move focus rings and highlight layers under accessibility bubbles.
>
> Original patch: http://crrev.com/c/2568547
> Revert: http://crrev.com/c/2583106
>
> Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel.
>
> Original description:
>
> Move focus rings and highlight layers under accessibility bubbles.
>
> Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers.
>
> Bug: 1157261, 1143814
> Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Joel Riley <joelriley@google.com>
> Cr-Commit-Position: refs/heads/master@{#836222}

Bug: 1157261
Bug: 1143814
Change-Id: I445296009d67c9b71d60f5e6b5f17e48b188be71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588309Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#836752}

1. Limit AImageReader max size to 1 based on the model name of the device.
Model name of the device is sent from server side using the finch
experiment.

2. There will be an equivalent critique CL to add a list of known
devices which can only support max size of 1. This CL will be checked
in first.

3. Move the finch experiment from media/ to gpu/ to avoid dependency
issues.

4. Add error logs to print device model name for the devices which fails
creating image reader with max size > 1. This is required so that the
model name can then be added to the finch experiment.

Bug: 1051705
Change-Id: Ie4809da3591b0535ca129642f248bf9534e37874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578385
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836751}

After examining these metrics, we decided that these metrics are
needed in at least 2021.

Bug: b/174067213
Change-Id: I1dabb7dddea7b6f936ecb684016332976c3e7bbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588016Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836750}

The response needs to be handled within this method anyway
adding a class for handling it would be nice, but doesn't
address any current issue. If portability is important in the
future a new class can be created at that time.

Bug: chromium:169883262
Change-Id: Idd8d8505ae003dc71f3b57b1d1877f6b4f903d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583507
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836749}

This histogram is still used by the profile metrics dashboard.

Fixed: 1121217
Change-Id: I82caf8e4c2afc738ca189ffcb57e4316e73afcb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587033
Auto-Submit: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836748}

Run with --enable-logging --vmodule=event_*=5,root_view=5 to enable the detailed diagnostic logging of input events as they pass through the event pipeline.

Bug: 1156656
Change-Id: I9f1c7b369276ada145fb06586a8d5fd5d0582bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550367Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836747}

As a label button, the read later button will match the style of the
other bookmark bar buttons. This change also fixes bugs with the button
label/icon not updating colors corrently with themes.

Bug: 1109316
Change-Id: Iebe176f60a87d26abbfdf1c8e01bc4c36f135445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586242Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836746}

This ensures that the MediaToolbarButtonView, which inherits from
ToolbarButton, gets the promo highlight. Before this change, the promo
highlight was only applied to the BrowserAppMenuButton.

Screenshot: https://screenshot.googleplex.com/FiSjzR3C4EZdDcJ

Bug: 1055150
Change-Id: I6d8aae51731ca7c5d22283088f689ef16cfc88b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588643Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#836745}

Resumes now happen at sentence boundaries.

AX-Relnotes: N/A

Bug: 1157817
Change-Id: Iaad4aa3fb0ae19d0d27d511e3cd8a04209d104bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586767Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#836744}

Bug: 1157603
Change-Id: I04bf94d2e2d758cd871d5328513de135c2e155de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585843Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836743}

This CL has no intended behavior change.

Change-Id: Ic05292cb7f620cd02e2950bee17b48c0ae69b725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585541
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#836742}

Roll Chrome Linux PGO profile from chrome-linux-master-1607925234-871dfb77196d03b9fcef95521dbd7963c906e6ee.profdata to chrome-linux-master-1607968714-2c0d8e306c302723844f6b00a98bd81e984a44c7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib9a429aa2088d617b48f40e524d685fd5c005259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836741}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c16dc7107fd3..7a0ca4ead94d

2020-12-14 capn@google.com Check that MSan builds use Clang

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I7ce57becb74239967bd0403f4e840cbea83b7656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588618Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836740}

Better document which kinds of "apps" use this type.

See also go/cros-app-types

Bug: none
Change-Id: Ia6b799915bc17a40ea151a9feda5a2e2da7ec3d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587869
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836739}

BUG=chromium:1158107
TEST=Fuzzer test passes

Change-Id: I8451e40e0ac5e89059e336618ebe2ed737ef96c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585823
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836738}

Bug: 1152274
Change-Id: If300d7e0fd0c39d56d4918ba0a414d93b88b7c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587375Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836737}

Records Suggestions.Tile.Tapped when tapping on an MV tile in Start.

Bug: 1033257
Change-Id: I720f8a987c37e6fa1a11751652cd1efe0f235a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590284Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836736}

BUG=b:153111783
TEST=Encrypted HEVC playback works w/ clear testing flag enabled

Change-Id: I08372658b04c2cadf2b6d032e619406ea05516e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587521
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#836735}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I50af9c054ccff43951ff6897e6a9dea04d93b2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836734}

cleanup() should have also been called after line:79 when iframe is
detected.

Bug: 1157974
Change-Id: I505fa12a82a17da4f3a2ae6dcd239c0f0613be59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588644Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836733}

Similarly as for effects. 'clip-path' is (sometimes, if mask) applied
via PaintLayerPainter, and we need an SVGResourceClient for it to manage
resources properly (respond to clip-path changes etc.).

See also crbug.com/892734.

Bug: 1158417, 1028063
Change-Id: I2aae303c6dcbf9bd5964bf40253a7fa7cb733058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589876Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#836732}

When rendering HDR video/texture quads, SkiaRenderer disables implicit
color conversion in Skia by making the SkImage color space match the
destination color space.  After the above fix was landed, an old DCHECK
was left in accidentally.  This CL fixes the incorrect DCHECK.

Bug: 1153917
Change-Id: I1ba9da4ae4a78090fb3e96d3196cc141a0b6618a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587831Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836731}

This reverts part of the code in commit 57f97b28.

The reason is that, based on mmenke@'s comment in crrev/c/2570123,
copying the whole set once per saved cookie for comparison is generally
not worth the overhead, should use an enum class object instead.

Bug: 1136102
Change-Id: I3bcc07a84d64e8ce55fb999567e154fdbfe43443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580461Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836730}

TBR=ynovikov@chromium.org

Bug: chromium:1136231
Change-Id: Ib05d4463514e29bc4827b32a10ac6459011043b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590039Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836729}

As part of one time permissions for Geolocation on desktop, updated the Content Settings Bubble and Site Settings page to reflect the change.

Bug: 1150347
Change-Id: I6d13c59315a60fdf64a4ef54d52a2b7882f752a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544889Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836728}

This is needed so //ui/gfx/x/ can register event dispatchers.

BUG=739898
R=sky

Change-Id: Iacff98f103a1a0094f6e11e0453da20580b3aeb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836727}

No change to logic. This adds laisminchillo@ to support_library OWNERS.
She has already reviewed several changes to this directory and has been
a committer for quite some time.

Test: N/A
Change-Id: I2920f0b4fa2e39c800d97217b13ef1d478d5751e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589639
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836726}

When you install the CRD Host MSI and the website is open to either
/access or /support (after generating a code), the install will
appear to be successful but the user will get a warning that they
need to reboot their machine.  This is because although the files
were removed, the website is using the old NMH processes which are
still in memory.

To prevent this error (and to ensure the new NMH are being used),
we can run taskkill as a custom action to close the in-memory
instances of the Me2Me and It2Me native messaging hosts.  This will
prevent the error from being displayed.  The user will needed to
refresh the website if they are in this state, but they won't be
running old code.

Bug: 1003606
Change-Id: Ia6355942acb154eaabf2b2a7d84a5250e9d1a1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587619Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836725}

Couldn't help myself when I noticed this bug with
::file-selector-button.

Fixed: 978105
Change-Id: I42da51ffa7117e0d4ecd55e2e12fbb7548571378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587042
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836724}

Bug: none
Change-Id: I387f48a86be50c70c10d107d30c6b35328a3b7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587766Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836723}

With isolated splits enabled, the classes from a DFM will not be
available in the base ClassLoader. This change makes sure all of the
calls to inflate in autofill_assistant are able to access the classes
defined in the DFM.

Bug: 1158028, b/174219371
Change-Id: I6e6599f0831b089d97d5041864ce9df41c00e0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587872Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836722}