- 02 Aug, 2018 40 commits
-
-
Hector Carmona authored
Bug: 832938 Change-Id: I315fa5a1fbb25d321828b922271c067f38a54535 Reviewed-on: https://chromium-review.googlesource.com/1157513 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#580338}
-
Dale Curtis authored
Without this we end up using bogus source ids for reporting to UKM which end up dropped. BUG=870407 TEST=none Change-Id: I6dd43a70dad670613c9bffe440a5f4d8934d3a42 Reviewed-on: https://chromium-review.googlesource.com/1161162Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580337}
-
Navid Zolghadr authored
Change-Id: I6482dcf43065cf07d994d35f7334e798915174e5 Reviewed-on: https://chromium-review.googlesource.com/1161204Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580336}
-
Johannes Henkel authored
... except for the virtual time properties. I'll do these separately so it's possible to review them. Bug:851762 Change-Id: I49333c7e0265cfc855cdb550e6f3338f74d1ebb1 Reviewed-on: https://chromium-review.googlesource.com/1157696 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580335}
-
Eric Roman authored
Moves CertBuilder higher in the file so it can be used in a follow-up change. Change-Id: Ic51018282de2deb851d08bfdc9246850babdb73c Reviewed-on: https://chromium-review.googlesource.com/1161108Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580334}
-
Philip Rogers authored
This internals-only code is not needed post-rls. BUG=823365 Change-Id: I48e9a149230a89bc235e3323a132420764fbc394 Reviewed-on: https://chromium-review.googlesource.com/1154321Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580333}
-
Quan Nguyen authored
Bug: 863620 Change-Id: Id15fc12e23ca4fd51b92454d27d87133120aee82 Reviewed-on: https://chromium-review.googlesource.com/1157249Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580332}
-
Chase Phillips authored
As a result of the recent IO thread hopping removals, |io_runner| is no longer needed. Bug: 717812 Change-Id: I525785fda65a2edfaf86f11bcfcc21d6c74de85b Reviewed-on: https://chromium-review.googlesource.com/1155830 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#580331}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5300616351f5..3481542a423d git log 5300616351f5..3481542a423d --date=short --no-merges --format='%ad %ae %s' 2018-08-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@3481542a423d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idb0f1f657c162e9e2293ab4eb0ede6b3b3a64e0e Reviewed-on: https://chromium-review.googlesource.com/1160793Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580330}
-
Johannes Henkel authored
There's just one field for the enabled bit so this one's trivial. For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Bug: 851762 Change-Id: Ie709f8c99d196f5be018838e1cb9e70a2cb6aed8 Reviewed-on: https://chromium-review.googlesource.com/1159721 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc73f241145d..cb4ae446080b git log cc73f241145d..cb4ae446080b --date=short --no-merges --format='%ad %ae %s' 2018-08-02 thomaslmiller91@gmail.com Make Angle compile for Arm64 Windows Created with: gclient setdep -r src/third_party/angle@cb4ae446080b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5986cace96b3b6f981fe95b23aed231187ded690 Reviewed-on: https://chromium-review.googlesource.com/1160796Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580328}
-
Philip Rogers authored
This patch fixes a crash where we were using the wrong paint offset when snapping the scrolling contents rect. Previously, the scrollable area's location was used as the paint offset, but this is incorrect and the property tree builder's context should be used instead. This patch adds a unit test that mirrors a composited layer mapping test of the same issue (ScrollLayerSizingSubpixelAccumulation). It also adds a minimized layout test of the crash. Bug: 868613 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d045ae4d50ccb7a8eae6efbe2817e6e93d462ee Reviewed-on: https://chromium-review.googlesource.com/1158798Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580327}
-
Nico Weber authored
As far as I can tell, this is unused. Bug: 489490 Change-Id: I729acb5d1f50ad56848e00b3c2b771e1074dba00 Reviewed-on: https://chromium-review.googlesource.com/1160777Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580326}
-
Eric Orth authored
Implemented as a single ResolveHost method in NetworkContext for now with all the real work in a separate ResolveHostRequest class that we'll be able to use from multiple places if we copy or move the ResolveHost method to other interfaces. Per recent discussions, we've diverged from the design in the doc. Responses are now always sent via a dedicated response client mojo pipe instead of using response callbacks on the request pipe. This makes cancellation and callback control much clearer and bug-proofed for clients because it's always clear which pipe controls the callbacks and the callbacks are usually tightly bound to the relevant mojo binding. The design doc will be updated after this CL is landed. Design doc: https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib0ae407008fdbec089437083796cae725cd8d8d0 Reviewed-on: https://chromium-review.googlesource.com/1113665Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#580325}
-
Alexis Hetu authored
As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324}
-
Peter Kasting authored
With the increased frame/tab heights in refresh, not all theme frame images are tall enough. Opque frame didn't tile at all, and glass frame repeat-tiled; both look bad with certain themes (e.g. Into The Mist). Vertically mirroring looks better. Bug: 866671 Change-Id: I594e189196abff0ea55248be4ab9ca8f404fe3c2 Reviewed-on: https://chromium-review.googlesource.com/1157877 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580323}
-
Vladimir Levin authored
This patch ensures that IsSkippingCache, which is the only public indicator that we might skip a cache, to return true if the paint controller is transient. This ensures that DCHECKs that verify the caches don't fire if they are guarded by IsSkippingCache checks. R=pdr@chromium.org, chrishtr@chromium.org Bug: 869809 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1051609f65588dbef31e6d2b81e77d16752d2982 Reviewed-on: https://chromium-review.googlesource.com/1161057Reviewed-by:
-
Zach Helfinstein authored
Switch access should only use KeyEvents from physical keyboards as switches; virtual keyboard events should be ignored. Added a browser test for SwitchAccess BUG=864802 Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc Reviewed-on: https://chromium-review.googlesource.com/1114069Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#580321}
-
Mustafa Emre Acer authored
This is a followup to crrev.com/1097549. Bug: 843361 Change-Id: Ifed5b3aaff5a4312e7302904c28955232f125a7c Reviewed-on: https://chromium-review.googlesource.com/1155758 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Mao Huang authored
Original CL: - https://codereview.chromium.org/1678893002 allocator: add use_experimental_allocator_shim build flag This CL introduces a new GYP/GN build flag use_experimental_allocator_shim (default: false). After this CL, the only side-effect of that flag is that tcmalloc does not override anymore the libc symbols (malloc, new etc.). This is in preparation of a unified shim layer, which will come separately in upcoming CLs, which will take care of overriding those symbols in Chrome. Design doc: http://bit.ly/allocator-shim BUG=550886 Committed: https://crrev.com/3217078aa86523fb341e0cf2b0c49d55434b534a Cr-Commit-Position: refs/heads/master@{#374449} BUG=724399,b:70905156 Change-Id: Iaa205ec87dc160a2e738cc0d9adfe3c66acb12d9 Reviewed-on: https://chromium-review.googlesource.com/1130785 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580319}
-
Danyao Wang authored
This works around a quirk of WKWebView that changes URL in between didCommit and didFinish callback of the same WKNavigation. This fixes DCHECK in error_try_state_machine.mm. Bug: 869540 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5fd9b35732a9717de47bdfb43d1e943770b2f9ee Reviewed-on: https://chromium-review.googlesource.com/1157911 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1de8d3d..cdda2f0c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f211f368f637f48a6f09bf252d0945ef6f190d3 Reviewed-on: https://chromium-review.googlesource.com/1161020Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580317}
-
akaba authored
This CL removes Child to Parent relationship is in SurfaceReference as a cleanup step toward making Viz more clean and efficient. This relationship is not contributing to any logic so it's safe to be removed. Bug: 868925,869444 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I458ca17de868ef31eada09b5ff23c09c13c22523 Reviewed-on: https://chromium-review.googlesource.com/1155095 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580316}
-
Quan Nguyen authored
This CL moves LoginUserMenuView::EnsureWidgetInWorkArea to LoginBubble::EnsureBubbleInWorkArea and adds handling for the case where the bubble extends past the right side of the screen. Bug: 827599 Change-Id: I29de2ac035e2a641250a047283cf0b5aa66a55ea Reviewed-on: https://chromium-review.googlesource.com/1160933Reviewed-by:
-
Ramya Nagarajan authored
Only the first experiment entry gets covered by perf waterfall, so adding this item ensures better test coverage. Also, the existing experiment, NewTabPageAllBirthday_Enabled, could not be re-used since go/revising-finch-configs recommends creating a new experiment when changing size or behavior of existing groups. Bug: 831910 Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 Reviewed-on: https://chromium-review.googlesource.com/1160925Reviewed-by:
-
akaba authored
This CL fixes SurfaceRange::IsInRangeExclusive in the case when the embed tokens are different by comparing with either ends of the range. In addition, it adds 2 extra utility functions to SurfaceRange which are needed to make the code cleaner for following work. Bug: 867531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia542e94b13c566989f3764c32cad4016bfddd32b Reviewed-on: https://chromium-review.googlesource.com/1159100 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit 9a6c55fc. Reason for revert: Linux CFI and Android CFI both breaking on bluetooth tests after this landed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352 Original change's description: > [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set > > BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of > std::set_union in order to merge advertised uuids and service uuids. > However, std::set_union requires sorted ranges as input, which wasn't > necessarily guaranteed before this change. When using a > std::unordered_set the order of elements is not specified and > std::set_union is not guaranteed to work correctly. Using a > base::flat_set for UUIDSet instead fixes this issue. In order to prevent > future regressions this change also replaces the usage of std::set_union > with base::STLSetUnion performing an explicit IsSorted() check in Debug > builds. > > Bug: 821766, 870208 > Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0 > Reviewed-on: https://chromium-review.googlesource.com/1159374 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580198} TBR=ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I6e3ce514af12bc718a2b759d73086d24d3446c9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1161022Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580312}
-
akaba authored
GetLatestInFlightSurface should return the primary if it exists and active. There is no reason for it not to do so and this will make working with it easier. Bug: 869507 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icae9da8527de69555e8c925740c08b187f827b02 Reviewed-on: https://chromium-review.googlesource.com/1157140 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Majid Valipour authored
WorkletAnimations which have a ScrollTimeline need to be animated and ticked every time that scroll offset is changed on compositor thread. This ensures their output is in sync with scrolling. Scroll animations on compositor (e.g., smooth wheel animations) are a source of scroll offset change on compositor. So to make sure scroll-linked worklet animations can respond to latest scroll offset we need to tick these animations **after** cc scroll animations produce their output. Previously our approach was to tick mutator (update all worklet animations) once before ticking all animations and every time a cc scroll animation change the scroll offset. However, ticking mutator updated worklet animation without actually applying their output which meant worklet animation can fall behind cc scroll animation. Further more this causes mutator to be ticked multiple times (once per each scroll animation). This patch changes our behavior as follows: - Tick regular animations which including cc scroll animations. - Tick mutator which sends update to AnimationWorklet and receive its new output. - Tick worklet animations to apply the new output. This ensures we see the scroll animation and any linked worklet animation output in the same frame. Also it avoid excessively ticking mutator since we only need to do it once after all cc scroll animations are ticked. TEST:AnimationHostTes.LayerTreeMutatorUpdateReflectsScrollAnimations Bug: 844436 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ica09a4779ae3b78af9f0f93125a43846d91e8bc1 Reviewed-on: https://chromium-review.googlesource.com/1152899 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580310}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b07deb3fc1f5..8ed949d3dcdc git log b07deb3fc1f5..8ed949d3dcdc --date=short --no-merges --format='%ad %ae %s' 2018-08-02 thestig@chromium.org Remove some checks in IsLinearizedHeaderValid(). Created with: gclient setdep -r src/third_party/pdfium@8ed949d3dcdc The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7a15c4c8c68c5b0a4667c44baab6cf6e06c1fa9d Reviewed-on: https://chromium-review.googlesource.com/1160794Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580309}
-
Jun Choi authored
Currently resident key option in CTAP MakeCredential request parameter is set to false regardless of what the relying party sets in AuthenticatorSelectionCriteria. Add resident key option to CTAP MakeCredential request accordingly. Bug: 870153 Change-Id: I3c964c0e036008f3d38d60a5ab3c6610eb80085b Reviewed-on: https://chromium-review.googlesource.com/1159825 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#580308}
-
Sarah Hu authored
This fix the linux-chromeos-dbg compile error by export class PublicAccountWarningDialog. TBR=xiyuan@chromium.org,msw@chromium.org Bug: 864549 Change-Id: Ibf7e0b14a17460114563bf40bc562294b86993cb Reviewed-on: https://chromium-review.googlesource.com/1145864 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580012} Reviewed-on: https://chromium-review.googlesource.com/1161082 Cr-Commit-Position: refs/heads/master@{#580307}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a31f4e51d559..20ee171b98bd git log a31f4e51d559..20ee171b98bd --date=short --no-merges --format='%ad %ae %s' 2018-08-02 robertphillips@google.com Revert "Update GrTextureStripAtlas for DDLs" 2018-08-02 kjlubick@google.com Productionize PathKit 2018-08-02 fmalita@chromium.org [skottie/sksg] Move source files list to .gni 2018-08-02 robertphillips@google.com Update GrTextureStripAtlas for DDLs 2018-08-02 stani@google.com Prototype an Android lottie player 2018-08-02 halcanary@google.com tests: Move SkUTF tests to their own file. 2018-08-02 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e22c542d6be..dd4c8631343f (1 commits) 2018-08-02 jvanverth@google.com Fix minimization function for offset code 2018-08-02 benjaminwagner@google.com [infra] Ensure Mac xSAN backfill tasks can find Xcode. 2018-08-02 bsalomon@google.com Move mip map regen from GrGLProgram to GrGLGpu Created with: gclient setdep -r src/third_party/skia@20ee171b98bd The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icecbe92f71210720d4f37bae7fe8352f71039fe0 Reviewed-on: https://chromium-review.googlesource.com/1160788Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580306}
-
Dan Sinclair authored
This will pull in the SPIRV-Tools fuzzers. TBR=piman@chromium.org Change-Id: I16112846d862dbeb385cd2d22fe639376d63629f Reviewed-on: https://chromium-review.googlesource.com/1161090Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#580305}
-
Dan Elphick authored
Use v8::Value::SameValue instead which does not require a Context and works just as well (if not faster) when both arguments are v8::Strings. Change-Id: I41f4e2b78f94671b4408c45b97c0e7b22ba554fb Reviewed-on: https://chromium-review.googlesource.com/1150524Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#580304}
-
Cathy Li authored
Bug: 867488 Change-Id: Ibb67a81cfef555e93128ae395fe6a9f0081a45ed Reviewed-on: https://chromium-review.googlesource.com/1157183 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Consider the sequence: 1. We query the number of displays using CGGetActiveDisplayList and get |display_count| as 0. 2. We allocate a vector |displays| with that size, so it's nullptr. 3. We populate that vector with a call to CGGetActiveDisplayList, but, because |displays| is nullptr, that populates |display_count| with the number of displays on the system. 4. BUT, it so-happens that between steps 1 and 3, we added an active display, so |display_count| is now non-zero. 5. We now index into |displays|, which is empty, and blow up. Early-out if our initial |display_count| is zero to avoid this situation. Bug: 870320, 869570 Change-Id: Ibeec67ce430faccb6e350af3fb335f1770e7b072 Reviewed-on: https://chromium-review.googlesource.com/1160769 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580302}
-
Jared Saul authored
Bug: 868566 Change-Id: Icf41453cc6b4528463e32338d30eef0c037ce6b4 Reviewed-on: https://chromium-review.googlesource.com/1159738 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580301}
-
Matthew Jones authored
This patch re-adds some of the code that was removed during Chrome Home cleanup to correctly position the overflow menu when anchored to the bottom of the screen (removal patch fround here: https://chromium-review.googlesource.com/c/chromium/src/+/934978). Bug: 866265 Change-Id: I4e4341b138cd9315f9a7fae8cbf47487923a0086 Reviewed-on: https://chromium-review.googlesource.com/1161174Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#580300}
-
Danyao Wang authored
This is to ensure that BrowserViewController's |updateToolbar| never mistakes the pending back/forward navigation item for the last committed item and prematurely hides adaptive toolbar. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22e8358c1127878a983a657ad1373ed98303d6f7 Reviewed-on: https://chromium-review.googlesource.com/1157915Reviewed-by:
-
