- 13 Apr, 2018 40 commits
-
-
Patti authored
The KeywordHintView should be dark in incognito mode in touch. Fix. This patch also fixes a bug where the KeywordHintView would not update itself if the browser window was resized with it showing. See screenshots - https://drive.google.com/file/d/1RM2TC9Wg3Js6UCrntkWc808pj_S3A59b/view?usp=sharing Bug: 830328 Change-Id: If9bb98d447454d34448cd9d63d31e6afc471cecc Reviewed-on: https://chromium-review.googlesource.com/1004714Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#550511}
-
Yuly Novikov authored
conformance2/transform_feedback/too-small-buffers.html on Win NVIDIA OpenGL no_passthrough BUG=832238 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie44d23e20053e06e7c355b2b20609a37b3d049ba Reviewed-on: https://chromium-review.googlesource.com/1011597 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550510}
-
Min Chen authored
Should cancel the stated showing menu animation for repeat power button releases. Otherwise, the ongoing animation will run the callback function SetShowMenuAnimationDone to start |pre_shutdown_timer_| OnImplicitAnimationFinished after release the power button. This will lead to device power off. Bug: 831915 Change-Id: I07753f4156dfc7ba299c37f8fd7a7551d5ec858a Reviewed-on: https://chromium-review.googlesource.com/1009485Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550509}
-
chaopeng authored
Disable overscroll history navigation on Windows Touchpad with feature flag. This CL also wraps all changes in crrev/c/98210 and crrev/c/1003214 behind this flag. This CL also disable overscroll history navigation on Linux Touchpad since we will set has_precise_delta for Linux soon. Bug: 647140 Change-Id: Id08654bf20b3ada7b5e75f2308a915efeed0e934 Reviewed-on: https://chromium-review.googlesource.com/1002866 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550508}
-
Ramya Nagarajan authored
This change adds an emoji icon to be shown along with the menu text. https://screenshot.googleplex.com/LO3aKXYwaqc. For more details, see http://go/chrome-emojisertion. Bug: 827404 Change-Id: I2b480a7a60ca92ceeb042bdc347ebb5441fd71f7 Reviewed-on: https://chromium-review.googlesource.com/1010978Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550507}
-
Dale Curtis authored
Expecting readyStateChanged() to quit the message loop and do nothing else appears to be unreliable due to us having configured our ScopedTaskEnvironment for asynchronous execution. Switching to a manually queued version would be painfully verbose given all the happenings of the underlying demuxers and decoders; so instead wait for loading to complete instead of quitting mid-way through the loading process. BUG=831566 TEST=tests don't flake under tsan. Change-Id: If59ab647bb349bf996050545bb63b0e65cc471e2 Reviewed-on: https://chromium-review.googlesource.com/1011642 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#550506}
-
Peter Boström authored
Changes the color from 212121 to 202124. This also makes sure that the site permission (page info) icons are rendered close to their correct GG700 by default (they are derived from this text color). Bug: chromium:820531, chromium:821996 Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1 Reviewed-on: https://chromium-review.googlesource.com/1011548Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550505}
-
Peter Boström authored
This method is used from ToolbarActionsBar to see if BrowserActionsContainer is larger than all visible actions (and needs to be downsized). Per a recent change this was clamping to the ToolbarActionsBar max size which would make ToolbarActionsBar think it's already the appropriate full size and not not animate it to the smaller new full size. Bug: chromium:831977 Change-Id: I1a8b3a83504a4f0afcf6e72146bef0e85ecc4fd9 Reviewed-on: https://chromium-review.googlesource.com/1011343Reviewed-by:
-
Steven Bennetts authored
Bug: 831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55a1de65656bb646b9954dfafa5199dc3667867e Reviewed-on: https://chromium-review.googlesource.com/1010913Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550503}
-
Giovanni Ortuño Urquidi authored
Also changes Installable to an enum class to avoid accidental implicit casts to bools. Bug: 801940 Change-Id: I186d878b338375e339b3b5eb24fa5f2abd6c975a Reviewed-on: https://chromium-review.googlesource.com/981835Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#550502}
-
Paul Dyson authored
Bug: 820883 Change-Id: Id1fe9224d8a0a39104a44205799ddc9d9093dc89 Reviewed-on: https://chromium-review.googlesource.com/1005637 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
-
Dave Schuyler authored
This CL will parse the rich entity image dominant color and the image URL. The data is not yet used on the client, that will happen in a later CL. (Similar to the prior CLs which moved the values from the CompleteServer to GWS; then from GWS to Chrome; now this moves the values from the received JSON data to closer to the GUI code). TBR=mpearson@chromium.org Bug: 798631 Change-Id: I1d4a31e4b149669c058340ad856ebf89f0663147 Reviewed-on: https://chromium-review.googlesource.com/994129Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
This depends on crrev.com/990203. UI spec: page 10 in https://docs.google.com/presentation/d/1Kp8trbUeYH8W04pX14WHi99u7_QdSIx7QpuaH3idCeg/edit?usp=sharing Screenshot: https://drive.google.com/file/d/19AvhiZCyinocnfpoaa5HxEo3m1kSJ6d2/view?usp=sharing This also change UpdateAutoHideFrame to check if it's maximized/fullscren or pinned so that autohide happens when the state switched to maximized. I also fixed TestClientControlledStateDelegate::HandleBoundsRequest. It should commit only if it has something to commit. BUG=b/33693796 TEST=manual. covered by unittest. Change-Id: I0ac1b9a57112c0e7d86745f990fa16ab1c7d7945 Reviewed-on: https://chromium-review.googlesource.com/1009205Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550499}
-
Kenneth Russell authored
With the WebGL conformance roll in https://crrev.com/d5fd79c66c041e669cb7cc0d0a41dbcdac886649 , this test should be passing reliably. Tbr: kainino@chromium.org Bug: 818336 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3fbff79ce0cd11afc562870dd4f05ed06303bafd Reviewed-on: https://chromium-review.googlesource.com/1011593Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550498}
-
Matt Falkenhagen authored
These tests no longer exist. Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I51cf81a18df2b3740613b0c08c8eceb64424e747 TBR: shimazu Reviewed-on: https://chromium-review.googlesource.com/1011524Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550497}
-
Farah Charab authored
the overhead associated with seeding the generator. One can do ~18 M (~26 M) calls per second when using unifom_int_distribution on top of Mersene engine versus <1M (~ 8M) calls per second when using the current implementation on POSIX and Windows, respectively. Note that these figures are obtained when the generator is seeded once, otherwise the figure obtained for the suggested implementation would be <1M (this is for POSIX, we don't have the figure for windows). To that end, we use thread's local storage to seed the generator once. Change-Id: I628d2e0ab882a9703e52b4007d53fa5cf49d4d47 Reviewed-on: https://chromium-review.googlesource.com/982115 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550496}
-
Miguel Casas authored
This CL corrects the initialization value of |display_id| from -1 (which is bad) to what it used to have before the CL reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/970085/23/ui/ozone/platform/drm/common/drm_util.cc#b385 The -1 it breaks (at least) amd64-generic-tot-chromium-pfq-informational (see bug). TBR=dnicoara@chromium.org since it's a trivial fix and has been verified. Bug: 832136 Change-Id: I3c1db741979f20877483880b87f2d052b2a02cf9 Reviewed-on: https://chromium-review.googlesource.com/1010517 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550495}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20586d941c23..d2c34b35c8b1 $ git log 20586d941..d2c34b35c --date=short --no-merges --format='%ad %ae %s' 2018-04-04 cmtice [clang-tidy-builder] Fix some issues with builder not finding logs. 2018-02-28 phobbs cidb: Remove status arg from latest build requests Created with: roll-dep src/third_party/chromite BUG=chromium:831200,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8b28b7da1eaa3ffaf2f4053403ac9c80b5a1e2bf Reviewed-on: https://chromium-review.googlesource.com/1011219 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550494}
-
Yunchao He authored
Removes the suppression for: conformance2/textures/image_bitmap_from_image/ tex-3d-r16f-red-float.html Bug: 679695 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifec56d01e4cf903f827a09a1aa176275912c8f0c Reviewed-on: https://chromium-review.googlesource.com/1010022Reviewed-by: -
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bf1af11228f..130fd7666d42 $ git log 6bf1af112..130fd7666 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I59c7b196f5cc9369305cb4cdf81e65a96b6e1a7c Reviewed-on: https://chromium-review.googlesource.com/1011559 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550492}
-
Scott Little authored
Bug: 635105 Change-Id: Ic1d61399cf3b1f5aafeed64238c25250849d43a4 Reviewed-on: https://chromium-review.googlesource.com/1011386Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#550491}
-
James Hawkins authored
R=khorimoto@chromium.org, tbarzic@chromium.org Bug: 829039 Test: none Change-Id: I25c885d2bbed34146dc313e2298384e90b00e425 Reviewed-on: https://chromium-review.googlesource.com/1011345Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#550490}
-
Andrey Kosyakov authored
Just moving & renaming classes, no logic changes yet. Change-Id: Ic736feeef5524d6145e1c505fbfa50538b041732 Reviewed-on: https://chromium-review.googlesource.com/1011503Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550489}
-
Hiroshige Hayashizaki authored
Bug: 827415 Change-Id: Ia1d57357525366f1c07a6fd1d87b4f604072cb7a Reviewed-on: https://chromium-review.googlesource.com/1000720 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550488}
-
Becca Hughes authored
Update preload=none state based on the new mocks. Also adds ShouldShow[Audio/Video]Controls to MediaControlsImpl to simplify the logic around which set of controls we should show. BUG=818659 No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide3bed15161aa5e1e1096275212c718eacb24a77 Reviewed-on: https://chromium-review.googlesource.com/993757 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550487}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: Ia95e37e8d28d41fbf56ece38fedda14da6a64060 Reviewed-on: https://chromium-review.googlesource.com/1009683Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550486}
-
Ian Vollick authored
Too many issues close to branch. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I464cb04328684ff1888821465a394a0c0d983e32 Reviewed-on: https://chromium-review.googlesource.com/1011353 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550485}
-
Peter Boström authored
More functionality is about to be added into this button so it's no longer appropriate to bundle it into ToolbarView. Doing this as a separate step to avoid large patches. Bug: chromium:822070 Change-Id: I07f690ebeefa29f4ac4177cb59785bab01a56f0b Reviewed-on: https://chromium-review.googlesource.com/1008628 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I55f6ffafa1cc11c0199ab9ef9076cbc8b06ffd92 Reviewed-on: https://chromium-review.googlesource.com/1011782Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550483}
-
Jianpeng Chao authored
This reverts commit 6c5c219b. Reason for revert: buildbot failed Original change's description: > [Extensions] Stop loading manifest v1 extensions > > Manifest v1 extensions have been deprecated for a long time. > Stop loading these extensions unless a special (existing) commandline > flag is present. There are a few straggling tests (which rely on > packaged extension resources, like .crx files) that still need to be > updated; use the commandline flag (or a runtime variant) in those tests. > These will be cleaned up in follow-up CLs. > > Bug: 831909 > Change-Id: If2323829cd75f826d54a34b713eecf7c28973667 > Reviewed-on: https://chromium-review.googlesource.com/1009070 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550426} TBR=stevenjb@chromium.org,pastarmovj@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,qinmin@chromium.org Change-Id: I5a0a4c7f90421d139dce7cdc27d1affa2059c5a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831909, 832488 Reviewed-on: https://chromium-review.googlesource.com/1011710Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550482}
-
Hiroki Nakagawa authored
This reverts commit fef93a84. Reason for revert: This seems to cause compile failures on multiple bots: https://ci.chromium.org/buildbot/chromium/Win/66061 https://ci.chromium.org/buildbot/chromium/Linux%20x64/62330 Original change's description: > Extensions: Rename DictionaryBuilder::SetBooean -> Set. Same for ListBuilder. > > The overload resolution failure isn't any issue anymore after > https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9, > so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append. > > Bug: None > Test: Internal only change. > Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1 > Reviewed-on: https://chromium-review.googlesource.com/1009489 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550475} TBR=avi@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org Change-Id: I90a4d81ee507212f829c85c6aba77334ce3bb97c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1011763Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550481}
-
Jianpeng Chao authored
This reverts commit e192695d. Reason for revert: Buildbot failed. Original change's description: > [media] VdaVideoDecoder > > This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a > media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access > to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. > > VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is > inherently tied to the GPU thread. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I23f81c92b9ad72a5f0141c2eec2a528de1ffa9d3 > Bug: 522298 > Reviewed-on: https://chromium-review.googlesource.com/940336 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550471} TBR=xhwang@chromium.org,sandersd@chromium.org,liberato@chromium.org Change-Id: I706bf6a9b8b31d430b5facd0151e7e20dc73bcfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522298, 832484 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1011709Reviewed-by:
-
Nico Weber authored
We accidentally passed -T to the static archive tool on mac and ios. The static archive tool on mac and ios is not ar but a mac-specific tool called libtool, and its -T flag means something completely different. Bug: 801925 Change-Id: I44dacbb8696cceb26ac7a5de86a2e8a0de638c00 Reviewed-on: https://chromium-review.googlesource.com/1010513 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550479}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/51c84139d960..7aaece4a0870 $ git log 51c84139d..7aaece4a0 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 derat system_api: Add type field to PowerSource message. 2018-03-16 allenvic smbprovider: Add auth params for MountOptionsProto 2018-04-06 jkardatzke Constants for D-Bus server for opening URLs with Chrome 2018-04-06 timzheng Add D-Bus call to concierge for getting icons. 2018-03-18 claudiomagni Add main mojom files for the ML Service API. Created with: roll-dep src/third_party/cros_system_api R=jkardatzke@chromium.org Bug: None Change-Id: I89147d8d0f92f8968f117789296578db637b8867 Reviewed-on: https://chromium-review.googlesource.com/1011124Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#550478}
-
Helen Li authored
Bug: 821030 Change-Id: Iec0c32ba9cc7cb0335e7c320179e2689ab59bba6 Reviewed-on: https://chromium-review.googlesource.com/957918Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550477}
-
Tetsui Ohkubo authored
Different from the current notification center, UnifiedSystemTray will shrink its area when notifications are removed. UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=828752 Change-Id: I5c793d39f88aa81fb7a2fa90366e62fc5dc9af2d Reviewed-on: https://chromium-review.googlesource.com/1011522Reviewed-by:
-
Istiaque Ahmed authored
The overload resolution failure isn't any issue anymore after https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9, so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append. Bug: None Test: Internal only change. Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1 Reviewed-on: https://chromium-review.googlesource.com/1009489Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550475}
-
Daniel Nicoara authored
If the output surface is displayed as an overlay plane and there is a video underlay, make the primary plane blend with the underlay such that the transparent video hole in the primary plane allows the video to show. Bug: b/74998539 Test: Ran on device and verified video shows Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I01fd6c325dd2e93f7781fbbf1619bca402998217 Reviewed-on: https://chromium-review.googlesource.com/1005808Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#550474}
-
Erik Luo authored
Around M63, logs from OOPIFs contained invalid scriptIds that led to linkifier failure, preventing users from seeing their logs. A fix [1] landed to make JSPresentationUtils not throw when linkifier fails. This CL adds a test. [1] https://chromium.googlesource.com/chromium/src/+/060e1aacae0500e12dbb746ef4242dc3ec49eadb Bug: 826210 Change-Id: Ie343b7927ee15c0def8fc28723b2d763ecad875a Reviewed-on: https://chromium-review.googlesource.com/1011453Reviewed-by:
-
Bret Sepulveda authored
On Windows the system menu is expected to appear on a single left-click to the top-left corner of the window, and a double click is expected to close the window. The Views window icon added by custom titlebar was intercepting the click and so the WM_NCLBUTTONDOWN message was not getting DefWindowProc'ed. This patch fixes this by disabling event handling on that icon, as it isn't supposed to do anything. Bug: 828429 Change-Id: I1ee0cfe38707479948b51eed48da83639964a7ae Reviewed-on: https://chromium-review.googlesource.com/1011544Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#550472}
-
