- 28 Sep, 2018 40 commits
-
-
Tatiana Buldina authored
Bug: chromedriver:1998 Change-Id: I6ae25aaff9bb6a5811fed81c858250f2fbc34472 Reviewed-on: https://chromium-review.googlesource.com/1244615Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595139}
-
Ben Pastene authored
With this, any changes to the filesystem a test makes will only last for as long as the VM is alive. Since we launch+shutdown for every test, this perfectly isolates consecutive tests from one another. No more out-of-disk errors! Bug: 887753 Change-Id: Ifdf4af22e288583135cfe99d363eb3e79045e08d Reviewed-on: https://chromium-review.googlesource.com/1252005Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595138}
-
Vaclav Brozek authored
This enum was used in a metric which have been removed for some time now. Bug: 456119 Change-Id: I9483787580dd86c5eb494febac049bc1aca342b8 Reviewed-on: https://chromium-review.googlesource.com/1251583Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595137}
-
Matthew Jones authored
Bug: 884144 Change-Id: Idf9634bd70ce37fb8b0dfdc51e5c2a5aa3d3847d Reviewed-on: https://chromium-review.googlesource.com/1251767Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595136}
-
Xiyuan Xia authored
CrostiniAppIconLoader should use the passed-in icon size instead of from AppListConfig. Bug: 880979 Change-Id: I20840e4eced66ea2320149c57ebda4a9c8226341 Reviewed-on: https://chromium-review.googlesource.com/1251961Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce4c48bb2fa0..928526013073 Created with: gclient setdep -r src-internal@928526013073 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9b352590ed3f948be6c0ca284fcffda323b80d4d Reviewed-on: https://chromium-review.googlesource.com/1250953Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595134}
-
Mario Sanchez Prada authored
Replace instance of SigninManagerBase with one of IdentityManager and update calls accordingly. Bug: 889882 Change-Id: I4e76d223a1b8a6bc328cb97e1624d2c4d7532fae Reviewed-on: https://chromium-review.googlesource.com/1251532Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595133}
-
Boris Sazonov authored
This CL adds TextAppearance.UpdateMenuItem and replaces hardcoded textColor and textSize values in update_menu_item.xml. Bug: 727723 Change-Id: I1b085d973502143e9a4a44dcbd1013d20386f01c Reviewed-on: https://chromium-review.googlesource.com/1251539Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595132}
-
Jonathan Metzman authored
Remove redundant check for "use_libfuzzer" introduced in 6376140d. This check is redundant and causes build failures because it stops /OPT:NOLLDTAILMERGE from being used. Bug: 884545 Change-Id: Ifb665751ff568ff557c4a896aca2d3b3f7a97dd3 Reviewed-on: https://chromium-review.googlesource.com/1249734Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595131}
-
Christopher Cameron authored
This is to * Clarify what code exists in the app shim side, and what code exists on the browser side. * Ensure (via include rules) that the app shim side not call back into any ui/views code (that is, that it always goes through appropriate interfaces). R=ellyjones TBR=bsalomon (skia/OWNERship) Bug: 821561 Change-Id: I4b3d48dac707507bc1881f9a1a0478ac1d15355c Reviewed-on: https://chromium-review.googlesource.com/1247526 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595130}
-
Abhishek Arya authored
ninja runs gen_fuzzer_owners.py from build directory and not chromium source root. This causes script to fail to find owners since it checks source file from incorrect relative location. This regressed in https://chromium.googlesource.com/chromium/src/+/3fb53cf0d187b9537160ad967975f17641d59c1f R=mmoroz@chromium.org Bug: 890352 Change-Id: Ib14884f294eadeaa87d08cd57062bf41d63f002e Reviewed-on: https://chromium-review.googlesource.com/1252003Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595129}
-
Charlie Harrison authored
See spec: https://w3c.github.io/speech-api/#speechsynthesiserrorevent and discussion on i2s on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8_H3FUZm23g Previously, errors were just going through as SpeechSynthesisEvents. This CL now dispatches errors as SpeechSynthesisErrorEvents with an empty "error" method. This CL also adds constructors on both SpeechSynthesisEvent and SpeechSynthesisErrorEvent. Bug: 885297 Change-Id: I70ba998182943a50e17f2fc11eb7e163d8289e94 Reviewed-on: https://chromium-review.googlesource.com/1231839 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#595128}
-
Hongchan Choi authored
This is a fix suggested by dcheng@ at: https://bugs.chromium.org/p/chromium/issues/detail?id=888366#c12 Locally confirmed the change stops the crash. Bug: 888366 Test: The CL build does not crash on the repro case anymore. Change-Id: I4b56228589b4c71f1191fb82e849240f39c938ed Reviewed-on: https://chromium-review.googlesource.com/1246945 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595127}
-
Vladislav Kuzkokov authored
Bug: 853877 Change-Id: I9441f6b95fec76c5f50b9aa25e7695878983ac52 Reviewed-on: https://chromium-review.googlesource.com/1251531Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595126}
-
Lei Zhang authored
Move the function from PrintPreviewMessageHandler in chrome/ to PageSetup in printing/, so it can be used by printing code outside of chrome/, e.g. in pdf/. BUG=890058 Change-Id: Icb5969e8a948373056df00d06cdb2b002ce201c1 Reviewed-on: https://chromium-review.googlesource.com/1250129Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595125}
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: 869558 Change-Id: Ia49d751aff97a8b3e67fb0aa7c453b66d11f9b0a Reviewed-on: https://chromium-review.googlesource.com/1246148 Commit-Queue: Yuly Novikov <ynovikov@google.com> Reviewed-by:
Yuly Novikov <ynovikov@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595124}
-
Torne (Richard Coles) authored
This defines basic build targets for a Trichrome build using the upstream package names/configuration. The shared library APK contains the 32-bit version of libmonochrome.so and a few autogenerated Java pieces only at this stage, which means the total size of the three APKs is significantly larger than Monochrome at present. Reland fixes a conflict with another CL that went through the CL in parallel, and fixes an issue where gn generation failed when is_official_build=true. Bug: 887078 Change-Id: I86082eeffef53c018ccdc13a3122ff72fed5f5e6 Reviewed-on: https://chromium-review.googlesource.com/1246728Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595123}
-
Troy Hildebrandt authored
This CL breaks up many larger tests into smaller tests that are less likely to time out. Also reduced the amount of work particular tests perform to further ensure no timeouts. TBR=nyquist@chromium.org Bug: 879922 Change-Id: I9591c9bd4f4308ce9eb183289d5c49c98df72b32 Reviewed-on: https://chromium-review.googlesource.com/1240127 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595122}
-
Wei Li authored
Our dev tools used '0.0.0.0' as client address which doesn't work on Windows. See some silimar discussion at https://github.com/senecajs/seneca-transport/issues/37. Since we don't have any remote server discovery in place, it would be sufficient to use local host address '127.0.0.1' for showing the local client address on chrome://inspect page. Thus this CL fixes the client address by replacing with local host address. BUG=750191 Change-Id: Ife011e59316b472af3e56036d539282dd6667247 Reviewed-on: https://chromium-review.googlesource.com/1249271Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#595121}
-
Camille Lamy authored
They are taking too long to run and timeout when run with MSan. TBR=jam@chromium.org Bug: 890313 Change-Id: Ib7d1f3d6edcb62adcddbc54a0c636a9aae37d002 Reviewed-on: https://chromium-review.googlesource.com/1251453Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595120}
-
Valeriya Sinevich authored
Set listAccounts result stale to true on Multilogin finished. iOS fully working. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id24213b3c2ab8000bbcc6170140de50bcd84986c Reviewed-on: https://chromium-review.googlesource.com/1245707 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595119}
-
Lei Zhang authored
Currently, 1-up printing and N-up printing have separate paths that do transformations on PDFs to fit them to the printable area for printing. The 1-up path has been in use for years. The N-up path is in development but has some trouble with certain PDFs. To fix the N-up path, make it go through the 1-up path first. Now with a properly transformed 1-up PDF, the N-up path can just do N-up layout in addition. This also makes N-up PDF printing work correctly with the scaling setting. BUG=844211 Change-Id: I911187e585214ff40327752801c38bda8cf129b7 Reviewed-on: https://chromium-review.googlesource.com/1238078Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6758f34. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25462 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If30af85018e70839c6b934aca1689ed0b6674c26 Reviewed-on: https://chromium-review.googlesource.com/1251741 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595117}
-
Mirko Bonadei authored
This reverts commit dfabb6a5. Reason for revert: Speculative Revert. Failures: https://ci.chromium.org/buildbot/chromium.webrtc/Linux%20Tester/43473 Original change's description: > Roll src/third_party/webrtc 1ee9160a2e0b..89f64d305eff (4 commits) > > https://webrtc.googlesource.com/src.git/+log/1ee9160a2e0b..89f64d305eff > > > git log 1ee9160a2e0b..89f64d305eff --date=short --no-merges --format='%ad %ae %s' > 2018-09-28 crodbro@webrtc.org Move network trace calculation from analyzer to rtc_event_log_parser. > 2018-09-28 mbonadei@webrtc.org Remove deprecated field_trial_default and metrics_default. > 2018-09-28 peah@webrtc.org AEC3: Remove killswitches in AecState > 2018-09-28 phensman@webrtc.org Add option to call VMAF in compare_videos.py. > > > Created with: > gclient setdep -r src/third_party/webrtc@89f64d305eff > > The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng > > BUG=chromium:b/116768521 > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Iaf84f48258437048eba24462cabc1b0971408fc1 > Reviewed-on: https://chromium-review.googlesource.com/1250946 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#595060} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie2537d71336a02b628f968bc293436c3b748e0c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:b/116768521 Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1251585Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595116}
-
John Lin authored
Bug: 882404 Change-Id: I8a72e73be43f9cc9183c1716323dffa44894a4e5 Reviewed-on: https://chromium-review.googlesource.com/1221627Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#595115}
-
Henrique Grandinetti authored
By doing data we can guarantee consistency between the data that locks the device and the data reported. Bug: 881445 Change-Id: I4451a082f14afb38c4e01fff05aa83df813b96bd Reviewed-on: https://chromium-review.googlesource.com/1249741 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595114}
-
Leonard Grey authored
Bug: 850098 Change-Id: Ib2af48ceb226bbe2650c65331d4bbec2321c0956 Reviewed-on: https://chromium-review.googlesource.com/1251328Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#595113}
-
Alexey Kozyatinskiy authored
V8 roll will include console.timeLog implementation. TBR=dgozman@chromium.org Bug: chromium:854474 Change-Id: I3669e7cd82e1c83689f91a297a81c7324fe6db7e Reviewed-on: https://chromium-review.googlesource.com/1251749 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595112}
-
Randy Rossi authored
These gesture enums were missing. Prevented two finger tap from silencing the screen reader. Bug: 888695 Test: Manual Change-Id: I6e71cf65de19651ea3560fbf825cfe59ca6cdcbb Reviewed-on: https://chromium-review.googlesource.com/1241274Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595111}
-
Tatsuhisa Yamaguchi authored
We want to have the same design with the one in the bubble. The icon is same as unified_menu_managed.icon, but differs by the padding size. So it's kept as a separate file from that. Bug: 870409 Change-Id: I9876c12bad7aa99f5fe46cf599866aed2eced70f Reviewed-on: https://chromium-review.googlesource.com/1250382Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595110}
-
Jennifer Apacible authored
This change cleans up some of the custom control work, including: - removing unused function - updating naming to be consistent to other functions - rearranges for proximity to relevant functions There are no functional changes. Change-Id: I5b86f5dec7b850745e11f3adac16de159bf8ac48 Reviewed-on: https://chromium-review.googlesource.com/1249540Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#595109}
-
Nico Weber authored
Bug: 832676 Change-Id: I08c741b57717e69d434d34b1ad73c132e3125d94 Reviewed-on: https://chromium-review.googlesource.com/1251329Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595108}
-
Bill Budge authored
- Modifies Mojo code caching API to specify JS or WASM cache. - Adds WebAssembly GeneratedCodeCache. Bug: chromium:719172 Change-Id: Ie7dec8112a8e6cea7c576e2e502683bba0bb3d4a Reviewed-on: https://chromium-review.googlesource.com/1235283 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595107}
-
Egor Pasko authored
The CCT benchmark is a small app with minimal dependencies and no proguard. If it includes Chromium java pieces, it would not fit into the method count limits, so it would need to enable proguard. This is overly heavy for the purposes of this app. So we would like to use android.util.Log in this app instead. Bug: None Change-Id: Ia44c6d60a97721bce827061e022d4c5cb8c2fa81 Reviewed-on: https://chromium-review.googlesource.com/1251624Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595106}
-
Manuel Rego Casasnovas authored
In r591642 we updated the behavior so layout containment suppress baseline alignment, while size containment does not. However, we forgot about the special cases (flexbox and grid) that have their own code for this, which are fixed in this patch. Regarding WPT tests, these changes will fix the following issue: https://github.com/web-platform-tests/wpt/issues/13252 One of the Mozilla tests is failing now, it was mentioned in the associated bug report (https://bugzilla.mozilla.org/1491235). BUG=882333 TEST=external/wpt/css/css-contain/contain-layout-button-001.html TEST=external/wpt/css/css-contain/contain-layout-flexbox-001.html TEST=external/wpt/css/css-contain/contain-layout-grid-001.html TEST=external/wpt/css/css-contain/contain-size-button-001.html TEST=external/wpt/css/css-contain/contain-size-flexbox-001.html TEST=external/wpt/css/css-contain/contain-size-grid-001.html Change-Id: I5e437d7f82d07d2f6222416a1eb9a3b89cb44eca Reviewed-on: https://chromium-review.googlesource.com/1250524 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595105}
-
Chris Harrelson authored
This is needed to support IOv2 occlusion testing via hit test. It also allows content under foreignObject to receive disambiguation on touch screens. Bug: 823796 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I80089feb9a30d3f28ce2c68f7276cafc5410adcb Reviewed-on: https://chromium-review.googlesource.com/1227470 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#595104}
-
Eric Stevenson authored
This CL filters the output that explains dealing with size regressions when no size regression occured. Also adds normalized_apk_size to the output JSON. Bug: 702625 Change-Id: I38be87bdd6b4fb74e179043cabd42dfcbc93473f Reviewed-on: https://chromium-review.googlesource.com/1249883 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#595103}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bea5a39cb895..ce4c48bb2fa0 Created with: gclient setdep -r src-internal@ce4c48bb2fa0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0dce02aea77a56df271dc3a1dd7632efb895fb18 Reviewed-on: https://chromium-review.googlesource.com/1250952Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595102}
-
Joe Mason authored
Fix ICWYU error in chrome_cleaner/os/rebooter_api.h R=csharp Bug: 830892 Change-Id: I3f311bdd32e21b2901594a835aead483ae8d823b Reviewed-on: https://chromium-review.googlesource.com/1227683 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595101}
-
Daniel Bratell authored
In content/child there were two g_lazy_tls global variables in two different anonymous namespaces. In jumbo build experiments, where many files compile together and share anonymous namespace, those globals collided. This patch gives them more distinct names. Bug: 746953 Change-Id: Icac936f2092d1c8b1bc5de38d443d71cb8955045 Reviewed-on: https://chromium-review.googlesource.com/1251605Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595100}
-