- 03 Aug, 2020 40 commits
-
-
Joshua Pawlicki authored
Bug: 1105589 Change-Id: I9d4f4df1d6d2a6c8919e1a8ae615211008e1adae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333085 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794297}
-
Liquan (Max) Gu authored
Change: * Move the UI logic that's inlined in PRImpl#init into PaymentUIsManager. * Add PaymentOptionsUtils#requestAnyPayerInformation to simplify the code. Bug: 1102522 Change-Id: I25f3d06c2d107be38cba545c85ce513482220099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329943 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#794296}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fba96e90cf66..4c7e3ee345c3 2020-08-03 m.maiya@samsung.com Capture/Replay: Account for EGL_KHR_no_config_context 2020-08-03 nguyenmh@google.com Add texture serialization capability 2020-08-03 lehoangq@gmail.com Metal: Implement EGL_ANGLE_iosurface_client_buffer. 2020-08-03 lehoangq@gmail.com Metal: Enable end2end tests on Intel. 2020-08-03 jonahr@google.com Add entry points for OES/EXT_texture_buffer 2020-08-03 cclao@google.com Vulkan: Set depthStencil loadOp to DontCare when not used and stored 2020-08-03 jmadill@chromium.org Capture/Replay: Use vector for resource maps. 2020-08-03 lehoangq@gmail.com Metal: Fix Intel's LOD clamp and blit shader's filtering. 2020-08-03 jmadill@chromium.org Vulkan: Remove ImageHelper::mSerial. 2020-08-03 jmadill@chromium.org Trace Tests: Scale results based on frames in capture. 2020-08-03 jmadill@chromium.org Vulkan: Clean up ScopedDescriptorSetUpdates. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Iabadacb07c6c30f6cdff2995b944bd8beb09f9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794295}
-
Joshua Pawlicki authored
Bug: 1105506 Change-Id: Ia207cc070241677b4fd51c465644d04249e87b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333042 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794294}
-
James Hollyer authored
This is part of the Core Location implementation in Chrome. This change deals with the UI element. It checks the permission from the UI side and prompts the user accordingly Bug: 1051591 Change-Id: I69b9964690f5e9f114a1502a5cc45a38d6da558c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240029 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794293}
-
James Hollyer authored
This CL adds WPT for gamepad feature policy and secure context. It also adds virtual tests suites and expected results as these restrictions are currently behind a flag. Bug: 1098921 Change-Id: Icde27ddfbb6f95220d0b7455ae7c8da3fea11d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333537 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#794292}
-
William Lin authored
The disclaimer for the getAuthToken scopes parameter is currently directly under getAuthToken general documentation. This change moves it to a more relevant location (directly under the callback documentation) so it is closer to what it refers to. Bug: None Change-Id: Id13ecb8adbe038dd69b92b3ead2939d19b7a4c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335638 Commit-Queue: William Lin <williamlin@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794291}
-
Liquan (Max) Gu authored
Change: * Move EditContact into PaymentUIsManager because it's PR UI logic. * Move mRetryQueue into PaymentUIsManager because EditContact needs it. Bug: 1102522 Change-Id: I3958d2a16550d0d7e7c6d82195650ca625e4d622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324971 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794290}
-
David Levy authored
New dependencies were scraped from the output of `gn check` and added automatically to the relevant `BUILD.gn` files. Bug: 949535 Change-Id: I795d2f05c938f3af09ff2412a4901f4e829434da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330951Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Levy <drl@google.com> Cr-Commit-Position: refs/heads/master@{#794289}
-
Prakhar authored
They have diverged since coverage build was first created. Bug: 1024915 Change-Id: Iec853bce25916efe7aea644c1a6ddcef4339a849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335573 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#794288}
-
Bella Bah authored
grouping.xml. grouping.xml defines the overall grouping/structure for annotations as presented to clients. This CL would ensure that the annotation exists in grouping.xml. Bug: 1107860 Change-Id: I675f6bd0f8660faf8f16be36d515df9f04d36f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303313 Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#794287}
-
Bo Liu authored
Bug: 1107954 Change-Id: Ie8fe9536e3ed91e81c8b08f30c0a8fc64ae753e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333207Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794286}
-
Scott Violet authored
The logic in ErrorPageHelper is only applicable when the error page content is provided by weblayer. If the embedder provides html for an error page, then ErrorPageHelper shouldn't be used. This adds a mojom interface to disable ErrorPageHelper for the next load. I had wanted to delete the instance, but this is complicated if the frame is reused and would result in having to duplicate some of the logic. BUG=1031060 TEST=none Change-Id: I21d9390a3bfd9dc32084bb77b7a4c1b55c770324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330936 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794285}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I95e49bb990b0ee40c53538db8804e9d7c9e51e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335570Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794284}
-
Dylan Sleeper authored
Adds UseCounters to the HTML reader and writer to track how much this new feature is used. Bug: 931839 Change-Id: Ie187eced3d79a8276a6f8f84638b2e78c90ba2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304959 Commit-Queue: Dylan Sleeper <dsleeps@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794283}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b9da25e1b8b..d2dc2064dda5 2020-08-03 ethannicholas@google.com fix clang-tidy make_unique warning 2020-08-03 herb@google.com move source padding to the AtlasLocator for small path 2020-08-03 nifong@google.com A quick start guide for CanvasKit app structure 2020-08-03 michaelludwig@google.com Add comments to blend coefficient table to help readability If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Ibafc3dda2866acb293a0faa690a8238dda45d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794282}
-
Haiyang Pan authored
This reverts commit 0c765395. Reason for revert: The roll in crrev.com/c/2333227c works fine on Marshmallow emulator. For example https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/747 Original change's description: > Reland "emulator: Disable the feature GLDMA." > > This is a reland of b7a9b68b > plus increasing the default timeout to make sure emulator starts successfully. > > Original change's description: > > emulator: Disable the feature GLDMA. > > > > android emulator team points out that the exception is related to DMA. > > Disable GLDMA temporarily to see if it can fix the timeout issue on MM > > > > Bug: 1093602 > > Change-Id: I940b8111db48d8b542b47f350b949dab7448d1d8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293279 > > Auto-Submit: Haiyang Pan <hypan@google.com> > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787433} > > Bug: 1093602 > Change-Id: If4c1e60c0f45bd6c1e6be2444eafbf9b1550f209 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295324 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787834} TBR=liaoyuke@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093602 Change-Id: I2d98ec9a6691bd71d074ff45f6191450424ba5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335401Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#794281}
-
David Grogan authored
The test page is identical to the one from the bug, I only added some assertion stuff and boilerplate around it. This is a test only, no behavior change. Fixed: 808750 Change-Id: I5734bf3f0e0a6b461cd6988d0e325096d5be56dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335411 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794280}
-
Richard Knoll authored
This hooks up notification actions from ConnectionRequest notifications to the NearbySharingService. Bug: 1102348 Change-Id: I652449568893ca215925562e3cd50b7bd79fb901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335174 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#794279}
-
rajendrant authored
This CL implements fallback redirect for subresource redirect feature, that when the redirected fetch timesout or fails with certain response codes, the subresource redirect feature is not attempted for subsequent page loads until a bypass duration. The bypass duration is obtained from Retry-After response header or a random duration if its not available. Bug: 1099805 Change-Id: I571caa50226254b769064e6ea436156a035cf323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310915Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#794278}
-
Sven Zheng authored
Adding lacros builder/tester to CI with not closing tree option. The selected tests are tests running in the fyi bot and are stable: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-fyi-rel When the bot is stable, we will change it to closing tree to true. Bug: 1104291 Change-Id: I8ff14f3cba6b0bcca256a100beb6d7a80362672e Ignore-CQ-Freeze: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333334Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794277}
-
Michael Hansen authored
This adds a row in the Nearby Settings subpage for the "Data usage" setting, as well as the dialog which appears when the user clicks the edit button on the row. The dialog saves the selected option to prefs, but in a future CL this will be updated to use a mojo. Screenshot of the row in the subpage: https://screenshot.googleplex.com/5BGciifsy8m Screenshot of the dialog: https://screenshot.googleplex.com/2cVEQtz9yVx Specs in Carbon: https://goto.google.com/orazy Bug: b:154866240 Change-Id: I25749a71a3b78ebf4b75350a60ab2ede744b3927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311050 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794276}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e2a0b5a6..953fc9e3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I87bc70f5fbb852f8ed5f61ce33f925307844000c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334581Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794275}
-
Brandon Wylie authored
Bug: 1041576 Change-Id: Ied77204b4c4c38fb7d80b887d208c71c29bfa233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304158Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#794274}
-
Martin Kreichgauer authored
Also replace SimulateNavigation() with plain NavigateAndCommit() since their behavior seems to be identical in practice. Change-Id: I447d5321bf524f21a657b346479e6cf3f10be76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299467 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#794273}
-
Lindsay Pasricha authored
Bug: 1107597 Change-Id: I918049483adbe8a8ad673bf6e2e19c0ea9d27f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333142Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#794272}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7abb4a6dbdaf017af3ad212bbb6c639c7734d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334676Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794271}
-
wutao authored
This patch adds checks to only allow ambient mode with primary user and certain email domains. In those cases, we do not show the ambient mode Settings. Bug: b/161481420, b/161866797 Test: new AmbientClientImplTest.* Change-Id: Ibed75fb72a0da1e19e9980a232d63eeb78607540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311900Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794270}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I0aa69eb02c01d1e06c0c6c8353d5a2f4bf8752ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295704 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794269}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596434376-45a7a59068fd7ea7cf40a05d52ae81f0a49abd4e.profdata to chrome-mac-master-1596475240-d93356acbdf692b1bcca469d15900f1aa84583f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I4f551982a8d21b90daa18cee02e7142a07f0d45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335601 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794268}
-
Avi Drissman authored
In the past, this wasn't done for Canary because the idea was for it to be as identical to the normal Chrome Stable as possible. Now that we're making Chromes to run side-by-side to Chrome Stable, they need their own identity lest visual issues like the one in the linked bug appear. This relands commits 21e6c4e1 and 34b007d8. They were reverted because they broke crash uploading; the change in this CL of crashpad_mac.mm addresses that. Bug: 1109411 Change-Id: Ib85d773a8ade79422826fe99d88254cd40a35b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333074Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794267}
-
Jesse McKenna authored
This change makes the following updates to IdleWakeups' README: * Add compilation instructions * Change example usage for Edge from "MicrosoftEdge" (old Edge) to "msedge" (new Chromium-based Edge) * Rename from ReadMe.txt to README.md to match others in the repo * Fix example usage syntax for Firefox * Update Firefox usage to reflect that Firefox is now multi-process * A few other small grammatical tweaks Change-Id: Ia1918180c914b1af8b99fa93f3e346e67f7ff1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335334 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#794266}
-
Toni Barzic authored
The test has started failing on official builds after CL:2333141. That change prevents home button bounds animations that would not actually change the button's bounds. It looks like removed compositing requests (caused by setting identical button bounds/transform) caused OverviewSessionFlingTest.BasicFling to end before sufficient number of grid fling animation steps get handled. This updates the test to wait for compositing to start during each test iteration (as animation steps depend on compositing). BUG=None Change-Id: I0ed5946be12300e8e450d2796acf7e7318f8c914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333742 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#794265}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/eac38cfbc1de..1ea3a22f521e 2020-08-03 tommek@google.com Adding a validation for destroyed textures in Queue::WriteTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I97c38be922e259658589916a14fb217be455a70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794264}
-
Alex Chau authored
chrome/services/sharing/* chrome/services/sharing/* - Introduced RequestConnection and DisconnectFromEndpoint for establishing and cancelling a connection with remote endpoints chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of RequestConnection/DisconnectFromEndpoint. NearbyConnectionsManager uses RequestConnection to establish connection, automatically accept the connection and return a NearbyConnection socket-like object that send/receive byte payloads to/from remote endpoints. chrome/browser/nearby_sharing/nearby_connection_impl* - Socket like class that send/receive byte payloads to/from remote endpoints. Its lifecycle is managed by NearbyConnectionsManager Bug: 1076008 Change-Id: Ic7433772c8f072821a3eab3ea48b1c15f236296a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317785Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#794263}
-
Clark DuVall authored
This effectively reverts https://crrev.com/c/2200082, which optimized memory usage by re-creating the WebLayer context without INCLUDE_CODE. This unfortunately leads to a bug where the library path is no longer correct, and WebLayer cannot find the native libs. For more info, see the discussion on https://crrev.com/c/2333305. Bug: 1111508, 1061512 Change-Id: Ia17654bc760ec7f2fc7e3d25e323643de26151fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335500 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794262}
-
Travis Skare authored
Change-Id: I8a68ead67e71e01843dad72681e1e786a313a45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330298 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794261}
-
Xinghui Lu authored
Screenshot: http://screen/zaaBRbPGsTd Bug: 1097310 Change-Id: I26b76f2071d4e2ee5b4fc5ff04868b24bed88a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316829 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794260}
-
Xing Liu authored
This CL pulls the attributes for Android checkbox to a style in components/browser_ui. Bug: 1110521 Change-Id: I20c4e879498677e700d296feb7a8ba6107a1c127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335404Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794259}
-
Sebastien Lalancette authored
Adding: - Open in New Tab - Open in New Incognito Tab - Open in New Window (if Multi-Window is supported and iPad) This CL also adds two method to allow creating OpenInNewTab and OpenInNewIncognitoTab action via methods taking in a |block| parameter instead of the existing methods taking in URLs. The reason is that some components need to add extra configurations to their UrlLoadParams before loading the URL. Having both types of methods allow simple components to easily get the action, and more complex components to create a specific action based on their needs. Bug: 1093302 Change-Id: I46eab2378b11aace8e66955b332c3fa02e2dca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333366 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794258}
-