- 28 Jul, 2020 40 commits
-
-
sauski authored
The SettingsPrivateEventRouter is written such that it expects to be shutdown before the GeneratedPrefs service, this CL makes this expectation explicit by declaring a dependency in the service factory. Bug: 1110305 Change-Id: Ica1844daa151d1f1fd161e155a313c66e066f325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323370Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#792277}
-
Ioana Pandele authored
The PasswordCheckBridge needs to signal its C++ counterpart when it's no longer needed in order to free up memory. Since the C++ bridge gets destructed, we need to destroy the entire PasswordCheck component, so that we don't end up with a partially initialized object. The object responsible for the tear-down is the last object to need the component. Possible cases are: MainSettings > PasswordSettings > PasswordCheck -> MainSettings should call destroy PasswordSettings > PasswordCheck -> PasswordSettings should call destroy MainSettings > SafetyCheck > PasswordCheck -> MainSettings should call destroy PasswordCheck (launched from the leak dialog) -> PasswordCheck should call destroy Bug:1102025, 1101256 Change-Id: I6706ab489049da2192ccb8c03632cc5a7fe38609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297504 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#792276}
-
Saurabh Nijhara authored
We get CRX_FETCH_URL_EMPTY failure reason with check status as noupdate and empty info field when the extension being requested is no longer being served by the Chrome Web Store and this can be considered as an admin side misconfiguration. Bug: 1063031 Change-Id: I61f2beca94ea38faa32b1539bff42318fce7a6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306044 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792275}
-
Chris Hamilton authored
This replaces the use of SharedWorkerId. Further CLs will plumb the generated token into the renderer process where it will be used to adorn the associated WorkerOrWorkletGlobalScope. BUG=1096617 Change-Id: If23756e40ccbdf02f72a173d32addd5247f544bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313102 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#792274}
-
Anastasiia N authored
Currently ProfileOAuth2TokenServiceDelegateChromeOS doesn't remove cached errors on account removal. GetAuthError() should return GoogleServiceAuthError::AuthErrorNone() if account is not present in Account Manager. Change-Id: I8d9e7ab0328c9eb6f4eb79d4e46c2138cd74cbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302634 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792273}
-
Tomasz Wiszkowski authored
This change corrects the delimiter used for subtype logging from previously used . to a correct i. There are no functional changes included in this CL. Bug: 1110104 Change-Id: Ie2b8b4b7fe764d85e5e936853a42bf8057b0e73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321512Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Cr-Commit-Position: refs/heads/master@{#792272} -
My Nguyen authored
Track user retention for assistive features. Bug: 1108251 Change-Id: I2986c193194c35e0b502cc9d8f8384b292a4582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311986 Commit-Queue: My Nguyen <myy@google.com> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792271}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f31e5f45..e8188f21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f934280fc258d0f36c556a8e08190da0f0ff880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321450Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792270}
-
Stephen Martinis authored
This CL modifies the PRESUBMIT.py files in directories which are likely to affect the Chromium CQ. It changes it to require a git footer in CLs which touch them, and adds an error message if the footer isn't present. See the linked bug for more details on the production freeze. No-Try: true Ignore-CQ-Freeze: Implementing CQ Freeze Bug: 1109980 Change-Id: Ibfd41a2a0cf7a8f3f0e6a1ad930e3e2e6b8407d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320992Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#792269}
-
dpapad authored
Specifically: - bookmarks_test - material_elements_test - params_parser_test Bug: 1000989 Change-Id: Ife9caa747482afe05eed471f4a70f85fa77e7cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321243 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792268}
-
Maxime Charland authored
The new illustrated empty state in Bookmarks root will happen when a user does not have any bookmarks or folder. This means that the Mobile Bookmarks folder will not be created when it is empty. In addition to this change, a few other changes are needed : - The Mobile Bookmarks TableViewItem should not be created if the folder is empty. - When the state of the Sign In Promo is changed, the TableView background should be updated. - When a bookmark is deleted, the root TableView should be updated to display an empty state if the user has deleted their last bookmark. - Because the empty state is loaded right after Chrome has finished loading the user's bookmarks, there is a possibility that the spinnerView is no longer the background view when the spinnerView has finished its animation. Therefore, we should only remove the TableView background if the spinnerView is still the active background. (Googlers only links) Screenshot: https://drive.google.com/file/d/1gzEm1IazTYK23UispwRF4zNQIn6Dd3f-/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I05d7938d7193e6dfd34d075778eee0dd3b75003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304536 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#792267}
-
Xiaoqian Dai authored
Add AppStateIndicatorColor and AppStateIndicatorColorInactive according to the spec. Bug: 972162 Change-Id: Ibcc583dc3d7df5f8ecdbae0511f886adb0aa669f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321833Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792266}
-
Mugdha Lakhani authored
Delete code around swapping in prerendered webcontents. There's no swapping in NoStatePrefetch. Bug: 1106294 Change-Id: Ib5afda1fcc1fec8809d3c0b82943dfdfd15f84f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302189 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#792265}
-
Oksana Zhuravlova authored
This change adds an initial version of a class that establishes the mojo connection with the renderer and calls RemoteObjectGateway interface methods. Only the 'add interface' functionality is implemented in this CL. Bug: 794320 Test: local patch (https://crrev.com/c/2293476) where JavascriptInjectorImpl uses RemoteObjectGatewayProxy + JavaBridgeBasicsTest#testTypeOfInjectedObject test Change-Id: I72c99bc1f9480197a9e90d216c20e0f422974adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285026 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792264}
-
Oleh Lamzin authored
Use strict flags for closure compilation of telemetry extension sources. Change-Id: Ia5ba8ec67fe16ef3dd8aed68c2d9b74ff198fd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320588 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#792263}
-
Gang Wu authored
Change-Id: I9f058ec2fdd929e1b48a5a8c08055ccebe0a6611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321513 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792262}
-
Daniel Rubery authored
The SBClientMalware feature was removed entirely, so these metrics are no longer being recorded. Fixed: 1109955 Change-Id: I9e21a84061266d390872b06f3b20031db4f53087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320085 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#792261}
-
Travis Skare authored
Change-Id: Ifdf8969673ad991b8235945c12d7f10a31be31bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320137 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792260}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c11a19145f1f..5b007a519a28 2020-07-28 cwallez@chromium.org dawn_wire: Implement MapRead/WriteAsync on top of MapAsync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I62064e0c7aa84731b1e8078bcb4677ae5d8b398d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792259}
-
Roman Sorokin authored
Was broken by CL:2297621 Fixed: 1109179 Change-Id: Ieeb06baa6b42cbd89df462966bf30977b3fb8fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320574 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792258}
-
Minoru Chikamune authored
This is single call site which uses SequencedTaskRunnerHandle::Get() under third_party/blink. task_runner_ is initialized from ctor of MimeSniffingThrottle. And MimeSniffingThrottle is instantiated from NavigationURLLoaderImpl::MaybeStartLoader(). But NavigationURLLoaderImpl::MaybeStartLoader() uses base::ThreadTaskRunnerHandle::Get() instead of SequencedTaskRunnerHandle::Get(). Bug: 1045925 Change-Id: I66640684214b288bbab477165feec36c53d39335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320712Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#792257}
-
Mark Brand authored
This change simplifies the protobuf representation of Remote/Receiver types, and adjusts the generated code accordingly. It also removes some duplication of code in the Remote/AssociatedRemote cases so that the handling of calls to remotes need only be implemented once for each interface. Bug: 1076336 Change-Id: Ib4cdb0cb6cf700ebb74feb28cd66acb3b49f2d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302609Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#792256}
-
Olivier Robin authored
This fixes non standard startup parameters like - external pdf files - extension search text/images Bug: 1108801 Change-Id: If38c4bb795ec1dfb920a3b5970e4ae6423e4df15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320872Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792255}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I5ec5f9ba5a1af3957bfff1127fb6fac69a9d2623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321062Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792254}
-
Ulan Degenbaev authored
The timer that starts the memory measurement in the Finch experiment can fire for a frame that was detached leading to a nullptr access. Bug: 1105494 Change-Id: I37a2b067acb24303fc5da5a7b7d2855445f28847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792253}
-
Hitoshi Yoshida authored
The new code generator for IDL dictionaries were run in a different target from other IDL definitions (enumerations and interfaces, atm.) This CL merges them and cleans up related GN targets. Also renames a GN flag to use the new generator for IDL dictionaries to be consistent with interface's one. Bug: 839389 Change-Id: Ic22bd52de7e82ebdb628a78e33d2d4a11fc6707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299681 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792252}
-
Lei Zhang authored
Make sure the call succeeds before continuing, to avoid potentially using uninitialized values. Bug: 1108351 Change-Id: Ife6f8b861a53cad0bbaec8130eef0dd1341ab71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321339Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792251}
-
Luke Zielinski authored
New sha is 22901727d52297378d44b217af0b4c06d5b0a484 Change-Id: Ic1aa7c32de4f2057ce8d7c267774b64fb917a352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320749 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#792250}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I817fa17aa6d19593dd4507962abd57db1ae0a0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319336Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#792249}
-
Solomon Kinard authored
Bug: 179375 Change-Id: I309fa16bc32c5b699dc54da2de2dc64edafff700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300664 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792248}
-
Luke Zielinski authored
This rolls up to sha 40ef02d00e6e4209a8c48d59f56952ad7654731c Main changes are: - set_storage_access testdriver API - hide_test_state member in testharness Change-Id: I98cc4e56379e7d299365dd90684350cf2236c99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320412 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792247}
-
Peter E Conn authored
Change-Id: I66384669d3ef45802ca3ae9468f805ba6fed874f Bug: 1096428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320614 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#792246}
-
Matthias Körber authored
Also removed some duplicated code that slipped through. Change-Id: I15a4a8e7572e8ec07782b818c2eb193afd0baea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300084 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#792245}
-
Mugdha Lakhani authored
So WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: I50d0247ffe8fcba358c7eeaf499ca72cd693279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312702 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#792244}
-
Anton Ohontsev authored
Back in 2012, we had a problem with the state of the created shortcuts on the desktop: crbug.com/133585 As a fix, we create full-fledged shortcuts and icons only if the profile with which the browser is launched is in the DefaultUserFolder. If the UserDataDir policy is used, a shortcut is created in "%AppData%\Roaming\Microsoft\Internet Explorer\Quick Launch\ User Pinned\ImplicitAppShortcuts" with the path to the icon %ProfilePath%\Default\Yandex Profile.ico, but the icon itself is not created in the profile. To fix this problem, we need to subscribe to create shortcuts and enable the feature of creating shortcuts for a profile from a policy, if such exists. When using --user-data-dir, a different mechanism is used, in this case the shortcut is not created, but the crhome.exe icon is used. BUG=1108485 Change-Id: I21d914d5a4d8b18960bda248a90bf320b649e323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314516Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792243}
-
Michael Thiessen authored
Introduces BlankCTATabInitialState.java, which manages initial state across test suites. No post-batch cleanup is required as the only state carried across test suites is the Activity, which is finished by the test runner. Also batches all device_dialog instrumentation tests together, dramatically speeding them up. Bug: 989569 Change-Id: I66fa56da157491defe1dca9b4ce9464a3d308961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307650Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792242}
-
Avi Drissman authored
In the past, this wasn't done for Canary because the idea was for it to be as identical to the normal Chrome Stable as possible. Now that we're making Chromes to run side-by-side to Chrome Stable, they need their own identity lest visual issues like the one in the linked bug appear. Bug: 1109411 Change-Id: Ie3c75014f5dabfe61d5925383dac5f07b2fce481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318726 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792241}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I8bb93738b8c7c7a726eb257faf2632d351e2d802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321209 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792240}
-
Peng Huang authored
Bug: None Change-Id: I4df510cd17acf64bd45fef658da20c0df6e7aae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321770 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#792239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46d04d09. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0e702f34ea4561f034498245d279468e7323b3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322946Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792238}
-