- 13 Dec, 2017 40 commits
-
-
Adam Rice authored
Change the order of functions in ReadableStream.js to match the standard. This will make it easier to update the implementation to match changes to the standard. No functional changes. This corresponds to step 3 of issue 710728. Verified identical to the previous version once comments and blank lines are removed and the file is sorted by function. Bug: 710728 Change-Id: I8b0ae4ad41aa5e84f234901560ad6f97e6319001 Reviewed-on: https://chromium-review.googlesource.com/821955Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#523739}
-
Gauthier Ambard authored
When the user long press a link and open it in a new tab, the toolbar should stay in its state on iPhone. On iPad, the toolbar should be shown. Bug: 793830 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I34c345ba0687385a6e546181584230631ed61ad3 Reviewed-on: https://chromium-review.googlesource.com/823923Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523738}
-
Daniel Bratell authored
In jumbo builds more code compile in the same translation unit so it's more important to keep the names unique to avoid compilation clashes. Bug: 746953 Change-Id: I649731d0725a9c5b5ab0ec72775cc81ea54434a9 Reviewed-on: https://chromium-review.googlesource.com/819556Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523737}
-
stkhapugin@chromium.org authored
Makes the location bar clip to bounds. Bug: 791068 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59eff7def75de42d7e75b8bac87d0ada726a61ba Reviewed-on: https://chromium-review.googlesource.com/822255Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523736}
-
Takashi Toyoshima authored
Mark crashing tests. It's fine enough for virtual/outofblink-cors since it is still under development. Bug: 793866 Change-Id: I5773c2b587f43d27328a614e777907f5fdd45e14 Reviewed-on: https://chromium-review.googlesource.com/821752Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523735}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I431671dc03fa7157c25433575c3cdd5cf75d098a Reviewed-on: https://chromium-review.googlesource.com/808447Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523734}
-
Maksim Sisov authored
This CL adds a preliminary support to maximize/minimize or set Wayland windows to fullscreen. WaylandWindow extends HandleSurfaceConfigure and stores new states. As a result, Wayland windows will be sending changed window states to the |delegate_| and notify ServerWindow and thus aura::Window about changed states. This change is in downstream now [1], but will be sent as a follow-up cl. [1] https://github.com/Igalia/chromium Bug: 784836, 578890 Change-Id: I4dee446b5d145ca2a15f168d78aacf7c96acb2e7 Reviewed-on: https://chromium-review.googlesource.com/768681 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#523733}
-
Mostyn Bramley-Moore authored
This should avoid the following jumbo build error: ./../../third_party/WebKit/Source/core/css/cssom/CSSScale.cpp:14:6: error: redefinition of 'IsValidCoordinate' bool IsValidCoordinate(CSSNumericValue* value) { ^ ./../../third_party/WebKit/Source/core/css/cssom/CSSPositionValue.cpp:15:6: note: previous definition is here bool IsValidCoordinate(CSSNumericValue* v) { ^ BUG=789370 Change-Id: I13f1540c9969d4ff34420fcfda831687c4580555 Reviewed-on: https://chromium-review.googlesource.com/822199Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#523732}
-
Guido Urdaneta authored
This CL adds to AudioManagerWin implementations of the following methods: * GetDefaultInputDeviceID * GetCommunicationsInputDeviceID * GetCommunicationsOutputDeviceID Bug: 780492 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I22c71f79695de8930ccb0d9c3d7ed2ba56ebdf23 Reviewed-on: https://chromium-review.googlesource.com/811184Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#523731}
-
Christos Froussios authored
This reverts commit e5c68a86. Reason for revert: Suspected for breaking several tests in ash_unittests-mus on Linux Chromium OS ASan LSan E.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187/steps/ash_unittests-mus Original change's description: > mus: Support display mirroring for mus without viz > > Append mirrors to the list of displays in DisplaySynchronizer. > (creates normal ws::Displays for ash to handle mirror content) > > Add & call aura::WindowTreeHostObserver::OnAcceleratedWidgetOverridden. > (lets MirrorWindowController handle mus's async initialization) > > Support WindowTree::ProcessSetDisplayRoot use with existing displays. > Remove WindowManagerState::DeleteWindowManagerDisplayRoot NOTREACHED. > (now hit when re-using a display and switching mirror->extended) > > Allow ash/window_manager.cc to include ash/host/ash_window_tree_host.h > > Bug: 770243 > Change-Id: I21ada68097cff001bb98b9a8a22482d59d0ac1c8 > Reviewed-on: https://chromium-review.googlesource.com/806238 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523618} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org,kylechar@chromium.org Change-Id: I87b3b57193b38c955f3089f039a5c479c869c50c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770243 Reviewed-on: https://chromium-review.googlesource.com/824042Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#523730}
-
Alexandre Courbot authored
Use the new vaapi-reviews group and monitor media/gpu/v4l2 as well. Change-Id: I982c5240c68136e9de403fb91b0818e584ab36ea Reviewed-on: https://chromium-review.googlesource.com/821811Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523729}
-
Christos Froussios authored
This reverts commit 28e0c070. Reason for revert: Suspected of breaking vr/VRDisplay_rAF_fires_with_window_rAF.html on Win7 Tests (dbg) E.g https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65158 Original change's description: > Avoid null poses in WebVR magic window mode > > There's a race condition where the first magic window VSync could arrive before > ever getting a pose. Add a check and deferred execution to avoid this. > > BUG=787196 > > Change-Id: If804e4d6acc3da7b903ba36108f23c00b1c8fe5b > Reviewed-on: https://chromium-review.googlesource.com/783887 > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523657} TBR=mthiesse@chromium.org,bajones@chromium.org,klausw@chromium.org,billorr@chromium.org Change-Id: Ic70d3ebdb294e04bf70a0488d21790e05d43e1d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787196 Reviewed-on: https://chromium-review.googlesource.com/823903Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#523728}
-
Achuith Bhandarkar authored
BUG=chromium:790015 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4e1159a3aef37e7bde21f3032de6fdea107080cb Reviewed-on: https://chromium-review.googlesource.com/822893Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#523727}
-
Rob Buis authored
Sync CSSStyleDeclaration.setProperty with the spec [1], specifically make value and property not nullable, treat null as empty string and for value change default from null to empty string. TEST: LayoutTests/fast/css/cssom-setproperty-undefined-value.html [1] https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface Change-Id: I9ca067626c65aed5cce7f9bcb23af1133a0822b6 Reviewed-on: https://chromium-review.googlesource.com/806751 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#523726}
-
rhalavati@google.com authored
Network Traffic Annotation is added to extensions/browser/api/socket classes. Bug: 656607 Change-Id: Ieb1f5559b1b2885154d3faf101b4b8d65a3ebe5d Reviewed-on: https://chromium-review.googlesource.com/813534Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#523725}
-
Marijn Kruisselbrink authored
These methods are never called, so get rid of them to make future refactoring and cleanup easier. Also change the map in PublicURLManager to now map from URL to Registry, rather than the other way around. Bug: 756743 Change-Id: I1a7fec77f498b11c916fce1adc520ffda9268545 Reviewed-on: https://chromium-review.googlesource.com/822153Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523724}
-
Daniel Bratell authored
There are three very similar pieces of code with identical constants controlling and this patch renames them so that they don't clash in jumbo builds. Jumbo builds compile multiple cc files in the same translation unit which means that those cc files will share the same anonymous namespace. Bug: 746953 Change-Id: I85462687798819212b78926c92d3351f44039583 Reviewed-on: https://chromium-review.googlesource.com/822474Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523723}
-
Daniel Bratell authored
There are many types in Chromium named Result. When importing that name into the global (or content) namespace with a using statement, you run the risk of clashing with another Result type. That happened in jumbo builds where more code is compiled per translation unit. This patch uses the fully qualified name instead of just Result instead. Bug: 746953 Change-Id: I5ccfb5e6b70712372a764c89b40a2a9340cc33fb Reviewed-on: https://chromium-review.googlesource.com/822335 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523722}
-
Daniel Bratell authored
There is a template named BindInterface in content/public/common/bind_interface_helpers.h so to avoid compilation failures when that header is included directly or indirectly (as in jumbo builds), it's better to call local functions something else than BindInterface. This renames BindInterface -> BindNamedInterface. Bug: 746953 Change-Id: Ib595232b8c6c9ae58b5321ff58ad1c2927787631 Reviewed-on: https://chromium-review.googlesource.com/822433Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523721}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/a98a28112b0e..9db70de8ecb6 $ git log a98a28112..9db70de8e --date=short --no-merges --format='%ad %ae %s' 2017-07-04 cwallez Reland: Implement EGL_ANGLE_iosurface_client_buffer 2017-12-12 cwallez Add test for Chromium's EGL_D3D_TEXTURE pbuffer creation Created with: roll-dep src/third_party/angleBUG=794086 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2c715d83485f7eccf3873d327bf956ce0bb51559 Reviewed-on: https://chromium-review.googlesource.com/823528Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523720}
-
Hiroki Nakagawa authored
ThreadedMessagingProxyBase::WorkerThreadCreated() is provided as a virtual function for DedicatedWorkerMessagingProxy to post queued tasks to the worker after thread creation. However, DedicatedWorkerMessagingProxy itself initiates the thread creation in StartWorkerGlobalScope() and can know when it's available, so such the virtual function is not necessary. For cleanup, this CL removes WorkerThreadCreated() and inlines posting the queued tasks in StartWorkerGlobalScope(). Bug: 680046 Change-Id: I5248c78d381e0820461e167249ce89bac93e44a5 Reviewed-on: https://chromium-review.googlesource.com/823052 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523719}
-
Hiroki Nakagawa authored
Bug: 655458 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie95f0a06c594b26630e213b0a8ee2cfedfa37980 TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/823512 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#523718}
-
Rob Percival authored
SingleTreeTracker could previously reveal to a DNS resolver that a user was accessing a particular host, as a side-effect of performing a Certificate Transparency inclusion check over DNS. It will now first check that a DNS lookup for that host has already occurred (i.e. the DNS resolver already knows that the user has been accessing that host), otherwise it will avoid revealing that information by not performing an inclusion check. Bug: 506227, 682193 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifd5ef10773155b5b27aea32bee9c460320c1e264 Reviewed-on: https://chromium-review.googlesource.com/768790 Commit-Queue: Rob Percival <robpercival@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523717}
-
Guido Urdaneta authored
With this change, it is safe to enable the SYSTEM_MONITOR caching policy for MediaDevicesManager. Bug: 788687 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3b067a566e825c5a8219705bc75ee4b66c198787 Reviewed-on: https://chromium-review.googlesource.com/822935Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#523716}
-
rhalavati@google.com authored
Network Traffic Annotation is added to the socket write of the AdbClientSocket class. Bug: 656607 Change-Id: I1e05fc201290e0c55b78b8b03aee79284ffd7b4d Reviewed-on: https://chromium-review.googlesource.com/813757 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523715}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/fbee1329c2da..3ac7c0f0224e $ git log fbee1329c..3ac7c0f02 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 yuzus Fix logical errors in leak detection metric test & change the timing of error throw Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8aed07f40849a85037e057c724e6dbb4c97e5e5b Reviewed-on: https://chromium-review.googlesource.com/823527 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523714}
-
Hiroki Nakagawa authored
Before this CL, credentials tests for worklets are completely broken as follows: - In credentials.py, |credentials_mode| is compared by "is" that conducts the object equality check. As a result, all conditions unexpectedly pass through and the script always returns a valid response. - In credentials.py, |is_cross_origin| value is always |False| because requests don't have the GET param. - fetch() needs { credentials: 'include' } option for configuring the document's cookie with the Set-Cookie header, but it's not specified. - Response headers are not specified for a 404 response. This results in test timeout instead of a network error. This CL fixes these bugs and cleans up tests. Bug: 738769 Change-Id: I9aeb11fca23dec3fd3057a765fa60eb6e59d8258 Reviewed-on: https://chromium-review.googlesource.com/799730 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523713}
-
nikhil authored
Fixing names of password_manager PasswordImport feature as per the naming convention. Bug: 785953 Change-Id: I7c7bbdd5852f40e6735ffd51e9c519e59d3a6b0c Reviewed-on: https://chromium-review.googlesource.com/817458Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523712}
-
Stuart Langley authored
The overriden_deps field was removing the dependency on :mojo_platform_bindings, which is needed because message_port/message_port.mojom depends on blob/blob.mojom. I tested this fix using the following: $ gn clean out/Default $ ninja -C out/Default -j 1 obj/third_party/WebKit/common/mojo_bindings/message_port.mojom.o ... Build fails fatal error: 'third_party/WebKit/common/blob/blob.mojom.h' file not found With change: $ gn clean out/Default $ ninja -C out/Default -j 1 obj/third_party/WebKit/common/mojo_bindings/message_port.mojom.o Build works. Bug: 794419 Tbr: mek@chromium.org Change-Id: I8d2e98ae51da4228d1a8be396616d02814130f84 Reviewed-on: https://chromium-review.googlesource.com/823051Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#523711}
-
Matt Falkenhagen authored
This reverts commit a5b3a661. Reason for revert: This seems to be causing flaky build errors on chromeos-amd64-generic-rel: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/chromeos-amd64-generic-rel/ In file included from ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp:60: In file included from ../../third_party/WebKit/public/platform/Platform.h:56: In file included from ../../third_party/WebKit/public/platform/WebURLLoader.h:36: ../../third_party/WebKit/public/platform/WebURLRequest.h:41:10: fatal error: 'services/network/public/interfaces/request_context_frame_type.mojom-shared.h' file not found #include "services/network/public/interfaces/request_context_frame_type.mojom-shared.h" Probably need to add some DEPS to BUILD.gn. I will revert for now. Original change's description: > Merge all native enums RequestContextFrameType into single mojo enum > > This CL creates blink.mojom.RequestContextFrameType enum type and uses > it to replace existing native enums content::RequestContextFrameType and > blink::WebURLRequest::FrameType. > > This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo, > and finally to remove content::ExtendableMessageEventSource, which is an > incremental step toward Onion Soup: having less dependence on content types > for service worker. > > BUG=782528 > > Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd > Reviewed-on: https://chromium-review.googlesource.com/791916 > Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523699} TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org,xiaofeng.zhang@intel.com Change-Id: I25d74d983877227b5482a441f6cebb74374751b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782528 Reviewed-on: https://chromium-review.googlesource.com/823332Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523710}
-
Renjie Liu authored
Original author: amoylan@chromium.org Original cl: https://chromium-review.googlesource.com/c/chromium/src/+/706439 This CL adds the GeoLanguageProvider browser singleton as described in the design doc: https://docs.google.com/document/d/18WqVHz5F9vaUiE32E8Ge6QHmku2QSJKvlqB9JjnIM-g This interface provides a list of language codes corresponding to local languages based on the device's approximate geolocation derived from its public IP address, using the PublicIpAddressGeolocator service. IP geolocation updates are requested no more often than every 24 hours. This singleton is started up after Profile init in PreMainMessageLoopRun. The startup runs on a background task runner, connecting & subscribing to the IP geolocation service. Startup is gated on the Feature setting "GeoLanguage" which is false for now. Bug: 76915 Change-Id: I9af2b1375fabda3d029ca396043b9195acab7cf0 Reviewed-on: https://chromium-review.googlesource.com/807884 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#523709}
-
Hajime Hoshi authored
This is the 4th trial to add the UKM Document.OutliveTimeAfterShutdown. This change caused a problem that logs became huge, but now the problem has been fixed by holte@'s fix (https://chromium-review.googlesource.com/c/chromium/src/+/795362). This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is recorded when a Document object survives 5, 10, 20 or 50 garbage collections after detached. If a document outlives such long time, the document might be leaked. The UKM would be very useful to know where such leaky documents exist and to fix them. Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing Bug: 757374 Change-Id: I20c390c8f3856ed8a9cd733ab6ac18d667b12d95 Reviewed-on: https://chromium-review.googlesource.com/818676Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523708}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I9d5948b3a480a183aafbe2579adba93427056c93 Reviewed-on: https://chromium-review.googlesource.com/823782Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523707}
-
Darren Shen authored
Currently CSSTranslate, CSSRotate and CSSScale do not accept calc values (CSSMathValues) because it requires type checking the calc value to see if they match the right type [1]. Since type checking and matching are now implemented, we have all the machinery to accept CSSMathValues too. This patch uses CSSNumericValueType.Matches* functions to check if the CSSNumericValues passed in resolve to the right type. We also (re)moved some redundant DCHECKs. We will have a follow up patch for CSSSkew and CSSPerspective. Note that percents are not allowed in CSSTranslation (spec needs edit): https://github.com/w3c/css-houdini-drafts/issues/530 [1] https://drafts.css-houdini.org/css-typed-om-1/#cssnumericvalue-match Specs: https://drafts.css-houdini.org/css-typed-om-1/#dom-csstranslation-csstranslation https://drafts.css-houdini.org/css-typed-om-1/#dom-cssrotation-cssrotation https://drafts.css-houdini.org/css-typed-om-1/#dom-cssrotation-cssrotation-x-y-z-angle https://drafts.css-houdini.org/css-typed-om-1/#dom-cssscale-cssscale Bug: 789370 Change-Id: I6f538a3f07b4c58eb15c9f059c39751e66f64f2f Reviewed-on: https://chromium-review.googlesource.com/812364 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#523706}
-
Doug Arnett authored
This is a refactor to consolidate the commit-time previews decision in one place (in ChromeResourceDispatcherHostDelegate) for both server-determined and client-determined previews with propagation of decision to renderer (via PreviewsState in mainframe response info) and UI thread (via PreviewsUserData). Bug: 782922, 725645 Change-Id: I8f7e5ef3a8a45b9ba2e1bbc07f09bfb9670e16b1 Reviewed-on: https://chromium-review.googlesource.com/807305Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#523705}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/106e17aa38c9..c0720db247f4 $ git log 106e17aa3..c0720db24 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 rmistry [Infra] Fix revision in upload_skiaserve 2017-12-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 3acfc6255..9db70de8e (1 commit) 2017-12-12 mtklein disable f16<->f32 instructions on Google3 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit) 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit) 2017-12-12 rmistry [Infra] Missing configuration in out dir Created with: roll-dep src/third_party/skiaBUG=794086,794086 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I09ca5ff52d18a8bb0068e3286b2e887fd6508716 Reviewed-on: https://chromium-review.googlesource.com/822928Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523704}
-
Xianzhu Wang authored
This is a reland of 3b36628a Fix crashes on release-without-DCHECK builds by adding check for contex.tree_builder_context before dereferencing it. Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} Bug: 790560 Change-Id: I2bc134f829aa38398cf87ad8fa89ac229634d6d0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/822139Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523703}
-
Frank Barchard authored
Using all_dependent_configs to pass libyuv_config around. Using public_configs, client projects must rely on public_deps to propagate configurations up in the build graph. This is bad because public_deps allows the exposition of headers that live in another target. This can lead to a really unhealthy build. On the other side, all_dependent_configs is automatically propagated up in the build graph but if a target includes a libyuv header it is forced by GN to declare the dependency (and this will propagate libyuv_config). Bug: webrtc:8605, webrtc:8603 Test: None Change-Id: I590c620b29102f2f7720da36872335f83ea7c453 Reviewed-on: https://chromium-review.googlesource.com/822334 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523702}
-
yoshiki iguchi authored
Previously, I have added SystemTrayView class which was owned by SystemTray class (crrev.com/727379). But the views in the tray are assumed to be destroyed with the parent view and the bubble, so that caused some issues. This patch changes that and makes SystemTrayView owned by the view hierarchy. Then the issues are solved. This patch also updates the newly-added code in NetworkStateListDetaiedView because the code didn't assume that lifetime of views. Bug: 790716, 789833 Change-Id: I62eca328780cabb7c5d68967cc1ddee7a1e23b9a Reviewed-on: https://chromium-review.googlesource.com/813153 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#523701}
-
Victor Miura authored
This CL enables RasterInterface for Compositor Worker contexts in content/renderer and content/browser. RasterInterface provides a subset of GLES2Interface APIs required for OOP Rasterization. This will gradually diverge away from GLES2. The initial change adds a client-side implementation of RasterInterface on top of GLES2Interface. Design Doc: https://goo.gl/Q6E1ZC BUG=757607 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaefd861f0c51b9995ad27eb94de2068d0f9dab22 Reviewed-on: https://chromium-review.googlesource.com/778242 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523700}
-