- 21 May, 2020 40 commits
-
-
Karandeep Bhatia authored
Types which are only referenced once are inlined by the Docserver by default. This causes excessive nesting in documentation for declarativeNetRequest. Prevent this by explicitly disallowing inlining for these types. BUG=1085326 Change-Id: I2d2a938832fdfd26915b8956b14f1d41e3b0a646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209966 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770954}
-
Shik Chen authored
This CL removes the renaming behavior for video recording to simplify the logic, and mitigate thumbnail regeneration timeout issue in Files app for long video. Bug: 1058325, 1080869 Test: Verify the file name manually, and pass CCAUIRecordVideo and CCAUIIntent Change-Id: I074885d95e8cf41d85cf46ef866c47500726708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210201 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#770953}
-
Hiroki Nakagawa authored
For code cleanup, this CL renames LinkFetchResource that was used only for <link rel='prefetch'> to LinkPrefetchResource. This also renames LinkResourceFactory to Factory. That is the internal class of LinkPrefetchResource, so just naming it "Factory" would be simpler and still understandable. Bug: 1075582 Change-Id: If057c89242a41ea1969045ba19f1ceef6d4195a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210202 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#770952}
-
Daniel Murphy authored
There is a pre-installed Youtube app that is a hosted app (and not a bookmark app), but it is hard coded as a bookmark app. To add to this weirdness, the app id is not the hash of the start url, so this causes problems within the bookmark app system which assumes this. This CL fixes the default app configuration, and adds migration code to fix this for all installs. R=alancutter@chromium.org, loyso@chromium.org Bug: 1068453 Fixed: 1084848, 1078450 Change-Id: I7fab1714edede1fbf4030beb55c118b8300f4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181827 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#770951}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ae2ed9f992e1..98dedb300ca7 2020-05-21 dberris@chromium.org auto-bisect: Add more details to creation message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084858 Tbr: sadrul@google.com Change-Id: I2bdd1ceaa0ea39697c4aa2e12f249a98fdce69d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770950}
-
Brian Manthos authored
Change-Id: I20f5b9b18345272e435b478f7688a0e0bf10694f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210540Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770949}
-
Sonny Rao authored
We still use these histograms to keep track of memory issues and other crashes. Bug: 1072534 Change-Id: I5a32a787a456685385f1a7c7e647f12d923ec920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211362Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770948}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590019092-0150ca95063dc0ad33468a89535d4804f9e0bc6b.profdata to chrome-mac-master-1590033536-e720add817899a0a9587c78e7de615e881dda3e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25f2bf4a4f959f17136c63aa859c14bcf524cb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211470Reviewed-by:
-
Mohsen Izadi authored
Please see a screenshot from a sample trace at: https://drive.google.com/file/d/1rTdrSmfPoM07ycf76cpLAC1zHZrfwus0/view Bug: 1054009 Change-Id: Ia24056e6a9951dae4e4be00f1e58aa6c93ff2706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166637Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770946}
-
chrome://media-appTrent Apted authored
Currently the color is specified in the manifest and on the <backlight-app> element loaded in the iframe. But the element only loads after translations are ready, so there's a period where the background color is white. Setting it on <body> in the main frame (and not also in the iframe) appears to be sufficient to avoid any white flash, since everything else is transparent. Bug: 996088 Change-Id: If9dbff68fb07a535113c26133721c5c8b28ea6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210337Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#770945}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/13e565a5999c..8a3cc5c4dfd8 2020-05-21 jiawei.shao@intel.com Add adapter type in test name when the adapter is Microsoft Basic Render If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1b6de2a49c6249a6ba1480d71cebfb929588eaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211464Reviewed-by:
-
Hiroki Nakagawa authored
For code cleanup, this CL removes the resource type param from the ctor of LinkFetchResource that was always ResourceType::kPrefetch, and instead hard-codes the resource type in the class. Bug: 1075582 Change-Id: I2230f107968969c6df71bacd8089d1a82b1dd0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210338Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1084612 Change-Id: I23eb128c361064f4a490c1316139415a582dbdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209292 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770942}
-
Nicholas Verne authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2b37f52a06d9..6b108dadbc56 $ git log 2b37f52a0..6b108dadb --date=short --no-merges --format='%ad %ae %s' 2020-05-13 nverne permission_broker: Support USBDEVFS_DROP_PRIVILEGES mask. 2020-05-19 akhouderchah hermes: Have SM-DS create pending Profile object rather than Event tuple Created with: roll-dep src/third_party/cros_system_api Bug: 1082075 Change-Id: I776b14c5a6083d71f64842f9192ea97dfc7a2946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210086 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#770941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c256b1f2a5f3..a6b59e58b6b5 2020-05-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4aa114627f15dc25fa9de0640f5d8ce958b662ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211463Reviewed-by:
-
sangseok.jang authored
These functions' body was removed by previous patch(https://chromium-review.googlesource.com/c/chromium/src/+/1983215) but declarations still remain. Bug: none Change-Id: I06f2a3e9f80350132465f2f4320b373f8604570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208313 Commit-Queue: SANGSEOK JANG <sangseok.jang@gmail.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#770939}
-
Alex Gough authored
Does not change behavior. Prelude to removing WithSandboxType option from service process host API. See linked bug for rationale. Tests: content_browsertests StoragePartitionImplBrowsertest Bug: 1065087 Change-Id: Ic3aed7e47eecfe75fbe0fcc630af3d362854a0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209295Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#770938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab2265ec86ea..3bc19daeb343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1041701,chromium:1084764 Tbr: yosin@google.com Change-Id: I53eac19a0c52e9ca7231ab4839364f6aa3c68a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210913Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770937}
-
John Z Wu authored
This fixes issue where the generated .modulemap file is referencing a nonexistent header file. Change-Id: I156ccff21b5a8cd56b56e4777c2dd601957c5eb3 Bug: 1084855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209569 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#770936}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I002852ecc746ea9e1c66eabf1a8d66134bf2cd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211465Reviewed-by:
-
Dmitry Torokhov authored
We need to re-notify the user about each and every failure to start Plugin VM, otherwise, if notification was closed, but not dismissed, the failure appears to be silent. Bug: b/155685388 Change-Id: I018af01601562747053b0ade7b0c3e214728c1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211156Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#770934}
-
Luciano Pacheco authored
The sorting icon should be an arrow pointing up when sorting in ascending order. Bug: 1081853 Change-Id: If559358bb05aa34a4875504ea4386364c25ccd01 Fixed: 1081853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208887 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770933}
-
Luciano Pacheco authored
Only show focus ring only when interacting with keyboard. Add the hover color/style for OK button. Fix font face when opening delete dialog from <quick-view>, it was using Arial font, because it was missing "text_defaults.css" in this context. Bug: 992827, 1062902 Change-Id: Ibc4f6c576779a764d496d3d810d46bfa5378eef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208779 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
In next CLs: Add more started/shutdown checks in WebAppInstallFinalizer, WebAppInstallManager, ManifestUpdateManager. Bug: 1084939 Change-Id: I720cbdd79998e895f5b9171e3173f89c6977be6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210085 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Alex Danilo authored
The drop-down menu hanging off the elider button has a width range between 192px and 288px depending on the content inside it. Wide menus can get clipped on the right hand side if the window width is reduced to the smallest size possible, obscuring any scroll bar in the drop-down. Changes the max-width selector to take the minimum of 288px or 40vw which guarantees the right side of the menu doesn't get clipped out. Bug: 1083046 Change-Id: Ia64dc5befe62e5d4370044fe2545c1c720efee40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210177 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Wenyu Fu authored
Add paddingTop to make spacing consistent between top and bottom. Bug: 1068831, 1084791 Change-Id: I68639415615c24d3fa7889c53b74d9102482a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209895Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770929}
-
chrome://media-appDavid authored
This patch * Mutates `currentFiles` upon deletion and tries to open the next file. * allows empty fileLists in `advance()` and `sendFilestoGuest()` * Adds a test for the scenario of deleting files in a directory of images. * reworks some of DeleteOriginalIPC to make the test more robust as before it was passing due to FakeFileSystemHandle always having the same default file name. Explicitly adding a filename makes the test more obvious when debugging. * Also swap DeleteOriginalIPC assert calls around to have the expected value on the LHS as we use the `assertEquals` from go/crcs/chrome/test/data/webui/test_api.js Bug: 1077732, b/156042029 Change-Id: I1606809db9ccae388182a086aa9045280624c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206195 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#770928}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1069817 Change-Id: Iee9b615a27bd3b88d73228461dc52e188bfce52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208888 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770927}
-
Khushal Sagar authored
Add a finch feature flag to disable delaying scroll response in the compositor for scroll handlers. R=sadrul@chromium.org,szager@chromium.org Bug: 1080911 Change-Id: Ida54b5f160b4438898cde48e59037d5c5254b4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209688 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770926}
-
Thomas Lukaszewicz authored
Updated the FocusRing class to use a ScopedObserver when observing its parent. Currently the FocusRing is successfully removed as an observer from the parent due to the fact that the FocusRing lives in a unique_ptr in the parent class. When destruction of the FocusRing's parent occurs, the unique_ptr is deleted before ~View() begins deleting the parent's children - a process which nullifies the parent_ pointers of the children. Since the unique_ptr is deleted prior to the ~View() destructor it still maintains a pointer to its parent and can successfully remove itself as an observer of its parent. In the current state this works, however the intention is to remove the use of set_owned_by_client() in FocusRing. If added as an owned child of the parent view, it will not have access to a pointer to its parent during destruction, meaning that it will be unable to remove itself as an observer of the parent, causing a seg fault later in destruction. The use of a ScopedObserver solves the problem in this case by allowing the FocusRing to remove itself as an observer of the parent irrespective of whether the parent_ pointer exists. Bug: 1044687 Change-Id: I54f486a326a6babe50baa3746868cfa27284e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210009 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#770925}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie58e595af915448eb44851f34e409d802e3204d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211460Reviewed-by:
-
Sadrul Habib Chowdhury authored
Report the top-level UMA metrics for rendering from the system_health benchmark. BUG=1080679 Change-Id: Ie8e1810714780c786200d6d703e0dcacdd2ab041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198597 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#770923}
-
Mike Jackson (EDGE) authored
Rename shortcut_manger to shortcut_manager Change-Id: Ie21c942340b858f615f2dec84fe1b8821af00ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208304 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770922}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f83baf230c69..4c0578632217 2020-05-21 reed@google.com init fDeviceClipBounds for empty canvas 2020-05-21 fmalita@chromium.org [skottie] Add support for embedded fonts (glyph paths) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ia2c1952313c35d4c1a08996b278222dd9e932d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210062Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 0bd440c5. Fixed (mostly invisible) raster invalidation issue with PaintOpBuffer::NeedsAdditionalInvalidationForLCDText() to invalidate the whole layer when LCD Text under SaveLayerAlpha may change. Original change's description: > Revert "Preserve LCD-text in SaveLayerAlphaOp when possible" > > This reverts commit 0c258cbd. > > Reason for revert: Flakiness of raster result. crbug.com/1082804. > > Original change's description: > > Preserve LCD-text in SaveLayerAlphaOp when possible > > > > This achieves LCD-text under non-composited opacity when possible. Pass > > two flags to SkCanvas::SaveLayer() for SaveLayerAlphaOp: > > kPreserveLCDText_SaveLayerFlag to preserve LCD text, and > > kInitWithPrevious_SaveLayerFlag to to ensure an opaque background. > > > > This doesn't apply when there any SaveLayer modes which would break > > LCD text or be broken by kInitWithPrevious_SaveLayerFlag. So we disable > > the feature for the whole layer when there is any of such effects in > > the layer. The new operation is also a bit more expensive, so only do > > it when there is text. For now these two conditions are applied on the > > whole layer for simplicity. Otherwise we would need to track them in > > SaveLayerAlpha/Restore hierarchy which would be complex and error-prone. > > > > Bug: 942051 > > Change-Id: I3ab2e8051e26c5714fd72830a7921099b9170d0d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189260 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#768367} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 942051, 1082804 > Change-Id: I36f281df4940588d5c2b1b4da415f5d22b0aa9e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203495 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769425} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 942051, 1082804 Change-Id: Ic4bccc769a044061238469a38edf0822a6ed16c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206213Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770920}
-
Moe Ahmadi authored
Only realbox matches with descriptions should have a hyphen Bug: 1085240 Change-Id: Ieb4f8f27dcbf8b6763d025935a7547a2180657b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211129 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770919}
-
Julie Jeongeun Kim authored
This reverts commit aff3274e. Reason for revert: This causes the crash. It's important to handle the message in order in the preview UI. So, the interface should be converted with PrintHostMsg_MetafileReadyForPrinting together. TBR=dtapuska@chromium.org Bug: 1008939,1084837 Change-Id: Iedae9b30c7fb1c87a1537efbf8696e7762e8e259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208778 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770918}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a09ea700d32b..011959aafddc $ git log a09ea700d..011959aaf --date=short --no-merges --format='%ad %ae %s' 2020-05-13 absl-team Googletest export 2020-05-13 absl-team Googletest export 2020-05-11 absl-team Googletest export 2020-05-08 martin Remove an explicit include of debugapi.h 2020-05-08 martin Revert "Googletest export" 2020-03-29 verdoialaurent Fix --gtest_print_time coloring Created with: roll-dep src/third_party/googletest/src Change-Id: I57639ecb4ed40df147a55e41434bd3fccc441b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211195 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770917}
-
Brian Sheedy authored
Suppresses some lightly flaky WebGL 2 shader operation tests on Intel GPUs with a RetryOnFailure expectation. TBR=ynovikov@chromium.org Bug: 1085222 Change-Id: I8bf470a2b7c4fa4a8a9277cb50d12328fb45cc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210972 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#770916}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 668e5fe8. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" 2588266e "ServiceWorker: Modernize fetch-request-resources.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: If9c1eaff752d01fd9fa323d2aa42e754f66fd5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210536Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770915}
-
