- 19 Apr, 2019 40 commits
-
-
Peter Boström authored
This removes the confusing behavior where a user clicks a button, expecting an action to happen, but there is no associated action so we would instead spawn a context menu. This now does not look like a clickable button (no hover state) and the three-dot menu is used to access the context menu for extensions without actions. Bug: chromium:943702 Change-Id: I9ae6fe7d549dd2dac2d003fb6f1fecdab66e9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575859Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#652618}
-
Piotr Bialecki authored
Change-Id: I735de5c7f56cad4fec89dd3033ad6748a875ebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575360 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652617}
-
Simon Pelchat authored
The default_integration policy should be used when no exp= is otherwise specified to make sure that the GFE cache is not used. Bug: 950734 Change-Id: I6129845bed78f84175fb440003575f626431ccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560454Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/master@{#652616}
-
BUG=762641 TBR=agawronska@google.com Change-Id: I26b7b542d8172a9743da9a2fc5bf404be25f3c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574262Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652615}
-
Torne (Richard Coles) authored
Improve the doc comment for the GN arg "system_webview_package_name" to mention that it controls TrichromeWebView as well as SystemWebView, and to explain more about why you might want to use it. Change-Id: I4c4c6e003416c9e2f39ab2492078baaa049237b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575732 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652614}
-
Roman Sorokin authored
TBR=xiyuan@chromium.org CQ-DEPEND=CL:1570024 Bug: 952855 Change-Id: I783e41a3c810764d8118dda3643f2a1964186966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572405Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652613}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/4a8c05ffe826c61d50fdf13483b35097168faa5c..e55c64fdd3f47413e17eaa8e4f4d2a62622a01eb Bug: none Change-Id: I0f0220cfd3cd3288281d85808645eca3dc7fefb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574296 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652612}
-
Brandon Wylie authored
Bug: 953893 Change-Id: Ic30e369768a6c154209ef7fdd9b881374b3f8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572534 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#652611}
-
Dana Fried authored
Affects folders in the bookmark folder as well as subfolders. We could also log this at the event source using the existing BookmarkBar_ContextMenu_OpenAll event, but since it's a click/gesture rather than a context menu action I created a new event type for it. Bug: 954254 Change-Id: I4ae18d9f2dbdda5448fdc3993e06b6ef76159570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574147 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652610}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fcc3ec31b83b..c467f7b54188 git log fcc3ec31b83b..c467f7b54188 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 spang@chromium.org Compute usage from format properties cache in glTexStorageMem2DEXT Created with: gclient setdep -r src/third_party/angle@c467f7b54188 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic5bd49ac7a44e0d08263f331d0d91e4a10d20803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652609}
-
Yuwei Huang authored
* Implement a MuxingSignalStrategy to be used exclusively by JingleSessionManager to handle messages from both signal strategies. * Integrate all the signaling stuff into remoting_me2me_host, which can be enabled by passing a `--enable-ftl-signaling` flag. This has been tested with ftl_signaling_playground and I'm able to finish candidate exchange for ~99% of the attempt. I did see one DCHECK failure when JingleSession receives a duplicated message, but that will be tracked and fixed in a different bug/CL. Bug: 947337 Change-Id: Id6a6a183041a2668a0dd31deb735b01ceb4c4aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565537 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652608}
-
Jacob Dufault authored
TBR=xiyuan@chromium.org TBR=rsorokin@chromium.org Bug: 928555 Change-Id: Iae26e383c7fe81cbd5a0bf638c432bf1947f77da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572234 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Dana Fried authored
Requested by Chronav logging initiative. See attached bug for details. Bug: 951906 Change-Id: Ia532b16cde546b3cbadc1c52cafc2503a452f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574601 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Frank Poole authored
This change adds the GetInnerRangeBoundsRect interface to AXPlatformNodeDelegate. Similar to GetRangeBoundsRect, GetInnerRangeBoundsRect also calculates bounds for a range. Unlike GetRangeBoundsRect, GetInnerRangeBoundsRect accepts text offsets relative to GetInnerText in which text offsets on descendant nodes are included. This interface is intended for clients which calculate text offsets relative to GetInnerText, such as the UIA ITextRangeProvider implementation which relies on AXNodePosition. This change also adds values to the result of BrowserAccessibility::GetInnerText so that it has parity with AXNodePosition::GetInnerText. GetHypertext and GetInnerText interfaces are added to AXPlatformNodeDelegate although they are currently only implemented on BrowserAccessibility and its subclasses. Bug: 928948 Change-Id: I5607ee796a9f4bfc4352e43b2f7209200685b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558708 Commit-Queue: Frank Poole <frpoole@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#652605}
-
sczs authored
This CL also makes some improvements to InfobarContainerCoordinator so the test can pass: - isPresentingInfobarBanner is now directly based on the ChildCoordinator Banner presentation and not just the existence of a VC. - A disconnect method is added to make sure the mediator stops observing WebStateList before being dealloced (This is a common pattern throughout mediators since the memory de-alloaction order in unittest can cause this) - Adds a legacyContainerFullscrenSupportDisabled to disable FullScreen support in the legacyContainer. This is needed to avoid a crash after cleaning up each test case, in order to properly fix this we'd need to know when the legacyContainer has been dismissed, that would require some refactoring and the effort/risk is not worth it at this point. - Removes a DCHECK in the legacyContainer since now the count of total Infobars doesn't necessarily match the count of total Infobars in the legacy Container. This because one of them can be a message. The iOS implementation of the container was merely sending infobar.count() for position, meaning we were never using position anyways. Bug: 911864 Change-Id: Ie46c9dc88d2f5277401eb1d08aa54a09d4dbaf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566756 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652604}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/726fdfaee1e0..7ef31b3e5b93 git log 726fdfaee1e0..7ef31b3e5b93 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jclinton@chromium.org Revert "chromeos-config: disable boards affected by crbug.com/954446" Created with: gclient setdep -r src/third_party/chromite@7ef31b3e5b93 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I043ed8d16da0a2d4db0082bb7f7770413a05cfcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575655Reviewed-by:
-
cjamcl@google.com authored
For terminology alignment with CruX. Bug: https://github.com/googlechrome/lighthouse/pull/6163 Change-Id: I90ebd73384947114f9b237f4afee3fdd4683db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575823Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#652602}
-
Charlie Harrison authored
This experiment has been disabled for a while. It should be pretty easy to reland if we decide we want to do it. Bug: 829042 Change-Id: I273d7a757312f1628ce3878e266311455eb73eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574281 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/847d55be4e62..377befab7175 git log 847d55be4e62..377befab7175 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 michaelludwig@google.com Update compositing benchmark to use image-set API 2019-04-19 csmartdalton@google.com ccpr: Indicate path fill type by winding direction of cover triangles 2019-04-19 ethannicholas@google.com added error detection for writing to a constant swizzle mask 2019-04-19 kjlubick@google.com [spec] Initial commit for web spec 2019-04-19 ethannicholas@google.com Revert "Revert "added more SPIR-V RelaxedPrecision decorations"" 2019-04-19 reed@google.com use char-to-glyph cache in freetype typeface 2019-04-19 brianosman@google.com Remove SK_TREAT_COLINEAR_DIAGONAL_POINTS_AS_CONCAVE 2019-04-19 robertphillips@google.com Allow GrShadowRRectOp::Make to fail 2019-04-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 82bcffa78747..145ec7fa7c81 (10 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader abaecd5f2ba7..a16238df3f28 (12 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f968f64c..a55917cb (433 commits) 2019-04-18 martin@mainframe.co.uk Properly retrieve memory block in SkTextUtils 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 halcanary@google.com SkPDF: move type1 font code into single file 2019-04-18 csmartdalton@google.com Swap front and back stencil sides when rendering bottom-left 2019-04-18 bsalomon@google.com Swap x/y radii for EllipticalRRectOp depending on matrix. 2019-04-18 halcanary@google.com SkQP: consolidate cut_release scripts 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 reed@google.com remove experimental from some APIs (that are no longer experiments) 2019-04-18 michaelludwig@google.com Fix quad type detection from SkPoint array 2019-04-18 brianosman@google.com Remove the axis-aligned vector special case to convexity checker 2019-04-18 ethannicholas@google.com fixed assertion failure in skslc SPIR-V output 2019-04-18 bungeman@google.com Make more SkTypeface virtuals pure. 2019-04-18 borenet@google.com [infra] Fixes for chrome_release_branch 2019-04-18 hcm@google.com Update Skia milestone to 76 Created with: gclient setdep -r src/third_party/skia@377befab7175 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935198,chromium:946965 TBR=herb@chromium.org Change-Id: I23c6433ad9bc7d5e0982253667916e854515899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575654Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 4dd1f3ce. Reason for revert: Failing on Linux ChromiumOS MSan Tests. Sorry... Example failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12454 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12450 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12438 Original change's description: > Reland "Move loading of data URLs out of the network process." > > This is a reland of f45ff75d > > Original change's description: > > Move loading of data URLs out of the network process. > > > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > > > Bug: 937146, 939871 > > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652196} > > Bug: 937146, 939871 > Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652335} TBR=kinuko@chromium.org,jam@chromium.org,rockot@google.com,dtrainor@chromium.org Change-Id: I5e8c075a625f94841328b207c22ab45da0a32082 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937146, 939871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575864Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652599}
-
Bret Sepulveda authored
Other tests in the suite continued to flake overnight, so this patch disables the entire suite. TBR=caseq@chromium.org Bug: 954398 Change-Id: I6bacd513c9d32164091237da3443542474ea49eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575860Reviewed-by:
-
Matt Menke authored
Previously, we'd invoke them whenever any request was deleted or when a SpdySession is created. With this CL, we invoke them only when the first request is deleted or a SpdySession is created. This reduces the number of PostTasks and searches through std::maps when we have a bunch of requests all waiting on the creation of the same SpdySession. Bug: 912727 Change-Id: I5083137cf0726e3b1ddb3ac4608b706121964cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570914 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652597}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia32c76a1410538f92b334b289af3563bcc3dd95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575653Reviewed-by:
-
Miguel Casas-Sanchez authored
- s/DECODE_COMPLETE_TIMESTAMP/DECODE_TIME/ - Moved place where that metadata is stamped. Bug: 950183 Change-Id: Iab34674090aaf0bc10e65ed0bee157a0aa63586a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575580Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#652595}
-
Michel Promonet authored
crosscompiling on crossbuild-essential-armhf from ubuntu 18.04 for armv6 that doesnot support thumb fails reporting error: - sorry, unimplemented: Thumb-1 hard-float VFP ABI Change-Id: I2c6a5c6ae3c8af9ab168f6dbd281e2eb4e94f509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565885Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#652594}
-
Maks Orlovich authored
This is to permit splitting up reporting of network service from utility without it basically duplicating ProcessMap for its own -- and to avoid every future potential service wanting its own memory usage stats needing to do that (Audio service already does, but it does more with it). Bug: 947573 Change-Id: I0b036b4a6a4db1b5ae22e87ed4df08841a2b9820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548680Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652593}
-
Yuwei Huang authored
Previously deleting the scoped stream will only prevent new tasks from being scheduled, and it doesn't drop pending tasks. This is a potential issue if the caller expect its method not to be called after the scoped stream is deleted. This CL fixes this by making the stream request check the scoped stream's validity before running the task. Bug: 927962 Change-Id: I6a43b21772b89231ee89a8def68ba40c2b50c821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574893Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c5646485a95..40beee366962 Created with: gclient setdep -r src-internal@40beee366962 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I0749e1b27c27d453e3a46fabd0e893c46fc45f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575652Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652591}
-
Dana Fried authored
Previously, only top-level bookmark buttons were logged. Bug: 951899 Change-Id: I9480ed64186ddc068db9a3184363680596df5b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572811Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: Ic81533da811793d655efca111ceb3629d14275d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574108 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652589}
-
Becky Zhou authored
Fix two issues introduced by https://crrev.com/c/1568092 + Scrim status bar color on pre-L. The old "parity" logic does not work now that we calculate the status bar color instead of passing in a previously used status bar base color. + In tab grid switcher, the url focus percentage can change before #onObservingDifferentTab() is notified, so we need to avoid calling #updateStatusBarColor() in #onUrlExpansionPercentageChanged() with the out-of-date tab. Bug: 952752, 953665 Change-Id: I175b1e2d3136fd5dc190d4ec8cdba2f88888c23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572702 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#652588}
-
Brandon Wylie authored
Using dialog_list_item layout to match the more button to specs. Bug: 937450 Change-Id: I3f5966a5a9f8fb47e9d674361b02a9913c89561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559236 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#652587}
-
sczs authored
Bug: 953532 Change-Id: Icd9233feb6e2c0df92f81dd5bc58132aa61487ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574600 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I198bd3b15ddc6e4f871c6de517c0a2bb3442979a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575718 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652585}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/92d14c28e81b..b60ce313b947 git log 92d14c28e81b..b60ce313b947 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate alerts-controls.js to es6 module Created with: gclient setdep -r src/third_party/catapult@b60ce313b947 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=charliea@chromium.org Change-Id: I5e578e0db41462e33512f81214ede8f3f892e856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575651Reviewed-by:
-
Hesen Zhang authored
Bug: 952354 Change-Id: I63d493056071d0677cb6d8ff506ab51625d6b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575020 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652583}
-
Matthew Cary authored
The previous crrev.com/c/1570829 did not set these, which are necessary to build some targets. Bug: 849207, 640840 Change-Id: Ibc2b3e315e8a3bee040cfb054a15b54901a4edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575581 Auto-Submit: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#652582}
-
Becky Zhou authored
Intialize the colors properly in StatusMediator so that the icon tint is set correctly when tint update is never called. Bug: 953975 Change-Id: I21909656d412667dd8958738884c60879d4e1295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575121Reviewed-by:
-
Ahmed Mehfooz authored
Create AppListPaginationController Move PaginationController to ash/public/cpp/pagination/ Move PaginationModelObserver to ash/public/cpp/pagination/ Move PaginationModel to ash/public Bug: 914077 CQ Dry Run to ensure no unit tests broken Test: Manual Test to ensure Pagination and Pagination Metrics not broken Change-Id: I25a665fb59e252c63d369445e8225e7d6b73722e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564583Reviewed-by:Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Theresa authored
BUG=953462 Change-Id: I937076dbdf0fc97da644bf73aaf3e79678bf215b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570588Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652579}
-
