- 12 Jan, 2021 40 commits
-
-
Dan Elphick authored
Now that v8 declares V8_USE_PERFETTO as an external definition that appears whenever including the main V8 headers (https://chromium-review.googlesource.com/c/v8/v8/+/2621083), we can remove its definition from gin. Bug: 1006541 Change-Id: I5b48bedfce1588c078fda0c307c0f345dcb222ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622096 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#842468}
-
Marc Treib authored
This adds a new feature param which, when set to true, sets the default password store to the account store when the user opts in to the account storage. This is mostly meaningful together with the |kSaveToProfileStoreByDefault| feature param. This is a follow-up to https://crrev.com/c/2599529. Bug: 1160655 Change-Id: Ia3a39ee1002b456ff09bec04b774e6f37ec85d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622115Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#842467}
-
Minoru Chikamune authored
[MBI] Return per-AgentSchedulingGroup default task runner from ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() The MBI project is introducing a scheduling boundary called AgentSchedulingGroup (ASG in short). Per-thread task runners are implicitly used by calling base::ThreadTaskRunnerHandle::Get() (TTRH::Get() in short) and base::SequencedTaskRunnerHandle::Get() (STRH::Get() in short). This CL changes the contract of TTRH::Get() and STRH::Get() to return per-ASG task runners instead of per-thread task runners so that the callsites of TTRH::Get() and STRH::Get() use the per-ASG task runners when there is an active ASG. [Design Doc] https://docs.google.com/document/d/1zHkk2z-iwUrTczayT3xkL3gz12xxjJ_aOtVjqKsBCvw/edit?ts=5fbf2f4b&resourcekey=0-4Sbdx2v7kLvdawkNpp3DdQ Bug: 1105403 Change-Id: I153c3bf72e66580d838cf053de48d4d7048fa542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550326 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Tal Pressman <talp@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#842466}
-
Alice Wang authored
This CL refactors and tests ForcedSigninProcessor. Bug: 1045525 Change-Id: Id4948e2c546ddb7e0bee374e5ff2fdf5530f6afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617941 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842465}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13694cecae39..73995827981d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rainhard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rainhard@google.com Change-Id: I141896158ba767997140f075e6ab9b6e52ae6bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624147Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842464}
-
Sanja Perisic authored
Added support for disabling Chrome Web Store if SystemFeaturesDisableList policy is set Bug: 1142785 Test: SystemFeaturesPolicyTest.DisableWebStoreBeforeInstall, SystemFeaturesPolicyTest.DisableWebStoreAfterInstall, SystemFeaturesPolicyTest.DisableCameraAndWebStoreAfterInstall Change-Id: Iab279d250a07bdd866b4d8dfb6761f55507d8848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606351 Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#842463}
-
Jordan Demeulenaere authored
Before this CL, only the details image could be replaced by an animated placeholder. This CL exposes a new PlaceholdersConfiguration in the DetailsProto to configure the placeholders shown in the details, so that we can also have a placeholder behind the title and descriptions. Some UI changes will still need to be done in a follow-up CL, given that right now there is no space between the placeholders, which looks a bit weird. Bug: b/174652960 Change-Id: Iededbae9e7393d9fe9d505faa33b5dee6da83c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599860Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#842462}
-
Javier Fernández García-Boente authored
The ShapeLineBreaker::NextBreakOpportunity function determines the non-hangable run end based on the currently break-offset. This value is, by definition, always smaller than the break-offset. However, if the break-offset value exceed the range_end, we use this as the actual offset. If we have reached this scenario because there is no breaking opportunity to prevent the overflow, then we just call ShapeToEnd and return. Otherwise, we continue processing the text item. In this situation, we must ensure that the new offset is greater than the previously computed non-hangable run end, since it's possible that we end up using it as the final offset, leading to the assert violation described in the bug, since the used break-offset is smaller than the item's end. This CL adds the logic to prevent this situation, clearing the non-hangable run end and computing it again, if necessary, based on the new offset. Bug: 1161793 Change-Id: Ie10ffae3c654aefa626d80abd01bd38e026c9e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604908 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842461}
-
Andre Le authored
This is a reland of 5ac617b2, which caused a MSan issue since TimeTrayItemView instance was destructed after the UnifiedSystemTrayModel instance in UnifiedSystemTray. This reland fix the order of destructions. Original change's description: > Scalable Status Area: Show date in status area in large screen. > > - Add a flag for the scalable status area feature. > - Add enum and helper function in SystemTrayModel to capture system tray > size. > - Add date to system tray when the screen is large. > > Bug: 1161557 > Change-Id: Id85a6bee9a30684c65b2253862ba30ab78583525 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600912 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841227} Bug: 1161557 Change-Id: I2894c68e6e59bef90c374dfe6d6c85ea74ef1850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618445 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842460}
-
Rune Lillesveen authored
Bug: 1164055 Change-Id: Id74b628ce9a99e8a317d881c20a391ece1b85af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620620Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#842459}
-
Morten Stenshorne authored
Previously we'd just stop when reaching a legacy fragment (since such fragments are always childless). But descendants of a legacy object may re-enter NG layout further down the road (this is the case for tables and grid, for instance), and dumping those fragment subtrees may also be useful. Example (assuming that tables are laid out by the legacy engine): <!DOCTYPE html> <div style="display:table;"> <div>HELLO</div> </div> NGPhysicalFragment::DumpFragmentTree() will now include the DIV child of the table: .:: LayoutNG Physical Fragment Tree ::. Box (block-flow-root block-flow)(self paint) offset:unplaced size:800x34 LayoutNGBlockFlow HTML Box (block-flow) offset:8,8 size:784x18 LayoutNGBlockFlow BODY Box (block-flow-root legacy-layout-root) offset:0,0 size:53x18 LayoutTable DIV (NG fragment root inside legacy subtree:) Box (block-flow-root block-flow) offset:unplaced size:53x18 LayoutNGTableCell (anonymous) Box (block-flow children-inline) offset:0,0 size:53x18 LayoutNGBlockFlow DIV NGPhysicalLineBoxFragment offset:0,0 size:52.4375x18 NGPhysicalTextFragment 'HELLO' offset:0,0 size:52.4375x17 Change-Id: I95c63181f1d716bd8f79dfb25b9e31fdde49545e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617845Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Jack Franklin authored
https://crrev.com/c/2622192 is moving binaryIndexOf to not be a prototype-polluting method and it is now tested as a DevTools frontend unit test, so we do not need the additional test here. Bug: chromium:1050549 Change-Id: Ie06805ae2b46bf6585368b428950316e1ecf3b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624207 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842457}
-
Camillo Bruni authored
Currently we have little coverage of this new feature and writing unittests for streaming compilation is not yet supported. Once successfully shipped, these tests should be removed again. Bug: 1011762 Change-Id: I52a433e4655003cc5a3ac53d3df0ba2cca241537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617820Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842456}
-
Luciano Pacheco authored
JS modules for //ui/file_manager/file_manager/foreground/js/: - file_type_filters_controller.js - file_type_filters_controller_unittest.m.js - navigation_uma.js - metrics_start.js - mock_actions_model.js - spinner_controller.js - spinner_controller_unittest.m.js Bug: 1133186 Change-Id: I90a3a2f8168ec8bf6e9b47abcc179d3cf3526dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623573Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842455}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/537f11c11412..12cf8695092d 2021-01-12 sigurds@chromium.org Add performance measureMemory in FrameDetailsView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1139899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I617484c4568fd4dd8027e578899a757a3fb57848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842454}
-
Stephane Zermatten authored
This change introduces a way for content to set arbitrary bottom sheet offsets while the content is active. The offset set that way stays as long as the sheet doesn't change state or need to be refreshed (onLayoutChange) This change also ignore onContentSizeChanged calls that report no changes, as this would otherwise reset the sheet offset for no reasons. The immediate goal of this change is to allow controlling the height of the Autofill Assistant bottom sheet to have it scroll in sync with the browser. Change-Id: I020f393a580df0e85921ec7dd9388b72944f566d Bug: b/171792266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599863 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#842453}
-
Miriam Polzer authored
During re-enrollment, if install attributes are present, we check that the domain to re-enroll to matches the one in install attributes. Only compare install attributes domain to the login-given domain if it is non-empty, i.e. if a gaia login took place. If no login happened, e.g. during auto re-enrollment, the domain is provided by the server and stored in the enrollment config. Policy validation will fail if the server provided domain is different from the one in install attributes. The check edited in this CL is not necessary in this case. Bug: 1158573 Change-Id: I4c65c5d91f237a24d02edfac6aec6c5f31a6eeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598852Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#842452}
-
Ramin Halavati authored
ProfileAttributesStorage::GetAllProfilesAttributes is updated to exclude Guest profile unless it is explicitly requested by the caller. Bug: 1161494, 1125474 Change-Id: I1f006d6fb8c58bb23099d111d83da0f84c2ec2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621299Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#842451}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/84c7d11419c5..a3806cb35923 2021-01-12 tsepez@chromium.org Avoid inifinite loop in agg_math_stroke.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Id2f046aed5779c8e1923b7eb3bc921d4fa1d7875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623988Reviewed-by:
-
David Roger authored
See go/spaces-strings Main view screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/a064193913da1c2d06ab2a932d094c622e45a837 Menu screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/cce701c74e713ef7261c237cb86d70425f50d285 Remove confirmation screenshots: Actual: https://storage.cloud.google.com/chromium-translation-screenshots/2a3a3c3d5bf360187d890afbfe303e8c733403c5 Mock syncing: https://storage.cloud.google.com/chromium-translation-screenshots/408fca9dc377d9224566b3b54d059f351c2b7673 Mock local: https://storage.cloud.google.com/chromium-translation-screenshots/2bacc5f33ddef4d028243d6e97f85797d5792774 Change-Id: I3ccd4d0bee5e46eb119f101d0042c95d2b531216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622173 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
-
Side Yilmaz authored
This CL updates the functions of DownloadManagerService to support multiple off-the-record profiles by passing OTRProfileID instead of isOffTheRecord boolean. Bug: 1099577, 1060940 Change-Id: I3fb81d8eea3b0c3fc34e6772fb525d6507285566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617794Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842448}
-
Ulan Degenbaev authored
This generalizes the existing handling of FrameNodes using ExecutionContextTokens. Bug: chromium:1085129 Change-Id: I483c0fcfef85e9d82151e09ca3c99ff0a8377081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621634 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842447}
-
Collin Baker authored
Bug: None Change-Id: I5ace2a9bdcb2333e03d5b1118747f2b41d74d081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618626 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842446}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4c3f342596793f6be0e49fb1bd5323f2fdad8a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623805Reviewed-by:
-
Irem Uguz authored
Currently, screen-reader reads the field title and the values separately in the dialog page. However,the desired behaviour for screen-reader is to read out all information about a field in one-go for better user experience. This cl improves this behaviour. Bug: 1157398 Change-Id: Icce01a076411c66c8aa667b7642fc48e9bb038b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602293Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#842444}
-
Hirokazu Honda authored
ForceKeyFrame requested after the frames are released specified times and checks if the first bitstream returned by VideoEncodeAccelerator is keyframe after requested. However, releasing frames and producing bitstreams are asynchronous. This check is wrong. This CL corrects the fix by seeing if the keyframe exists in a few produced bitstreams after requested rather than the first bitstream. Bug: b:176252185 Test: video_encode_accelerator_tests on grunt Change-Id: I442635a3c1ffefd4fcade9abdd81e74205e931be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614527Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842443}
-
Victor Vianna authored
The method is unused. Bug: 1156620 Change-Id: Iedccf2b93b2b0c6e9391c243b8312283706ddec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579967Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#842442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b97affa04ee..13694cecae39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ib6b3661cab426ee9e9c593875678abf0039e36f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623947Reviewed-by:
-
Daniel Hosseinian authored
Meanwhile, consolidate calls to FPDFAvail_IsLinearized() to a private helper. Bug: 93619 Change-Id: I0b1fd52e9067e2c05e66034caf3d3ceb641411de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622515 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842440}
-
Mike Dougherty authored
Bug: 1042335 Change-Id: I5caadeedf9b94344f535c9171c381530820eaf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555580 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#842439}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c65da28a2ee..bdbcbe94074d 2021-01-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 193bb22c to 734de1a6 (311 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I0f464b6662af8ac1efb1efd482f3b6b1ced7fd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623794Reviewed-by:
-
Alice Wang authored
This CL changes Context to Activity as argument to open Settings on android device. Bug: 1163470 Change-Id: I5ef9b166f0168140510f163eb83a96805bda2898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621633Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4281a3f2..0e5a5d24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9fad47cbe78789879ef6c258a77f79b383b4167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623853Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842436}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610408110-5a618b6e0bdb5b4a60796f5aa8c6f6759f78cdd3.profdata to chrome-mac-master-1610431066-5d7d40ce59ba8e505b376b46e02fe57205cb3e46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6d664ec96b53885b31375fc981a7a6998f200c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623803Reviewed-by:
-
dpapad authored
Bug: None Change-Id: I6df66bd19eab1edff837b340dd63d1ae4040ec61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620467 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#842434}
-
Colin Blundell authored
This CL abstracts RealTimePolicyEngine's dependence on signin and sync for determining whether safe browsing access token fetches are supported, instead having it take in a callback supplied by its client. We place the abstracted functionality in //components/safe_browsing/core/browser/sync along with adjusted versions of its unittests. The purpose of this abstraction is to enable this code to be reused by WebLayer, which does not use signin or sync. This CL binds the callback in RealTimeURLLookupService, but a followup will do the binding in the embedder of the SafeBrowsing component. Bug: 1080748 Change-Id: I7bf0d3d15eae173b107f95cdc1616e08e0f69eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616352Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842433}
-
Ewann authored
This is a reland of 60e867a2 Original change's description: > [iOS] Updates system colours to use google material colours > > This CL replaces the existing system colours by Google material colours. > > Bug: 1155472 > Change-Id: Ia9c9e8f31d65fe1db70fd29ad94ca370d0aede07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595050 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Javier Flores <javierrobles@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840999} Bug: 1155472 Change-Id: I4ce77a7ffbe2cb75fe3c3434e54f1ff34fdae7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620804Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#842432}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610408110-1b25c741a858a17df9d643531610232aedd2e5da.profdata to chrome-linux-master-1610431066-b046cf295bac84ed9eefc440cb75a6df945c21fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54747662dcc6290e178ced85691a6bf5188766bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623802Reviewed-by:
-
Matt Falkenhagen authored
This is a reland of f4b58578 The fix is to add an early return of null `handle_` in MaybeCreateSubresourceLoaderParams() which is a weak ptr. The comment for `handle_` explains that for workers it can be destroyed before the interceptor, because {Dedicated,Shared}WorkerHost can be destroyed during loading. Also change WorkerScriptLoader to early return when the host is already destroyed, to avoid unexpected behavior like going to network instead of the service worker when it should. Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (3/3) > > Bug: 1138155 > Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307 > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842305} Bug: 1138155 Change-Id: I0b76d1cc9f0365d4bb0f063e1b42e5cb96d6d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623609Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842430}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. This CL is a reland. The original CL was reverted as the introduced tests were flaky. I have since debugged the source of the flake; the fix is contained in the diff between PS1 and PS2. It turned out to be a pre-existing problem in //weblayer's subresource_filter_browsertest.cc that the new tests simply tickled: I was holding the TestRulesetCreator in a local variable and sending the temporary files that it creates to renderer processes, but it destroys those temporary files when it is destroyed. D'oh! Bug: 1116095 Change-Id: I25f5dca647761f652c9d5a2dfc41db1a4d7712b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622215 Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842429}
-
