- 17 Oct, 2019 40 commits
-
-
Daniele Castagna authored
There is some stuttering when viewing protected content with a DP MST dongle attached. Looking at a trace it looks like we spend a lot of time (200ms) in DrmDisplay::GetHDCPState, in particular in drm_->GetConnector. This patch caches the connector used to check if HDCP is available. It additionally downgrades log severity when the HDCP properties is not found to INFO, since it can happen every 2 seconds. Bug: 1001211 Change-Id: I77eb86b2e55f0fd4640560ae2e38d64d5e2b2174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864354Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#707065}
-
Yann Dago authored
Bug: 1013598 Change-Id: I19dbb6981eae07d45c0d760f41f4f42508b80929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856799Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#707064}
-
Max Moroz authored
Added fuzzy padding to the Key value generation, plus included two known colliding values to be used with approximately 1% chance. I was trying to discover crbug.com/973943 with this improvement, but have not succeeded so far. However, the fuzz target seems to be running much faster now and keeps discovering new coverage starting from the existing corpus. This is a good indicator that the change makes sense. I've also compared the code coverage reports locally to make sure those pieces of code under key size checks are now getting executed, such as: https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L449 and https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L793 Also fixed a presubmit warning regarding the use of std::to_string. Bug: 990644, 973943 Change-Id: I0c7560f700ccaf5e25bda2e1d56f3cb613bbe91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865408Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707063}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f088ab877cb..94e600d98301 git log 1f088ab877cb..94e600d98301 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 thestig@chromium.org Verify font resource dictionaries. 2019-10-17 thestig@chromium.org Add a JavaScript test for AFDate_FormatEx(). Created with: gclient setdep -r src/third_party/pdfium@94e600d98301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1013868,chromium:572901 Change-Id: I7c900f247a67da175eabf06115ad04fe1f9d3f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707062}
-
Justin Cohen authored
This reverts commit eda4c3ea. Reason for revert: This change is masking some exception failures. Original change's description: > [ios] Speed up egtest failures by skipping _recordFailure. > > _recordFailure internally spends a very long time symbolicating > on iOS13. Skipping this seems to be safe. > > Bug:991338 > > Change-Id: I74c2872cd82de0840a6bcdd0f799703b5eb9bdb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725137 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684557} TBR=rohitrao@chromium.org,justincohen@chromium.org,monufriienko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 991338 Change-Id: I66223c64e6236dbea9feb8ac74e7c29b832e2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866990Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707061}
-
Mounir Lamouri authored
This reverts commit 2d943658. Reason for revert: feature got all the approvals. Original change's description: > Revert "[Lock screen media controls] Enable by default" > > This reverts commit 00d10067. > > Reason for revert: feature not ready to launch in M78, reverting in trunk then merging. > > Original change's description: > > [Lock screen media controls] Enable by default > > > > Enable the lock screen media controls by default > > since these are shipping in M78. > > > > BUG=965546 > > > > Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#690893} > > TBR=jamescook@chromium.org,beccahughes@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 965546 > Change-Id: I97211dd536f71ee8fed4b08b1124089343f797a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826043 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700041} TBR=jamescook@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965546 Change-Id: I567d6fa05394e31df3d5e9a35f9c3bcc8af600ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867196Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#707060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/930722709254..3e2416ee17a9 Created with: gclient setdep -r src-internal@3e2416ee17a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:1011937) Change-Id: I4c3a166f46df3ff8a22b8f9d0764ab7c02492453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866433Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707059}
-
Peng Huang authored
The crashes is becaued color spaces of DDL recorder colorspace and framebuffer sk surfaces do not match. Bug: none Change-Id: Ib970536c78eb2a9452528b0f99deecc067446247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866738Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707058}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a959deb00750..834ee546f93d git log a959deb00750..834ee546f93d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 johnkslang@users.noreply.github.com Merge pull request #1937 from jeffbolznv/volatile_atomics Created with: gclient setdep -r src/third_party/glslang/src@834ee546f93d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: Icd6d999b7245ae7761cacce2cf8cd7d71e057486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866432Reviewed-by:
-
Regan Hsu authored
screenshot: https://screenshot.googleplex.com/dFAHtHLKDVX Bug: 1004420 Change-Id: I9b3c509cb2cb3dfd2dbbf2f8007173f3abb96b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866019Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707056}
-
Denis Kuznetsov authored
Bug: 1007294 Change-Id: I99b7b3cc46e12c0fb060f76e086f5f31bd4cb812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865216 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707055}
-
Lan Wei authored
Change expectation file of pointerevent_coalesced_events_attributes.html to match the output on Mac 10.13 The wpt test pointerevent_coalesced_events_attributes.html is flaky on Mac10.13 Tests bot, because its running result is different from the default expectation file. I add a new expectation file for Mac10.13. TBR=lanwei@chromium.org,nzolghadr@chromium.org Bug: 1015254 Change-Id: I0795c7154d33689a80c8fa9a99433d7134678589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866993Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707054}
-
Koji Ishii authored
This patch implements |TextType()| and its utility functions for |NGFragmentItem|. This fixes symbol marker and other painting failures due to incorrect |TextType()|. Only one is removed from FlagExpectation because the bot is not ready yet. I will clean it up once the bot is ready. Bug: 982194 Change-Id: Ic99c9eb564b002682fefdb590d42679dbedeae60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865738Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707053}
-
Mounir Lamouri authored
This CL mark UKM metrics to aggregate and also add enumeration information to all metrics. Bug: 1001588 Change-Id: I67d78d364c726074dbfc75a239aba7b086f8a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862891Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#707052}
-
behdad authored
- An OWNERS file added - Some tests are failing currently as the update to Confidence intervals of Mac bots were not correct: https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/17407 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/18108 To fix this, based on values recorded on gpu.fyi bots, limits are updated. Bug: chromium:1011969 Change-Id: Ifc54ef48caaa976aec67960f6c53738a07fe36d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866616Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707051}
-
chrome://settings/addressesDominic Battre authored
This CL just prevents the user from foot gunning themselves by pasting 10 MB of text into chrome://settings/addresses. Bug: 1007442 Change-Id: I9ab3aa526b5ca20fcfc207c3248e9c5df5045ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855961 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707050}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/af60f62955c6..d0f315b3fac8 $ git log af60f6295..d0f315b3f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jophba Rename task_runner to GetTaskRunner 2019-10-14 mfoltz [Open Screen] Add linux64_gcc_debug to the LUCI waterfall page. 2019-10-15 jophba Change JsonCpp reader to use strict mode 2019-10-15 btolsch Add cast sender socket factory 2019-10-10 jophba Add Mac OS X ScopedWakeLock implementation 2019-10-14 mfoltz [Open Screen] Final round of gcc fixes. 2019-10-02 jophba Add frame agent config files 2019-10-11 mfoltz [Open Screen] Fix gcc build errors in osp/impl/discovery/mdns 2019-10-11 rwkeane PlatformClient: Use In Existing Classes 2019-10-11 mfoltz [Open Screen] Remove CDDL compiler dependencies on platform/. 2019-10-10 mfoltz [Open Screen] BUILD cleanups. 2019-10-11 rwkeane TcpSocket: Implement TlsWriteBuffer 2019-10-10 rwkeane PlatformClient: Add Threading Support 2019-10-10 mfoltz Use recursive deps for buildtools/. Created with: roll-dep src/third_party/openscreen/src Change-Id: Ie4bfe652f32e9fc2e55003da894a6759c957c335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865041Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#707049}
-
Dan Harrington authored
It is now implicitly enabled by default. Also updated OfflinePageAutoFetchTest to give more friendly output. TBRing reviewers: holte@chromium.org: Please review changes to fieldtrial_testing_config.json TBR=holte@chromium.org Bug: 887670 Change-Id: I30e169730b31f6ab804b125d4adbb3c5dfe9dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832630 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707048}
-
Dan Beam authored
We plan to add a confirmation dialog (or other similarly useful UI) to either confirm that the user wants to delete autocomplete matches or do then undo (depending on where we land UX-wise). R=tommycli@chromium.org Bug: 1013837 Change-Id: I8ec1942cbc519b2da18e23b04dcb00884719c6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866061 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707047}
-
Gauthier Ambard authored
Bug: none Change-Id: I60a3cdad143ac8e414415c1d03c34e59e843e34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864779 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#707046}
-
Yue Li authored
If Device Apps bit is disabled, we should not send the list of installed apps to the server. Also disable the open app feature. Bug: b/140584925 Test: Manual Test Change-Id: Id998a23b9d5e34cf3515a4ef07fda538c16fa2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854819 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#707045}
-
Maksim Moskvitin authored
Keystore key rotation is triggered by Sync server. In this case client receives new keystore keys together with old NigoriSpecifics. After keystore key rotation NigoriSpecifics should contain last keystore key and its keybag should be encrypted with this key. Because syncing with rotated keystore NigoriSpecifics is already supported, the only thing we need to do is to implement NigoriState transition: last keystore key should be added into |cryptographer| and used as the default encryption key. Additionally, we trigger keystore key rotation inside NigoriSyncBridgeImpl ctor, because it might be not completed in between of SetKeystoreKeys() call and browser restart. Bug: 922900 Change-Id: Ie67a922edf3f573fb6c7c768df789138804d5012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863936Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#707044}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I2f5c76a70e0f6092c3aa480a5c60b3be40897936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866698Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707043}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c836ccb431d..a2b2fc8164dc git log 7c836ccb431d..a2b2fc8164dc --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ziegs@google.com excelsior: add signing for factory shim Created with: gclient setdep -r src/third_party/chromite@a2b2fc8164dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9c6c11ce3fedfcaa7f3216e7481a4330a4d33445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866877Reviewed-by:
-
Lan Wei authored
FingerprintSetupTest.FingerprintSetupCancel is very flaky on ChromeOS since 2019/10/16. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTQsSBUZsYWtlIkJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEZpbmdlcnByaW50U2V0dXBUZXN0LkZpbmdlcnByaW50U2V0dXBDYW5jZWwM&show_all_occurrences=1 TBR=tbarzic@chromium.org Bug: 1015014 Change-Id: Id4210e6317067a5716212a12937ee079f562b4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867198Reviewed-by:
-
Justin Cohen authored
Also adds helpers for isCompactHeight and isSplitToolbarMode in ChromeEarlGreyImpl. Bug: 987646 Change-Id: Id8f48a0e126faab215ffb6ed8d2e306b13f33bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864355 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707040}
-
Jonathan Metzman authored
Dictionary mistakenly used "\n" instead of encoding as hex ("\x0a") causing exceptions on ClusterFuzz. Bug: 1015442 Change-Id: Id27fb1de4c08ad9fbfc40ddcf1caac915a828259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866878Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707039}
-
Bryan McQuade authored
Change-Id: I7d0ebe844fe5396665e17e0202698a5ff25afbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857299 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#707038}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/780eaa6043f2..13753e667da5 $ git log 780eaa604..13753e667 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 bnc Use IETF QPACK error codes on the wire. 2019-10-16 rch gfe-relnote: Send QUIC connection close packets at all available encryption levels. 2019-10-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_rto_retransmission3. 2019-10-16 wub gfe-relnote: (n/a) Always handle MSG_TOO_BIG when sending buffered packets. Protected by existing --gfe2_reloadable_flag_quic_treat_queued_packets_as_sent. 2019-10-16 fayang gfe-relnote: Remove QUIC v39. 2019-10-16 rch Remove broken code from ToyQuicClient which was landed in cr/275026885. Update flag definition per the "Send QUIC connection..." change. Remove QUIC_VERSION_39 references. Many seem to really be "the lowest available/implemented/... QUIC version", and thus were changed to refer to V43. Changed versions used in quic_http_utils_test.cc, FilterSupportedAltSvcVersions to reflect removal of version 39. Update components/domain_reliability/quic_error_mapping.cc to reflect addition of QPACK error codes. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I04d14224215bf4efe5bd3ffa95c6d7e45ed1f8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865560 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707037}
-
Xiaoqian Dai authored
Clamshell mode behavior will remain the same, i.e., tapping on the overview background will return to its previous state, it can either be in-app or home screen. Bug: 997885 Change-Id: I2dae82657d4d92876c834c78dd62d53830fbe6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865264 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707036}
-
Brandon Wylie authored
We introduced additional padding for the search engine icon experiment focused state. This additional padding happens post-layout, so we don't have to re-layout the view tree during the animation. As a result, the UrlBar's width=match_parent makes the UrlBar too wide and the end of the UrlBar's text is cut off by the next view. Bug: 1012436 Change-Id: I5f46a2dd530783b002c529d3c4cdccbdd81e1b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856868 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#707035}
-
Ahmed Mehfooz authored
Bug: 1015199 Change-Id: I73b009d4d4a20000a78ed15a11618adeec037800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864525Reviewed-by:
-
Mike Wasserman authored
Moves 'Remove Access' next to 'Done', like in the bookmark bubble. - Use the dialog's built-in cancel button placement/handling - Avoid revoking access on the 'Esc' key by overriding Close() Bug: 999756 Test: Button placement matches UX intent, no behavior change. Change-Id: I91e3befbbef1a4d0bc80bb039b835bcfb7b0d504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862856 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#707033}
-
Yue Li authored
Include oobe.css for the newly added CSS variables. Bug: 1012793 Test: Manual Test Change-Id: If67e43f454b9ccf193029c8b144ef45062d057ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864364Reviewed-by:
-
John Emau authored
Without this change screen readers in browse mode [1] will incorrectly read errors and warnings that have a tooltip of "42 errors, 99 warnings" as "4299". After this change screen readers will announce the same content as the shown in the tooltip: "42 errors, 99 warnings". Because errors and warnings are indicated with icons this change will fix the screen reader bug and helps meet success criteria for WCAG 1.1.1 Non-text Content [2]. Root cause: The icons do not have accessible names and screen readers will combine the content of the spans: <span><error-icon/>42<span><span><warning-icon/>99</span> is announced as 4299 The fix: * Set the accessible name of counter element (title alone is insufficient [3]). * Make the children of the counter hidden otherwise NVDA (and JAWs) screen readers will ignore the aria-label [4]. [1]: https://www.nvaccess.org/files/nvda/documentation/userGuide.html#BrowseMode [2]: https://www.w3.org/WAI/WCAG21/quickref/#non-text-content [3]: https://crrev.com/18d41172/third_party/blink/renderer/devtools/front_end/ui/Tooltip.js#190 [4]: https://github.com/nvaccess/nvda/issues/1354#issuecomment-155287285 Screenshot (NVDA speech viewer): https://i.imgur.com/KznR7O7.png screen reader should announce the number of errors and warnings. Test: Navigate to the counter in NVDA browse mode on Win10 and the Bug: 963183 Change-Id: I46985e223a6f8bac5cd1dbdf597a4b0c9ab71567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861214Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707031}
-
Rayan Kanso authored
Use the site engagement service to rank content index entries when handing off offline items. Change-Id: Ie9929f73e0fb52edff297fd63f21e0069eb3c8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866710 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707030}
-
Ankit Jain authored
When user tries to export password or view saved password by visiting chrome://settings/passwords url and clicking on "Export passwords..." or eye icon on password list respectively, OS Reauthentication is triggered, and on successful authentication plain text password is revealed. Currently OS authentication call is on UI Thread. And if OS authentication takes time, it freezes/hangs browser. This change has made authentication api async, and moved windows authentication call to thread pool from UI thread. Since the UI thread will be freed, browser will not freeze or hang. Bug: 1007950 Change-Id: I2f35707fe458687a4ec22de1381d21ec9603733f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828730 Commit-Queue: Ankit Jain <ankjain@microsoft.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707029}
-
Rakib M. Hasan authored
When a unittest uses multiple processes, it's subprocesses uses the host's file system class, not the mock file system class. This is problematic for the blinkpy unittest step running on many builders because artifacts from prevoius runs are not deleted on the bot. Bug: chromium:1015118 Change-Id: I7fdf01de5ea0f782ba3ca7d4aaffda71b8841da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866975 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#707028}
-
kyle Ju authored
1. Ignore skipped tests that are not in the test_path and not in the same shard; 2. Set the expected test status to SKIP if the actual status is SKIP; 3. Fix the issue with skipped tests - pytest deselect flag only works with relative path and pytest separator :: between a test and its subtest; 4. Add support for isolated-script-test-filter Bug: 992569 Change-Id: Ifa73e4c6372a12f63e7543c85d006cc32c848c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777070 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707027}
-
Raymond Toy authored
* Replace modulo operations with test and subtraction * Remove clamping Using spotify.github.io/web-audio-bench, without this CL we have: TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 393 383 390 393 400 403 DelayAutomation-a-rate 1053 1018 1050 1053 1065 1102 With this CL: Baseline 393 387 393 393 397 400 DelayAutomation-a-rate 485 437 443 485 487 513 The optimized version takes about half the time. Bug: 1012198 Change-Id: I643cbf137038714aad5fa2fb66299a8412e667bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864415Reviewed-by:
Andrew MacPherson <andrew.macpherson@soundtrap.com> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707026}
-
