- 18 Oct, 2019 40 commits
-
-
Lan Wei authored
This reverts commit 3a9215b3. Reason for revert: virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-module-test.js are flaky on WebKit Linux MSAN. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN Original change's description: > Adapt isolated-code-cache web tests to partitioned HTTP Cache > > The not-site-per-process isolated-code-cache web tests currently assume > that cross-origin resources are cached when code cache site isolation is > not active. This causes them to fail when the HTTP Cache is partitioned > by Network Isolation Key. We thus disable the partitioned HTTP Cache for > those tests and add a new test for when site isolation is not active, > but the HTTP Cache is still partitioned. > > Bug: 1009628 > Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421 > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Alex Turner <alexmt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707360} TBR=thakis@chromium.org,shivanisha@chromium.org,alexmt@chromium.org Change-Id: I8ebebb654e02d4d3c5d0c7e946ea70710b0b5df7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869477Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707457}
-
Sidney San Martín authored
Before this change, tooltips from a window might appear as you move your mouse around a different window which covers it, but only after tooltips in the back window have changed at least once. This is because, when tooltips change, the method below sends a fake NSMouseEntered event that allows tooltips to display no matter which window is on top. The method's goal is to clear and re-show tooltips immediately when they update, and with this change that only happens if the mouse is not over a different window. Bug: 883269 Change-Id: I37aace8cf86d5ac5a667d22f68be4da310e92fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869291Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707456}
-
Clark DuVall authored
This adds a way to execute javascript in WebLayer. The script will be executed in a weblayer isolate that will not be able to access any scripts from the page. Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707455}
-
Yicheng Li authored
Add UMA metrics related to positive match secret changes, to monitor how fingerprint authentication works under the positive match secret scheme, and whether migration to this scheme is successful. The associated Chrome OS CLs are CL:1829293, CL:1737809, CL:1737816 BUG=chromium:927095 Signed-off-by:
Yicheng Li <yichengli@chromium.org> Change-Id: I006d2cebaaf054d6ae4bfe53fe62318eda5f4698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864819Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#707454}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f7e0ede1e71..1d6005296701 git log 3f7e0ede1e71..1d6005296701 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 saza@webrtc.org Delete ApmPublicSubmodules, fix ApmPrivateSubmodules, ApmSubmoduleStates Created with: gclient setdep -r src/third_party/webrtc@1d6005296701 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I6fbc31e8bd6393db0211da84554a40b17743a522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707453}
-
kylechar authored
There should only be one mojom::GpuService message pipe so GpuServiceImpl only needs one receiver instead of a set of them. Bug: none Change-Id: I76737d92dfcd4af84120709f4a25497ca34ab9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869396Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#707452}
-
Eero Häkkinen authored
This changes the display source extension to use network.mojom.IPAddress for passing IP addresses over Mojo and network.mojom.IPEndPoint for passing IP address and port number combinations over Mojo. That prevents invalid IP addresses and port numbers from be accepted. Bug: 242107,666823 Change-Id: Id3d4d98e389ff224d073983f61261bd643d29d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675432 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707451}
-
siyua authored
Currently uses default foreground color and transparent background color. Uploaded screenshot in bug comment 25 Bug: 991037 Change-Id: Ic9a9899badaad7e06a94854f216ba4bfc26a238a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861047 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#707450}
-
Hajime Hoshi authored
If the domain does not match the condition for back-forward cache, the back-forward cache is not used and then recording the outcome or other things does not make sense. This CL skips to record anything in such case. Bug: 1004676 Change-Id: I7845598f7956bd3f02a099c9eb3053fa49d02fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869229 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707449}
-
Gary Kacmarcik authored
This adds a check to determine if the Screen Capture permission has already been granted and also triggers a 'fake' Screen Capture so that the binary will be added to the list of apps that the user can grant Screen Recording permission to. Bug: 1012545 Change-Id: Ia3ad4709f0e594fd07660f62a683e6725f762805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867447 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#707448}
-
sczs authored
Creates a new BadgeType for the Save Credit Card Infobar and setups the initial configuration for the SaveCard badge: Adds support for kBadgeTypeSaveCard on BadgePopupMenuItem. Creates a BadgeButton in the factory for the Save Credit Card Infobar. Creates a Popup menu option for the Badge Popup Menu. Creates an A11y constant for SaveCard Infobar. Bug: 1014652 Change-Id: Ic8b88961dfc701783aa72e8c0f1009fb7c721d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867273 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#707447}
-
Jazz Xu authored
This CL left-justify artist and track title when artwork is not available. We also don't hide the artwork view until waiting for 2.5 seconds after getting an empty artwork since the artwork could be in the process of downloading and media session sent an empty artwork first. Bug: 1012418 Change-Id: Iac85af54b314cdda97b97567e6466b72464769ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846729 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707446}
-
Oksana Zhuravlova authored
Change-Id: Ib3d02f306a5965e122e61a572c3771a3905c4b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867432Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707445}
-
Ana Salazar authored
Track the new pages created in the AppList root grid. This metric will be recorded if a new page is added by drag and drop an app into a new page, by moving the app with the keyboard or as a result of an app added to the grid. Bug: 954432 Change-Id: I8cccaef7ac7f0bd7ec20f161d0f2e5509d778081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859580 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707444}
-
Tommy Li authored
This CL is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/1865616 It should prevent renderer-initiated or browser startup focus events from triggering on-focus suggestions in the omnibox. Bug: 1013287, 996516 Change-Id: I5bb000a6ce37a2adbd9dec9b1ef2f3a78da1ac42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867307Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707443}
-
Daniel McArdle authored
The fuzzer for HandleMessage discovered a heap buffer overflow. This is not super serious because an evil kernel is outside of our threat model. It turns out that the NLMSG macros in netlink.h and RTA macros in rtnetlink.h assume a signed integer type. Because we used size_t, the *_NEXT macros were actually underflowing the size, causing the *_OK macros to erroneously return true. In excruciating detail: consider a loop using the RTA macros and |size_t length| to represent the number of bytes remaining in the buffer. RTA_OK(rta, length) checks whether rta->rta_len <= length. Then, RTA_NEXT(rta,length) subtracts RTA_ALIGN(rta->rta_len) from |length|. Supposing rta->rta_len == 9 and |length| == 10, RTA_NEXT will actually subtract *12* from |length|. Yikes! Bug: 1015070 Change-Id: I687bba0b814d7e76082e9f53b12a1f90fb59180d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865671 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707442}
-
Jaeyong Bae authored
This patch means disable save button when 'card expired' error message is seen in chrome://settings/payments. Bug: 917812 Change-Id: Icc5d2b85160faddd050b405146acfa62d718d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832181 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707441}
-
Maksym Onufriienko authored
ChromeEarlGreyAppInterface returns NSError* to indicate test failure, not BOOL. Bug: 1015549 Change-Id: I4d8478910c6914e94f07ea1ba0fa28ac7378ea2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866956 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707440}
-
Dominic Mazzoni authored
While the Blink tests for the speech synthesis API that we wrote use internals to mock the speech engine, the speech synthesis Web Platform Tests do not, so they were exercising real platform speech APIs on some platforms. Fix that by providing a testing implementation of TtsPlatform specifically for web tests. This change doesn't try to get any new WPTs to pass, it just hopefully introduces some more stability and consistency. Bug: 1003410 Change-Id: I45972c4717978a52427fce06bfe2e236b67cfab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821741 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707439}
-
Lan Wei authored
http/tests/devtools/a11y-axe-core/performance/landing-page-a11y-test.js is failing on WebKit Linux MSAN. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN TBR=juxiao@microsoft.com, yangguo@chromium.org Bug: 1015859 Change-Id: I61ac9a670f1d403d334f2e27e0e995ad1644ec2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869033Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707438}
-
Bettina authored
Fix password change events for sign-in non-syncing passwords. Previously, we were double counting password-change events where if the user first signs into an account, a password change event would trigger. This checks to see if a password hash already exists for the username first before triggering. Bug: 1015515 Change-Id: Ic8027f7c68fe1803a295a730812569dc0d4faf2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866911Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#707437}
-
Zhaoyang Li authored
This reverts commit 10cddf87. Reason for revert: This original change is causing flaky failures locally on some device and might be causing flaky infra failures on CI bots. Will investigate locally and redo this change. See crbug/1013462 . Original change's description: > Change location of ensureAppLaunchedWithFeatures call for test case. > > Moved ensureAppLaunchedWithFeatures from -setUp to overriding > launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run > results show significant improvement without the relaunches. > > BUG: 1009017, 1010463 > > Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706521} TBR=lindsayw@chromium.org,gambard@chromium.org,zhaoyangli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I41e945fec5166c3d5cd487244775a40c4ec0ad4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868983Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#707436}
-
yilkal authored
Bug: 1014122 Change-Id: I32dcb21d17d962c26ae02bd167330abc9fe39a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863839 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2e43102c54d1..b78fa92a5114 git log 2e43102c54d1..b78fa92a5114 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 lalitm@google.com trace_processor: fix starting on the correct bit for set bits iter 2019-10-18 lalitm@google.com Merge "trace_processor: use packet ts if power rail ts is empty" Created with: gclient setdep -r src/third_party/perfetto@b78fa92a5114 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I8ae77dab22fe869b36e5cf06554f875f84731315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707434}
-
Scott Haseley authored
Bug: 988753,988788,988800,988807 Change-Id: Ia07028ee94a734236463563070523e6f493be8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845996Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#707433}
-
Alec Douglas authored
This commit adds a call to ShouldSkipTest() to the early return in the new GLCopyTextureCHROMIUMES3Test.BigTexture tests. Bug: 991668 Change-Id: I898a3559cf6285055336d8ef6f77d8f3be25e5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868835Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707432}
-
Dave Tapuska authored
Rename the interface and remove the FrameImpl class and have LocalFrame implement the mojo interface directly. BUG=1008432 Change-Id: Id5e817ab6d2e266690cdd8687d9cad71662655ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863718Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#707431}
-
Daniel Rubery authored
In a few cases, the preferences for realtime reporting are enabled, but client_ is still null. For example, if the SafeBrowsingRealtimeReporting feature is disabled. This can lead to crashes when trying to report events. Bug: 1015849 Change-Id: I4ee0a042da4379ab4878c34ec8d726a3661c0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869292Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#707430}
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for mac-10_13_laptop_high_end-perf: - Added synthetic product name 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_1_475936.0'; - Updated OS from 'Mac-10.13' to 'Mac-10.13.3' - Updated GPU from '1002:6821' to '1002:6821-4.0.20-3.2.8' (This shows a equivalent list as using '8086:0d26-4.0.20-3.2.8'. Those bots seem having two graphic cards. E.g., https://chrome-swarming.appspot.com/bot?id=build139-a7) Please check the link below for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A1002%3A6821&f=os%3AMac-10.13&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=gpu Bug: chromium:996830 Change-Id: Ia88a6af8f543f90cf28528ad293f0d0479f6e8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865141 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#707429}
-
David Dorwin authored
Change-Id: I0611b41a7f428204c9bf92b7a0438271edc7846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864408 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707428}
-
Fabrice de Gans-Riberi authored
* Skip the scheme redirect check for rewritten data URLs. * Do not append query and ref to rewritten data URLs. Bug: 1014237 Change-Id: Ied4b9495031c2f86c196b036aeeb6d599cd98560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846811Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#707427}
-
Sammie Quon authored
Overview items now match the aspect ratio of the window bounds if they get snapped. This will happen if splitview is active on either side, or if the window is getting dragged close enough to an edge. A videos of before and after this patch is in the bug. Follow up: Make this work for tablet mode with 6 or more windows. In that case the positioning logic follows a different path. Match the exact dimensions in the spec, this patch only does rough clipping. Test: added tests, manual Bug: 1011973 Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#707426}
-
Chris Lu authored
With Translate moving to Messages, it will have a similarly named TranslateInfobarCoordinator that will replace TranslateInfobarController. Move the current TranslateInfobarCoordinator to LegacyTranslateInforbarCoordinator since it won't be used in the new Messages logic. Bug: 1014959 Change-Id: I6d5fb835cd0c826db1ffa7bac9fd48338c6ec894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864399Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#707425}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b582d244f316..68efdcdaefe2 git log b582d244f316..68efdcdaefe2 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 jrosenth@chromium.org lib/cros_build_lib: don't try and encode bytes 2019-10-18 jrosenth@chromium.org lib/gob_util: return bytes from FetchUrl Created with: gclient setdep -r src/third_party/chromite@68efdcdaefe2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie2db7dd31dfe6a9994aa12b05c6e4cb4f39337d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707424}
-
Miriam Zimmerman authored
Right now, the feedback doesn't have any label at all and is read as "image" by ChromeVox. BUG=chromium:1005521 TEST=Loaded onto an eve with chromevox, observed correct description. Change-Id: Idfd8f2946dbfaf3929b095bbc914a4954afcf6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864093 Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#707423}
-
Stephen Martinis authored
This command will be used by developers to debug their CL quickly. It allows them to specify only certain test suites to run. Bug: 1015682 Change-Id: I22e30c1cc29e31d4e484808d5a8302813cc4a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856822Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#707422}
-
Andrew Xu authored
This CL implements the feature that the scrollable shelf is able to show a new page when an app icon is dragged to the shelf's edge and stays for enough time. It will not change any behavior if the scrollable shelf is disabled. Bug: 1009500 Change-Id: I0bc7cb187031f77a4d332f06744d313a335b2508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859588 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707421}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55d19e590d9a..3f7e0ede1e71 git log 55d19e590d9a..3f7e0ede1e71 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 asapersson@webrtc.org Add option to make first scale factor depend on input resolution. 2019-10-18 nisse@webrtc.org Reland "Delete methods EncodedImage::Allocate and EncodedImageBufferInterface::Realloc" Created with: gclient setdep -r src/third_party/webrtc@3f7e0ede1e71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I91f4dad7c97d2521df63fbf74dc486bbe8753842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707420}
-
Will Harris authored
BUG=1015204 Change-Id: Id63ee4da3c8e51db06da0a306e90adeef7f5618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866972Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707419}
-
Joshua Peraza authored
2fb4e9e6a432 mac: Update the process_types version of dyld_all_image_infos for 10.15 c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST() d8f85829b07b linux: fix split stack test 7289acb78a6d linux: don't assume vdso exists 47a342133d60 linux: use boringssl in chromium 661a07a41b88 linux: add deps for boringssl in chromium Change-Id: Iae1ed525a228c4de3b879ac06097fd026ea01004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869397Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#707418}
-