- 27 Nov, 2019 40 commits
-
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ia31c0b27ee034e697551d170a961b131cf8415e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939989Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719596}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGLinearGradientElement> as new downcast helper 2. Use IsA<SVGLinearGradientElement>(element) in place of IsSVGLinearGradientElement(element) Bug: 891908 Change-Id: I3f775ab96a3fab152b797aa29d9f7db3ae962b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936609Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719595}
-
Hans Wennborg authored
CLANG_SVN_REVISION is prefixed with an 'n' these days, e.g. 'n331734'. Bug: 1015315 Change-Id: I6ed404f230be71f745f7febab10a222f8d6c6cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939973Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719594}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I5da0e1c07c06f17ff9c40ec8ba9fac55b540f875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939083Reviewed-by:
-
Guillaume Jenkins authored
The Spelling Service ("Enhanced Spell Check") was migrated from a JSON-RPC endpoint to a REST endpoint. This migration was rolled out as a finch experiment to ensure nothing had regressed. Now that everything has been working well for a few months, it's time to clean up everything related to the Finch experiment and the old JSON-RPC endpoint. Metrics about the new endpoint: https://uma.googleplex.com/histograms?sid=53ae9a4522ca75cb8f945bf4422baafe Migration bug: https://bugs.chromium.org/p/chromium/issues/detail?id=943108 Migration mini design doc: https://docs.google.com/document/d/1tmqz3QTF-lhbbkBxqOSYMdNZ-OOhlMIhb8hczhbZVhQ Bug: 943108 Change-Id: If46ffbbbdf956f7ed7000ade6c3bd9c5252361f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932095Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#719592}
-
Alexander Timin authored
Restarting navigations synchronously is problematic because we might be in a middle of starting a different navigation and restart is going to be harmful: post a task instead to be able to reason what's on top of the stack. R=alexmos@chromium.org,arthursonzogni@chromium.org BUG=1017594 Change-Id: I2198a4497c960a0903837604f9f20099475d92e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929246 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719591}
-
Eric Seckler authored
Our webview startup benchmark gets confused if we export to atrace, because it is tracing both via atrace and chrome. If we export correctly to atrace, we end up with duplicate events in chrome. Before my recent begin/end split patch, we only exported END events to atrace, which were pretty meaningless on their own. This patch essentially restores the behavior prior to my patch by not exporting any events to atrace when perfetto tracing is enabled. Long term, we have to figure out how to prevent the duplicate events in our benchmarks. Bug: 1028882 Change-Id: If2595ad4d7f46c37a7bbc464d7fd71ad129d0923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939748 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719590}
-
David Jean authored
Bug: 1023605 Change-Id: Idaf448e616a9ba1a0820c7f335595d8ae2d1fb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917166Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#719589}
-
Monica Basta authored
There is a bug in the new user menu that is the profiles in the other people list is not sorted alphatecially by name. This CL fixes the bug by retrieving the profile attributes entry sorted by name. Bug: 1027809 Change-Id: I4355b35baacc2f374ab3f82e9ee5807db14b468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940274Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719588}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/781bb85e9698..27d3c9399925 git log 781bb85e9698..27d3c9399925 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Revert "Vulkan: Accelerate Texture PBO updates" Created with: gclient setdep -r src/third_party/angle@27d3c9399925 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027098 Tbr: cwallez@google.com Change-Id: I353a3d7142fb0513c504adc6dd70c14a386fe9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940076Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719587}
-
Tommy Steimel authored
This CL updates the auto-dismiss logic to only count click-to-tabs as interactions instead of counting when the tab is focused by any means. The only reason we had it that way was to accommodate the "pre-refactor" world where it wasn't feasible to always detect the difference. Bug: 1026079 Change-Id: I8806f64ade7019716413ef54c07693574f192dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937141Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719586}
-
Robbie Gibson authored
The root cause is that, because CALayer uses CGColors, which don't support the whole dynamic color infrastructure, we have to manually set these colors to the correct version in -traitCollectionDidChange. However, CALayer automatically animates any change to these properties. This means that when the color mode changes, the rest of the colors update immediately, but the layer's colors animate to the correct color over the next ~0.5 seconds. To fix this, we can use CATransaction and setDisableActions to disable the automatic animation. Fixed: 1028091 Change-Id: Id217c5387bffc77a5a971aac0e43198a1ffa8200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940328Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#719585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a8799ff0874..03e4c95c31e6 git log 2a8799ff0874..03e4c95c31e6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 robertphillips@google.com Move creation of GrProgramDesc to GrCaps-derived classes Created with: gclient setdep -r src/third_party/skia@03e4c95c31e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I5a86702fd33d4a7cfe9e300e32415c8c1cb19912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940075Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fec12b8a43a1..66a99b6dabab git log fec12b8a43a1..66a99b6dabab --date=short --first-parent --format='%ad %ae %s' 2019-11-27 dberris@chromium.org Fix commit queue config Created with: gclient setdep -r src/third_party/catapult@66a99b6dabab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:985223 Tbr: rmhasan@google.com Change-Id: Ib20a7bebe43c571f6bfaf152c4f344b6ca650ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940077Reviewed-by:
-
Tim van der Lippe authored
Follow-up on crrev.com/c/chromium/src/+/1939791 Bug: 1006759 Change-Id: Ia4932f78b0190732c79d1bdf3112a798dfbe9f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940272 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#719582}
-
Dominique Fauteux-Chapleau authored
Change-Id: Ic4ef01d8a4e07a41253e36b2ea5e9086db81765f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937648 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#719581}
-
Nico Weber authored
Except on Windows for now, https://github.com/KhronosGroup/Vulkan-Loader/commit/6eb61431a4217b3eef75e59b1c70e25fc37b8064#r36147738 Bug: 1002945 Change-Id: Ia9d1c2fd17bf488c69217266cb0c85f59788f03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937654 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d8cdc0a. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I9747e3e2b756f6301e9d315c235f4f4e313a1e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940127Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719579}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d21964d6..6b5843d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8aea7999d38e3c2699736a0f720d220a47871a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719578}
-
sczs authored
- Also creates the ConfirmInfoBarController directly on crash_restore_helper since using CreateConfirmInfoBar would also create a Message infobar if the ConfirmInfobar as Messages flag is on. Bug: 1028951 Change-Id: I81fec50e851ed830c49e8306994c0f836d2c8efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939492Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#719577}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35e1a0ce9060..a64e0786130f Created with: gclient setdep -r src-internal@a64e0786130f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ia5b80a9b9afbe99104f97ace7c88304f64629ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940068Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719576}
-
Jeremy Apthorp authored
This caused build failures for Electron, which builds with MSSTL Change-Id: I5b21d27eb02523e975957befd50bf958a6fa6a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938028 Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#719575}
-
Juan Antonio Navarro Perez authored
TBR=twellington@chromium.org Bug: 979189 Change-Id: I4ffc83b13f01d032bbfe5d4be75362bff5d76559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940109Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719574}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e14cb994086d..b1ccae253e0b git log e14cb994086d..b1ccae253e0b --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sprang@webrtc.org Reland "Fixes dynamic mode pacing issues." 2019-11-27 danilchap@webrtc.org Add VideoCodecType::kVideoCodecAV1 value Created with: gclient setdep -r src/third_party/webrtc@b1ccae253e0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I982644bb2293420496481c445b9b38188bcba223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940070Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca29ecd5c79b..5b6f642d9c3b git log ca29ecd5c79b..5b6f642d9c3b --date=short --first-parent --format='%ad %ae %s' 2019-11-27 treehugger-gerrit@google.com Merge "Switch TRACE_EVENT to something that is only one line of code." Created with: gclient setdep -r src/third_party/perfetto@5b6f642d9c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id75eca01d57f5272752d1422115105019645f942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940071Reviewed-by:
-
Tim van der Lippe authored
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934218 we are adding an extra module to these panels. Disable the test for now to land the front_end CL. Once DevTools is rolled into Chromium, the test expectation will be updated and the test will be re-enabled. Bug: 1006759 Change-Id: I7dd5393a884d9f4559d8b7f53d5dc7472a4cea76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940327 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719571}
-
Anastasiia Nikolaienko authored
Block propagation of secondary accounts to ARC for Child users. Bug: 1017160 Change-Id: I7530ecb07a58b686d0dedb1367ffa1ab543e7a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904074 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719570}
-
Michael van Ouwerkerk authored
Also, use our own constant so that the limit does not get raised again without us knowing in the future. The in-memory limit was recently raised to 5MB: https://chromium-review.googlesource.com/c/chromium/src/+/1866194 Bug: 1018138 Change-Id: I2ce729203fe418d6eca8a0145d2df36be6c4bc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939707 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719569}
-
Koji Ishii authored
Hit-testing requires traversing siblings in the reverse order, which is not easy for either |NGPaintFragment| nor |NGFragmentItem|. Currently |NGBoxFragmentPainter| copies all siblings to a list and iterate the list in the reverse order. This is not very efficient, but hit-testing is the only user today, and seems to be fast enough. In order to abstract the operation, this patch adds |NGInlineBackwardCursor|. This is a separate class, to avoid increasing stack size for every use of |NGInlineCursor|. We may revisit this if more users appear. Bug: 982194 Change-Id: Ie07564dccbcfc3ff7222392fc6f483c95e0579eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939152Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719568}
-
Tim van der Lippe authored
These tests contain race-conditions in the way that CodeMirror is booted up. When making cm_modes/ an ES module [1] these tests started to fail. Closer inspection showed that there are numerous Promises not being awaited, which causes the test to eagerly resume execution. Note however that in the real application, the race-condition is WAI and does not cause any issues. It is only in the synthetic testing environment that this issue occurs. After the ES modules migration, we will refactor the classes to properly handle Promises and enable the test again. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928924 Bug: 1006759 Change-Id: Ic213897def208c148034632627924f31c012cca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939791 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Michael Ershov authored
The flakiness of the test was fixed in the CL that fixed DeviceCloudPolicyManagerChromeOSEnrollmentTest.Success Bug: 1014318 Test: DeviceCloudPolicyManagerChromeOSEnrollmentTest.UnregisterSucceeds Change-Id: I5b89b3dc1eb63a223093832c2ff8ec696be4d668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939413Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#719566}
-
Kamila authored
These strings are updated or added according to the latest iterations with UX, for the Notifications settings page. Bug: 986737 Change-Id: I2898a074a3c6973d9158133255cbc232f9988308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937168 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719565}
-
Rob Buis authored
In r716655 new display attribute values math and inline-math were introduced but they should also have been added to PlatformEnumToCSSValueID to prevent running into a NOTREACHED. Bug: 6606 Change-Id: Ic0a7c43389731aaf72ab075719cb83d3e75a45d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939787Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#719564}
-
Stephen Nusko authored
Fix the INTERNAL_UID macro so it actually appends the value of __LINE__ rather then the string "__LINE__" Add a test to catch it. And also switch to the same implementation as the client library with the in parameter. Change-Id: I94b775e6692fe88a14efc7c6030c280057012935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939971 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#719563}
-
Koji Ishii authored
It looks like we tried to copy the logic in |LayoutObject:: NodeForHitTest| to |NGPaintFragment|. As part of deprecating |NGPaintFragment|, this patch moves it to |NGPhysicalFragment|, using the existing logic in |LayoutObject|. In future, this logic might be moved to |Node| or something that represents the box tree. Until then, using the logic in |LayoutObject| looks most reasonable. Bug: 982194 Change-Id: Ib6b967dc616714eb2cb1a16585493d106c44c504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937953Reviewed-by:
-
Oriol Brufau authored
The interaction of a ::marker pseudo-element with a 'content' property and the ::first-line of the list-item produced a DCHECK failure in debug builds (it was fine with debug disabled). This patch fixes it. Bug: 457718 TEST=external/wpt/css/css-pseudo/first-line-and-marker.html Change-Id: I443934f3a5cbfd95913287ac2bfb0966fa707e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937068Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#719561}
-
Mikhail Khokhlov authored
Build directories on bots follow more or less unified naming scheme, so it's possible to guess the path to the trace processor. Bug: 1028612 Change-Id: I6065fc2bac2ca23dcdf9363b4defb43b7cb8d22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936314 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1028949 Change-Id: I4a3d9296649c6bd52a8fc7d5d38b793945a6b35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932551 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719559}
-
Reilly Grant authored
This change updates usage of base::Callback to explicitly choose between base::OnceCallback and base::RepeatingCallback based on whether the callback will be executed repeatedly or not. Bug: 1007663 Change-Id: I058632afae3e14f14f1c51b9b4fe251b9011eb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937353 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719558}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c363982eeab3..e14cb994086d git log c363982eeab3..e14cb994086d --date=short --first-parent --format='%ad %ae %s' 2019-11-27 peah@webrtc.org Correct/update the activation of the multi-channel processing in APM Created with: gclient setdep -r src/third_party/webrtc@e14cb994086d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If7f5a6540348a3dfbbc6062a0ba6611b04e95d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939887Reviewed-by:
-
