- 18 May, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28d716a6. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7e8427c2272b612ff3a8486d131ecac3ec0e1456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207019Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769848}
-
Brandon Maslen authored
This change updates the logic used in the Blink document for document.hasStorageAccess and document.requestStorageAccess. Gates have been added to ensure the proper restrictions such as having a non-opaque origin, sandbox token (if applicable), as well as ensuring that hasStorageAccess reflects the actual state of storage access on the page. Additionally defense in depth logic checks have been added in StorageAccessGrantPermissionContext to shortcut if we get a request for a scenario no grant would be needed. Some additional cleanup is included with this change to remove the temporary usage of CONTENT_SETTING_SESSION in StorageAccessGrantPermissionContext and to ensure all content settings updates will propagate to the network service. A follow up change will ensure this does not result in duplicate updates when we perform our initial update. Browser tests have been added to validate end to end functionality. Bug: 989663 Change-Id: I09fdc115a30a71e341961b385a2e2e05fd161536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194905Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769847}
-
Abigail Klein authored
Reset the accessibility event recorder pointer and the web contents observer pointer rather than releasing them. This ensures that the objects are destroyed, rather than just the reference to them released. Also, stop the accessibility event recorder when destroying the AccessibilityUIMessageHandler. AX-Relnotes: Fix bug in chrome:accessibility page. Bug: 785493, 1081469, 1043024, 1042569 Change-Id: I61ecc6cb12d3f9695130ca9c15900bf3070de1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199020Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#769846}
-
Daniel McArdle authored
kDnsHttpssvcExperimentDomains and kDnsHttpssvcControlDomains: Comma-separated lists to define the domains for which we are allowed to query HTTPSSVC or INTEGRITY. The exact query sent (or none at all) will be determined by the existing feature params: kDnsHttpssvcUseIntegrity and kDnsHttpssvcUseHttpssvc. kDnsHttpssvcEnableQueryOverInsecure: This feature param will enable querying HTTPSSVC or INTEGRITY over Do53, but we don't plan to turn it on soon. The default is DoH-only. Bug: 1052476 Change-Id: I78c8df8b5ac2e4cb16aea6358666fccef013baee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202317 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#769845}
-
Vincent Boisselle authored
Bug: 1083409 Change-Id: Id06677cb30ac4264a81162a075f023b5c5faf36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204544Reviewed-by:
-
Xianzhu Wang authored
We don't need to do anything in FinishCycle() for transient PaintController, or if we haven't committed anything since the last FinishCycle(). Remove code that resets paint property changed flags from PaintArtifact::FinishCycle() for CAP, so that LocalFrameView can do that in the same way for both CAP and pre-CAP. This doesn't actually reduce any extra calls for crbug.com/1049159, but prepares for that. This CL actually avoids the repeated VLOGs in FinishCycle when it does nothing. Bug: 1049159 Change-Id: I6f4f11acebc3194cf85ac26b909c663dba422a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205977 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769843}
-
= authored
This update brings performance, low latency, and API improvements. Testing on a Pixelbook shows that the inking surface receives a hardware overlay in all orientations. The new binaries are smaller. The new WebAssembly binary is 6.8 MB compared to 5.5 MB for the old one, plus a 2 MB memory initialization file that's no longer required. That's a net reduction of 0.7 MB. The JavaScript is smaller as well; 217 KB to 183 KB for the WebAssembly loader and bindings script, and 350 KB to 89 KB for the Ink closure JS binary. Also, only the threaded build is required now that threads are stable in Chrome, which eliminates the entire 7.8 MB non-threaded WebAssembly and script files. Total savings: 8.8 MB. The Ink exported binary uses a new interface with narrowly defined externs and no longer exports 'goog' among other globals from the previous automatic externs. It may be possible in a future change to remove the iframe sandboxing from the Ink binary. Change-Id: Ieba6513b723f91d67c445246e7ba4e08f113469e Bug: 1084273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204141 Commit-Queue: William Furr <wfurr@google.com> Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#769842}
-
Robert Ogden authored
This header is copied from prefs, per the design doc. Bug: 1084186 Change-Id: Id99652bbf573b6aa6ede9230a7d6da5c23904acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207752Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#769841}
-
Morten Stenshorne authored
The main motivation behind this change is that we may want to name the first page (to give it a non-default orientation, for instance). This requires two things: 1. Manually name the first entry in the page name mapper. We normally insert named pages as part of inserting a forced break. However, there's no break before the first page (or it wouldn't be the first page anymore). Add a way to name the first page(s) manually, at the end of LayoutView layout. 2. Correct start/end page name handling and propagation, as described in the spec [1]. An author may want to set the first page name on the first SECTION, DIV, etc., rather than specifying it on the root element (which would be rather non-intuitive). Therefore, improve on our current, rather simplistic, approach to how the layout engine deals with named pages, and do it exactly as the spec describes. Page name propagation is currently only supported for block containers. It would also be appropriate to support this for table, flex, etc. [1] https://drafts.csswg.org/css-page-3/#start-page-value Bug: 1053768 Change-Id: I0f16cfb4325f6641b2c77355e03a6e439084d333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205937Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#769840}
-
Dylan Cutler authored
We use IdentifiabilityMetricBuilder to report hashes of the different values this method can return to UKM to determine how much entropy this function leaks. Bug: 973801 Change-Id: I4aa45f5662d62a83f1971a62c61891f3ebdfa81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186997 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#769839}
-
David Black authored
Bug: b:156675499 Change-Id: I098a339572c2e8c3c319500a23d42dc69f8b4df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204695Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#769838}
-
Jesse Schettler authored
Since the probe categories are ignored, remove them. Also, remove MakeTelemetryInfo() and its helper functions since they add no value to the test. Bug: None Change-Id: I6a77a761e822678caf840b66fbe471139d1157d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207773 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769837}
-
Andrew Walbran authored
META is already set to NullButton higher up in the function. BUG=1073130 Change-Id: Ic148ddd58d3b0768e171d95f7c3d2101ab24d6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203210 Commit-Queue: Andrew Walbran <qwandor@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#769836}
-
Mustafa Emre Acer authored
This CL records a new histogram called Navigation.PasswordEntry.SiteEngagementLevel the first time a user modifies a password field. Bug: 1073604 Change-Id: Ide7ca623d4962daf9c9213a1c424bba096995b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199711 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I150d50963f2a45a60c103e2b3e981fcf87e5f0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207497Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#769834}
-
Xianzhu Wang authored
After we stopped calling back into DisplayItemClient for display items moved from cached subsequence, we still get crash reports in FinishCycle(). The only reason seems that some DisplayItemClient is deleted before FinishCycle(). Add a flag in DisplayItemClient to track that. Bug: 1021766 Change-Id: I8cbdcdc14bd017fad2ac009485e000fd08ce4558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205522Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/329091623b91..75cebbe5d303 git log 329091623b91..75cebbe5d303 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 bsalomon@google.com Inset subset rect in texture op when nearest sampling 2020-05-18 mtklein@google.com clean up some SK_LEGACY... defines 2020-05-18 reed@google.com extend custom typeface gm 2020-05-18 herb@google.com Isolate fGlyphs in SubRun Created with: gclient setdep -r src/third_party/skia@75cebbe5d303 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I56aefc9c5b9914a0aecc4e917ebf12446719ab62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769832}
-
Thomas Lukaszewicz authored
ImpressionTagNavigatesExistingRemoteFrame_ImpressionReceived has been flaking on the Mac test bots. TBR: csharrison@chromium.org Bug: 1084201 Change-Id: Icb3035c96877e791f2cd8985f5cd50c708f68016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207911Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769831}
-
Henrique Ferreiro authored
Bug: 1039255 Change-Id: I6816e92fd6378ccbcc73e172d06c1730b21f3fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207210Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#769830}
-
Varun Khaneja authored
Instead, define |next_update_time_| as optional and initialize it to |nullopt| so that it's value can be checked directly. R=xinghuilu Fixed: 1084159 Change-Id: I828571de55f2ae81676a635c80bcd3759c032bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207796 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769829}
-
Stephen Chenney authored
A recent change for painting narrow elements whose widths falls below 0.5 under zoom has caused problems when such elements have a single pixel border. In such cases, the element size, including the border, is greater than 1 and snaps normally, but the inner border rect has non zero size below 0.5 and snaps up to size 1, instead of zero. As a result the inner border rects is the same as the outer border rect and the border is clipped out. Here we change the rounding for inner border rect to not enforce the non-zero-width constraint, as it is inappropriate in this case. Bug: 1070091 Change-Id: Ia368ca00375fe5d8a060b88c2d9e314f25679b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204362Reviewed-by:
-
Paul Moy authored
Add four new storage values to cros_healthd's NonRemovableBlockDevice category, and plumb these new values through DeviceStatusCollector. Bug: chromium:1067670 Change-Id: I3c6fb2d73c9343fe729688cba76f435b3d8025d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203016Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769827}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3e9068a6b488..3a35312b64a0 git log 3e9068a6b488..3a35312b64a0 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 danilchap@webrtc.org In pc/ replace mock macros with unified MOCK_METHOD macro 2020-05-18 tommi@webrtc.org Rename several more tests that use EXPECT_DEATH to *DeathTest. 2020-05-18 handellm@webrtc.org RtcpSender: remove lock recursions. 2020-05-18 tommi@webrtc.org Rename EchoPathDelayEstimator to EchoPathDelayEstimatorDeathTest. 2020-05-18 danilchap@webrtc.org Introduce ChainDiffCalculator 2020-05-18 tommi@webrtc.org Add support for injecting Clock to RepeatingTaskHandle. Created with: gclient setdep -r src/third_party/webrtc@3a35312b64a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I47f0cb8242cd05d0cea91a28b41376fd12ce3d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207990Reviewed-by:
-
Reilly Grant authored
This ScopedGeneric-based wrapper around an HDEVINFO is now in //base/win and so this change removes the duplicate copies in usb_service_win.cc and serial_device_enumerator_win.cc. hid_service_win.cc is fixed to no longer leak the HDEVINFO it creates by using this wrapper there as well. Bug: None Change-Id: I8bccffced3fadbc282062808b15d614dd6426503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205011 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#769825}
-
Mike Jackson (EDGE) authored
Per feedback, submitting a separate change to explicitly disable BMO flag for this test to unblock BMO in ToT. A follow up change should create a fork of this test for BMO using TestWebAppRegistryController. Bug: 1082854 Change-Id: Ibe4c5c64715f01620d3cc857dc6588746445130c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206219Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769824}
-
Nico Weber authored
Before a07b9feb, the early exit only happened if the script was running as a runhook. Now that we've had conditions in DEPS for a while now, this script only runs if checkout_linux is true, so completely removing the check is more in line with behavior before a07b9feb, and it still makes it possible to download the sysroot on e.g. a mac host. No intended behavior change for any bots or devs. Bug: none Change-Id: I98641e6a2190f1c7a61c08e2925f61bde581558e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207977 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#769823}
-
Mila Green authored
Bug: 1072061 Change-Id: I78ccb3889dc0eff5afd20cb2fee80ec4a7ff8c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199709 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769822}
-
Jarryd authored
Omit trivial subdomains (such as www and m) from the origin string on the notification. Bug: 1077115 Change-Id: I70350ef95da7c7633545db0978639296b1bfd10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207952Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3f70e6d20c82..62fea391fa99 git log 3f70e6d20c82..62fea391fa99 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 david@freetype.org Remove obsolete HAVE_STDINT_H probing macro. 2020-05-18 david@freetype.org Remove Jamfile files from the tree. Created with: gclient setdep -r src/third_party/freetype/src@62fea391fa99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5c152330319ddc096ec0f79d5e25884f3e7dfe00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207890Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#769820}
-
Greg Thompson authored
We have a population of users for whom Chrome crashes during startup because the loaded locale does not equal the preferred locale (https://crbug.com/1022934). In https://crrev.com/758991, we moved this crash to be a little earlier in the stack. As expected, this population started crashing earlier. This CL moves the crash *even earlier* in startup, and attempts to capture some information regarding the actual underlying issue. In particular: what locale file was Chrome trying to load? Was the file missing? Could the file not be opened? Based on this data we may discover some sort of mitigation strategy. BUG=1022934,1076423 R=asvitkine@chromium.org Change-Id: I75a539d3afd7d9f9a81ba76b954e1658875678b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203059Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#769819}
-
Erik Chen authored
This bug was present when the code was introduce. It was pointed out but I never got around to fixing it. See https://bit.ly/3fPjCmx. Bug: 971452 Change-Id: I76b482beaebf0d42b8e443d3315b2014cf0dffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203769 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769818}
-
Christopher Thompson authored
Change-Id: I39932f64bd85ef14e143c3718593bf276ba15d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208030Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#769817}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6de1c6b0..d136b6ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b2e9c9fc0727c9e9da72be50829c64a943263ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769816}
-
Juan Pablo de Lima authored
Bug: 1083145 Change-Id: I8beaeeb8a0b57a11d684ee7d074a8a3207a6d036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203293Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#769815}
-
Maggie Chen authored
Bug: 850881 Change-Id: Ied7fda20f7460d78029ab5401ad036c7c1069cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207931Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769814}
-
Kurt Horimoto authored
When UnsafeResources are added to the allow list as pending or allowed decisions, the WebState's visible security state is updated. This CL adds GetMaliciousContentStatus() to security_state_utils to calculate the malicious content state based on Safe Browsing unsafe resource state. This malicious content status is added to the VisibleSecurityState returned by GetVisibleSecurityStateForWebState(), which is used to compute the correct icon to show in the omnibox when malicious content is loaded. Since the security_state_utils functions take const WebStates, AreUnsafeNavigationsAllowed() and IsUnsafeNavigationDecisionPending() are updated to be const functions. The LocationBarModelImpl was also updated to remove an ifdef for iOS because billing safe browsing error pages are now supported. To prevent GN deps cycles introduced by the security_state/ => safe_browsing/ dependency, the allow list was moved to a separate source set. Finally, the SafeBrowsingBlockingPage was updated to remove pending unsafe resource decisions upon its destruction to match the functionality of other platforms. Bug: 1081926 Change-Id: I773cbee072a2d75d0f965a048edb933f2383a065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200085 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#769813}
-
Fabrice de Gans-Riberi authored
* Add handling of the Cast Streaming MessagePort in the browser process when WebEngine is started with the --enable-cast-streaming-receiver command line argument. * Add a test to check basic functionality. * Refactor WebMessage creation in frame_impl_browsertest.cc. Change-Id: I6ee67142c94b091e6f65d9872dceb2202620b13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187152 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769812}
-
Robert Sesek authored
This is a reland of 9bfda396 Original change's description: > Mac: Add a build step to verify the dynamic libraries linked to Chrome executables > > The executables should largely be devoid of links to system libraries, > since most of the code resides in the Framework. For Helper > executables, this is a security property (so that system framework > static initializers run sandboxed). > > Bug: 1082896 > Change-Id: Iba66129a4940263c661fe8d64260229aef1174ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203256 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769706} Bug: 1082896 Change-Id: I65a8e526ee441b58c53f3bf90e7e8bae780c1bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207502Reviewed-by:
-
Ian Kilpatrick authored
Before this patch we'd consider a text-control a relayout root. If this was also a NG flex-item it wouldn't have enough information to correctly layout, (it wouldn't know what size to stretch to for example). This patch disables the relayout boundary optimisation for text-controls and SVG roots - which are also flex-items. Bug: 1082447 Change-Id: I0e3b2186301fbf9488c0723c525a5e45e2ca80df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207611 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#769810}
-
Toni Barzic authored
The search box placeholder text and accessible names for clamshell and tablet mode were being pushed from Chrome's app list client. Though, the strings do not depend on any Chrome state - the app list client just loads the strings when Chrome starts, and pushes them to the app list controller. It's much simpler to set the strings ash (similar to close and assistant button tooltips). Additionally, this ensures that the strings are retrieved when first needed. Given that the app list is first used in active user session, this should ensure that the string used is not using the default locale from when the profile is first created during user adding flow. Moves logic that tracks tablet mode state from SearchBoxViewBase to SearchBoxView class (given that SearchBoxView is the only specialization that cares about tablet mode state). Bug:1083787 AX-Relnotes: n/a Change-Id: I867a699c36e42a2b9896f448c3e01645e526fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205979Reviewed-by:
-
