- 25 Sep, 2018 40 commits
-
-
danakj authored
So don't try to handle both anymore. DCHECK this is the case. R=dcheng@chromium.org, piman@chromium.org Bug: 720116, 419087 Change-Id: Ia10e77f6c81da37eacb1000ca679d1055b2ea372 Reviewed-on: https://chromium-review.googlesource.com/1239004Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594000}
-
Orin Jaworski authored
This feature param prepares the way for experimentation with new omnibox pedal development. Two pedal suggestion modes are already implemented, ready to be gated by this feature flag. A subsequent CL will hook this feature into chrome://flags . Change-Id: I04ec30cb01308f1e98be87c3bbe18592ee6eb30b Reviewed-on: https://chromium-review.googlesource.com/1235200 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#593999}
-
Tanya Gupta authored
R=ramyan@chromium.org Bug: 882822 Change-Id: I1a70d25d39a927d0a07a2a77420f0b696513c788 Reviewed-on: https://chromium-review.googlesource.com/1241795Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#593998}
-
David Black authored
Per UX guidance, mic should open for both launcher entry points when in tablet mode. Otherwise, we will use keyboard input modality. Later we will also factor in user preference. Bug: b:116509014 Change-Id: I5961f48aa2c8c808dde1a55307e8fd149fabe22c Reviewed-on: https://chromium-review.googlesource.com/1241760Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#593997}
-
Xi Cheng authored
While "Double Pointer" is commonly used in C, let's use (implicit) move semantics in the modern C++ era. Bug: 886957 Change-Id: I15693413a8a2474fb8200fc1778d4f9fe4656905 Reviewed-on: https://chromium-review.googlesource.com/1242298 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593996}
-
Clark DuVall authored
The error handling in WebRequestProxyingURLLoaderFactory was causing some objects not to be destroyed. This now uses a pattern similar to signin::ProxyingURLLoaderFactory. Bug: 888707 Change-Id: I033bd11c4281b238cebeb7924cc334a0264ff3b4 Reviewed-on: https://chromium-review.googlesource.com/1242297Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593995}
-
Robert Sesek authored
Bug: 832676 Change-Id: Ibeba925bbd23e5eb33aeaf748bc2f48161db6a96 Reviewed-on: https://chromium-review.googlesource.com/1243727Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593994}
-
Ryan Harrison authored
Currently if a search term in the PDF text has been broken over two lines by a soft hyphen, find will not correctly identify it as a match. This is rooted in the fact that the result of FPDF_GetText includes a marker for soft-hyphens, 0xFFFE, which causes the match to fail. This CL adds in filtering this character from the text being searched over, so that these matches can pass. This requires changes in the SearchUsingICU method to strip ignorable characters from the string before searching, and correctly converting the results back into the non-stripped index space. Ranges also have had filtering for 0xFFFE added in, so that the highlights created by searching are properly placed. BUG=chromium:788799 Change-Id: I06c8181358cdebe6454c36437065592820637808 Reviewed-on: https://chromium-review.googlesource.com/1234998 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#593993}
-
Eugene But authored
Bug: 887273 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99e171f64a20c7dba9f8984d05cb509b00d01ea5 Reviewed-on: https://chromium-review.googlesource.com/1243166Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593992}
-
sczs authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5775e79501baf6787e86c275ea7dbdbff5f6a5f6 Reviewed-on: https://chromium-review.googlesource.com/1239545 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#593991}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I4d72bf67afb654ee6752c7a3c02a03f9b3c7dc80 Reviewed-on: https://chromium-review.googlesource.com/1242459Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#593990}
-
John Chen authored
This CL is one step in making InitSession command W3C compliant. It expands Capabilities object to include all capabilities that are specified in the W3C spec. Changes include: * Re-ordered fields in Capabilities into W3C section and ChromeDriver specific section. Entries in W3C section are listed in the same order as they appear in W3C spec. * Added browserName, browserVersion, and platformName capabilities. They will be needed for proper firstMatches handling. * Added fields needed for timeouts capability. Parsing and using of these fields will be added in an upcoming CL. * Replaced legacy name unexpected_alert_behaviour with W3C-compliant name unhandled_prompt_behavior. * Modified Capabilities::Parse to accept all capability values, including those not yet supported by ChromeDriver. Added another method Capabilities::IsSupported to check for unsupported options. This is needed for upcoming W3C-compliant capability validation. Bug: chromedriver:1997 Change-Id: I5f53341cf47f77a1853f40028b1efe6f0b69c611 Reviewed-on: https://chromium-review.googlesource.com/1241213 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#593989}
-
Ahmed Fakhry authored
This CL is a preparation for turning the feature on by default. It fixes the following issues: - Editable elements focus change notifications are broadcasted to all listeners from all render view hosts. Handle it only for the active webcontents. - The value of DoBrowserControlsShrinkBlinkSize() should never change while scrolling is in progress. It should also return false when the feature is disabled regardless of the current shown ratio. - A gray patch that used to show at the bottom of the page. We should never set the shown ratio of the browser immediately without asking the renderer to do it first and call us when done. For that we need to defer switching the status to disabled until the renderer calls us with the final shown ratio value, only then we know both the browser and the renderer are synchronized and we can layout the browser view. - The active webcontents can be null in unit tests. - Expose top-controls related fields from behind OS_ANDROID. BUG=867063, 885223, 884453 TEST=Manual, passes existing tests, passes all tests with the feature enabled by default. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3bc7747a745619dd6f789d25a2a1609bbe8f15db Reviewed-on: https://chromium-review.googlesource.com/1217754 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593988}
-
Maria Tarasova authored
If browser_tests is built with tsan enabled, Thread Sanitizer reports data races in browsing_data_remover_test_util. There are two threads to concurrently access the shared data, the test’s main thread and a thread controlled by TaskScheduler singleton. Both access browsing_data_remover_done_ and/or flush_for_testing_complete_ fields to break run loop and exit test after some cleanup occurs. In TaskScheduler’s thread, the write access is done by the lambda function. The proposed solution is to use the lambda call only to report the asynchronous event to main thread, which becomes the only one to access the fields implementing run loop break logic. R=sky@chromium.org Bug: 885188 Change-Id: I706edb24ed362444cf46e558b1d54389179884da Reviewed-on: https://chromium-review.googlesource.com/1233613Reviewed-by:
-
Nico Weber authored
Bug: 101600 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I39cc247a432861bf8e7ac815dc2d1a2834a2cf08 Reviewed-on: https://chromium-review.googlesource.com/1240975Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593986}
-
Andreas Haas authored
Bug: v8:7295 v8:8015 Change-Id: I0b6a6c6348d446b318329db9a91ac1a148eee7ca Reviewed-on: https://chromium-review.googlesource.com/1238176Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593985}
-
Robert Sesek authored
Bug: 845389 Change-Id: I33de543963096de0a4473252cc4017aa52b4a981 Reviewed-on: https://chromium-review.googlesource.com/1243623Reviewed-by:
-
Adithya Srinivasan authored
- Adds blink.mojom.FileSystemManager to the frame and worker registries, allowing it to be accessed directly from ExecutionContext::GetInterfaceProvider()->GetInterface() - Changes ownership of blink::FileSystemDispatcher: now owned by ExecutionContext - Omits render_frame_id_ from ChooseEntry - Removes WebFileSystem and content::FileSystemDispatcher Bug: 787281, 873661 Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f Reviewed-on: https://chromium-review.googlesource.com/1217506 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593983}
-
Jordan Demeulenaere authored
This flag was removed in the backend, so it is safe to remove here as well. Bug: 806868 Change-Id: Ibe9415dcb0f8415591fe59110fb99e1bcbfd3d5a Reviewed-on: https://chromium-review.googlesource.com/1243284Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 887645 Change-Id: I0f05856b0473bb6c197d53184322faa1042b2f23 Reviewed-on: https://chromium-review.googlesource.com/1237253Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#593981}
-
Theresa authored
BUG=888980 Change-Id: Ic1699abfe2b1b911857557ccfdc04f49543c80d5 Reviewed-on: https://chromium-review.googlesource.com/1243046Reviewed-by:
-
Michael Lippautz authored
Removes a test that was checking that a JS wrapper was collected when doing a V8 GC. This relies on the fact that wrapper tracing does not see the back references in LiveNodeList::owner_. No-try: true Bug: 843903 Change-Id: I0586ba63f15d686a6e33c152d9eb9a8f08247cd5 Reviewed-on: https://chromium-review.googlesource.com/1243066Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593979}
-
Justin DeWitt authored
This patch does the following: * Adds a method to determine the variation of ExploreSites that is enabled * Inflates the ExploreSites ViewStub with the layout appropriate for the variation * Renames several dimensions to make them specific for the Experimental variation of EoS. * Adds a TileGridLayout for ExploreSites to match the Suggestions TileGridLayout * Adds two ExploreSitesCategory TileView classes (regular and condensed) * Adds an ExploreSitesSection that asks for the catalog and inflates the category tiles. This does not properly hook up: * Icon generation/fetching * exact layout parameters. Bug: 888176 Change-Id: Ie7e1b9f66defeac745dce98853e06f10af88330a Reviewed-on: https://chromium-review.googlesource.com/1239658 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593978}
-
Alexander Hendrich authored
This CL updates the ONC documentation and adds a section + examples for GlobalNetworkConfiguration policies (AllowOnlyPolicyNetworksToAutoconnect, AllowOnlyPolicyNetworksToConnect, AllowOnlyPolicyNetworksToConnectIfAvailable, BlacklistedHexSSIDs, DisableNetworkTypes) and recommended values. Bug: 426390, 837205, 280146, 208378, 848719 Change-Id: I9b573f4dd8533b8d7fe83da2e7e5e45e2eb18573 Reviewed-on: https://chromium-review.googlesource.com/1238584Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593977}
-
David Benjamin authored
Bug: 137767 Change-Id: I6c67ee775b1edfe3865603440c19d38ab9180fb1 Reviewed-on: https://chromium-review.googlesource.com/1237542Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#593976}
-
yiyix authored
Since we will use Approximate Square Root instead exact square root in FrameMetrics (cl: 1225105), there is no need to test precision for square root accumulator. Removing NoAccumulatedPrecisionErrorBasic, NoAccumulatedPrecisionErrorBig and NoAccumulatedPrecisionErrorBigger. Bug:881863 Change-Id: Ib4ccf49e6c58f19587aa97964b76df6568be1629 Reviewed-on: https://chromium-review.googlesource.com/1239262Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#593975}
-
David Gunnarsson authored
Change-Id: I2a067705707646f3a2021fb7107661a2c4745bd5 Reviewed-on: https://chromium-review.googlesource.com/1243283 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593974}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40599feeed92..15052410fda2 git log 40599feeed92..15052410fda2 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 85c4b43e6db1..beb669dac125 (4 commits) 2018-09-25 jvanverth@google.com Don't draw device-independent ellipses with degenerate matrix 2018-09-25 halcanary@google.com SkPDF: remove unused PDFDevice::fExistingClipStack Created with: gclient setdep -r src/third_party/skia@15052410fda2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I1d22f787abf93c378abf3af38205097870adac2d Reviewed-on: https://chromium-review.googlesource.com/1243268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593973}
-
Matthew Jones authored
Touch-dismissal is too quick for the feature, this patch adds a 6 second timeout instead. Bug: 888697 Change-Id: I5c3ca03435c634bd93f6255bc9af7b12abe89451 Reviewed-on: https://chromium-review.googlesource.com/1241136 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Check for root document URL in blink before sending anchor element metrics to the browser process. This check makes it consistent with the check in the browser process which verifies the properties of the root document URL. Additionally, navigation predictor is currently used only for metrics recording, it's safe to temporarily return on receiving a bad message instead of crashing the renderer. Bug: 879999 Change-Id: I881ed1079693c4a4952203a59c74980685069606 Reviewed-on: https://chromium-review.googlesource.com/1236469Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593971}
-
Alex Clarke authored
Relanding https://chromium-review.googlesource.com/c/chromium/src/+/1238468 The fix can be seen in the delta between patch set 1 and 2. Original patch description: Make Chrome_DevToolsADBThread shutdown gracefully in tests To land the BrowserUIThreadScheduler we need in tests for all threads to stop using base::PostTaskWithTraits before the scheduler is deleted. Currently this is true for the UI and IO threads but it's not true for Chrome_DevToolsADBThread. This patch makes sure references retaining AndroidDeviceManager::HandlerThread are released in tests which triggers thread shutdown, fixing the problem. TBR=dgozman@chromium.org,finnur@chromium.org,mlamouri@chromium.org Bug: 863341, 872372, 888994 Change-Id: Ie9298d652cad2df6ad93d19cfb3dd5b76fdcf339 Reviewed-on: https://chromium-review.googlesource.com/1243115Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593970}
-
Chris Hamilton authored
This will be used to determine if a tab is unsafe to discard due to a beforeunload handler that returns a non-empty string. BUG=877550 Change-Id: Ib0f9c11fbf74ca6a49c23c6b5866dde5faa2885f Reviewed-on: https://chromium-review.googlesource.com/1231739 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593969}
-
Mikel Astiz authored
A datatype should be allowed to resolve conflicts in a way that deletions are preferred. None of the USS datatypes has done this until now, but we're experimenting with EXTENSIONS being integrated, and we do have such a policy for EXTENSIONS. Bug: 870624 Change-Id: Ib8869e4f31050def316d94161b7ea02a2dbd09a1 Reviewed-on: https://chromium-review.googlesource.com/1243185Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593968}
-
Chris Lu authored
Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: Ia60758a2594130d46918cee61d87fed38ead55d6 Reviewed-on: https://chromium-review.googlesource.com/1239534Reviewed-by:
-
Dmitry Gozman authored
When navigation to "about:blank" gets a new render process, we get site instance url equal to "about:". In this case our standard check for url permission fails. Usually about:blank does not go to a separate process, but there are some rare cases: - navigating away from isolated error page forces a new site instance; - navigating after crash creates a new renderer, since there is no existing one to reuse. Bug: 882589 Change-Id: I076ab544ca2360e7e4c13b58475c08e0be627593 Reviewed-on: https://chromium-review.googlesource.com/1240865Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Danyao Wang authored
These tests currently assume that the repost confirmation dialog is shown on back/forward navigation. This is not true for WKBasedNavigationManager because it matches WKWebView behavior, which uses back/forward cache for back/forward navigation. This CL adds |reload| to explicitly trigger the repost confirmation dialog. Bug: 874635 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I24dafdd02014184f3fbc5b86f1026ebe8f5f00c7 Reviewed-on: https://chromium-review.googlesource.com/1243323 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593965}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9def3b45ef06..f3119ef66d5c git log 9def3b45ef06..f3119ef66d5c --date=short --no-merges --format='%ad %ae %s' 2018-09-25 danilchap@webrtc.org Add generic frame descriptor to list of supported video extensions 2018-09-25 philipel@webrtc.org Use the generic descriptor information in the RtpFrameReferenceFinder. 2018-09-25 kron@webrtc.org Revert "Second reland of "Optimize execution time of RTPSender::UpdateDelayStatistics"" 2018-09-25 sakal@webrtc.org Disable AudioDeviceTest on thread sanitizer. 2018-09-25 danilchap@webrtc.org Support first packet reduction in H264 packetizer 2018-09-25 oprypin@webrtc.org Reland "Use new internal trybot in commit queue" Created with: gclient setdep -r src/third_party/webrtc@f3119ef66d5c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib77c53c8e722fddfab62637fd3e6b5cdddef43b0 Reviewed-on: https://chromium-review.googlesource.com/1242604Reviewed-by:
-
Jongheon Kim authored
This patch changes the data type of video and audio decode counts in the IDL Bug: 887593 Change-Id: Ib988825d6db4eb7b1d18a3d2b5d2b4c2b791e882 Reviewed-on: https://chromium-review.googlesource.com/1240573Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#593963}
-
Eric Aleshire authored
I've been testing the iOS Autofill code against uwyiming@'s saved recipes and replays (in //src/chrome/test/data/autofill/captured_sites/), and found a few bits of profile information that I didn't set, so I went and added them in this minor change. This includes a credit card profile. Additionally, I change the profile data to match the data expected in uwyiming@'s recipes, since currently the profile data is hardcoded (instead of being included with the recipes). Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia24bb7e2b2cde8d5cab7c6623aa34d12b3ad9c1c Reviewed-on: https://chromium-review.googlesource.com/1240317Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#593962}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aa858e5..c5a1fcbf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iedc6a2b929fb712a3bc975df3f03547d6f8a74e3 Reviewed-on: https://chromium-review.googlesource.com/1243363Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593961}
-
