- 04 Dec, 2018 22 commits
-
-
Kyle Horimoto authored
Previously, we would attempt a BLE scan any time that we got a DeviceChanged() or DeviceAdded() callback. However, the DeviceChanged() callback was invoked when a device was in the process of disconnecting, meaning that we would see a disconnecting device, then try to start a connection immediately. This resulted in spurious connection requests which could sometime cause a deadlock in underlying Bluetooth code. Additionally, we would rely on the DeviceChanged() and DeviceRemoved() callbacks to listen for Bluetooth disconnections, which also resulted in error-prone disconnections. This CL updates both call sites to use the updated DeviceAdvertisementReceived() and DeviceConnectedStateChanged() callbacks instead. Bug: 898334 Change-Id: I743e51e6e47194649ab6852966b9d892c3ef334d Reviewed-on: https://chromium-review.googlesource.com/c/1359478 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613358}
-
Mounir Lamouri authored
Bug: None Change-Id: I99172fb7a36e002fe535c2176189368cee3283e1 Reviewed-on: https://chromium-review.googlesource.com/c/1357384Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#613357}
-
Yury Khmel authored
This reverts commit 36458f22. Reason for revert: This CL leads to data loss. Original change's description: > [Locked Fullscreen] Disable ARC while in locked fullscreen > > Locked fullscreen is supposed to be a secure mode where the user cannot do > anything outside of the current browser window, but ARC apps can currently draw > on top of it. To fix this, we disable ARC when entering the mode, and we > re-enable it upon exiting the mode. > > Bug: 888611 > Change-Id: I84cda87a260a42108f1ef6c4767c174bc8b1fb61 > Reviewed-on: https://chromium-review.googlesource.com/c/1356813 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Ivan Šandrk <isandrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613254} TBR=isandrk@chromium.org,karandeepb@chromium.org Change-Id: I9e5ca84ba4e186cb43e3a186da9b659b03368145 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888611 Reviewed-on: https://chromium-review.googlesource.com/c/1359813Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613356}
-
Robbie McElrath authored
Bug: 911173 Change-Id: I8ecef4636e421c0e698af3d5f1796fca78cb269a Reviewed-on: https://chromium-review.googlesource.com/c/1359330Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#613355}
-
Kouhei Ueno authored
Bug: 909576 Change-Id: Ic202cda4e44410d75bd774edae721a8a2cb6ae10 Reviewed-on: https://chromium-review.googlesource.com/c/1350420Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#613354}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d835d664bd3b..b1ff8ba5b90f git log d835d664bd3b..b1ff8ba5b90f --date=short --no-merges --format='%ad %ae %s' 2018-12-03 33432579+alan-baker@users.noreply.github.com Check device scope for Vulkan memory model (#2149) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b1ff8ba5b90f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icc484759c9089e59e6a8ae22aa4d631ac2526d4d Reviewed-on: https://chromium-review.googlesource.com/c/1358769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613353}
-
Zakhar Voit authored
Show warning icon on public session login screen when managed sessions are enabled. Bug: 910218 Change-Id: I119dd321c6d9a7bf8dd3b3da533b8774e9620bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1337492 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613352}
-
Charlie Harrison authored
This CL: 1. Adds method to ContentBrowserClient which allows logging blink UseCounters scoped to a given RenderFrameHost. 2. Uses this new API to log UseCounters for opener navigations resulting in downloads. Bug: 632514 Change-Id: I4459281c5a104fac776a13f9f003b1d75349354f Reviewed-on: https://chromium-review.googlesource.com/c/1324244 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#613351}
-
Jamie Madill authored
Bug: 822310 Change-Id: I08253e03f7a7e954b129d7650ca30efcca5fc9cb Reviewed-on: https://chromium-review.googlesource.com/c/1355603Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#613350}
-
Sky Malice authored
Bug: 910712 Change-Id: I70b768c1215ef0f540fbccbe98d0907881388782 Reviewed-on: https://chromium-review.googlesource.com/c/1357537 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#613349}
-
Kent Tamura authored
- content::LayoutTestBluetoothFakeAdapterSetterImpl - content::LayoutTestBrowserMainParts - content::MojoLayoutTestHelper Their file names were already renamed in crrev.com/613027. This CL has no behavior changes. Bug: 84341 Change-Id: I97c32f04a8b2d3ba06947176e912a222885b9cdd Reviewed-on: https://chromium-review.googlesource.com/c/1358313Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#613348}
-
James Cook authored
This breaks a dependency from AutomationManagerAura to the extensions system. It should make AutomationManagerAura easier to test in unit tests. Bug: 910280 Test: browser_tests Change-Id: I3e7036671d6e6140b6e19b72e7d6482e2fb6f376 Reviewed-on: https://chromium-review.googlesource.com/c/1357548Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#613347}
-
Dale Curtis authored
There's currently no way to resume these sinks from html/js so there's no point in restoring the sink state after disconnection. Specifically you can't call MediaElementAudioSourceNode.disconnect() and expect the underlying media element to be able to ever work again. See this demo: http://storage.googleapis.com/dalecurtis/webaudio-test.html Once AudioContext.createMediaElementSource(element) has been called on an element, that element can never be used standalone again. It must always be connected to the AudioContext to be used. In fact it's actually causing unnecessary work when the elements are destructed since removing the client respins the sink and mixer, etc. BUG=910951 TEST=passes cq. R=hongchan Change-Id: I5ff7fc532545075d62859a30f96d17c83bff9d21 Reviewed-on: https://chromium-review.googlesource.com/c/1359092 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613346}
-
bsheedy authored
This is a reland of 06b8660d No changes made from original CL - original was reverted due to a failing DCHECK, but it turns out that DCHECK was invalid and got reverted. Original change's description: > Use mocked VR controller for scrolling > > Switches all VR instrumentation tests for scrolling using the Daydream > controller to use the Chrome-side controller mock instead of the > VrCore-side emulation via intents. The latter has always been somewhat > flaky, so this should help reduce VR test flakiness. > > Bug: 902938 > Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 > Reviewed-on: https://chromium-review.googlesource.com/c/1341061 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613107} TBR=vollick@chromium.org, cjgrant@chromium.org Bug: 902938 Change-Id: Ifd06d60a292f0f55e34f3c177c346d79504fde5c Reviewed-on: https://chromium-review.googlesource.com/c/1358648Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613345}
-
bsheedy authored
Regular roll to the most recent release version. TBR=bajones@chromium.org Change-Id: Icff9d97925cd15670da6f3c38e53416855c31fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1359482Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613344}
-
François Beaufort authored
This PR makes sure the last video frame stays visible in the PiP window when video ends. This is what <video> elements currently do inline. Bug: 910433 Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b Reviewed-on: https://chromium-review.googlesource.com/c/1356707Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#613343}
-
Caleb Rouleau authored
--smoke-test-mode's only effect is to set pageset-repeat to 1. This is only true for benchmark runs. For merge scripts, that flag has different meaning and does not need to be removed. Note that Note that we currently support duplicate conflicting flags: for example ‘run_benchmark ... --pageset-repeat=2 --pageset-repeat=3’ We use the last flag, 3 in the example. --smoke-test-mode is getting deprecated in https://chromium-review.googlesource.com/c/catapult/+/1356903 Bug: 894254 Change-Id: I1b0e423167018f6010f66255838ad8a33d6acd76 Reviewed-on: https://chromium-review.googlesource.com/c/1357722Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#613342}
-
Noel Gordon authored
- change the Crostini externs file to be an @interface class - add missing methods from the current implementation - add background BUILD rules to Closure compile {Crostini} - rename the background page Crostini to CrostiniImpl and make it @implements the {Crostini} class interface - use CrostiniImpl as the implementation for Files App: it is only instantiated on the Files app background page. - use CrostiniImpl for foreground unittests for now, until a mock (test-only) implementation is available. No change in test behavior, no new tests. Tbr: lucmult@ Bug: 911024 Change-Id: I580c9701374d6d8c1842a96040625c6be719ed64 Reviewed-on: https://chromium-review.googlesource.com/c/1358319 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613341}
-
Lei Zhang authored
Stop copies with DISALLOW_COPY_AND_ASSIGN() and also switch AndroidHardwareBufferCompat to use base::NoDestructor. Change-Id: Ifbe0224ace714335ca105803f9271dc00f190b62 Reviewed-on: https://chromium-review.googlesource.com/c/1330994Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613340}
-
John Budorick authored
webkit_layout_tests_isolated_scripts was identical to chromium_webkit_isolated_scripts except for the configured shard count. Bug: 910859 Change-Id: Ie014793403154978e08e47cebaf04631a45a1e24 Reviewed-on: https://chromium-review.googlesource.com/c/1359032Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613339}
-
Lei Zhang authored
Because writing out std::vector<printing::PrinterSemanticCapsAndDefaults::Paper> takes up the entire line. Also initialize more class members in print_backend.h. Change-Id: Ia623501c2d124ef3c6a601cb863585d3e8772776 Reviewed-on: https://chromium-review.googlesource.com/c/1357620Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613338}
-
David Black authored
Previously, Assistant would auto-hide for any press event outside its bounds or due to widget deactivation. Now, it will continue to do so unless in mini state. Bug: b:120291398 Change-Id: I06dff99094ad62782745d1f677f87744d4ad0307 Reviewed-on: https://chromium-review.googlesource.com/c/1357519 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#613337}
-
- 03 Dec, 2018 18 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec0f45be1144..ec086d842ce7 git log ec0f45be1144..ec086d842ce7 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 srte@webrtc.org Fixes race in SendSideCongestionControllerTest.OldFeedback. Created with: gclient setdep -r src/third_party/webrtc@ec086d842ce7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b9c9d8a3e9eb8b45e4b661eba92c960a2b9a680 Reviewed-on: https://chromium-review.googlesource.com/c/1359372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613336}
-
Ken Rockot authored
Migrates most remaining usage of ServiceContext over to ServiceBinding and eliminates all remaining usage of EmbeddedServiceInfo outside of content. Bug: 891780 Change-Id: Id7a83918e58a1cecdcadd6c20ee624c1dcbd3729 Reviewed-on: https://chromium-review.googlesource.com/c/1357534Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#613335}
-
Nigel Tao authored
Lots of TODOs, but there's enough implemented so that running "chrome --enable-features=AppService" will populate the launcher with extension apps' names and icons, and clicking on the icon will launch the app. BUG=826982 Change-Id: Id424abac859dde69ffdac3c28a473fce61fbe8df Reviewed-on: https://chromium-review.googlesource.com/c/1351975 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#613334}
-
Joshua Peraza authored
This is a reland of 66b2e0f1 Original change's description: > Enable Crashpad for Android > > Overview: > This CL disables Breakpad for Chrome, Content Shell, WebView, and > Chromecast on Android and replaces it with Crashpad. When a crash > signal is received, the browser forks+execs a Crashpad handler process > either for itself or on behalf of a crashing child to create a crash > dump. > > components/crash/ > - Remove CrashDumpManager. Minidump creation is handled entirely by > Crashpad. > - Remove OnChildStart from ChildExitObserver as it is no longer > necessary. > - ChildExitObserver observers CrashHandlerHost to be notified when > child processes receive crash signals. > - De-duplicate calls to ChildExitObserver::Client::OnChildExit when > NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. > > components/minidump_uploader/ > - Uploaders expect crash reports to already be MIME encoded since > Breakpad was doing that in a signal handler call-back. > CrashFileManager now automatically calls into native code to do > the encoding and write to a directory of crash reports whenever it > checks for reports without logcats. > > chrome/app/*.{cc,h} > chrome/browser/*.cc > content/shell/app/*.{cc,h} > content/shell/browser/*.cc > - Initialize Crashpad instead of Breakpad, with minor cleanup and > adjustment for changes to CrashDumpObserver. > > chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc > - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, > CLOSED} and signals sent to ChildExitObserver instead of a crash > dump. > > android_webview/ > - AwBrowserTerminator now observes child process crashes via > ChildExitObserver rather than its own pipe. > - Crashpad always produces minidumps, and not microdumps. > - Disabling Crashpad is not yet supported. > > chromecast/ > - There are now two directories that crash report uploaders should > be aware of: "Crashpad" contains a database of raw minidumps > produced by Crashpad, and "Crash Reports" contains MIME encoded > minidumps. MIME encoding is performed by a CrashReportMimeWriter > in CastCrashUploader.java:checkForCrashDumps(). > > Bug: crashpad:30 > Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg > Change-Id: I0efa451585f60287853c47f860f09ced581c8958 > Reviewed-on: https://chromium-review.googlesource.com/c/989401 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612987} TBR=tobiasjs@chromium.org,jam@chromium.org,wnwen@chromium.org,halliwell@chromium.org,sanfin@chromium.org,yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org Bug: crashpad:30 Change-Id: Ia1654bc4fbe59005513f30364753309ae232052d Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/c/1357941 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#613333}
-
Dan Beam authored
This makes test code easier to write and understand and is also what the "prod" WebUI class already does. This is loosely related to Dark Mode support, as I discovered this difference in behavior while working on unit tests for this work. WIP Dark Mode CL: https://crrev.com/c/1354685 R=jam@chromium.org BUG=883049 Change-Id: I6862e2cd0244bdb02bd6dd92870bc2ec70d2099a Reviewed-on: https://chromium-review.googlesource.com/c/1359132Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613332}
-
Dominic Mazzoni authored
Bug: 862710 Change-Id: I84432cae10fb11134023dd68da86995855fa809f Reviewed-on: https://chromium-review.googlesource.com/c/1351088Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#613331}
-
Eugene But authored
NavigationItemCommitted is deprecated in favour of DidFinishNavigation. This change will simplify transition from NavigationItemCommitted to DidFinishNavigation, because DidFinishNavigation does not pass NavigationItem as argument. Bug: 720786 Change-Id: I758d7220c2d600bc663d8c55eeb49b5c54e619ff Reviewed-on: https://chromium-review.googlesource.com/c/1356770 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613330}
-
Doug Arnett authored
The EffectiveConnectionTypeThresholdForClientLoFi() is no longer used except for tests (replaced by GetECTThresholdForPreview(PreviewsType::LOFI)), Change-Id: I925c21ecd5589d6a74f232359dd24f2e84b16ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1359460Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#613329}
-
dpapad authored
Conversions performed with a tool (lebab). In a few occasions had to manually convert, where the tool could not determine if the conversion was safe. This is in preparation of turning on no-var, and prefer-const ESLint checks for all of chrome/browser/resources/ Bug: 792774 Change-Id: I0d5fa98d5efb935e84c1990db635f96df5957e4d Reviewed-on: https://chromium-review.googlesource.com/c/1357726Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613328}
-
Kurt Horimoto authored
This will allow AlertCoordinators to access FullscreenController, which will provide the necessary insets to use for non-modal alert presentation. This CL also removes the unnecessary empty initializers, as this is handled by the NS_UNAVAILABLE annotation now. Bug: 674649 Change-Id: I0d1b5efbcf0266103090e879b078cef64df42593 Reviewed-on: https://chromium-review.googlesource.com/c/1340602 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613327}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: Ie2331c427c40d394319e94e62e649a0d21fd0f58 Reviewed-on: https://chromium-review.googlesource.com/c/1359484Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#613326}
-
Lei Zhang authored
The class and file referenced do not exist anymore. Change-Id: I80f0b67c94b6f7a5d3ad5498f885464cf2c0c4e9 Reviewed-on: https://chromium-review.googlesource.com/c/1359316Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613325}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1fbed8388ab1..8b8b9a06ee3d Created with: gclient setdep -r src-internal@8b8b9a06ee3d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: Ib2d9012753c7ddca3d7aab6ece572a2288686385 Reviewed-on: https://chromium-review.googlesource.com/c/1358765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613324}
-
iOS Autoroller authored
TBR=smut Change-Id: Iac742b113fdcd8e50516d808c2039e19eceb5d95 Reviewed-on: https://chromium-review.googlesource.com/c/1358640Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#613323}
-
Jay Harris authored
Bug: 853593 Change-Id: I4618ca91c53a18ed7a56cb8dce0416d25318ab41 Reviewed-on: https://chromium-review.googlesource.com/c/1328084 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#613322}
-
Jacob Dufault authored
- Simplify helper code used with ScreenLockerTest.TestFullscreenExit - Simplify BrailleDisplayPrivateAPIUnitTest.KeyEventOnLockScreen, remove MSAN restriction since views-lock screen is significantly faster to load Bug: 899777 Change-Id: I0cf3c50c562289c42513b8509a86f901caf93035 Reviewed-on: https://chromium-review.googlesource.com/c/1327543 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#613321}
-
Min Chen authored
Open the application select menu of chrome shortcut will trigger the window stacking change. It will update the shelf visibility before showing the menu. Call UpdateVisibilityState after the menu is shown to keep the auto-hide shelf shown. Bug: 908681 Change-Id: I1e4dca91a03ca85df5ddb1511bd2b4f3fe6c8d63 Reviewed-on: https://chromium-review.googlesource.com/c/1356595 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613320}
-
Kenneth Russell authored
The GPU tests act much like integration tests for the entire browser, and tend to uncover flakiness bugs more readily than other test suites. In order to surface any flakiness more readily to the developer of the CL which is introducing it, we disable retries with patch on the commit queue. Bug: 906166 Change-Id: Iee56100a774377b9172325627da4694ce0a15009 Reviewed-on: https://chromium-review.googlesource.com/c/1357569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613319}
-